diff mbox series

man: fix missing cachestat manpage

Message ID 20250409160059.GA6283@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series man: fix missing cachestat manpage | expand

Commit Message

Darrick J. Wong April 9, 2025, 4 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Fix missing cachestat documentation so that xfs/514 doesn't fail.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 man/man8/xfs_io.8 |    3 +++
 1 file changed, 3 insertions(+)

Comments

Christoph Hellwig April 10, 2025, 6:24 a.m. UTC | #1
On Wed, Apr 09, 2025 at 09:00:59AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix missing cachestat documentation so that xfs/514 doesn't fail.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Ritesh Harjani (IBM) April 12, 2025, 6:16 a.m. UTC | #2
"Darrick J. Wong" <djwong@kernel.org> writes:

> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix missing cachestat documentation so that xfs/514 doesn't fail.
>

Thanks for the fixing this. I didn't notice xfs/514 tests undocumented
xfs_db commands. 

The changes looks good to me. Please feel free to take:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  man/man8/xfs_io.8 |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index f36f1577a2b6c8..3c06e1b4d0fe2c 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -1101,6 +1101,9 @@ .SH FILE I/O COMMANDS
>  Do not print timing information at all.
>  .PD
>  .RE
> +.TP
> +.BI "cachestat off len
> +Print page cache statistics for the given file range.
>  
>  .SH MEMORY MAPPED I/O COMMANDS
>  .TP
Ritesh Harjani (IBM) April 12, 2025, 6:30 a.m. UTC | #3
Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes:

> "Darrick J. Wong" <djwong@kernel.org> writes:
>
>> From: Darrick J. Wong <djwong@kernel.org>
>>
>> Fix missing cachestat documentation so that xfs/514 doesn't fail.
>>
>
> Thanks for the fixing this. I didn't notice xfs/514 tests undocumented
> xfs_db commands. 

For xfs_io, xfs/293 tests for undocumented commands.

-ritesh
diff mbox series

Patch

diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index f36f1577a2b6c8..3c06e1b4d0fe2c 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -1101,6 +1101,9 @@  .SH FILE I/O COMMANDS
 Do not print timing information at all.
 .PD
 .RE
+.TP
+.BI "cachestat off len
+Print page cache statistics for the given file range.
 
 .SH MEMORY MAPPED I/O COMMANDS
 .TP