diff mbox series

[v2,1/1] xfs/539: Ignore remount failures on v5 xfs

Message ID 5cd91683c8eec72a6016914d3f9e631909e99da8.1741094926.git.nirjhar.roy.lists@gmail.com (mailing list archive)
State New
Headers show
Series xfs/539: Ignore remount failures on v5 xfs | expand

Commit Message

Nirjhar Roy (IBM) March 4, 2025, 1:48 p.m. UTC
Remount with noattr2 fails on a v5 filesystem, however the deprecation
warnings still get printed and that is exactly what the test
is checking. So ignore the mount failures in this case.

Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
---
 tests/xfs/539 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nirjhar Roy (IBM) April 1, 2025, 4:40 a.m. UTC | #1
On 3/4/25 19:18, Nirjhar Roy (IBM) wrote:
> Remount with noattr2 fails on a v5 filesystem, however the deprecation
> warnings still get printed and that is exactly what the test
> is checking. So ignore the mount failures in this case.

Hi,

Can I please get some review on this?

--NR

>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>   tests/xfs/539 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/539 b/tests/xfs/539
> index b9bb7cc1..5098be4a 100755
> --- a/tests/xfs/539
> +++ b/tests/xfs/539
> @@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do
>   done
>   for VAR in {noattr2,ikeep}; do
>   	log_tag
> -	_scratch_remount $VAR
> +	_scratch_remount $VAR >> $seqres.full 2>&1
>   	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
>   		echo "Could not find deprecation warning for $VAR"
>   done
diff mbox series

Patch

diff --git a/tests/xfs/539 b/tests/xfs/539
index b9bb7cc1..5098be4a 100755
--- a/tests/xfs/539
+++ b/tests/xfs/539
@@ -61,7 +61,7 @@  for VAR in {attr2,noikeep}; do
 done
 for VAR in {noattr2,ikeep}; do
 	log_tag
-	_scratch_remount $VAR
+	_scratch_remount $VAR >> $seqres.full 2>&1
 	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
 		echo "Could not find deprecation warning for $VAR"
 done