From patchwork Tue Mar 21 19:02:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Sandeen X-Patchwork-Id: 9637397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86B9B60327 for ; Tue, 21 Mar 2017 19:03:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 764EC26E69 for ; Tue, 21 Mar 2017 19:03:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6AFD528418; Tue, 21 Mar 2017 19:03:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7826126E69 for ; Tue, 21 Mar 2017 19:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757684AbdCUTCv (ORCPT ); Tue, 21 Mar 2017 15:02:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59252 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756845AbdCUTC0 (ORCPT ); Tue, 21 Mar 2017 15:02:26 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8AF080469; Tue, 21 Mar 2017 19:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E8AF080469 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sandeen@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E8AF080469 Received: from Liberator.local (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85A9C785C0; Tue, 21 Mar 2017 19:02:25 +0000 (UTC) Subject: [PATCH RFC 1/2] xfs_io: move stat functions to new file To: linux-xfs References: <0bc83cf4-a927-e78e-9bfb-7f3fa91303eb@redhat.com> Cc: David Howells , Andreas Dilger , Christoph Hellwig From: Eric Sandeen Message-ID: <72ee841b-9bb3-835f-4dd8-c7bdfa850831@redhat.com> Date: Tue, 21 Mar 2017 15:02:23 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0bc83cf4-a927-e78e-9bfb-7f3fa91303eb@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 Mar 2017 19:02:26 +0000 (UTC) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Adding statx will add a bit of code, so break stat-related functions out of open.c into their own new file. Signed-off-by: Eric Sandeen --- -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/io/Makefile b/io/Makefile index 32df568..435ccff 100644 --- a/io/Makefile +++ b/io/Makefile @@ -11,7 +11,7 @@ HFILES = init.h io.h CFILES = init.c \ attr.c bmap.c cowextsize.c encrypt.c file.c freeze.c fsync.c \ getrusage.c imap.c link.c mmap.c open.c parent.c pread.c prealloc.c \ - pwrite.c reflink.c seek.c shutdown.c sync.c truncate.c utimes.c + pwrite.c reflink.c seek.c shutdown.c stat.c sync.c truncate.c utimes.c LLDLIBS = $(LIBXCMD) $(LIBHANDLE) $(LIBPTHREAD) LTDEPENDENCIES = $(LIBXCMD) $(LIBHANDLE) diff --git a/io/io.h b/io/io.h index c40aad0..7e95bd5 100644 --- a/io/io.h +++ b/io/io.h @@ -53,7 +53,7 @@ extern fileio_t *filetable; /* open file table */ extern int filecount; /* number of open files */ extern fileio_t *file; /* active file in file table */ extern int filelist_f(void); - +extern int stat_f(int argc, char **argv); /* * Memory mapped file regions */ diff --git a/io/open.c b/io/open.c index 941fdc1..2ed55cf 100644 --- a/io/open.c +++ b/io/open.c @@ -39,9 +39,7 @@ #endif static cmdinfo_t open_cmd; -static cmdinfo_t stat_cmd; static cmdinfo_t close_cmd; -static cmdinfo_t statfs_cmd; static cmdinfo_t chproj_cmd; static cmdinfo_t lsproj_cmd; static cmdinfo_t extsize_cmd; @@ -49,96 +47,6 @@ static cmdinfo_t inode_cmd; static prid_t prid; static long extsize; -off64_t -filesize(void) -{ - struct stat st; - - if (fstat(file->fd, &st) < 0) { - perror("fstat"); - return -1; - } - return st.st_size; -} - -static char * -filetype(mode_t mode) -{ - switch (mode & S_IFMT) { - case S_IFSOCK: - return _("socket"); - case S_IFDIR: - return _("directory"); - case S_IFCHR: - return _("char device"); - case S_IFBLK: - return _("block device"); - case S_IFREG: - return _("regular file"); - case S_IFLNK: - return _("symbolic link"); - case S_IFIFO: - return _("fifo"); - } - return NULL; -} - -static int -stat_f( - int argc, - char **argv) -{ - struct dioattr dio; - struct fsxattr fsx, fsxa; - struct stat st; - int verbose = (argc == 2 && !strcmp(argv[1], "-v")); - - printf(_("fd.path = \"%s\"\n"), file->name); - printf(_("fd.flags = %s,%s,%s%s%s%s%s\n"), - file->flags & IO_OSYNC ? _("sync") : _("non-sync"), - file->flags & IO_DIRECT ? _("direct") : _("non-direct"), - file->flags & IO_READONLY ? _("read-only") : _("read-write"), - file->flags & IO_REALTIME ? _(",real-time") : "", - file->flags & IO_APPEND ? _(",append-only") : "", - file->flags & IO_NONBLOCK ? _(",non-block") : "", - file->flags & IO_TMPFILE ? _(",tmpfile") : ""); - if (fstat(file->fd, &st) < 0) { - perror("fstat"); - } else { - printf(_("stat.ino = %lld\n"), (long long)st.st_ino); - printf(_("stat.type = %s\n"), filetype(st.st_mode)); - printf(_("stat.size = %lld\n"), (long long)st.st_size); - printf(_("stat.blocks = %lld\n"), (long long)st.st_blocks); - if (verbose) { - printf(_("stat.atime = %s"), ctime(&st.st_atime)); - printf(_("stat.mtime = %s"), ctime(&st.st_mtime)); - printf(_("stat.ctime = %s"), ctime(&st.st_ctime)); - } - } - if (file->flags & IO_FOREIGN) - return 0; - if ((xfsctl(file->name, file->fd, FS_IOC_FSGETXATTR, &fsx)) < 0 || - (xfsctl(file->name, file->fd, XFS_IOC_FSGETXATTRA, &fsxa)) < 0) { - perror("FS_IOC_FSGETXATTR"); - } else { - printf(_("fsxattr.xflags = 0x%x "), fsx.fsx_xflags); - printxattr(fsx.fsx_xflags, verbose, 0, file->name, 1, 1); - printf(_("fsxattr.projid = %u\n"), fsx.fsx_projid); - printf(_("fsxattr.extsize = %u\n"), fsx.fsx_extsize); - printf(_("fsxattr.cowextsize = %u\n"), fsx.fsx_cowextsize); - printf(_("fsxattr.nextents = %u\n"), fsx.fsx_nextents); - printf(_("fsxattr.naextents = %u\n"), fsxa.fsx_nextents); - } - if ((xfsctl(file->name, file->fd, XFS_IOC_DIOINFO, &dio)) < 0) { - perror("XFS_IOC_DIOINFO"); - } else { - printf(_("dioattr.mem = 0x%x\n"), dio.d_mem); - printf(_("dioattr.miniosz = %u\n"), dio.d_miniosz); - printf(_("dioattr.maxiosz = %u\n"), dio.d_maxiosz); - } - return 0; -} - int openfile( char *path, @@ -697,58 +605,6 @@ extsize_f( return 0; } -static int -statfs_f( - int argc, - char **argv) -{ - struct xfs_fsop_counts fscounts; - struct xfs_fsop_geom fsgeo; - struct statfs st; - - printf(_("fd.path = \"%s\"\n"), file->name); - if (platform_fstatfs(file->fd, &st) < 0) { - perror("fstatfs"); - } else { - printf(_("statfs.f_bsize = %lld\n"), (long long) st.f_bsize); - printf(_("statfs.f_blocks = %lld\n"), (long long) st.f_blocks); - printf(_("statfs.f_bavail = %lld\n"), (long long) st.f_bavail); - printf(_("statfs.f_files = %lld\n"), (long long) st.f_files); - printf(_("statfs.f_ffree = %lld\n"), (long long) st.f_ffree); - } - if (file->flags & IO_FOREIGN) - return 0; - if ((xfsctl(file->name, file->fd, XFS_IOC_FSGEOMETRY_V1, &fsgeo)) < 0) { - perror("XFS_IOC_FSGEOMETRY_V1"); - } else { - printf(_("geom.bsize = %u\n"), fsgeo.blocksize); - printf(_("geom.agcount = %u\n"), fsgeo.agcount); - printf(_("geom.agblocks = %u\n"), fsgeo.agblocks); - printf(_("geom.datablocks = %llu\n"), - (unsigned long long) fsgeo.datablocks); - printf(_("geom.rtblocks = %llu\n"), - (unsigned long long) fsgeo.rtblocks); - printf(_("geom.rtextents = %llu\n"), - (unsigned long long) fsgeo.rtextents); - printf(_("geom.rtextsize = %u\n"), fsgeo.rtextsize); - printf(_("geom.sunit = %u\n"), fsgeo.sunit); - printf(_("geom.swidth = %u\n"), fsgeo.swidth); - } - if ((xfsctl(file->name, file->fd, XFS_IOC_FSCOUNTS, &fscounts)) < 0) { - perror("XFS_IOC_FSCOUNTS"); - } else { - printf(_("counts.freedata = %llu\n"), - (unsigned long long) fscounts.freedata); - printf(_("counts.freertx = %llu\n"), - (unsigned long long) fscounts.freertx); - printf(_("counts.freeino = %llu\n"), - (unsigned long long) fscounts.freeino); - printf(_("counts.allocino = %llu\n"), - (unsigned long long) fscounts.allocino); - } - return 0; -} - static void inode_help(void) { @@ -920,14 +776,6 @@ open_init(void) open_cmd.oneline = _("open the file specified by path"); open_cmd.help = open_help; - stat_cmd.name = "stat"; - stat_cmd.cfunc = stat_f; - stat_cmd.argmin = 0; - stat_cmd.argmax = 1; - stat_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; - stat_cmd.args = _("[-v]"); - stat_cmd.oneline = _("statistics on the currently open file"); - close_cmd.name = "close"; close_cmd.altname = "c"; close_cmd.cfunc = close_f; @@ -936,12 +784,6 @@ open_init(void) close_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK | CMD_FLAG_ONESHOT; close_cmd.oneline = _("close the current open file"); - statfs_cmd.name = "statfs"; - statfs_cmd.cfunc = statfs_f; - statfs_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; - statfs_cmd.oneline = - _("statistics on the filesystem of the currently open file"); - chproj_cmd.name = "chproj"; chproj_cmd.cfunc = chproj_f; chproj_cmd.args = _("[-D | -R] projid"); @@ -983,9 +825,7 @@ open_init(void) inode_cmd.help = inode_help; add_command(&open_cmd); - add_command(&stat_cmd); add_command(&close_cmd); - add_command(&statfs_cmd); add_command(&chproj_cmd); add_command(&lsproj_cmd); add_command(&extsize_cmd); diff --git a/io/stat.c b/io/stat.c new file mode 100644 index 0000000..3ae9903 --- /dev/null +++ b/io/stat.c @@ -0,0 +1,189 @@ +/* + * Copyright (c) 2003-2005 Silicon Graphics, Inc. + * All Rights Reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it would be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include "command.h" +#include "input.h" +#include "init.h" +#include "io.h" +#include "libxfs.h" + +static cmdinfo_t stat_cmd; +static cmdinfo_t statfs_cmd; + +off64_t +filesize(void) +{ + struct stat st; + + if (fstat(file->fd, &st) < 0) { + perror("fstat"); + return -1; + } + return st.st_size; +} + +static char * +filetype(mode_t mode) +{ + switch (mode & S_IFMT) { + case S_IFSOCK: + return _("socket"); + case S_IFDIR: + return _("directory"); + case S_IFCHR: + return _("char device"); + case S_IFBLK: + return _("block device"); + case S_IFREG: + return _("regular file"); + case S_IFLNK: + return _("symbolic link"); + case S_IFIFO: + return _("fifo"); + } + return NULL; +} + +int +stat_f( + int argc, + char **argv) +{ + struct dioattr dio; + struct fsxattr fsx, fsxa; + struct stat st; + int verbose = (argc == 2 && !strcmp(argv[1], "-v")); + + printf(_("fd.path = \"%s\"\n"), file->name); + printf(_("fd.flags = %s,%s,%s%s%s%s%s\n"), + file->flags & IO_OSYNC ? _("sync") : _("non-sync"), + file->flags & IO_DIRECT ? _("direct") : _("non-direct"), + file->flags & IO_READONLY ? _("read-only") : _("read-write"), + file->flags & IO_REALTIME ? _(",real-time") : "", + file->flags & IO_APPEND ? _(",append-only") : "", + file->flags & IO_NONBLOCK ? _(",non-block") : "", + file->flags & IO_TMPFILE ? _(",tmpfile") : ""); + if (fstat(file->fd, &st) < 0) { + perror("fstat"); + } else { + printf(_("stat.ino = %lld\n"), (long long)st.st_ino); + printf(_("stat.type = %s\n"), filetype(st.st_mode)); + printf(_("stat.size = %lld\n"), (long long)st.st_size); + printf(_("stat.blocks = %lld\n"), (long long)st.st_blocks); + if (verbose) { + printf(_("stat.atime = %s"), ctime(&st.st_atime)); + printf(_("stat.mtime = %s"), ctime(&st.st_mtime)); + printf(_("stat.ctime = %s"), ctime(&st.st_ctime)); + } + } + if (file->flags & IO_FOREIGN) + return 0; + if ((xfsctl(file->name, file->fd, FS_IOC_FSGETXATTR, &fsx)) < 0 || + (xfsctl(file->name, file->fd, XFS_IOC_FSGETXATTRA, &fsxa)) < 0) { + perror("FS_IOC_FSGETXATTR"); + } else { + printf(_("fsxattr.xflags = 0x%x "), fsx.fsx_xflags); + printxattr(fsx.fsx_xflags, verbose, 0, file->name, 1, 1); + printf(_("fsxattr.projid = %u\n"), fsx.fsx_projid); + printf(_("fsxattr.extsize = %u\n"), fsx.fsx_extsize); + printf(_("fsxattr.cowextsize = %u\n"), fsx.fsx_cowextsize); + printf(_("fsxattr.nextents = %u\n"), fsx.fsx_nextents); + printf(_("fsxattr.naextents = %u\n"), fsxa.fsx_nextents); + } + if ((xfsctl(file->name, file->fd, XFS_IOC_DIOINFO, &dio)) < 0) { + perror("XFS_IOC_DIOINFO"); + } else { + printf(_("dioattr.mem = 0x%x\n"), dio.d_mem); + printf(_("dioattr.miniosz = %u\n"), dio.d_miniosz); + printf(_("dioattr.maxiosz = %u\n"), dio.d_maxiosz); + } + return 0; +} + +static int +statfs_f( + int argc, + char **argv) +{ + struct xfs_fsop_counts fscounts; + struct xfs_fsop_geom fsgeo; + struct statfs st; + + printf(_("fd.path = \"%s\"\n"), file->name); + if (platform_fstatfs(file->fd, &st) < 0) { + perror("fstatfs"); + } else { + printf(_("statfs.f_bsize = %lld\n"), (long long) st.f_bsize); + printf(_("statfs.f_blocks = %lld\n"), (long long) st.f_blocks); + printf(_("statfs.f_bavail = %lld\n"), (long long) st.f_bavail); + printf(_("statfs.f_files = %lld\n"), (long long) st.f_files); + printf(_("statfs.f_ffree = %lld\n"), (long long) st.f_ffree); + } + if (file->flags & IO_FOREIGN) + return 0; + if ((xfsctl(file->name, file->fd, XFS_IOC_FSGEOMETRY_V1, &fsgeo)) < 0) { + perror("XFS_IOC_FSGEOMETRY_V1"); + } else { + printf(_("geom.bsize = %u\n"), fsgeo.blocksize); + printf(_("geom.agcount = %u\n"), fsgeo.agcount); + printf(_("geom.agblocks = %u\n"), fsgeo.agblocks); + printf(_("geom.datablocks = %llu\n"), + (unsigned long long) fsgeo.datablocks); + printf(_("geom.rtblocks = %llu\n"), + (unsigned long long) fsgeo.rtblocks); + printf(_("geom.rtextents = %llu\n"), + (unsigned long long) fsgeo.rtextents); + printf(_("geom.rtextsize = %u\n"), fsgeo.rtextsize); + printf(_("geom.sunit = %u\n"), fsgeo.sunit); + printf(_("geom.swidth = %u\n"), fsgeo.swidth); + } + if ((xfsctl(file->name, file->fd, XFS_IOC_FSCOUNTS, &fscounts)) < 0) { + perror("XFS_IOC_FSCOUNTS"); + } else { + printf(_("counts.freedata = %llu\n"), + (unsigned long long) fscounts.freedata); + printf(_("counts.freertx = %llu\n"), + (unsigned long long) fscounts.freertx); + printf(_("counts.freeino = %llu\n"), + (unsigned long long) fscounts.freeino); + printf(_("counts.allocino = %llu\n"), + (unsigned long long) fscounts.allocino); + } + return 0; +} + +void +stat_init(void) +{ + stat_cmd.name = "stat"; + stat_cmd.cfunc = stat_f; + stat_cmd.argmin = 0; + stat_cmd.argmax = 1; + stat_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; + stat_cmd.args = _("[-v]"); + stat_cmd.oneline = _("statistics on the currently open file"); + + statfs_cmd.name = "statfs"; + statfs_cmd.cfunc = statfs_f; + statfs_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; + statfs_cmd.oneline = + _("statistics on the filesystem of the currently open file"); + + add_command(&stat_cmd); + add_command(&statfs_cmd); +}