From patchwork Thu Mar 16 16:28:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Biebl X-Patchwork-Id: 9628915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 163D960522 for ; Thu, 16 Mar 2017 16:30:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04B44285EE for ; Thu, 16 Mar 2017 16:30:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED1BA28644; Thu, 16 Mar 2017 16:30:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EA03285EE for ; Thu, 16 Mar 2017 16:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138AbdCPQaL (ORCPT ); Thu, 16 Mar 2017 12:30:11 -0400 Received: from buxtehude.debian.org ([209.87.16.39]:50006 "EHLO buxtehude.debian.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104AbdCPQaJ (ORCPT ); Thu, 16 Mar 2017 12:30:09 -0400 Received: from debbugs by buxtehude.debian.org with local (Exim 4.84_2) (envelope-from ) id 1coYHu-0005NS-Of; Thu, 16 Mar 2017 16:30:06 +0000 X-Loop: owner@bugs.debian.org Subject: Bug#766811: spurious library links Reply-To: Michael Biebl , 766811@bugs.debian.org X-Loop: owner@bugs.debian.org X-Debian-PR-Message: followup 766811 X-Debian-PR-Package: xfslibs-dev X-Debian-PR-Keywords: stretch sid X-Debian-PR-Source: xfsprogs Received: via spool by 766811-submit@bugs.debian.org id=B766811.148968170419790 (code B ref 766811); Thu, 16 Mar 2017 16:30:05 +0000 Received: (at 766811) by bugs.debian.org; 16 Mar 2017 16:28:24 +0000 Received: from dd17218.kasserver.com ([85.13.136.134]) by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1coYGG-00058y-Cc for 766811@bugs.debian.org; Thu, 16 Mar 2017 16:28:24 +0000 Received: from [192.168.179.70] (x5ce00d47.dyn.telefonica.de [92.224.13.71]) by dd17218.kasserver.com (Postfix) with ESMTPSA id 37B966801B1C; Thu, 16 Mar 2017 17:28:22 +0100 (CET) From: Michael Biebl To: 766811@bugs.debian.org, Nathan Scott , Marco d'Itri References: <20141026004825.GA27863@bongo.bofh.it> <20160124151308.GA7620@jwilk.net> <20160206005821.GA11551@bongo.bofh.it> <20160206132241.GA2869@jwilk.net> <20160210031703.GA28092@bongo.bofh.it> <822351939.19802495.1455074423707.JavaMail.zimbra@redhat.com> <822351939.19802495.1455074423707.JavaMail.zimbra@redhat.com> Message-ID: <785bca5c-7b92-1c20-7a68-7c8b79419fa4@debian.org> Date: Thu, 16 Mar 2017 17:28:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <822351939.19802495.1455074423707.JavaMail.zimbra@redhat.com> Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Nathan On Tue, 9 Feb 2016 22:20:23 -0500 (EST) Nathan Scott wrote: > > Should I NMU? > > Please go right ahead Marco - many thanks! So this NMU happened, but unfortunately your followup maintainer upload, i.e. 4.5.0 did not include the changes from the NMU. Nathan, could you make another upload including the fix from Marco? I've attached the debdiff which still seems to apply against 4.9.0 Seeing that this issue already caused two duplicates being filed, I'd say it's worth fixing for stretch. Regards, Michael diff -Nru xfsprogs-4.3.0/debian/changelog xfsprogs-4.3.0+nmu1/debian/changelog --- xfsprogs-4.3.0/debian/changelog 2015-11-27 00:38:33.000000000 +0100 +++ xfsprogs-4.3.0+nmu1/debian/changelog 2016-02-10 04:39:50.000000000 +0100 @@ -1,3 +1,11 @@ +xfsprogs (4.3.0+nmu1) unstable; urgency=medium + + * Non-maintainer upload. + * Disabled the code in include/buildmacros which creates bogus symlinks + for libraries. (Closes: #766811) + + -- Marco d'Itri Wed, 10 Feb 2016 04:24:23 +0100 + xfsprogs (4.3.0) unstable; urgency=low * New upstream release diff -Nru xfsprogs-4.3.0/include/buildmacros xfsprogs-4.3.0+nmu1/include/buildmacros --- xfsprogs-4.3.0/include/buildmacros 2015-09-11 03:51:36.000000000 +0200 +++ xfsprogs-4.3.0+nmu1/include/buildmacros 2016-02-10 04:39:50.000000000 +0100 @@ -76,7 +76,7 @@ ../$(INSTALL) -m 644 $(LIBNAME).lai $(PKG_LIB_DIR)/$(LIBNAME).la ; \ ../$(INSTALL) -m 755 -d $(PKG_ROOT_LIB_DIR); \ ../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR); \ - if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \ + if false && [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \ "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \ ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a $(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \ ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la $(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \