diff mbox

[2/2] xfs_io: stat: treat statfs.f_flags as optional

Message ID b6e0865f-5528-c7c9-9663-1a14e660c243@sandeen.net (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Eric Sandeen Nov. 20, 2017, 6:10 p.m. UTC 
On 11/20/17 11:54 AM, Eric Sandeen wrote:
> 
> 
> On 11/17/17 1:54 PM, jeffm@suse.com wrote:
>> From: Jeff Mahoney <jeffm@suse.com>
>>
>> Kernels prior to 2.6.36 didn't contain statfs.f_flags.  Distros with
>> initial releases with kernels prior to this may not have updated
>> headers with this member.
> 
> You all are brave ;)
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>

Oops, but not tested-by!  This also needs:



but I can add it on the way in.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jeff Mahoney Nov. 20, 2017, 6:13 p.m. UTC | #1 
On 11/20/17 1:10 PM, Eric Sandeen wrote:
> 
> 
> On 11/20/17 11:54 AM, Eric Sandeen wrote:
>>
>>
>> On 11/17/17 1:54 PM, jeffm@suse.com wrote:
>>> From: Jeff Mahoney <jeffm@suse.com>
>>>
>>> Kernels prior to 2.6.36 didn't contain statfs.f_flags.  Distros with
>>> initial releases with kernels prior to this may not have updated
>>> headers with this member.
>>
>> You all are brave ;)
>>
>> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> 
> Oops, but not tested-by!  This also needs:
> 
> diff --git a/io/Makefile b/io/Makefile
> index 050d6bd..6725936 100644
> --- a/io/Makefile
> +++ b/io/Makefile
> @@ -110,6 +110,10 @@ ifeq ($(PKG_PLATFORM),linux)
>  CFILES += fsmap.c
>  endif
>  
> +ifeq ($(HAVE_STATFS_FLAGS),yes)
> +LCFLAGS += -DHAVE_STATFS_FLAGS
> +endif
> +
>  default: depend $(LTCOMMAND)
>  
>  include $(BUILDRULES)
> 
> 
> but I can add it on the way in.

Ah, right.  My build tests all succeeded because it was just skipping
f_flags.

Thanks,

-Jeff
diff mbox

Patch

diff --git a/io/Makefile b/io/Makefile
index 050d6bd..6725936 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -110,6 +110,10 @@  ifeq ($(PKG_PLATFORM),linux)
 CFILES += fsmap.c
 endif
 
+ifeq ($(HAVE_STATFS_FLAGS),yes)
+LCFLAGS += -DHAVE_STATFS_FLAGS
+endif
+
 default: depend $(LTCOMMAND)
 
 include $(BUILDRULES)