diff mbox

xfsdump: fix build on 32-bit platforms

Message ID d1f01b20-8272-80d8-df1c-0cb5c8f8aa70@sandeen.net (mailing list archive)
State Accepted
Headers show

Commit Message

Eric Sandeen Feb. 17, 2017, 9:02 p.m. UTC
Now that xfsprogs requires anyone using the headers to
properly define 64-bit file access, xfsdump has stopped
building on 32-bit platforms.

I think this is all it needs; works for me here.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

cc: Eric Biggers because he seems to enjoy this stuff :)


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Sandeen Feb. 27, 2017, 5:01 a.m. UTC | #1
On 2/17/17 3:02 PM, Eric Sandeen wrote:
> Now that xfsprogs requires anyone using the headers to
> properly define 64-bit file access, xfsdump has stopped
> building on 32-bit platforms.
> 
> I think this is all it needs; works for me here.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Ping?

(with the dearth of devel traffic for xfsdump, don't want this
to get lost...)

Thanks,
-Eric

> ---
> 
> cc: Eric Biggers because he seems to enjoy this stuff :)
> 
> diff --git a/configure.ac b/configure.ac
> index 7bb6f1d..8d78ed4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -6,6 +6,8 @@ AC_CONFIG_SRCDIR([common/main.c])
>  AC_CONFIG_HEADER(include/config.h)
>  AC_PREFIX_DEFAULT(/usr)
>  
> +AC_SYS_LARGEFILE
> +
>  AC_PROG_LIBTOOL
>  
>  AC_ARG_ENABLE(shared,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig Feb. 27, 2017, 8:45 a.m. UTC | #2
Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 7bb6f1d..8d78ed4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,6 +6,8 @@  AC_CONFIG_SRCDIR([common/main.c])
 AC_CONFIG_HEADER(include/config.h)
 AC_PREFIX_DEFAULT(/usr)
 
+AC_SYS_LARGEFILE
+
 AC_PROG_LIBTOOL
 
 AC_ARG_ENABLE(shared,