| Message ID | fba33a51-50c1-ade6-79d2-f7ceaceb372f@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs_db: add -d to short help for write command | expand |
On Mon, Jul 23, 2018 at 06:25:27PM -0700, Eric Sandeen wrote: > And note in the man page that -c and -d are exclusive. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > > diff --git a/db/write.c b/db/write.c > index 5ef76bcd..bbaa609d 100644 > --- a/db/write.c > +++ b/db/write.c > @@ -38,7 +38,7 @@ static int write_f(int argc, char **argv); > static void write_help(void); > > static const cmdinfo_t write_cmd = > - { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."), > + { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."), > N_("write value to disk"), write_help }; > > void > diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8 > index 10f2beb9..a1ee3514 100644 > --- a/man/man8/xfs_db.8 > +++ b/man/man8/xfs_db.8 > @@ -837,7 +837,7 @@ and > bits respectively, and their string equivalent reported > (but no modifications are made). > .TP > -.BI "write [\-c] [\-d] [" "field value" "] ..." > +.BI "write [\-c|\-d] [" "field value" "] ..." > Write a value to disk. > Specific fields can be set in structures (struct mode), > or a block can be set to data values (data mode), > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 23, 2018 at 06:25:27PM -0700, Eric Sandeen wrote: > And note in the man page that -c and -d are exclusive. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Looks good. Reviewed-by: Bill O'Donnell <billodo@redhat.com> > --- > > diff --git a/db/write.c b/db/write.c > index 5ef76bcd..bbaa609d 100644 > --- a/db/write.c > +++ b/db/write.c > @@ -38,7 +38,7 @@ static int write_f(int argc, char **argv); > static void write_help(void); > > static const cmdinfo_t write_cmd = > - { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."), > + { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."), > N_("write value to disk"), write_help }; > > void > diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8 > index 10f2beb9..a1ee3514 100644 > --- a/man/man8/xfs_db.8 > +++ b/man/man8/xfs_db.8 > @@ -837,7 +837,7 @@ and > bits respectively, and their string equivalent reported > (but no modifications are made). > .TP > -.BI "write [\-c] [\-d] [" "field value" "] ..." > +.BI "write [\-c|\-d] [" "field value" "] ..." > Write a value to disk. > Specific fields can be set in structures (struct mode), > or a block can be set to data values (data mode), > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/db/write.c b/db/write.c index 5ef76bcd..bbaa609d 100644 --- a/db/write.c +++ b/db/write.c @@ -38,7 +38,7 @@ static int write_f(int argc, char **argv); static void write_help(void); static const cmdinfo_t write_cmd = - { "write", NULL, write_f, 0, -1, 0, N_("[-c] [field or value]..."), + { "write", NULL, write_f, 0, -1, 0, N_("[-c|-d] [field or value]..."), N_("write value to disk"), write_help }; void diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8 index 10f2beb9..a1ee3514 100644 --- a/man/man8/xfs_db.8 +++ b/man/man8/xfs_db.8 @@ -837,7 +837,7 @@ and bits respectively, and their string equivalent reported (but no modifications are made). .TP -.BI "write [\-c] [\-d] [" "field value" "] ..." +.BI "write [\-c|\-d] [" "field value" "] ..." Write a value to disk. Specific fields can be set in structures (struct mode), or a block can be set to data values (data mode),
And note in the man page that -c and -d are exclusive. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html