From patchwork Thu Apr 11 02:53:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengjiu Wang X-Patchwork-Id: 10895043 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 196301515 for ; Thu, 11 Apr 2019 02:55:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECDDE28AA1 for ; Thu, 11 Apr 2019 02:55:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0F3F28AC4; Thu, 11 Apr 2019 02:55:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 35DAA28AA1 for ; Thu, 11 Apr 2019 02:55:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 446F384D; Thu, 11 Apr 2019 04:54:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 446F384D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1554951298; bh=OEMfsMFt4nVYhNokGFvsYu82IoM30WPEIPZ0zN5bzmA=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=nBY+wsj/Z4808YSv1TQ21tw+lwyW/6kPkTTUHuD4b71+Wy2x6qPtdpaYeSwIAkJeQ 9sLna9lKX/qTyq5N4clFMuPVSIejHG6QkogtfATnh8Ys4gwe3K+asmpJWANw1pGnnP jp7ukOleTAFDbIl+sLkw+JeFPautvKBduRYX58N0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 18BB6F89625; Thu, 11 Apr 2019 04:54:07 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C404F89636; Thu, 11 Apr 2019 04:54:04 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A5365F89616 for ; Thu, 11 Apr 2019 04:53:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A5365F89616 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="qqVmLmW3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oFRZAj2fVDjtJKeeOGrQYfnkZacjrhxFHT4VJRAJRTQ=; b=qqVmLmW3AzJZBq+lYbEU55IhTXEY9AFFxa84dlKowdBlwnFia61PUo9Gp7XlJ/sahGg9RYjPLGv3+YXWhdObh72vbatOElBbPT0A7sRUH+Kdcpa27YFoRs0XFj4PEm8Eg6kbPBW4TXOb6eNgf4JjvIYJat9rYD8kRmY8/yyfwns= Received: from VE1PR04MB6479.eurprd04.prod.outlook.com (20.179.233.80) by VE1PR04MB6431.eurprd04.prod.outlook.com (20.179.232.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Thu, 11 Apr 2019 02:53:57 +0000 Received: from VE1PR04MB6479.eurprd04.prod.outlook.com ([fe80::6c03:86ad:729d:e311]) by VE1PR04MB6479.eurprd04.prod.outlook.com ([fe80::6c03:86ad:729d:e311%6]) with mapi id 15.20.1771.016; Thu, 11 Apr 2019 02:53:57 +0000 From: "S.j. Wang" To: "timur@kernel.org" , "nicoleotsuka@gmail.com" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "broonie@kernel.org" , "alsa-devel@alsa-project.org" , "gustavo@embeddedor.com" Thread-Topic: [PATCH V3] ASoC: fsl_esai: Fix missing break in switch statement Thread-Index: AQHU8BHOw6LtfQFF70KMm36/nLWEtg== Date: Thu, 11 Apr 2019 02:53:56 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 x-clientproxiedby: HK2PR02CA0165.apcprd02.prod.outlook.com (2603:1096:201:1f::25) To VE1PR04MB6479.eurprd04.prod.outlook.com (2603:10a6:803:11e::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shengjiu.wang@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 190675bc-7fe1-4914-bd8a-08d6be28f0a6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6431; x-ms-traffictypediagnostic: VE1PR04MB6431: x-microsoft-antispam-prvs: x-forefront-prvs: 00046D390F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(396003)(39860400002)(366004)(346002)(189003)(199004)(4744005)(2501003)(36756003)(2616005)(2201001)(102836004)(316002)(6506007)(2906002)(118296001)(476003)(99286004)(305945005)(66066001)(186003)(81156014)(81166006)(256004)(26005)(52116002)(8676002)(14444005)(486006)(106356001)(5660300002)(508600001)(6486002)(8936002)(105586002)(6436002)(386003)(71200400001)(53936002)(71190400001)(7736002)(14454004)(97736004)(110136005)(6116002)(86362001)(4326008)(68736007)(50226002)(25786009)(6512007)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6431; H:VE1PR04MB6479.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tYagBdO0zEpw0HO1F4686zCuaa+GAhAfknpvViQEjExUim1aHWgxYwjdXGGonnzuEE/evitWfhZ0pHgkOiMUmJ3THGpxPoU02Aejucb2W/PvlyvduCXoXsh3syxzY44XCOMbWstqvosq6VfJEi1WfKh05mS0xitJc9U5zb2gyN4IQ9pNVtHQxrr77yyK5HVknTG6kYJbEP7C9dLGfW/XCvXoUIYGxppG/ZLLrGUwimlYDSRjQ+1t5Y5UUqGr2iPEU4pmIJ6v80djuSQvGdLiTNWVQpQxF5OLHhckZo/THXrYAKR43NBc0gcAvtG+RlvWq8Pcx+7blEPwc2ym+X8X44D+BLe8reRdARy2X4idInOurg7xm8FrPYlWCZkR9C+zGm8iy5wx20hokygqK2ceuz2b432A7gAkEWJh9uL7mTU= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 190675bc-7fe1-4914-bd8a-08d6be28f0a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2019 02:53:56.9585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6431 Cc: "linuxppc-dev@lists.ozlabs.org" Subject: [alsa-devel] [PATCH V3] ASoC: fsl_esai: Fix missing break in switch statement X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break. Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Signed-off-by: Shengjiu Wang Cc: --- changes in v3 - add cc stable - change the subject sound/soc/fsl/fsl_esai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 3623aa9a6f2e..15202a637197 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, break; case ESAI_HCKT_EXTAL: ecr |= ESAI_ECR_ETI; - /* fall through */ + break; case ESAI_HCKR_EXTAL: ecr |= ESAI_ECR_ERI; break;