From patchwork Thu Apr 11 23:21:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10897059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E3BF017EF for ; Thu, 11 Apr 2019 23:22:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C573A28B02 for ; Thu, 11 Apr 2019 23:22:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B467528E1E; Thu, 11 Apr 2019 23:22:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5679B28B02 for ; Thu, 11 Apr 2019 23:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=B231d5DJynT5QM7q2rQdf85CZEI5xeL+UJ1Z+2FsQgI=; b=pUDrMBDTg6bbP2 vxm2lAWMW590naWTQcQOPOxF3haLMrXA4nsklNFIiGcfQewTZa9lj7y/V3AgV/72COyJIEtRyQdaW s9XfntI/PfnEKquIyNc9kgsUoowqblE8kzUEg65iN86oI8q9ztwFR9GKdLHyOpgvG4TUM9mRpJZzA sBd6r+t7RszNMyinIQEh4uEEn6LuwB0cubwlKgaMgb8u46ajL9VOQenDnKvNRd+8uGlhU9fDZWxsQ 7MhMvlIPz+nI9PZKVWmZgN9quRBn7uV9Mgl9b/PsgrlRg4CSus7OKNZFgxbGGxTfJH0LJiRkmylwY Wrjjslr/UcdHhbjfYXAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1w-0006ES-I8; Thu, 11 Apr 2019 23:22:52 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1u-0006Cs-2V for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:51 +0000 Received: by mail-pf1-x443.google.com with SMTP id 10so4177753pfo.5 for ; Thu, 11 Apr 2019 16:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IkgB2Wu06Pd4z96v65dmkLjB7xuMujb7ajfyz6BRah8=; b=N4REOu2PSJZDy8Il/YjNSGOzdd42AawfVoDMOOt6HZp1ngpPBE6CA/t76JpBEwkXBl cAN8r2SyAJ1bLpt011QPNQ8lZnjDMCSXRqEMDkWXr0wmUKdmTRvB3oPXPk0Lz5Opngui 1WEL9Zwqmou9Zs2xgCH45HTwTWINT+X5NCU3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IkgB2Wu06Pd4z96v65dmkLjB7xuMujb7ajfyz6BRah8=; b=ZTWZG+q7k0KQ+YbY5BoL14JIeGAXfZ1aOQH+6rFDpT+0uGutoR1tHX84bUmnZmu+ZE 1V6/0MEtJdo5Eak9PX/UqBtjLyKzxzEwmWrbUB1FI4OMP/qVyUTz0IGJNDbxt95+SR8F H0qVfgupPVm44iMIfMRelQhEAy79qH5p/JAtJeefbg4pVNshXh87RspRghvjOKg8cKIN Q724WdMayEcYwnRvEypTRmYwE3IqcRQMMZ8uvRZzyDILxjtyardmfAWFwlCRXGWIh8Kn viJaZtosaeNdDTAJXXxyovkro3hmP5EjkX4Ilci46NCJYy8Ae6pBNhIASvf/oUtj8GE2 9Nbg== X-Gm-Message-State: APjAAAV+h46wMqBf/7sSU71qoXtrq1q+ANU8e/oipyYWYUdzXrKqBHGg gLWPA4JiUvZtePEpt7B9w7aS0g== X-Google-Smtp-Source: APXvYqwIprzlKW2nejCZ3fCZPI0yJSk+LmODFFzKDpPN5QTpEfwTCtsN7TwwhtNqpjpRD3mINi7aMg== X-Received: by 2002:a63:ed48:: with SMTP id m8mr35963091pgk.104.1555024968498; Thu, 11 Apr 2019 16:22:48 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:47 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend Date: Thu, 11 Apr 2019 16:21:53 -0700 Message-Id: <20190411232157.55125-1-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162250_141092_B5EB2E77 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: briannorris@chromium.org, amstan@chromium.org, Stephen Boyd , Michael Turquette , dbasehore@chromium.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Experimentally it can be seen that going into deep sleep (specifically setting PMU_CLR_DMA and PMU_CLR_BUS in RK3288_PMU_PWRMODE_CON1) appears to fail unless "aclk_dmac1" is on. The failure is that the system never signals that it made it into suspend on the GLOBAL_PWROFF pin and it just hangs. NOTE that it's confirmed that it's the actual suspend that fails, not one of the earlier calls to read/write registers. Specifically if you comment out the "PMU_GLOBAL_INT_DISABLE" setting in rk3288_slp_mode_set() and then comment out the "cpu_do_idle()" call in rockchip_lpmode_enter() then you can exercise the whole suspend path without any crashing. This is currently not a problem with suspend upstream because there is no current way to exercise the deep suspend code. However, anyone trying to make it work will run into this issue. This was not a problem on shipping rk3288-based Chromebooks because those devices all ran on an old kernel based on 3.14. On that kernel "aclk_dmac1" appears to be left on all the time. There are several ways to skin this problem. A) We could add "aclk_dmac1" to the list of critical clocks and that apperas to work, but presumably that wastes power. B) We could keep a list of "struct clk" objects to enable at suspend time in clk-rk3288.c and use the standard clock APIs. C) We could make the rk3288-pmu driver keep a list of clocks to enable at suspend time. Presumably this would require a dts and bindings change. D) We could just whack the clock on in the existing syscore suspend function where we whack a bunch of other clocks. This is particularly easy because we know for sure that the clock's only parent ("aclk_cpu") is a critical clock so we don't need to do anything more than ungate it. In this case I have chosen D) because it seemed like the least work, but any of the other options would presumably also work fine. Signed-off-by: Douglas Anderson Reviewed-by: Elaine Zhang --- drivers/clk/rockchip/clk-rk3288.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c index 5a67b7869960..b245367393cd 100644 --- a/drivers/clk/rockchip/clk-rk3288.c +++ b/drivers/clk/rockchip/clk-rk3288.c @@ -859,6 +859,9 @@ static const int rk3288_saved_cru_reg_ids[] = { RK3288_CLKSEL_CON(10), RK3288_CLKSEL_CON(33), RK3288_CLKSEL_CON(37), + + /* We turn aclk_dmac1 on for suspend; this will restore it */ + RK3288_CLKGATE_CON(10), }; static u32 rk3288_saved_cru_regs[ARRAY_SIZE(rk3288_saved_cru_reg_ids)]; @@ -874,6 +877,14 @@ static int rk3288_clk_suspend(void) readl_relaxed(rk3288_cru_base + reg_id); } + /* + * Going into deep sleep (specifically setting PMU_CLR_DMA in + * RK3288_PMU_PWRMODE_CON1) appears to fail unless + * "aclk_dmac1" is on. + */ + writel_relaxed(1 << (12 + 16), + rk3288_cru_base + RK3288_CLKGATE_CON(10)); + /* * Switch PLLs other than DPLL (for SDRAM) to slow mode to * avoid crashes on resume. The Mask ROM on the system will From patchwork Thu Apr 11 23:21:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10897063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3E850922 for ; Thu, 11 Apr 2019 23:23:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22EE428B02 for ; Thu, 11 Apr 2019 23:23:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1742328E1E; Thu, 11 Apr 2019 23:23:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BAEF928B02 for ; Thu, 11 Apr 2019 23:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lbNjgiTdLfShoZnI4tLrk+fbbKTJfc0sQWPkGvgvyYI=; b=jYi3HHIwgWbdx+ IkLTDNhMcaUD5y9JXXEKfwRLbOEpFpGjtcQpPcr/oXyniopcn8VUyCVwq7Pz5KQYmQtTMX6cGW9Ju tde0VkhkExcxtlasxwSVWwcVQ8W9IS/DBrTUY+fBcQJjJP9ds/BGayzbpamNhSO0QMNdg1IqQlmUu EIi04hxjFuxpB0eunWD+1XhlGaaVh0idYUUlGXxm9W9Q4wkwafpFAXLVtngOVkeksQV64ycS9sIVC 4ydz0lLC/rjD/z7mna9vrG5MQTRF3I5HCPixS44y6AjX7L1x8exVtBznCIYIMsFuSczbbOnOXCryJ yZMkQeBeA0W6ZifGMUCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj23-0006Nk-Sc; Thu, 11 Apr 2019 23:22:59 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1u-0006Cw-Ex for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:52 +0000 Received: by mail-pf1-x444.google.com with SMTP id 10so4177780pfo.5 for ; Thu, 11 Apr 2019 16:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8FKJf/NaqYGyiUvGYru2/2r1FkwEHrLbQS3N/eYB4lI=; b=KS/NfPl8RJldrt8mNhy3MbR0s3XVMRoY1JtQVPa2H5JgXYDmX2Gj5reoKqtC6MPJZo MnntIAMLm0VT6DvXWGY+7IVnisZGpq5PMZB0pjigiJOn5VyXVfCaQap5sZgNyAFp0Wkz N7b4JoVpM4Onl7eGHR3DySurhjWIo/rJxSGrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8FKJf/NaqYGyiUvGYru2/2r1FkwEHrLbQS3N/eYB4lI=; b=sOuK5PDH7f4kr5PiCmzEBhKxagnToMypTX2vt2bhJih46UWq20HP7aNIvE6TodBMN8 wTMjdtYhrDXxTx04mtMh5iHIAUtQd+jdadKx2x+8mrUIPV6TQg0KQvWQ835Sh+hzLGQz ua1Z31QzbjxDxyYeNxht0H4A8/p5x7ICNqatxL3vsoNRLsd1SDT7E8GfaZv7TsREpjqu NIc2ftpYSQKSDvoAy5AaauFkqipeUKPG06dnvb2HL5h1bOxvCou51+pwJBXbq/YsGR2/ Fhvl+d6LWivsldNNw09j6eqZrF6wp2z9fB38g62rdcj2AZ6WzuboU57Mr5UUExecPjIw da0w== X-Gm-Message-State: APjAAAVkfyd4CLV/uADgZBNp9gjn4tm50bfamXRag4GY2K8u7k3r3Je2 6x6os3H92Uo2sJR1ovmeq3tA/A== X-Google-Smtp-Source: APXvYqzF6EMcdmnX13ucI/Kyu+YMU4DSuvUyYP7dA+WAWkBpVu3DEO/SrCvvL0Esyk6oCZIVsOY/ZQ== X-Received: by 2002:a63:c302:: with SMTP id c2mr50588843pgd.235.1555024969853; Thu, 11 Apr 2019 16:22:49 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:49 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 2/5] ARM: rockchip: pm: Mark init functions __init Date: Thu, 11 Apr 2019 16:21:54 -0700 Message-Id: <20190411232157.55125-2-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162250_497564_6E3F54F8 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: briannorris@chromium.org, amstan@chromium.org, linux-kernel@vger.kernel.org, dbasehore@chromium.org, Douglas Anderson , Russell King , linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The functions rk3288_config_bootdata() and rk3288_suspend_init() are only called in the context of rockchip_suspend_init() which is already marked __init. We can mark them __init too. Signed-off-by: Douglas Anderson --- arch/arm/mach-rockchip/pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c index 0592534e0b88..065b09e6f1eb 100644 --- a/arch/arm/mach-rockchip/pm.c +++ b/arch/arm/mach-rockchip/pm.c @@ -59,7 +59,7 @@ static inline u32 rk3288_l2_config(void) return l2ctlr; } -static void rk3288_config_bootdata(void) +static void __init rk3288_config_bootdata(void) { rkpm_bootdata_cpusp = rk3288_bootram_phy + (SZ_4K - 8); rkpm_bootdata_cpu_code = __pa_symbol(cpu_resume); @@ -230,7 +230,7 @@ static void rk3288_suspend_finish(void) pr_err("%s: Suspend finish failed\n", __func__); } -static int rk3288_suspend_init(struct device_node *np) +static int __init rk3288_suspend_init(struct device_node *np) { struct device_node *sram_np; struct resource res; From patchwork Thu Apr 11 23:21:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10897067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 267D11800 for ; Thu, 11 Apr 2019 23:23:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0955028B02 for ; Thu, 11 Apr 2019 23:23:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F13D928E1E; Thu, 11 Apr 2019 23:23:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9C28F28B02 for ; Thu, 11 Apr 2019 23:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m1EKsBh0SFs1hRCuN+C5C6e74IkYhw4My38s4ko44yE=; b=BBiq9ssW3lT1rK zmd9nCKD6Wa0MCRsV0XXrQroQz9dVNl2cy/E7E5kVhRcDGv2NUX02DXpw2UQrS4gHCoWEw4AQUKdM a4n6quGI7flXvdd4RbaBqbfNMxXGalDuk7UGNLk8CwaSZziA5436PkgqztV0fRWGouvULjZ+AHHP7 fuJxCBdQ351mvibX9euMAGWplGmRhrzI6lFdYWQk5TkqC+bErpKpr+1hTeXWeHTydLoo5jsM+zOfE qMAmNZUNS6+nloswhtRgwy9WOtJxUVJrXrOJuTXTYdRX2lcgLAgYj535+ts0gRzz9CmmXU8zv5At5 adq2sKbj3d2QVLvVyHdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj2I-0006mD-9f; Thu, 11 Apr 2019 23:23:14 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1v-0006Dm-Mx for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:53 +0000 Received: by mail-pl1-x644.google.com with SMTP id n8so4118674plp.10 for ; Thu, 11 Apr 2019 16:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nFRL7YQcOP+54+XtyuurGi/h9kYH21q/4YonKxFfN48=; b=mtoQdtYdv/A6dVYfHotuBCeIUtbyDJ8QnSoJHmF2egOvgYBi2quA5A2rqVHRmLi+q6 ooffBxjq9ebY6p5spGRew+2qrtZvsCRwsRFUDZhgFYTRWVfBDpmirEnzdGSyZbjwSRpw jPd3gVaKf/sAQMJEA6kzSp0779qcfGB2pQJ7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nFRL7YQcOP+54+XtyuurGi/h9kYH21q/4YonKxFfN48=; b=gbRzpAGzcxidnej6T7Ync+SBckEMLO/BYYgPWlJSAgnwY4/grW2v0n2+7ZjGR+lcmi YDlFUA7XT89FCpSFLn1Gj35p4T/8ZGDGx0T6u9YihWRzRG9O65HHwb9PUMiXUp4Ypx4P c53nFsrS5L1k9lKJJtzyxgaNU1G53Pw36yC/+DLaX+kjzP0869Wsb1VfNxdgiZtuAkCn KoGoin4AKoud3pyFop87jOIaQ55n+g4HMZPu+Z6uPyquNs+6LeeoDmDy59hP9A1gqYM1 68RM1R6EduudiuHg6qiqSp6OdkAy/axbv118SDud3KFgs+ZHXSFqdSPAO+CmfXqOAQ6i FFJg== X-Gm-Message-State: APjAAAX3qr9As/uJ8kYURhjn+MRuJ5nEfo1Zafc7r3WWn9vRY91nEoaf qzwNiM7QaX2UZ6HQGALTLeamRg== X-Google-Smtp-Source: APXvYqw7aAMpX9Ku6JhGdnv7ENn2RP8AbEIfD/ZttHWgz8+ulfZ4g1HN8piQntu0ujz0VpdwcKBY/w== X-Received: by 2002:a17:902:9a95:: with SMTP id w21mr51217464plp.74.1555024970982; Thu, 11 Apr 2019 16:22:50 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:50 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 3/5] ARM: dts: rockchip: Add DDR retention/poweroff to rk3288-veyron hogs Date: Thu, 11 Apr 2019 16:21:55 -0700 Message-Id: <20190411232157.55125-3-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162251_858835_C9534C5D X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, amstan@chromium.org, dbasehore@chromium.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Even though upstream Linux doesn't yet go into deep enough suspend to get DDR into self refresh, there is no harm in setting these pins up. They'll only actually do something if we go into a deeper suspend but leaving them configed always is fine. Signed-off-by: Douglas Anderson --- arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 ++++ arch/arm/boot/dts/rk3288-veyron.dtsi | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index 72c4754032e9..b9cc90f0f25c 100644 --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi @@ -229,6 +229,8 @@ &pinctrl { pinctrl-0 = < /* Common for sleep and wake, but no owners */ + &ddr0_retention + &ddrio_pwroff &global_pwroff /* Wake only */ @@ -236,6 +238,8 @@ >; pinctrl-1 = < /* Common for sleep and wake, but no owners */ + &ddr0_retention + &ddrio_pwroff &global_pwroff /* Sleep only */ diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 5c67acc3e6d8..279d7f4ecce0 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -451,10 +451,14 @@ pinctrl-names = "default", "sleep"; pinctrl-0 = < /* Common for sleep and wake, but no owners */ + &ddr0_retention + &ddrio_pwroff &global_pwroff >; pinctrl-1 = < /* Common for sleep and wake, but no owners */ + &ddr0_retention + &ddrio_pwroff &global_pwroff >; From patchwork Thu Apr 11 23:21:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10897073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF69317EF for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4ABD28B02 for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A815328E1E; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4EA5528B02 for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ZHLGKNyYn4RUq7ol+Lu6NFpLNkbPQUvTsTJ3lz/eAU=; b=IhbPAbpdGjMcjz USJFpzSj7QWAHFHBF7bMjHNdWSaoL7iAkts6ZZjRQWykpBWBs+NWehhdT8f1M6C/YFl150dut2JdS zY8BTThL8OKB/AKHN8wZ0kJIIkCUkLPRMyM6z5SjwbR5z2Nb7PZOBrZ3FbP6o5oZGDqu4BRCYWoo5 Ykyj3pUSLdYL7Jcg/cA11+xAVif65/CWfb9sJ/G/Mqst+qbMxqcj+v93kJCnCxBjXCpGR1JDzR9Tj LmyaiFKGaawRTpnf6Deq0GBsEO9+j/k1vVFQCTL4SPA5xEOV8YqxkD7mNCMHo1p2EbJ4CdfG5yfSm DE5uY2EqlI7Y54oLnUSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj2e-0007Fz-BY; Thu, 11 Apr 2019 23:23:36 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1w-0006ER-IY for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:55 +0000 Received: by mail-pf1-x442.google.com with SMTP id b3so4185695pfd.1 for ; Thu, 11 Apr 2019 16:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wyUtO6FBL1xGO1LJ/Cb0qrWJLFLRp1Daf+h1sPg+o68=; b=TPS/dpoQuEcPL74mFmY5Uu60oJSHdAOiKPcubSb51l+oOx9K6r+U5YweUjegwXEhNk Ak+ZDNB5BJbm2Dwp5VgYogWw3aqICJd/kHSUrL/fEc0SKuJbzjOtBFUEJ+kiljE4vK5e FMpSlLeSusSGvEg82D+uwsy5EklfJ/Gm9EAJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wyUtO6FBL1xGO1LJ/Cb0qrWJLFLRp1Daf+h1sPg+o68=; b=kQ6WxDrjsk0Ap0OBSdicJc3IICuFBWg3Id8Y4h7eV5lFFtTglP7RmQqpLAeLUCcEPx dIsS+5KvIaKWfjzRHC2n0P905UYtS5CW1Mktg1NSFwNDTKQhxPD5O3MJCHKLSWBKSyRp cnoc0VkMU0x1V2gb3ThE4QyleXXzBC6/Tud995tAyELl2r0PyTT7ZPGiHkmI38rS12li TPCHbynK+teQ9BC/iLIcbxkqd/RWOVRK2FtsZozO0+IKEyYzBRbgoqYGk+5poXWGaDGl MhlEVXMMA7TlL9bRhHsTw560UceN2MWXKZItO+xLRwgbjAiDmX1qSADD+qI40QdYf0Fu oklA== X-Gm-Message-State: APjAAAW2kQ1op13NK58OemDNX0m1yXTSiBbcU7i9ZX+86+SkVo/VoTMv xUyEP9Vk3XLZwgDqrpYBOjIhZA== X-Google-Smtp-Source: APXvYqzs4AKfNFevOdhKmdg8KcOTyRngwms5IiA0+9tyh468oqtIH4NxO2YYemeRS8vq4ZNVmBoUdQ== X-Received: by 2002:a62:2fc7:: with SMTP id v190mr51345536pfv.10.1555024972090; Thu, 11 Apr 2019 16:22:52 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:51 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook Date: Thu, 11 Apr 2019 16:21:56 -0700 Message-Id: <20190411232157.55125-4-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162252_758156_5136AADD X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, amstan@chromium.org, dbasehore@chromium.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As per my comments when the device tree for rk3288-veyron-chromebook first landed: > Technically I think vcc33_ccd can be off since we have > 'needs-reset-on-resume' down in the EHCI port (this regulator is for > the USB webcam that's connected to the EHCI port). > > ...but leaving it on for now seems fine until we get suspend/resume > more solid. It's probably about time to do it right. [1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=U37Yx8Mqk75_x05zxonvdc3qRMhqp8TyTDPWGHqSuRqg@mail.gmail.com/ Signed-off-by: Douglas Anderson Reviewed-by: Elaine Zhang --- arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index b9cc90f0f25c..fbef34578100 100644 --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi @@ -176,8 +176,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <3300000>; + regulator-off-in-suspend; }; }; }; From patchwork Thu Apr 11 23:21:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 10897075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76B6A922 for ; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C0B628B02 for ; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5052F28E1E; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DFF3628B02 for ; Thu, 11 Apr 2019 23:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cBAjOOp/tbZ3Amadmxy3lPW4dZVv3cO7rw7cOiGi4Vg=; b=OtlqvxMr6sXs8l JHbFM48nltOBjsFQ4Laxm7N2wAIqc4JwgWKfm8YOM9VRlJ/3k9eizVZTexDjM7jra4p+EJKXPzCQa bdFglvzRX0EquUEHpXsn/IUwxmZjXrmXkTDHkobKnx0rUgSuL6VUGAQvlPovNSNoexCGu6nNksN1m GSXByPurYFc19s+SLO+IX+XedajivfkZkIPbTueTVDKS9BbvmrE14th+DV00uiqzdc3ZXFReRibWx zZhKdSwuRkjl20isFFwA5WufDfmQyON4zDKUZU22lDwphptkwz+WiSXsu4F7oXFvfB7WDers8wvtE dOx4SOcdiI5XnCBhvKqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj2g-0007IF-7y; Thu, 11 Apr 2019 23:23:38 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1x-0006FZ-K6 for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:55 +0000 Received: by mail-pl1-x644.google.com with SMTP id t16so4148168plo.0 for ; Thu, 11 Apr 2019 16:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dL9JtcZ92ryYmPw47PdDoJyrwRFQyhVA65jTVCpTryA=; b=Sr77n9xkvP4TmRJRlFx+/1VN6Dgqc6UfpixQ1GSApsVFnAs2CAIlHTRNhdSholz9gh E0W/+rxbcVE4Sk0kKEJSjJpEwqo5SmT4ONkdLlVl5L8LcEwOiD3OcJKhzY3/nbzjJaM3 2T1pIxq/6DDdtBkR22oAPqRH86BRG7IpZdKSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dL9JtcZ92ryYmPw47PdDoJyrwRFQyhVA65jTVCpTryA=; b=dKffXqTBMLa90rRt76twAApoIUymASH57R6rAlfPNnMuRxQuV9nNCwc6JgnGO/jc+S vXZ/qMQms3verq2egCFCfp8gmnh1gTrOp+6KsDCVPzdn0qlC602N+GG1rhDZioAUu0cO ixUuHjh/OxJ2xRZdihTVH/UbCa9CVQ0pBuPutaOFbUBfCGSk4i2dJhAIRZkKV+8/cth9 H2V33E4VaDihgYpXe1xGrRRqyEQehdaJqj9s73k0Ku/Wi9wE5gfW6dffgOwbCFDsdNyF ZI+PZe8kna4SiRkGY82eIrn5SI5Hr38gmxzfgHRoKYlhz1iPlF1aUUMDxWMVmpZyfm6/ AXeQ== X-Gm-Message-State: APjAAAVE5Kt6OfglfDoGKuG+R2zp64HJmsVfsWjSDRUtMCLsoOQdmZlY uWZkNZIg/Hwgy7AfCzFNLMjp3g== X-Google-Smtp-Source: APXvYqxR3xzpG4aO7AHfUFf+3SjHVnPXZxk4DrkkC1n22Mku+W8I6WVCHkI9MtZMNBQwKnm8EptMEA== X-Received: by 2002:a17:902:e684:: with SMTP id cn4mr51769749plb.71.1555024973170; Thu, 11 Apr 2019 16:22:53 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:52 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron Date: Thu, 11 Apr 2019 16:21:57 -0700 Message-Id: <20190411232157.55125-5-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162253_785543_34248149 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, amstan@chromium.org, dbasehore@chromium.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP At some point long long ago the downstream GPU driver would crash if we turned the GPU off during suspend. For some context you can see: https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts At some point in time not too long after that got fixed. It's unclear why the GPU is left enabled during suspend on the mainline kernel. Everything seems fine if I turn this off, so let's do it. Signed-off-by: Douglas Anderson Reviewed-by: Elaine Zhang --- arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 279d7f4ecce0..1252522392c7 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -217,8 +217,7 @@ regulator-max-microvolt = <1250000>; regulator-ramp-delay = <6001>; regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <1000000>; + regulator-off-in-suspend; }; };