From patchwork Sat Apr 13 07:14:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 10899321 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A45C17EF for ; Sat, 13 Apr 2019 07:20:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6AB028E89 for ; Sat, 13 Apr 2019 07:20:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8D4428E91; Sat, 13 Apr 2019 07:20:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8257F28E89 for ; Sat, 13 Apr 2019 07:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lsCrsJmkMWh/V4673sgUvj6SrevEgKF/1oQ5n14sx9I=; b=KbeWcT6azEsWEsj8D5JWA3KES4 AIpa1Zho/aP/p048Ku4eUcMjpfMKMZXm1/VdSDgnQ4Eq7BZvbVHSce+Ea1n3kNPojzN5BefAFy/7i Ji2kz8SNRPcychpeVqB9pMiDWtkEXG3PR3mz2VW7AGvuO3pm878ofPl7HuAsGwpiw5woFG9cBvb0W WDa68xISgBcBWPn+xrzXTqE47Be97jRcsnallFlRVrGcwdhcwCbNhPRNzXHp+ajTdGHLmGExrqHUT WlKbhotIy3iCHwIhPoypeBGgund3BuSVT9nut8EgSU0iyhC4y96GXoGxx39jF5cXjZOoJLh1xKOUJ 7R6WAdmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFCy8-0003iH-1m; Sat, 13 Apr 2019 07:20:56 +0000 Received: from www.osadl.org ([2001:a60:9266:ffff:62:245:132:105]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFCxu-0003VK-I3 for linux-arm-kernel@lists.infradead.org; Sat, 13 Apr 2019 07:20:46 +0000 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id x3D7JfAW003435; Sat, 13 Apr 2019 09:20:24 +0200 From: Nicholas Mc Guire To: Russell King Subject: [PATCH] ARM: u300: add missing check for kmalloc Date: Sat, 13 Apr 2019 09:14:20 +0200 Message-Id: <1555139666-948-9-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1555139666-948-1-git-send-email-hofrat@osadl.org> References: <1555139666-948-1-git-send-email-hofrat@osadl.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190413_002043_280421_E62BB6AC X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Rapoport , Tony Lindgren , Shawn Guo , Sascha Hauer , Janusz Krzysztofik , linux-kernel@vger.kernel.org, Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Nicholas Mc Guire , Fabio Estevam , Linus Walleij , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP kmalloc return for bigrxbuf_virtual was not being checked - in case of failure set status, cleanup bigtxbuf_virtual and baile out. Signed-off-by: Nicholas Mc Guire Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") --- Issue found with experimental coccinelle script Not sure about the checkpatch message: CHECK: Comparison to NULL could be written "!bigrxbuf_virtual" #32: FILE: arch/arm/mach-u300/dummyspichip.c:67: + if (bigrxbuf_virtual == NULL) { As the current check for bigtxbuf_virtual uses == NULL that was retained for consistency here. Patch was compile tested with: u300_defconfig (implies MACH_U300_SPIDUMMY=y) Patch is against 4.18 (localversion-next is next-20180824) arch/arm/mach-u300/dummyspichip.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-u300/dummyspichip.c b/arch/arm/mach-u300/dummyspichip.c index 68fe986..ff293ee 100644 --- a/arch/arm/mach-u300/dummyspichip.c +++ b/arch/arm/mach-u300/dummyspichip.c @@ -62,7 +62,13 @@ static ssize_t dummy_looptest(struct device *dev, status = -ENOMEM; goto out; } + bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); + if (bigrxbuf_virtual == NULL) { + kfree(bigtxbuf_virtual); + status = -ENOMEM; + goto out; + } /* Fill TXBUF with some happy pattern */ memset(bigtxbuf_virtual, 0xAA, DMA_TEST_SIZE);