From patchwork Tue Apr 16 10:25:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10902615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB11A1515 for ; Tue, 16 Apr 2019 10:25:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81B7E289A9 for ; Tue, 16 Apr 2019 10:25:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 74344283BB; Tue, 16 Apr 2019 10:25:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2B8AF2893A for ; Tue, 16 Apr 2019 10:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=y3a/Cp2uY8ZyQt+VW5XU2E/McU5YN9yJ9M9Q9IY5jR8=; b=NyY3smAV1vPG/yYXsAhEkP+XZ0 Dc0k07/oefqFtJTST0clp5ZzgzCMLlENa/QGQiaEvLEFQMVn1MetSSc4Cig+4oH8wW3sjFBXOn6ka W1dYqYZUVEO+J1JxrfYvRM1kxrIw3Mfba0CEBIpyrGSf0NH2P5vE76U3XInP5awsLb87YW8dgHxea XS6cjP8w9+ioEbpCSqG7H5TCQT0mS0rZCn9Gw3Bl01fnIMg/LFwyOGOEI58ovaC8v7IcH94TDv8hM EO5/i+9LBLDPEqctU3tkvKhppnW/foXr2CJAcF5D9W6ggaETRoqaARgkSiVZ/qDif530C6+mV/V1T x9aXmQmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHa-0006ht-9T; Tue, 16 Apr 2019 10:25:42 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHR-0006YT-5X for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 10:25:34 +0000 Received: from localhost (p54B332D3.dip0.t-ipconnect.de [84.179.50.211]) by pokefinder.org (Postfix) with ESMTPSA id 829732E35BE; Tue, 16 Apr 2019 12:25:27 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v2 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout Date: Tue, 16 Apr 2019 12:25:07 +0200 Message-Id: <20190416102515.12269-9-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> References: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_032533_358323_36A04AE3 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , NXP Linux Team , Pengutronix Kernel Team , Wim Van Sebroeck , Shawn Guo , Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/imx_sc_wdt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c index 86c2722f2a09..6dc24ceb1b2c 100644 --- a/drivers/watchdog/imx_sc_wdt.c +++ b/drivers/watchdog/imx_sc_wdt.c @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) imx_sc_wdd->parent = &pdev->dev; imx_sc_wdd->timeout = DEFAULT_TIMEOUT; - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); - if (ret) - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); - + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); watchdog_stop_on_reboot(imx_sc_wdd); watchdog_stop_on_unregister(imx_sc_wdd); From patchwork Tue Apr 16 10:25:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10902609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EB84113B5 for ; Tue, 16 Apr 2019 10:25:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C92DE283BB for ; Tue, 16 Apr 2019 10:25:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD1C3289A9; Tue, 16 Apr 2019 10:25:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 781A2283BB for ; Tue, 16 Apr 2019 10:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+ICW5CcY8T9URexrJkJa+MJgUSZnPn9I67A/bJdTrWM=; b=Gsv5ep6qc1X86g4CiAFsdgM9tt H5z0dK1CYNZVPbWr6mqScYHDqYpuZF7lYAm6vW73VgIuhhwo/UWd7Zg9zP+wSoQWt3S2o4xuLMMzb li1dnhHsDCGRdU9FerP+D7mGDXYg9X0gT/M8Krw9UtiSIiWs+tL7PnHqrZowiBXwTO/uZfuoM/YDI zi//Jk1Fyx7xY5jNbxWTbVvYHpljZZbbfXh3uYLMiOxBucwTWZsP701j6O5hblcU5p9s0UJTe3BvY 9vysASidmK86EpBGBjDeeo2lG/+45PYkLCwTKtaez7pn7KUK3120JduBKa37WnyVXVHdwRKZwIdwe n41rnFZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHV-0006ag-BL; Tue, 16 Apr 2019 10:25:37 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHR-0006Yv-70 for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 10:25:34 +0000 Received: from localhost (p54B332D3.dip0.t-ipconnect.de [84.179.50.211]) by pokefinder.org (Postfix) with ESMTPSA id 4D0A52E35C4; Tue, 16 Apr 2019 12:25:30 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v2 13/16] watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout Date: Tue, 16 Apr 2019 12:25:12 +0200 Message-Id: <20190416102515.12269-14-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> References: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_032533_416814_F66B00A2 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Patrice Chotard , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, Wim Van Sebroeck , Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/st_lpc_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c index 9a5ed95c3403..7a90184eb950 100644 --- a/drivers/watchdog/st_lpc_wdt.c +++ b/drivers/watchdog/st_lpc_wdt.c @@ -224,10 +224,8 @@ static int st_wdog_probe(struct platform_device *pdev) /* Init Watchdog timeout with value in DT */ ret = watchdog_init_timeout(&st_wdog_dev, 0, dev); - if (ret) { - dev_err(dev, "Unable to initialise watchdog timeout\n"); + if (ret) return ret; - } ret = devm_watchdog_register_device(dev, &st_wdog_dev); if (ret) { From patchwork Tue Apr 16 10:25:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10902629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F05913B5 for ; Tue, 16 Apr 2019 10:26:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0FC7283BB for ; Tue, 16 Apr 2019 10:26:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E5471289A9; Tue, 16 Apr 2019 10:26:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C6443283BB for ; Tue, 16 Apr 2019 10:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=yLrvPWc6tfUUAYwQX86U3xNpwxyEi5mrlAoBCwtgBlU=; b=cJ+Hb2QTLDolooS+JZZXPFYnPO A+DPKZHawqIxz2052Iez7xPnzCWMX2tZJgA5mA8YXmOUKUDE/gJuRL99H5tcljH83szbnQr3AJAiz 925aX/uSsPXZ6UTOep5xmHtnyXzIn4ViZPt/XsUyezE7BeqeMni+BlDwR+a1UHsmjQma8iYohIgLd 3DHJlVqit4IteHeRabi17DCzzfabUcseSbxFcXPQoO1JQV62lZO4Eizny9Kk6+dircCfO7GXU/sVJ nrWSwIlL++XNz5QbbJMJ4t8poET0IiqLYKJBrO67r8H3Ns/Tn6GkuQcbvnbh1yDFzJdQlzWJYyTl+ Zkp9ZNMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHv-00075U-1k; Tue, 16 Apr 2019 10:26:03 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLHS-0006Yx-CL for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 10:25:35 +0000 Received: from localhost (p54B332D3.dip0.t-ipconnect.de [84.179.50.211]) by pokefinder.org (Postfix) with ESMTPSA id D451F2E35C5; Tue, 16 Apr 2019 12:25:30 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v2 14/16] watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout Date: Tue, 16 Apr 2019 12:25:13 +0200 Message-Id: <20190416102515.12269-15-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> References: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_032534_561006_56505A5E X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Wim Van Sebroeck , linux-stm32@st-md-mailman.stormreply.com, Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/stm32_iwdg.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index 309563e002b8..50ce762bddb2 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -235,11 +235,7 @@ static int stm32_iwdg_probe(struct platform_device *pdev) watchdog_set_drvdata(wdd, wdt); watchdog_set_nowayout(wdd, WATCHDOG_NOWAYOUT); - - ret = watchdog_init_timeout(wdd, 0, &pdev->dev); - if (ret) - dev_warn(&pdev->dev, - "unable to set timeout value, using default\n"); + watchdog_init_timeout(wdd, 0, &pdev->dev); ret = watchdog_register_device(wdd); if (ret) {