From patchwork Thu Aug 23 14:11:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuo Handa X-Patchwork-Id: 10574219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF550921 for ; Thu, 23 Aug 2018 14:59:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CBA72C2BB for ; Thu, 23 Aug 2018 14:59:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 907172C2C5; Thu, 23 Aug 2018 14:59:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB7E72C2BB for ; Thu, 23 Aug 2018 14:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B32EC6B28D3; Thu, 23 Aug 2018 10:59:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AE36E6B2923; Thu, 23 Aug 2018 10:59:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D2506B2925; Thu, 23 Aug 2018 10:59:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 5D9B96B28D3 for ; Thu, 23 Aug 2018 10:59:31 -0400 (EDT) Received: by mail-pf1-f199.google.com with SMTP id t26-v6so3371772pfh.0 for ; Thu, 23 Aug 2018 07:59:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=9TD76GWdIKPXb8zcPibHi6/1X7u9omZDzUPj2Xp0dBw=; b=EyjuPCY7ML3ZOKfUE5gJaG8tsHz57mVAqmbIaUv1RGVess6h86uukcBdB4QovQnc3I 1HbZwBQgq5ZFdhYz4EAG+ZZfqFe6uRns68Kn7zVZDwTq712JndN4zbOZjuK86fg3gBis +0IrtrBdSAut1rL72gRk4E15NGllUSWSwdtVLfUmgZRA8Gk05ufMUjy37pDWp5+KWNHn 4DolvjXZgFz1y62NzfTpAb7IfqxNxiLsvx7I6bSK9CtrT2gBQG0LNommyz4Vxi3Ou6fc iwzwvS9UVMFM4jEA8vGmX/+v1m3zIH4SGgStf34rlqDlIn5VIxBx3LWjhcEzypZEzfoM c4mg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp X-Gm-Message-State: AOUpUlFHuxRG8wvK5mvhNLZw7DcqQ/hq5lZhWauqD0TBsiEuLcmwKjiz wFwTKA3KZOEurO4812AiYC99rirkK8QcPWFLZQRp1rQwT8n3a+GOVLt97YSSExGCM1izxOBXsZA BxVNUSk/kOnlil6iLviN93QnWaeL6NYBJQBS2EDwvlP0r3kMDkkwA9siCgHTU4MVrag== X-Received: by 2002:a63:1866:: with SMTP id 38-v6mr23097061pgy.313.1535036371025; Thu, 23 Aug 2018 07:59:31 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwduupV5Uy8nHZitfzr5DmOv+Rfwvc8KN7TRSk0BMCDIKsfAxeag/1oRGGN+YZXJ98m4a1u X-Received: by 2002:a63:1866:: with SMTP id 38-v6mr23097012pgy.313.1535036370103; Thu, 23 Aug 2018 07:59:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535036370; cv=none; d=google.com; s=arc-20160816; b=gNhE640YJmZI38AK+VEYgLvJHjUpHjJqi0QHXJQfh/Dsw1c0Ys4WlVCArV9JSgGe9T AkS0aZ4mdfk46A1ReqjdBMIO+6xyfg1WWOG1MQjmZaneYKgXHUBHe8G5XeUMFDKysd9q 4MRHy+ZsAcPQ8wOZP1hX47rBEL/Iw5WVFQH5wcP9Zc7G1Xst9hk1hlwuDzr9+vc4WCPR 5DrOWcZpzS02KzkSXEveumZfjvotxiYbQaF2OHxIPqUF4eQFs0HzTViUO5Vzs+4nk+5x qMwqebtuwZ38gbPvpFIwW71+BAzx+Wo4Z937Q8AEU7enkXSp9CToPyYsv3hYBo8GcTSt tknQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=9TD76GWdIKPXb8zcPibHi6/1X7u9omZDzUPj2Xp0dBw=; b=SSJl9XGwnjD9T4OPVNy5OHZB+VAvcAj6AnJuP4S7bGsgtV5aMQ10elK1DlLrTLspeo iCqEhe/3ovx0rzbNrc0Sqc3zEU2mnIoCgnv48YPZkVvoRpj8zxd2XNFhEx2dMPkq/AtU 1dRKXAPGxGEtegBHmQnp8TvK7Yzoug78NMgET4/618x5cWgcdwjrDRp9dRZDaP9f0hem Ii6yi0wbtQk5XeBDxZxCyrFl00K7tWnVXQ3wD3XV+K4XuSncZxGVcnsJjGJN+TuDUWkS srsP2T+lTNvLHlbqrTsPkES4VDJsknghvy8rg0h3EEDQAk04EAlI6RyDa+Ufvf1RMlhw ztPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from www262.sakura.ne.jp (www262.sakura.ne.jp. [202.181.97.72]) by mx.google.com with ESMTPS id d81-v6si5203941pfm.226.2018.08.23.07.59.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Aug 2018 07:59:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) client-ip=202.181.97.72; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from fsav404.sakura.ne.jp (fsav404.sakura.ne.jp [133.242.250.103]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w7NEBTRw091514; Thu, 23 Aug 2018 23:11:29 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav404.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav404.sakura.ne.jp); Thu, 23 Aug 2018 23:11:29 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav404.sakura.ne.jp) Received: from [192.168.1.8] (softbank060157066051.bbtec.net [60.157.66.51]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id w7NEBTt6091509 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 23 Aug 2018 23:11:29 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: [PATCH v2] mm, oom: Fix missing tlb_finish_mmu() in __oom_reap_task_mm(). To: Michal Hocko Cc: David Rientjes , Andrew Morton , linux-mm@kvack.org References: <1535023848-5554-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20180823115957.GF29735@dhcp22.suse.cz> <6bf40c7f-3e68-8702-b087-9e37abb2d547@i-love.sakura.ne.jp> <20180823140209.GO29735@dhcp22.suse.cz> From: Tetsuo Handa Message-ID: Date: Thu, 23 Aug 2018 23:11:26 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180823140209.GO29735@dhcp22.suse.cz> Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Commit 93065ac753e44438 ("mm, oom: distinguish blockable mode for mmu notifiers") added "continue;" without calling tlb_finish_mmu(). It should not cause a critical problem but fix anyway because it looks strange. Signed-off-by: Tetsuo Handa Acked-by: Michal Hocko --- mm/oom_kill.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index b5b25e4..4f431c1 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -522,6 +522,7 @@ bool __oom_reap_task_mm(struct mm_struct *mm) tlb_gather_mmu(&tlb, mm, start, end); if (mmu_notifier_invalidate_range_start_nonblock(mm, start, end)) { + tlb_finish_mmu(&tlb, start, end); ret = false; continue; }