From patchwork Fri Apr 19 18:15:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10909063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E1FBC14DB for ; Fri, 19 Apr 2019 18:16:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D617E28D3F for ; Fri, 19 Apr 2019 18:16:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA27828D97; Fri, 19 Apr 2019 18:16:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 880AD28D3F for ; Fri, 19 Apr 2019 18:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=y3a/Cp2uY8ZyQt+VW5XU2E/McU5YN9yJ9M9Q9IY5jR8=; b=tZVGV03PBHXLdKfyy2cYeO2n+F 9uIGAKuDGS/6lRSQp4HxNFQ0kBXOel6tUWAaQ92XKieYdvyNWt/QfV7c0GN15lCrq1lTlVSX4HuFK OuRtcbRt0Py8W+Fi5P0/nOQkszRBMWWsqfTNbuWMEKpIX2ofpSn+pji2ObrtQZ8SoZRSPPjo+3vCV tuLTXX3XyFpWKkP9mKmofpGVEi5poROqMb6ffsJ9sHSudA/h1aHy340tizXxlrVNpNS8sTFYIUWBw U71h1wnj823UsZQG6hHm9YsvLhXzRwix0JrCm2JRyeMPpSh+gs4/8mWOtpp8acNUW/eAd8qAgxNgg v30AsRkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY3h-0001jM-WA; Fri, 19 Apr 2019 18:16:22 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY3d-0001hq-OQ for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 18:16:20 +0000 Received: from localhost (p5486CC46.dip0.t-ipconnect.de [84.134.204.70]) by pokefinder.org (Postfix) with ESMTPSA id 556BF2E35C0; Fri, 19 Apr 2019 20:16:13 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v3 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout Date: Fri, 19 Apr 2019 20:15:53 +0200 Message-Id: <20190419181601.7412-9-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_111618_155907_5E428988 X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , NXP Linux Team , Pengutronix Kernel Team , Wim Van Sebroeck , Shawn Guo , Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/imx_sc_wdt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c index 86c2722f2a09..6dc24ceb1b2c 100644 --- a/drivers/watchdog/imx_sc_wdt.c +++ b/drivers/watchdog/imx_sc_wdt.c @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev) imx_sc_wdd->parent = &pdev->dev; imx_sc_wdd->timeout = DEFAULT_TIMEOUT; - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); - if (ret) - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n"); - + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev); watchdog_stop_on_reboot(imx_sc_wdd); watchdog_stop_on_unregister(imx_sc_wdd); From patchwork Fri Apr 19 18:15:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10909065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDCA817EE for ; Fri, 19 Apr 2019 18:16:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1D7128D3F for ; Fri, 19 Apr 2019 18:16:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B48F328D97; Fri, 19 Apr 2019 18:16:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F6B028D3F for ; Fri, 19 Apr 2019 18:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+ICW5CcY8T9URexrJkJa+MJgUSZnPn9I67A/bJdTrWM=; b=j5Fh0SNK+qzTqEI05svtjdraRU wQFZLoI8kRiPqN80+vzOfSWBuuCl+/HHlESaLZjmNLPF1bOMx0Gs+7DTfYm/1JGOIcFmRLPvysaHs GkNesRB0ZrWbL0PKmRMgh6mUFtNGgF9U3ayJDt4HHpBgHRUsxotW90O8W+zhMpd0zlkRPPQ6nrWCI +A405snp0MbNe7sl/eXqK/i3t4dzRSEIVEPPduuUm+9PEPiYeuTikAqHrdeyfLiR+kr80EZwh5mmi /sBtUH7dwg6cB6upHrH1mZnm60osg7n0y7kzI4UJcMF4fJBgpXMXyGuponvZ33NU5gUvN4d2nv2A3 IVquiwGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY3o-0001q8-S3; Fri, 19 Apr 2019 18:16:28 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY3e-0001iC-9D for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 18:16:20 +0000 Received: from localhost (p5486CC46.dip0.t-ipconnect.de [84.134.204.70]) by pokefinder.org (Postfix) with ESMTPSA id 23DE82E35C6; Fri, 19 Apr 2019 20:16:16 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v3 13/16] watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout Date: Fri, 19 Apr 2019 20:15:58 +0200 Message-Id: <20190419181601.7412-14-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_111618_482810_037FDAC1 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Patrice Chotard , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, Wim Van Sebroeck , Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/st_lpc_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c index 9a5ed95c3403..7a90184eb950 100644 --- a/drivers/watchdog/st_lpc_wdt.c +++ b/drivers/watchdog/st_lpc_wdt.c @@ -224,10 +224,8 @@ static int st_wdog_probe(struct platform_device *pdev) /* Init Watchdog timeout with value in DT */ ret = watchdog_init_timeout(&st_wdog_dev, 0, dev); - if (ret) { - dev_err(dev, "Unable to initialise watchdog timeout\n"); + if (ret) return ret; - } ret = devm_watchdog_register_device(dev, &st_wdog_dev); if (ret) { From patchwork Fri Apr 19 18:15:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10909071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0598514DB for ; Fri, 19 Apr 2019 18:16:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECA2C28D3F for ; Fri, 19 Apr 2019 18:16:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0A2928D97; Fri, 19 Apr 2019 18:16:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9DA9D28D3F for ; Fri, 19 Apr 2019 18:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=yLrvPWc6tfUUAYwQX86U3xNpwxyEi5mrlAoBCwtgBlU=; b=MrOvjHgAq6tabGJp4IJKHvPLKq eablmC05dDftnxgJaGZTyym4HORlMYHW6PsXWCLp3SShAv2i3Zkw2IBfXSQ0YtZbGpcwwpwEg77aD Ry2EyFcyaPp0CrU5zzOnDqEPcyvi37SAb0nV4SalhW51ChCFUHV1YAv9iOpmIxwqTzZ53Ua0zyec+ OqnHmxhOetsANGND0WroRTx+Qn8ZvIAmz8/wCKIIEz2qSdVXLXHMiLvHaZOs0XoaO3kMJtcPBNroz QXHtaX4PSkebUX8gwUQnTAJPZQNHGudp4GBerT8lN10U7f5hWtaLWQvQY6qCO0Gntc9Y+eKZTx2Tf 2vK54b2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY4B-0002Fx-9k; Fri, 19 Apr 2019 18:16:51 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHY3e-0001iD-Ph for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 18:16:21 +0000 Received: from localhost (p5486CC46.dip0.t-ipconnect.de [84.134.204.70]) by pokefinder.org (Postfix) with ESMTPSA id AC9822E35C7; Fri, 19 Apr 2019 20:16:16 +0200 (CEST) From: Wolfram Sang To: linux-watchdog@vger.kernel.org Subject: [PATCH v3 14/16] watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout Date: Fri, 19 Apr 2019 20:15:59 +0200 Message-Id: <20190419181601.7412-15-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> References: <20190419181601.7412-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_111618_977345_3A73780B X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Wim Van Sebroeck , linux-stm32@st-md-mailman.stormreply.com, Guenter Roeck MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The core will print out details now. Reviewed-by: Guenter Roeck Signed-off-by: Wolfram Sang --- drivers/watchdog/stm32_iwdg.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index 309563e002b8..50ce762bddb2 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -235,11 +235,7 @@ static int stm32_iwdg_probe(struct platform_device *pdev) watchdog_set_drvdata(wdd, wdt); watchdog_set_nowayout(wdd, WATCHDOG_NOWAYOUT); - - ret = watchdog_init_timeout(wdd, 0, &pdev->dev); - if (ret) - dev_warn(&pdev->dev, - "unable to set timeout value, using default\n"); + watchdog_init_timeout(wdd, 0, &pdev->dev); ret = watchdog_register_device(wdd); if (ret) {