From patchwork Mon Apr 22 05:44:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 72F51161F for ; Mon, 22 Apr 2019 05:45:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6223127FA5 for ; Mon, 22 Apr 2019 05:45:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 501CD2847B; Mon, 22 Apr 2019 05:45:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01D2B27FA5 for ; Mon, 22 Apr 2019 05:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbfDVFpL (ORCPT ); Mon, 22 Apr 2019 01:45:11 -0400 Received: from mail-eopbgr680043.outbound.protection.outlook.com ([40.107.68.43]:2887 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpL (ORCPT ); Mon, 22 Apr 2019 01:45:11 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by CY1PR07MB2166.namprd07.prod.outlook.com (2a01:111:e400:59d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:09 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:09 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:08 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:05 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5j44Y003263; Sun, 21 Apr 2019 22:45:04 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5j4nv003262; Sun, 21 Apr 2019 22:45:04 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 01/12] qedf: Change MSI-X load error message. Date: Sun, 21 Apr 2019 22:44:50 -0700 Message-ID: <20190422054501.3224-2-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855089326387;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(39860400002)(396003)(346002)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(51416003)(47776003)(14444005)(2906002)(36906005)(68736007)(4326008)(8936002)(53936002)(50226002)(81166006)(8676002)(6862004)(305945005)(2351001)(81156014)(316002)(36756003)(105606002)(42186006)(69596002)(16586007)(15650500001)(80596001)(498600001)(97736004)(54906003)(126002)(486006)(50466002)(6666004)(48376002)(85426001)(356004)(26005)(87636003)(76176011)(1076003)(4744005)(5660300002)(26826003)(336012)(2616005)(86362001)(476003)(446003)(11346002)(76130400001)(70586007)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2166;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f2ea217-9098-4c91-8b03-08d6c6e5ae0b X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:CY1PR07MB2166; X-MS-TrafficTypeDiagnostic: CY1PR07MB2166: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: g5W6oeeULNsBwLQmDuuP0029sHX4QaNcnJczfztmYrGa0jTLnaPRilvhujwE3jZ+3Fs85qY7xJ1g1FNAFvnYGPQxGB6d2ba2yRXdRVgssz+zNTxGQGWpyF4T1Ly8iIyHF2ui+Q+iKVs4e1M2WuFCGDoe9vxNB3o7v5CH+rlz/MYBPG0YWi+E/Lmf4ryhffUTQKsrmn4sfHOtyKZMTx0JsRUh0jiB9EWH+JNPAEgMOUyytuyoVdXULIiGDxNlILT6bskapWRZiSildBdDnDUXhQ7hc4lOni0DyiXg9iiHAqEea3RqAo+b3fjcsljdK5Ykc7cDXB+BSIETt3mBO29sZXUX3NfXm2GGFt+6CGIY7MSzMih2YrSiQHJhor2cwWFNE5pRWied//DE2A3hyUPOODDbBuOc28rTpgiBzxX0VcU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:08.5833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f2ea217-9098-4c91-8b03-08d6c6e5ae0b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2166 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Change the message to display load failure. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 84834d4..ffaf8f9 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -2275,7 +2275,8 @@ static int qedf_setup_int(struct qedf_ctx *qedf) QEDF_SIMD_HANDLER_NUM, qedf_simd_int_handler); qedf->int_info.used_cnt = 1; - QEDF_ERR(&qedf->dbg_ctx, "Only MSI-X supported. Failing probe.\n"); + QEDF_ERR(&qedf->dbg_ctx, + "Cannot load driver due to a lack of MSI-X vectors.\n"); return -EINVAL; } From patchwork Mon Apr 22 05:44:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9C0AC161F for ; Mon, 22 Apr 2019 05:45:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DDB127FA5 for ; Mon, 22 Apr 2019 05:45:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80BE92847B; Mon, 22 Apr 2019 05:45:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C2BF27FA5 for ; Mon, 22 Apr 2019 05:45:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbfDVFpP (ORCPT ); Mon, 22 Apr 2019 01:45:15 -0400 Received: from mail-eopbgr680088.outbound.protection.outlook.com ([40.107.68.88]:64837 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpP (ORCPT ); Mon, 22 Apr 2019 01:45:15 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by CY1PR07MB2166.namprd07.prod.outlook.com (2a01:111:e400:59d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:13 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:13 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:13 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:08 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5j8Pl003267; Sun, 21 Apr 2019 22:45:08 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5j8WZ003266; Sun, 21 Apr 2019 22:45:08 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 02/12] qedf: Add driver state to 'driver_stats' debugfs node. Date: Sun, 21 Apr 2019 22:44:51 -0700 Message-ID: <20190422054501.3224-3-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855134522174;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(39860400002)(396003)(346002)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(51416003)(47776003)(14444005)(2906002)(36906005)(68736007)(4326008)(8936002)(53936002)(50226002)(81166006)(8676002)(6862004)(305945005)(2351001)(81156014)(316002)(36756003)(105606002)(42186006)(69596002)(16586007)(80596001)(498600001)(97736004)(54906003)(126002)(486006)(50466002)(6666004)(48376002)(85426001)(356004)(26005)(87636003)(76176011)(1076003)(5660300002)(26826003)(336012)(2616005)(86362001)(476003)(446003)(11346002)(76130400001)(70586007)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2166;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbc93996-e7bb-443d-2d0e-08d6c6e5b0bd X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:CY1PR07MB2166; X-MS-TrafficTypeDiagnostic: CY1PR07MB2166: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: Csqosn1OJiYSUQ8mcfgMEcpipVITm4NyyndiIRLQJkbYDCndJNRAfmA2pQ0HLSXqIdzQ2fXmNv7ga8uvVbwQtvzNCfYr4bEe/UscgZ7bMC19ASqSmnTXjyaOBBOvdXAMxQtvbWidJqEUZgja8lHhyc/Rd79KvQlHW1AvQEr3ToF3CIfYEB7J/lUn2KqZoEQopj2siXxK2QKn3fjVAYxGEyhU8YBK/bT9KVFaUFtgir2NTNs9NX39DnBnHnw0/O6CHDWnvMXSyiNWgu9OqX0g2WAA7Ip5isYxGh+hQ7qpXCkrJFCFvmaviFZhb6yAZdVUXCUCI66POFqXPqVlbpMr4Qh7e242dxtzC4e6Uci/a74RpUHOTYPPxbQFPy+j5Z7BnQtZ7/v3/wSl3g0Zxqs4vg7fhRgp4K6HNKC4P3XLclU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:13.1009 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbc93996-e7bb-443d-2d0e-08d6c6e5b0bd X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2166 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Add debugs node for driver stats. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_debugfs.c | 55 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_debugfs.c b/drivers/scsi/qedf/qedf_debugfs.c index 6ae78dd..2353892 100644 --- a/drivers/scsi/qedf/qedf_debugfs.c +++ b/drivers/scsi/qedf/qedf_debugfs.c @@ -293,6 +293,33 @@ return single_open(file, qedf_io_trace_show, qedf); } +/* Based on fip_state enum from libfcoe.h */ +static char *fip_state_names[] = { + "FIP_ST_DISABLED", + "FIP_ST_LINK_WAIT", + "FIP_ST_AUTO", + "FIP_ST_NON_FIP", + "FIP_ST_ENABLED", + "FIP_ST_VNMP_START", + "FIP_ST_VNMP_PROBE1", + "FIP_ST_VNMP_PROBE2", + "FIP_ST_VNMP_CLAIM", + "FIP_ST_VNMP_UP", +}; + +/* Based on fc_rport_state enum from libfc.h */ +static char *fc_rport_state_names[] = { + "RPORT_ST_INIT", + "RPORT_ST_FLOGI", + "RPORT_ST_PLOGI_WAIT", + "RPORT_ST_PLOGI", + "RPORT_ST_PRLI", + "RPORT_ST_RTV", + "RPORT_ST_READY", + "RPORT_ST_ADISC", + "RPORT_ST_DELETE", +}; + static int qedf_driver_stats_show(struct seq_file *s, void *unused) { @@ -300,6 +327,25 @@ struct qedf_rport *fcport; struct fc_rport_priv *rdata; + seq_printf(s, "Host WWNN/WWPN: %016llx/%016llx\n", + qedf->wwnn, qedf->wwpn); + seq_printf(s, "Host NPortID: %06x\n", qedf->lport->port_id); + seq_printf(s, "Link State: %s\n", atomic_read(&qedf->link_state) ? + "Up" : "Down"); + seq_printf(s, "Logical Link State: %s\n", qedf->lport->link_up ? + "Up" : "Down"); + seq_printf(s, "FIP state: %s\n", fip_state_names[qedf->ctlr.state]); + seq_printf(s, "FIP VLAN ID: %d\n", qedf->vlan_id & 0xfff); + seq_printf(s, "FIP 802.1Q Priority: %d\n", qedf->prio); + if (qedf->ctlr.sel_fcf) { + seq_printf(s, "FCF WWPN: %016llx\n", + qedf->ctlr.sel_fcf->switch_name); + seq_printf(s, "FCF MAC: %pM\n", qedf->ctlr.sel_fcf->fcf_mac); + } else { + seq_puts(s, "FCF not selected\n"); + } + + seq_puts(s, "\nSGE stats:\n\n"); seq_printf(s, "cmg_mgr free io_reqs: %d\n", atomic_read(&qedf->cmd_mgr->free_list_cnt)); seq_printf(s, "slow SGEs: %d\n", qedf->slow_sge_ios); @@ -312,9 +358,12 @@ rdata = fcport->rdata; if (rdata == NULL) continue; - seq_printf(s, "%06x: free_sqes: %d, num_active_ios: %d\n", - rdata->ids.port_id, atomic_read(&fcport->free_sqes), - atomic_read(&fcport->num_active_ios)); + seq_printf(s, "%016llx/%016llx/%06x: state=%s, free_sqes=%d, num_active_ios=%d\n", + rdata->rport->node_name, rdata->rport->port_name, + rdata->ids.port_id, + fc_rport_state_names[rdata->rp_state], + atomic_read(&fcport->free_sqes), + atomic_read(&fcport->num_active_ios)); } rcu_read_unlock(); From patchwork Mon Apr 22 05:44:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CED371515 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C167E28668 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B616B2866D; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67D8128668 for ; Mon, 22 Apr 2019 05:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbfDVFpU (ORCPT ); Mon, 22 Apr 2019 01:45:20 -0400 Received: from mail-eopbgr700050.outbound.protection.outlook.com ([40.107.70.50]:15392 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpT (ORCPT ); Mon, 22 Apr 2019 01:45:19 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by MWHPR07MB2958.namprd07.prod.outlook.com (2603:10b6:300:1f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:17 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:17 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:16 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:11 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jBj8003271; Sun, 21 Apr 2019 22:45:11 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jB0r003270; Sun, 21 Apr 2019 22:45:11 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 03/12] qedf: Print scsi_cmd backpointer in good completion path if the command is still being used. Date: Sun, 21 Apr 2019 22:44:52 -0700 Message-ID: <20190422054501.3224-4-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855172121927;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(396003)(39860400002)(346002)(376002)(2980300002)(1110001)(339900001)(199004)(189003)(70206006)(305945005)(51416003)(76176011)(47776003)(126002)(476003)(2616005)(11346002)(446003)(26005)(87636003)(498600001)(486006)(336012)(36756003)(97736004)(70586007)(2351001)(85426001)(26826003)(5660300002)(69596002)(80596001)(316002)(36906005)(86362001)(2906002)(6862004)(1076003)(4326008)(356004)(48376002)(68736007)(50466002)(8936002)(8676002)(81166006)(81156014)(50226002)(53936002)(76130400001)(105606002)(42186006)(6666004)(16586007)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB2958;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31380f45-9e01-4fbb-e71d-08d6c6e5b2fa X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:MWHPR07MB2958; X-MS-TrafficTypeDiagnostic: MWHPR07MB2958: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: W2ZHKrsLU8ZpmEaZf3jLGMCJZjPA2B8ypmTt070x+e1NSi/BIT6jBwmtbP2uyFzA3586VG09wmzJU0Kpmihy3RQwpuf7dUcIwcK5XlFPsd04kjEgElFX/DJ7ivDyS46FWyQw6dBcCti5T2hxsDFRRsoK6MI6OksRTJG8BItv2PITZMvRPL4tFUtlYrReBXRJjqW2J13HOU+iR2yb8QAlk4ydcPbJqogBBJPkJ/mt9gnWJ1eEPKrI+3peX5vcce88paWvqXnr7K/pVXihE+r3JnYYA7Hpva7in56qp9ANXIXwPeIT4cUQTJAOInGtVDI6B11NSRGqxlaL4owVAwRpi4vRTnjPx+tzAU1ku75d0aNdnE5Bmxiv/dgJvJ+DM3bu0RgPpYKdd8mVOnl11hPQdXYdSGxCATrrFlYp/ELxubU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:16.8619 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31380f45-9e01-4fbb-e71d-08d6c6e5b2fa X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2958 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Printing scsi command pointer will help in crash dump analysis. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 51378e5..f2d4b30 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1859,9 +1859,9 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) if (!test_bit(QEDF_CMD_OUTSTANDING, &io_req->flags) || test_bit(QEDF_CMD_IN_CLEANUP, &io_req->flags) || test_bit(QEDF_CMD_IN_ABORT, &io_req->flags)) { - QEDF_ERR(&(qedf->dbg_ctx), "io_req xid=0x%x already in " - "cleanup or abort processing or already " - "completed.\n", io_req->xid); + QEDF_ERR(&qedf->dbg_ctx, + "io_req xid=0x%x sc_cmd=%p already in cleanup or abort processing or already completed.\n", + io_req->xid, io_req->sc_cmd); rc = 1; goto drop_rdata_kref; } From patchwork Mon Apr 22 05:44:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 308401515 for ; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23AD328668 for ; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 187862866D; Mon, 22 Apr 2019 05:45:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA50A28668 for ; Mon, 22 Apr 2019 05:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfDVFpY (ORCPT ); Mon, 22 Apr 2019 01:45:24 -0400 Received: from mail-eopbgr730042.outbound.protection.outlook.com ([40.107.73.42]:50144 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFpY (ORCPT ); Mon, 22 Apr 2019 01:45:24 -0400 Received: from SN4PR0701CA0019.namprd07.prod.outlook.com (2603:10b6:803:28::29) by BN4PR07MB2162.namprd07.prod.outlook.com (2a01:111:e400:59c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Mon, 22 Apr 2019 05:45:21 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by SN4PR0701CA0019.outlook.office365.com (2603:10b6:803:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:21 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:21 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:14 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jEwD003275; Sun, 21 Apr 2019 22:45:14 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jEtT003274; Sun, 21 Apr 2019 22:45:14 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 04/12] qedf: Add LBA to underrun debug messages. Date: Sun, 21 Apr 2019 22:44:53 -0700 Message-ID: <20190422054501.3224-5-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855214095163;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(346002)(396003)(136003)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(36756003)(97736004)(336012)(47776003)(446003)(126002)(68736007)(498600001)(87636003)(26826003)(86362001)(50226002)(2616005)(476003)(11346002)(48376002)(50466002)(486006)(2351001)(26005)(51416003)(76176011)(4326008)(6862004)(105606002)(53936002)(54906003)(16586007)(70586007)(81156014)(81166006)(5660300002)(85426001)(36906005)(70206006)(76130400001)(316002)(80596001)(69596002)(305945005)(2906002)(8936002)(42186006)(1076003)(8676002)(356004)(6666004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2162;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6464f90-becc-4439-35f1-08d6c6e5b57b X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN4PR07MB2162; X-MS-TrafficTypeDiagnostic: BN4PR07MB2162: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: g9ixNofgCcGCOOgaEWHYbXLr8s0Kx3VKRTy4LUa5oFRMrdYwmuSVFbQN9Y+nsHQ/w30+Ih7T7vp7s0ZOu8khv7UO/pE1cQLe7UdIYLQYj5AoxzsJoL0dWlr5+lO5Ksr1bIhhZ6eUQ5GO2Y0aY4DTzJsRDJEjKGkfjSjBEEpAg1PlpCp7iXtQLQMLVLCADvyvfgS0/j/uKVQz0zYTRvbZLQYGmEDavRjwIbs6BvdgqTsKKVRY5y/UNCCf6TGFBYZCAxdOR5fLK01Ota6HOx5Af4L0sbIEe0BMbA1NLF4lf6iwy9LLvBph87HHs0ZCFQd601WkoUd6PIDB8DUZKYwdRfErsfoAGq59VPUzzUZAv/lJSL/NukKlpDcQVj5YNjYkqDPfA+3lfVJ9YZSJS4S5ZoYr2PdwDaFy1YfkyZvchxo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:21.0682 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6464f90-becc-4439-35f1-08d6c6e5b57b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2162 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - Print LBA information for underrun cases. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index f2d4b30..29b456d 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1197,11 +1197,12 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, fw_residual_flag = GET_FIELD(cqe->cqe_info.rsp_info.fw_error_flags, FCOE_CQE_RSP_INFO_FW_UNDERRUN); if (fw_residual_flag) { - QEDF_ERR(&(qedf->dbg_ctx), - "Firmware detected underrun: xid=0x%x fcp_rsp.flags=0x%02x " - "fcp_resid=%d fw_residual=0x%x.\n", io_req->xid, - fcp_rsp->rsp_flags.flags, io_req->fcp_resid, - cqe->cqe_info.rsp_info.fw_residual); + QEDF_ERR(&qedf->dbg_ctx, + "Firmware detected underrun: xid=0x%x fcp_rsp.flags=0x%02x fcp_resid=%d fw_residual=0x%x lba=%02x%02x%02x%02x.\n", + io_req->xid, fcp_rsp->rsp_flags.flags, + io_req->fcp_resid, + cqe->cqe_info.rsp_info.fw_residual, sc_cmd->cmnd[2], + sc_cmd->cmnd[3], sc_cmd->cmnd[4], sc_cmd->cmnd[5]); if (io_req->cdb_status == 0) sc_cmd->result = (DID_ERROR << 16) | io_req->cdb_status; From patchwork Mon Apr 22 05:44:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910669 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8E72D161F for ; Mon, 22 Apr 2019 05:45:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FE8D28668 for ; Mon, 22 Apr 2019 05:45:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 748922866D; Mon, 22 Apr 2019 05:45:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25B6628668 for ; Mon, 22 Apr 2019 05:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbfDVFp1 (ORCPT ); Mon, 22 Apr 2019 01:45:27 -0400 Received: from mail-eopbgr720070.outbound.protection.outlook.com ([40.107.72.70]:21312 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFp1 (ORCPT ); Mon, 22 Apr 2019 01:45:27 -0400 Received: from SN4PR0701CA0011.namprd07.prod.outlook.com (2603:10b6:803:28::21) by BN7PR07MB4401.namprd07.prod.outlook.com (2603:10b6:406:b6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:25 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::208) by SN4PR0701CA0011.outlook.office365.com (2603:10b6:803:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:25 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:25 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:17 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jHge003279; Sun, 21 Apr 2019 22:45:17 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jHGm003278; Sun, 21 Apr 2019 22:45:17 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 05/12] qedf: Add port_id for fcport into initiate_cleanup debug message. Date: Sun, 21 Apr 2019 22:44:54 -0700 Message-ID: <20190422054501.3224-6-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855254306963;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(396003)(136003)(376002)(39860400002)(2980300002)(1110001)(339900001)(199004)(189003)(86362001)(50226002)(76176011)(80596001)(51416003)(85426001)(305945005)(36906005)(47776003)(42186006)(8936002)(54906003)(316002)(26005)(36756003)(81166006)(81156014)(16586007)(8676002)(87636003)(4326008)(69596002)(2351001)(97736004)(1076003)(498600001)(105606002)(4744005)(5660300002)(50466002)(6862004)(2906002)(53936002)(446003)(2616005)(48376002)(336012)(6666004)(356004)(70586007)(70206006)(486006)(126002)(68736007)(26826003)(76130400001)(11346002)(476003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR07MB4401;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c6f7e8a-9cc8-4544-cb48-08d6c6e5b7e0 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN7PR07MB4401; X-MS-TrafficTypeDiagnostic: BN7PR07MB4401: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: 3JmCBGRxWvhkWsYjUgUo1NrXuVAme3TuqQskjszf2iHbSGuoXZX7HF2vxjFEoKQ6gLjMWqIkzXP6fxgWJM2xh0f6S6VTot1DrDVbGG2/9JIURCcYiY4gJHWUqL7D+C+s049TKTfF+pJ7pn2l2HnmzzaWsc/cLToGuh4wsPZymdihIgIjIX0S4cppEN/OXt7lFn+DzDe/T92Z/eu6Tg0CCwl1Zs3CxEE5olOcvBIfW7qvIjQd1DSnKIuWzdZ1p7025XWZB84yMU1QYAV2HOTz3KVHUUeIBq4kJBhG/U/jL76/URBeX3GbbF8QQbFAnLS/LAfm+pOUve52MYynsVc+AO0rLgLvMIVLpLPZ15p4GQ5+DDKE49Icm9p3fmoAwtAznezbnKphQlIJg6F+UZCYyEA1fq3yX1a6SfcCjcBJXTY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:25.0824 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6f7e8a-9cc8-4544-cb48-08d6c6e5b7e0 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4401 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis - port id will help in debugging. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 29b456d..42f9f2a 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -2154,9 +2154,9 @@ int qedf_initiate_cleanup(struct qedf_ioreq *io_req, refcount = kref_read(&io_req->refcount); QEDF_INFO(&qedf->dbg_ctx, QEDF_LOG_IO, - "Entered xid=0x%x sc_cmd=%p cmd_type=%d flags=0x%lx refcount=%d\n", + "Entered xid=0x%x sc_cmd=%p cmd_type=%d flags=0x%lx refcount=%d fcport=%p port_id=0x%06x\n", io_req->xid, io_req->sc_cmd, io_req->cmd_type, io_req->flags, - refcount); + refcount, fcport, fcport->rdata->ids.port_id); /* Cleanup cmds re-use the same TID as the original I/O */ xid = io_req->xid; From patchwork Mon Apr 22 05:44:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910671 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06290161F for ; Mon, 22 Apr 2019 05:45:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDC6328668 for ; Mon, 22 Apr 2019 05:45:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E24EF2866D; Mon, 22 Apr 2019 05:45:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9540E28668 for ; Mon, 22 Apr 2019 05:45:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726718AbfDVFpd (ORCPT ); Mon, 22 Apr 2019 01:45:33 -0400 Received: from mail-eopbgr800042.outbound.protection.outlook.com ([40.107.80.42]:44640 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFpd (ORCPT ); Mon, 22 Apr 2019 01:45:33 -0400 Received: from SN4PR0701CA0011.namprd07.prod.outlook.com (2603:10b6:803:28::21) by BN4PR07MB2164.namprd07.prod.outlook.com (2a01:111:e400:59c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Mon, 22 Apr 2019 05:45:30 +0000 Received: from DM3NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::208) by SN4PR0701CA0011.outlook.office365.com (2603:10b6:803:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1813.12 via Frontend Transport; Mon, 22 Apr 2019 05:45:29 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT021.mail.protection.outlook.com (10.152.98.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:29 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:21 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jKI2003283; Sun, 21 Apr 2019 22:45:20 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jK8T003282; Sun, 21 Apr 2019 22:45:20 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 06/12] qedf: Add comment to display logging levels. Date: Sun, 21 Apr 2019 22:44:55 -0700 Message-ID: <20190422054501.3224-7-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855295829942;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(396003)(346002)(39860400002)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(76176011)(48376002)(81166006)(81156014)(8676002)(50226002)(4744005)(70586007)(51416003)(85426001)(68736007)(50466002)(8936002)(70206006)(26005)(97736004)(105606002)(86362001)(336012)(47776003)(11346002)(446003)(26826003)(87636003)(80596001)(2616005)(486006)(126002)(476003)(4326008)(53936002)(36756003)(69596002)(6862004)(36906005)(305945005)(76130400001)(2906002)(42186006)(16586007)(5660300002)(2351001)(1076003)(54906003)(498600001)(316002)(356004)(6666004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2164;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f537143-003c-41ee-893e-08d6c6e5ba5a X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN4PR07MB2164; X-MS-TrafficTypeDiagnostic: BN4PR07MB2164: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: QWusm3i53Qn4XPfDCLfc+tk/vv2dqqhs7BIMq+YwApsBfGUA8ogrxcdr9/MfPjwXzQ21eOL+hujNu9H3sFLOZMykit0PHEHQgG69HKWZEeLC47QNtSpXRXHfpeX2bsPeWKAUSqUs+BWlCadGZqmPKicc6OcEIMuxKpfyWcSyO76gPA3uzMD18rupaC9nCsW/ivQf69ZjAfyTr0La+h7BHdQqZdTtG85R0BHrHO16shSr5b5QNW59LWUtrXBSA6SlUWS4yLaGc2GjAE2W9Osw3hkpNhuz+czzC8dbgIylZtvj/dLTfjRMH5kGzcMVJeqVJnEMelpT6aZVTdmGpWlRFQMCILGKP43MMIkOnKwsnPi1Gt2aC/wuP7xAUdOo1abThNJGZ4i25Ao7OpkNQ72t4rp92YqZ4ze0AF4XCXCyX4I= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:29.2317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f537143-003c-41ee-893e-08d6c6e5ba5a X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2164 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Comment will help in decoding the logging level. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index f647817..2c08f6f 100644 --- a/drivers/scsi/qedf/qedf.h +++ b/drivers/scsi/qedf/qedf.h @@ -458,6 +458,12 @@ static inline void qedf_stop_all_io(struct qedf_ctx *qedf) /* * Externs */ + +/* + * (QEDF_LOG_NPIV | QEDF_LOG_SESS | QEDF_LOG_LPORT | QEDF_LOG_ELS | QEDF_LOG_MQ + * | QEDF_LOG_IO | QEDF_LOG_UNSOL | QEDF_LOG_SCSI_TM | QEDF_LOG_MP_REQ | + * QEDF_LOG_EVT | QEDF_LOG_CONN | QEDF_LOG_DISC | QEDF_LOG_INFO) + */ #define QEDF_DEFAULT_LOG_MASK 0x3CFB6 extern const struct qed_fcoe_ops *qed_ops; extern uint qedf_dump_frames; From patchwork Mon Apr 22 05:44:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910673 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 810FC1515 for ; Mon, 22 Apr 2019 05:45:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7436C28668 for ; Mon, 22 Apr 2019 05:45:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68C212866D; Mon, 22 Apr 2019 05:45:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 05E6728668 for ; Mon, 22 Apr 2019 05:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbfDVFph (ORCPT ); Mon, 22 Apr 2019 01:45:37 -0400 Received: from mail-eopbgr800044.outbound.protection.outlook.com ([40.107.80.44]:8916 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFph (ORCPT ); Mon, 22 Apr 2019 01:45:37 -0400 Received: from DM6PR07CA0021.namprd07.prod.outlook.com (2603:10b6:5:94::34) by BN6PR07MB2946.namprd07.prod.outlook.com (2603:10b6:404:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Mon, 22 Apr 2019 05:45:35 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by DM6PR07CA0021.outlook.office365.com (2603:10b6:5:94::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:35 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:34 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:24 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jNQi003287; Sun, 21 Apr 2019 22:45:23 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jN7N003286; Sun, 21 Apr 2019 22:45:23 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 07/12] qedf: Check for fcoe_libfc_config failure. Date: Sun, 21 Apr 2019 22:44:56 -0700 Message-ID: <20190422054501.3224-8-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855349995215;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(376002)(346002)(396003)(2980300002)(1110001)(339900001)(189003)(199004)(2906002)(80596001)(8676002)(50226002)(81156014)(81166006)(8936002)(2351001)(48376002)(50466002)(76176011)(51416003)(356004)(6666004)(336012)(486006)(126002)(11346002)(446003)(2616005)(476003)(105606002)(5660300002)(69596002)(1076003)(4744005)(70206006)(70586007)(85426001)(76130400001)(26005)(14444005)(4326008)(6862004)(54906003)(498600001)(86362001)(26826003)(47776003)(36756003)(87636003)(53936002)(97736004)(16586007)(42186006)(36906005)(316002)(305945005)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB2946;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07947a0e-2ae9-4a8e-6c38-08d6c6e5bd94 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN6PR07MB2946; X-MS-TrafficTypeDiagnostic: BN6PR07MB2946: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: Q33noYHoexPlC6GbsA41Vk/WCplDjZs0kvh5WaHfmgLC1SWSe8oCGDvXT4b4WNqn9RqtrtQ0SZSq85ukw/xNWZC+vg60JIWZcTYcoBEOzHGTwA8wOGyJjBmpq//rx3u90be5qiOvHOYNdxzQY+4bMNTORc7iZBrMCr83XP8FhCbdhBZOFdTx03xFjMoZ7hcOnZm7maKyw2oUCoknzSIsPpCTERqkmdxseUJKJL4+sKhwMJVXkZX3fwj6ocHzLOa8R++9nqCbgnP0mIbYLRPDOxK6KfmV583BwmJDOW0IgTkO9jJsJUXlcXSTlj22oDUWiRFrpCVD1OAI/A4X+1lvin3pHB1AVwAGNgqo4mbftAfoS+irOZv5HPvC8fi2tnSY6iacrYBydkKmPXI0UCPanAlQ6PDOftktX2M21gltr88= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:34.6552 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07947a0e-2ae9-4a8e-6c38-08d6c6e5bd94 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB2946 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Saurav Kashyap - Print the fcoe_libfc_config failure and return proper failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index ffaf8f9..a527b9b 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1618,7 +1618,11 @@ static int qedf_lport_setup(struct qedf_ctx *qedf) fc_set_wwnn(lport, qedf->wwnn); fc_set_wwpn(lport, qedf->wwpn); - fcoe_libfc_config(lport, &qedf->ctlr, &qedf_lport_template, 0); + if (fcoe_libfc_config(lport, &qedf->ctlr, &qedf_lport_template, 0)) { + QEDF_ERR(&qedf->dbg_ctx, + "fcoe_libfc_config failed.\n"); + return -ENOMEM; + } /* Allocate the exchange manager */ fc_exch_mgr_alloc(lport, FC_CLASS_3, FCOE_PARAMS_NUM_TASKS, From patchwork Mon Apr 22 05:44:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 983D5161F for ; Mon, 22 Apr 2019 05:45:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86CF628668 for ; Mon, 22 Apr 2019 05:45:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 757902866D; Mon, 22 Apr 2019 05:45:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EB2128668 for ; Mon, 22 Apr 2019 05:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbfDVFpl (ORCPT ); Mon, 22 Apr 2019 01:45:41 -0400 Received: from mail-eopbgr790074.outbound.protection.outlook.com ([40.107.79.74]:11186 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFpl (ORCPT ); Mon, 22 Apr 2019 01:45:41 -0400 Received: from DM6PR07CA0021.namprd07.prod.outlook.com (2603:10b6:5:94::34) by BYAPR07MB4408.namprd07.prod.outlook.com (2603:10b6:a02:c1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.14; Mon, 22 Apr 2019 05:45:39 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::207) by DM6PR07CA0021.outlook.office365.com (2603:10b6:5:94::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:38 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:38 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:27 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jR0X003291; Sun, 21 Apr 2019 22:45:27 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jR3M003290; Sun, 21 Apr 2019 22:45:27 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 08/12] qedf: Log message if scsi_add_host fails. Date: Sun, 21 Apr 2019 22:44:57 -0700 Message-ID: <20190422054501.3224-9-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855385753884;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(396003)(39860400002)(376002)(136003)(2980300002)(1110001)(339900001)(199004)(189003)(498600001)(26826003)(2351001)(87636003)(105606002)(86362001)(14444005)(70206006)(6666004)(70586007)(11346002)(1076003)(356004)(126002)(486006)(5660300002)(97736004)(69596002)(476003)(80596001)(4744005)(446003)(336012)(85426001)(2616005)(51416003)(76176011)(8936002)(26005)(50466002)(50226002)(6862004)(48376002)(53936002)(2906002)(42186006)(316002)(16586007)(36906005)(54906003)(47776003)(81156014)(36756003)(76130400001)(4326008)(81166006)(8676002)(15650500001)(305945005)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB4408;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57f3a849-d5bd-45d9-ab23-08d6c6e5bfb6 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BYAPR07MB4408; X-MS-TrafficTypeDiagnostic: BYAPR07MB4408: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: fOIKpK/yAkF6ud7EftqgPXlTGgeDlPPQN+fko52HxksJ2NwCC+vIfWViP4luSwJyATbbZqnry0I+ENxLRofkhnfD6Zf7benbqGgaF8A9Eeuz3bHu4c96C2aaKJrpL95GWuFX9OhMOTi1jYuEESdFPeGufSlC9pdi84W6bN5fqa5OvJeUpA+tQnc5/qtuX9j0bpjI1qIPEudrp3NRpZpADObUGFlHTBBDE+Sb9khmkOwxEgbMF5WYzJQ1aq6C5U8rqa9zWYuQp4wLlhEP5uGu4ACfffOX8HMz4lUOefjnT3x1xgicxnLpEEqnGy7pmHl5konPmkcTvFQYBWqSXFv1kDTdBQ+gNpYGvsU2jWkeRw+3EQx7SDh10ozpX3VpkvR61tTLqpSYZDzYqlPVNrDqonE5krZbq5NVOV8GLepEeU8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:38.2351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57f3a849-d5bd-45d9-ab23-08d6c6e5bfb6 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4408 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - print message on scsi_add_host failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index a527b9b..e2f3228 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3330,8 +3330,11 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) host->max_cmd_len = QEDF_MAX_CDB_LEN; host->can_queue = FCOE_PARAMS_NUM_TASKS; rc = scsi_add_host(host, &pdev->dev); - if (rc) + if (rc) { + QEDF_WARN(&qedf->dbg_ctx, + "Error adding Scsi_Host.\n"); goto err6; + } } memset(¶ms, 0, sizeof(params)); From patchwork Mon Apr 22 05:44:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A302161F for ; Mon, 22 Apr 2019 05:45:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DB9428668 for ; Mon, 22 Apr 2019 05:45:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 221BC2866D; Mon, 22 Apr 2019 05:45:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B626C28668 for ; Mon, 22 Apr 2019 05:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbfDVFpp (ORCPT ); Mon, 22 Apr 2019 01:45:45 -0400 Received: from mail-eopbgr760059.outbound.protection.outlook.com ([40.107.76.59]:20497 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbfDVFpp (ORCPT ); Mon, 22 Apr 2019 01:45:45 -0400 Received: from DM6PR07CA0027.namprd07.prod.outlook.com (20.176.74.40) by DM5PR07MB2956.namprd07.prod.outlook.com (10.168.104.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:42 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::202) by DM6PR07CA0027.outlook.office365.com (2603:10b6:5:94::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:42 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:42 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:30 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jUsf003295; Sun, 21 Apr 2019 22:45:30 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jUoX003294; Sun, 21 Apr 2019 22:45:30 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 09/12] qedf: Check the return value of start_xmit. Date: Sun, 21 Apr 2019 22:44:58 -0700 Message-ID: <20190422054501.3224-10-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855428217999;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(376002)(39850400004)(346002)(136003)(2980300002)(1110001)(339900001)(189003)(199004)(105606002)(2351001)(356004)(8676002)(5660300002)(81156014)(50226002)(6666004)(76130400001)(81166006)(8936002)(336012)(26005)(70586007)(14444005)(48376002)(446003)(11346002)(2906002)(97736004)(36756003)(50466002)(126002)(2616005)(486006)(53936002)(476003)(70206006)(4326008)(76176011)(1076003)(6862004)(69596002)(54906003)(498600001)(87636003)(26826003)(86362001)(16586007)(80596001)(47776003)(51416003)(36906005)(305945005)(42186006)(316002)(68736007)(85426001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB2956;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1664a7ba-adfd-481e-9e83-08d6c6e5c23e X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:DM5PR07MB2956; X-MS-TrafficTypeDiagnostic: DM5PR07MB2956: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: yiz1MeQaxlZO6nO28jjm2HfnjanPAlzqUU4qUGraksw+6PZqu7pqkK/3NniclC5OlbThUJ6X/Q9gFqssjNNvb+Ekmy4MYJdA9vPRagA81faSTFYEshnj1wu8iPes0mAfFDtGI7cC5A09Ysr78UeSo6sdu7A4nZcGOrAHJZQ9DxSUCi8dQQGur4bWdpg+4UD2b/EiDEKY7Fa72jHA2E37SRqzvxwHvmnSjra5KOoRNKc8ABoB22P+oE8doJNoqhjJZNZlPAKA7EluS2PS/l0nUHjIxmD+jcJTd6yplxajlRomgasVi3rwa5TfQedt41OX2XiGH9SYLyCUly1+IGNTyDdkuLt8H6UWMwokkfvC33NISkoc1/1o2lx3Gv5wAJ2uaSoZtqhGOK5Kv+GlQgCXLaMgfK3Tzi786k+yEHwMQoY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:42.4675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1664a7ba-adfd-481e-9e83-08d6c6e5c23e X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB2956 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Log the reason for start xmit failure. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 17 +++++++++++++++-- drivers/scsi/qedf/qedf_main.c | 7 ++++++- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index 49d0724..d4741f8 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/drivers/scsi/qedf/qedf_fip.c @@ -23,6 +23,7 @@ void qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf) #define MY_FIP_ALL_FCF_MACS ((__u8[6]) { 1, 0x10, 0x18, 1, 0, 2 }) static u8 my_fcoe_all_fcfs[ETH_ALEN] = MY_FIP_ALL_FCF_MACS; unsigned long flags = 0; + int rc = -1; skb = dev_alloc_skb(sizeof(struct fip_vlan)); if (!skb) @@ -66,7 +67,13 @@ void qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf) } set_bit(QED_LL2_XMIT_FLAGS_FIP_DISCOVERY, &flags); - qed_ops->ll2->start_xmit(qedf->cdev, skb, flags); + rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, flags); + if (rc) { + QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc); + kfree_skb(skb); + return; + } + } static void qedf_fcoe_process_vlan_resp(struct qedf_ctx *qedf, @@ -118,6 +125,7 @@ void qedf_fip_send(struct fcoe_ctlr *fip, struct sk_buff *skb) struct fip_header *fiph; u16 op, vlan_tci = 0; u8 sub; + int rc = -1; if (!test_bit(QEDF_LL2_STARTED, &qedf->flags)) { QEDF_WARN(&(qedf->dbg_ctx), "LL2 not started\n"); @@ -146,7 +154,12 @@ void qedf_fip_send(struct fcoe_ctlr *fip, struct sk_buff *skb) print_hex_dump(KERN_WARNING, "fip ", DUMP_PREFIX_OFFSET, 16, 1, skb->data, skb->len, false); - qed_ops->ll2->start_xmit(qedf->cdev, skb, 0); + rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, 0); + if (rc) { + QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc); + kfree_skb(skb); + return; + } } static u8 fcoe_all_enode[ETH_ALEN] = FIP_ALL_ENODE_MACS; diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index e2f3228..1de2b18 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1141,7 +1141,12 @@ static int qedf_xmit(struct fc_lport *lport, struct fc_frame *fp) if (qedf_dump_frames) print_hex_dump(KERN_WARNING, "fcoe: ", DUMP_PREFIX_OFFSET, 16, 1, skb->data, skb->len, false); - qed_ops->ll2->start_xmit(qedf->cdev, skb, 0); + rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, 0); + if (rc) { + QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc); + kfree_skb(skb); + return rc; + } return 0; } From patchwork Mon Apr 22 05:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4A1B1515 for ; Mon, 22 Apr 2019 05:45:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C6FC128668 for ; Mon, 22 Apr 2019 05:45:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB9992866D; Mon, 22 Apr 2019 05:45:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72A4528668 for ; Mon, 22 Apr 2019 05:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbfDVFpt (ORCPT ); Mon, 22 Apr 2019 01:45:49 -0400 Received: from mail-eopbgr800071.outbound.protection.outlook.com ([40.107.80.71]:28864 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpt (ORCPT ); Mon, 22 Apr 2019 01:45:49 -0400 Received: from DM6PR07CA0027.namprd07.prod.outlook.com (2603:10b6:5:94::40) by SN1PR07MB2175.namprd07.prod.outlook.com (2a01:111:e400:c455::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:46 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::202) by DM6PR07CA0027.outlook.office365.com (2603:10b6:5:94::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:46 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:46 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:33 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jXUf003299; Sun, 21 Apr 2019 22:45:33 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5jX5j003298; Sun, 21 Apr 2019 22:45:33 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 10/12] qedf: Print fcport information on wait for upload timeout. Date: Sun, 21 Apr 2019 22:44:59 -0700 Message-ID: <20190422054501.3224-11-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855464031095;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(346002)(39860400002)(136003)(396003)(2980300002)(1110001)(339900001)(199004)(189003)(50466002)(48376002)(8936002)(2616005)(70206006)(4744005)(51416003)(1076003)(356004)(26005)(6666004)(76130400001)(11346002)(47776003)(70586007)(446003)(126002)(336012)(53936002)(476003)(8676002)(97736004)(81156014)(81166006)(50226002)(486006)(16586007)(4326008)(5660300002)(105606002)(6862004)(69596002)(2351001)(80596001)(36906005)(76176011)(2906002)(54906003)(42186006)(85426001)(36756003)(305945005)(316002)(87636003)(86362001)(26826003)(498600001)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2175;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d548cc00-b0eb-47bc-ee56-08d6c6e5c460 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:SN1PR07MB2175; X-MS-TrafficTypeDiagnostic: SN1PR07MB2175: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: 4B60pDwmS7UeuwXBJ3bJu8HpEnA14PyIlUMjvdBqme2L6LbPd2/wPkA49Bx5QPhOsH9pZtLQEi2WTpeOeL5WshB/pSmHASIVsTwqCYuxld2qxdXLnKNDqx0jFiUkOeW+cuQF9WR+9V/sJ9JSYtubAfFs755yU/9YZ5lNjNqZIZGRLx60Xi4b3eDkW2v/JmgTdwlgcRD58Ps+4UYf1d/JBsu48YQu2lc3rm1aSuCK3IGRD6BtEh/Yb7lG6ctrwKt4AC6EExaEFGfyxcoQkrNOVpgSFyY6d1LjhuJ87KUO9T6DUhiLG/cFAAVA6C2TRcygZUmRLgQJ+hT5HwLnQmFrvLyqzJRNZexhLntT3X2/FSAQAPSZFuh5INOroBYhltkCsQOU306fCF2Q359kat4JHg62AFgOWkj5HD420PpkHYc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:46.0618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d548cc00-b0eb-47bc-ee56-08d6c6e5c460 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2175 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Log fcport for which upload failed. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 1de2b18..ffe536e 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -786,11 +786,13 @@ static int qedf_eh_device_reset(struct scsi_cmnd *sc_cmd) bool qedf_wait_for_upload(struct qedf_ctx *qedf) { struct qedf_rport *fcport = NULL; + int wait_cnt = 120; - while (1) { + while (wait_cnt--) { if (atomic_read(&qedf->num_offloads)) - QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC, - "Waiting for all uploads to complete.\n"); + QEDF_INFO(&qedf->dbg_ctx, QEDF_LOG_DISC, + "Waiting for all uploads to complete num_offloads = 0x%x.\n", + atomic_read(&qedf->num_offloads)); else return true; msleep(500); From patchwork Mon Apr 22 05:45:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1BE8F1515 for ; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F22928668 for ; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 03D3E2866D; Mon, 22 Apr 2019 05:45:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B83628668 for ; Mon, 22 Apr 2019 05:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbfDVFpx (ORCPT ); Mon, 22 Apr 2019 01:45:53 -0400 Received: from mail-eopbgr740053.outbound.protection.outlook.com ([40.107.74.53]:65162 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFpx (ORCPT ); Mon, 22 Apr 2019 01:45:53 -0400 Received: from DM6PR07CA0027.namprd07.prod.outlook.com (2603:10b6:5:94::40) by BN4PR07MB2161.namprd07.prod.outlook.com (2a01:111:e400:59c6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 05:45:50 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::202) by DM6PR07CA0027.outlook.office365.com (2603:10b6:5:94::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:50 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:50 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:36 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jaQ1003303; Sun, 21 Apr 2019 22:45:36 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5ja5E003302; Sun, 21 Apr 2019 22:45:36 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 11/12] qedf: Add return value to log message if scsi_add_host fails. Date: Sun, 21 Apr 2019 22:45:00 -0700 Message-ID: <20190422054501.3224-12-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855504134659;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(87636003)(26826003)(85426001)(498600001)(47776003)(2616005)(446003)(476003)(486006)(126002)(11346002)(86362001)(4326008)(5660300002)(69596002)(70206006)(80596001)(70586007)(6862004)(76130400001)(53936002)(305945005)(316002)(1076003)(16586007)(42186006)(4744005)(2351001)(8936002)(50466002)(54906003)(2906002)(8676002)(81166006)(81156014)(48376002)(36906005)(6666004)(76176011)(105606002)(51416003)(336012)(26005)(36756003)(50226002)(97736004)(68736007)(356004)(14444005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2161;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca4ca64b-04ed-42a4-03d3-08d6c6e5c6c5 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:BN4PR07MB2161; X-MS-TrafficTypeDiagnostic: BN4PR07MB2161: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: QmK5cvQ70upcQ4DwXDzdwcaV39U8VJKKsFxNbXZhdqh1rc7Mq9UmLTqzcHUsexG3oV+tK4BJpJv5M7Pvz2v+XW40MuCnoNS8S6tQEVwS5RrB+fyWminsKvOHW+t7a3LPRL9F/AdtsCHy2HKPb3jyQ0Rg1MK4BGYr++qziW8hQli2PtSUZ2sgQAay2uc5EmzAypyPtAdquYp8xtMgrNBWX1d5Wa7tdl1G4m5Tdg+pl1c/+dZiZ5vL3PoO4fps+qcZ+uUDpgldcbS6U/duaGIcwH54SAOABirto9zqER+U80WYH6+fpDqXkVh7Fld2tM6XHujxeWPenU5jj3Ze9jYgxnK3ZnHfKn/Nd32RzGbR746VWUhEsn2/ltTEkFj8M7IEglPJYPWmn32zy32M2NDCrFFFHjSQlMFKsDMYvK8B04w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:50.0731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca4ca64b-04ed-42a4-03d3-08d6c6e5c6c5 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2161 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Print return value of scsi_add_host on failure. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index ffe536e..5b07235 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1763,7 +1763,8 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) rc = scsi_add_host(vn_port->host, &vport->dev); if (rc) { - QEDF_WARN(&(base_qedf->dbg_ctx), "Error adding Scsi_Host.\n"); + QEDF_WARN(&base_qedf->dbg_ctx, + "Error adding Scsi_Host rc=0x%x.\n", rc); goto err2; } @@ -3339,7 +3340,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) rc = scsi_add_host(host, &pdev->dev); if (rc) { QEDF_WARN(&qedf->dbg_ctx, - "Error adding Scsi_Host.\n"); + "Error adding Scsi_Host rc=0x%x.\n", rc); goto err6; } } From patchwork Mon Apr 22 05:45:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10910683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0355E161F for ; Mon, 22 Apr 2019 05:45:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAA3528668 for ; Mon, 22 Apr 2019 05:45:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF2422866D; Mon, 22 Apr 2019 05:45:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97BF728668 for ; Mon, 22 Apr 2019 05:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfDVFp4 (ORCPT ); Mon, 22 Apr 2019 01:45:56 -0400 Received: from mail-eopbgr690073.outbound.protection.outlook.com ([40.107.69.73]:13849 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfDVFp4 (ORCPT ); Mon, 22 Apr 2019 01:45:56 -0400 Received: from DM6PR07CA0027.namprd07.prod.outlook.com (2603:10b6:5:94::40) by DM3PR07MB2171.namprd07.prod.outlook.com (2a01:111:e400:5980::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Mon, 22 Apr 2019 05:45:54 +0000 Received: from DM3NAM05FT059.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::202) by DM6PR07CA0027.outlook.office365.com (2603:10b6:5:94::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16 via Frontend Transport; Mon, 22 Apr 2019 05:45:54 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT059.mail.protection.outlook.com (10.152.98.176) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1792.7 via Frontend Transport; Mon, 22 Apr 2019 05:45:53 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Sun, 21 Apr 2019 22:45:36 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x3M5jaZ6003307; Sun, 21 Apr 2019 22:45:36 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x3M5ja6G003306; Sun, 21 Apr 2019 22:45:36 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH 12/12] qedf: Update the driver version to 8.37.25.20. Date: Sun, 21 Apr 2019 22:45:01 -0700 Message-ID: <20190422054501.3224-13-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190422054501.3224-1-skashyap@marvell.com> References: <20190422054501.3224-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 132003855541256916;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(396003)(346002)(136003)(39860400002)(376002)(2980300002)(1110001)(339900001)(189003)(199004)(105606002)(76130400001)(36756003)(5660300002)(316002)(42186006)(36906005)(16586007)(2351001)(54906003)(2906002)(26005)(76176011)(476003)(2616005)(126002)(336012)(486006)(51416003)(4326008)(11346002)(446003)(68736007)(47776003)(305945005)(50226002)(8936002)(53936002)(6862004)(8676002)(81166006)(81156014)(80596001)(69596002)(87636003)(498600001)(356004)(6666004)(14444005)(48376002)(70206006)(1076003)(26826003)(70586007)(97736004)(15650500001)(4744005)(50466002)(85426001)(86362001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2171;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 318ec2e6-8d16-4d02-74a4-08d6c6e5c8fb X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600141)(711020)(4605104)(2017052603328);SRVR:DM3PR07MB2171; X-MS-TrafficTypeDiagnostic: DM3PR07MB2171: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 00159D1518 X-Microsoft-Antispam-Message-Info: 8IDy2FoK8kZ+0+Q8GEap3uOeAiM/RrnZEXcwNi2BJKf4AwAGvXxVM/wCR+4USv3c9XtbSBeHPziF7XS9azF/5iMRA0yHjoro1s38H1XaEstvSwKax0SP58aIZDLzu90tLUr1U1ZoUal2MFHNU4f2sSFVjk+WdGwkMTSIBderdcEVH5n05npUof7d5o0R9uGtoDlu6m+l86B8Tj/uLBL0DY66dZwyqYM4qv6FH7ojN41DlAO4gG7k/kjVS86HOpDNZFaXnwGOxoiDvaszeKToESi0Th0ob6te2oAmUzH3kn6reWwJHUZ+HCueT6babIfWLsYKRdI+GQ0OHOwdGeyJQf3ARynFSlWCnZzqZSqDqBkC5tvPlry5g+Si+kkvOSU1HHDV6jDy6DPRPCu4x+s4AEKfgnt40mo4irwxPrzkhXY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2019 05:45:53.7824 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 318ec2e6-8d16-4d02-74a4-08d6c6e5c8fb X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2171 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Update the driver version to 8.37.25.20. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 9a06a58..334a9cd 100644 --- a/drivers/scsi/qedf/qedf_version.h +++ b/drivers/scsi/qedf/qedf_version.h @@ -7,9 +7,9 @@ * this source tree. */ -#define QEDF_VERSION "8.37.25.19" +#define QEDF_VERSION "8.37.25.20" #define QEDF_DRIVER_MAJOR_VER 8 #define QEDF_DRIVER_MINOR_VER 37 #define QEDF_DRIVER_REV_VER 25 -#define QEDF_DRIVER_ENG_VER 19 +#define QEDF_DRIVER_ENG_VER 20