From patchwork Tue Apr 23 07:36:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 10912035 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7875C1575 for ; Tue, 23 Apr 2019 07:38:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67089287FB for ; Tue, 23 Apr 2019 07:38:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B207287FF; Tue, 23 Apr 2019 07:38:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E2ABF287FB for ; Tue, 23 Apr 2019 07:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=gv4BdZgOHQ+BFKJkHidM1M2C6Y1Mrz4F0UOEoQ0C2Ok=; b=Z3A G0o8qVkqkCmx/T5Vd4OOEz2S+ICQBlnxNxZgMo/sywwAk0G+lghxGx6T1vWm30sHmpc2KgnW+MG// UVaBZMxn4zra/iPToNJJMiHiNfUZxNRlcLlr13fkidjcaKrK+HuegmTqpQCnzLzbF9pmW0aY3FsF5 catLUGq9Rx1rKcvLNAs+O5XZhIXtCMHQ3ITY87Z6F9+q+o5JHB3yAkfQq0p0ZHMfrtzjuZ84g1Mvf pqECrc/sGN/ITR+UHkm1vraT7GzihP96+GRO2GwM3IUuaOOIU/6RPJxnA6R8fH2KSeruMCiDrpwmw 2SAjoZU2nQRP80AEpsGYdm1GfTe8Igg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIq0G-0005Ds-Ue; Tue, 23 Apr 2019 07:38:08 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIq0E-0005DW-OZ for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 07:38:08 +0000 Received: by mail-pf1-x442.google.com with SMTP id 10so7027460pfo.5 for ; Tue, 23 Apr 2019 00:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RxFYCJET9zHUcOpjZ9bK7uMOuTUHPRpqiuEPuAi6Gtw=; b=Z0jSuOwwX6CFicJKldwZoTo3ZmYf1Xq5y9XX+JTNi1/r0ynpw2oqhP9K2VKQjxJz+p GbBOSoCne+u1WRAw2ID3l48V26UcB4jIJ1j6qBo4cqSwNExQfI4u3q7wBqay8lCxWm+4 Ui8fxxAMs+GW4OdS7YGM5exYAwczGQzOFo83iSURpe+bqWvtmRN1jhC9y9ZgrJoqQxJy RCm9EGGpSrkz0JVM5+5oCu/BqmrIC25WByjyCo/Vb9HBaE1RI6junCh4M2DpLvPUd/Km VKi6LDJBUfLFOpQhufhVJ843f1vMIHFcZVBZByRRE2cOSXIYr41V/s5DNeAjAJyHx8xl 5JZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RxFYCJET9zHUcOpjZ9bK7uMOuTUHPRpqiuEPuAi6Gtw=; b=US3XxMcSoQQNd+o4WoRIlNfkgvbkP84bacvqf7nE+LaYApAfEqE/oZyWufDBH1DSVl 6adg0iGGH60ngrWvYxwgte38DvePxJIRBYuFQxfye5JSR7bcLbOvxBIGuA1anGBnstoZ nvlrUywPmNokSGvalQuwwjCVQKfF7s8zKF6cdN/yTOvqFWhodKRfn6XiZc4v59lUXJ0g uvGL5W6lmHXMgeKJ30sqGIF4bLmtsF72ejL4QaDeJgXzdRx/QpogIQv8t8cut/u5PtIX m/9Dpu2rSVQmHRm2QDC5IAQ1xRPH7AJeE5KeV5dEQVhzCIsM0cJcrEywMVkKuRQyxsql pKRA== X-Gm-Message-State: APjAAAXxlfH0jKBB8MFam0Xg0XdFZR8WoWxC8u016ZKCIj37OXUYIyyX WQP9ZZKWjUUhXL/7uzbqklw= X-Google-Smtp-Source: APXvYqxnz3kkhBSsB7V7qIRsA9Pk5nBHcRVpjVStC9T1ow+buVdCOiyRAH3sROKewjUe6EITFOZfVw== X-Received: by 2002:a62:4d43:: with SMTP id a64mr25026195pfb.174.1556005085025; Tue, 23 Apr 2019 00:38:05 -0700 (PDT) Received: from localhost.localdomain ([219.91.196.67]) by smtp.googlemail.com with ESMTPSA id o81sm26360447pfa.156.2019.04.23.00.38.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Apr 2019 00:38:04 -0700 (PDT) From: Raag Jadav To: linux-i2c@vger.kernel.org Subject: [PATCH] i2c: at91: handle TXRDY interrupt spam Date: Tue, 23 Apr 2019 13:06:48 +0530 Message-Id: <1556005008-6318-1-git-send-email-raagjadav@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_003806_825788_C78AAEBB X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, Raag Jadav , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Performing i2c write operation while SDA or SCL line is held or grounded by slave device, we go into infinite at91_twi_write_next_byte loop with TXRDY interrupt spam. Signed-off-by: Raag Jadav --- drivers/i2c/busses/i2c-at91.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 3f3e8b3..b2f5fdb 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/drivers/i2c/busses/i2c-at91.c @@ -72,6 +72,7 @@ #define AT91_TWI_TXCOMP BIT(0) /* Transmission Complete */ #define AT91_TWI_RXRDY BIT(1) /* Receive Holding Register Ready */ #define AT91_TWI_TXRDY BIT(2) /* Transmit Holding Register Ready */ +#define AT91_TWI_SVREAD BIT(3) /* Slave Read */ #define AT91_TWI_OVRE BIT(6) /* Overrun Error */ #define AT91_TWI_UNRE BIT(7) /* Underrun Error */ #define AT91_TWI_NACK BIT(8) /* Not Acknowledged */ @@ -571,7 +572,10 @@ static irqreturn_t atmel_twi_interrupt(int irq, void *dev_id) at91_disable_twi_interrupts(dev); complete(&dev->cmd_complete); } else if (irqstatus & AT91_TWI_TXRDY) { - at91_twi_write_next_byte(dev); + if ((status & AT91_TWI_SVREAD) && (dev->buf_len == 0)) + at91_twi_write(dev, AT91_TWI_IDR, AT91_TWI_TXRDY); + else + at91_twi_write_next_byte(dev); } /* catch error flags */