From patchwork Wed Apr 24 18:02:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10915451 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B3C59922 for ; Wed, 24 Apr 2019 18:02:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A424D28A30 for ; Wed, 24 Apr 2019 18:02:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9777428AC1; Wed, 24 Apr 2019 18:02:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33F0F28A30 for ; Wed, 24 Apr 2019 18:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389846AbfDXSCa (ORCPT ); Wed, 24 Apr 2019 14:02:30 -0400 Received: from mail-yw1-f74.google.com ([209.85.161.74]:50462 "EHLO mail-yw1-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389804AbfDXSC1 (ORCPT ); Wed, 24 Apr 2019 14:02:27 -0400 Received: by mail-yw1-f74.google.com with SMTP id j66so15292258ywa.17 for ; Wed, 24 Apr 2019 11:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=4cWEd2olSrQJQ8tmsuPoZ/kztpf8F/cSWsps4u6UzJM=; b=EdG1iXl8Zi4YbNJTGA9Z9SOnNPWVmifAdWUaAWBGhaPMufzkyRsaXWX2LahCvtRBLV gR9oxkgA+AuvpPQXlv1J40F/mC+fdOP5dMHRvr0FrnyqtnaOxYaSH7h+EdLbFURGBnuB 0273YdzlvKHDJ8Wyrx0jN7sNMHsHsSgR+kwohLNt3xw1QpvZj+cfOaaEa2vkznANgEpY nGzkRh0R14gQsuorR4mmLSA9xqAYWldfObl838egaeZZu8QQgoqBxjDOb8P9Vg5Ye/32 n5pw+m62lJ3SJ9Yxc6pNjM88WfbdaTZJaR1oX2R1lXdbwMCU6PiGvlms6ZoxHDHIRamr YGqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=4cWEd2olSrQJQ8tmsuPoZ/kztpf8F/cSWsps4u6UzJM=; b=HlZueA4nZnPMT1Uzk2rId5q7x1VlxZp2SMcjqaum4vqPzzr3FphLM9Q6ntgqWkn5tV RK8htS+5yGgCKwIGpwJVu7SeSJdvKZZATejF/Wr3oD+BVEa0a3JjeG5UhEFuZBz2SOoZ N9qtUx9P63pqtfEH+GGpTT80EygGgWDegu55gYX+/r4vWRX1ih5LC8NrTtwXCYLyQyGO NOa+J0Lq2YoK9mOihOkAxfNf58NsDgJ6WCPr3ModcJJGGeIvhTFfOtYxHghLiOTB/B8h A66haiSxvUXhfQIWUZ2usM6DXR1N6sPuvKVzYJNC4yTjp7BcJc0h/FwBBUcdydQXBk4o d6XA== X-Gm-Message-State: APjAAAVGYXqqiJQFN6rH24dZ6zYvEyzYHRIKPbKJP4pA/P8He4SDUC15 WyyJ/3/7jQVqlUzOk/E5ZovkG757yqlGqsvSSbE= X-Google-Smtp-Source: APXvYqyZoRq7Pl9ugvCWkv7NtZ7aXD7/NvBdNLqZaIQX5bjQl5thcWJdtzVe/p5PCB/NwsxFEd440DlSunYZNnVb/5w= X-Received: by 2002:a25:42c8:: with SMTP id p191mr28479025yba.442.1556128946422; Wed, 24 Apr 2019 11:02:26 -0700 (PDT) Date: Wed, 24 Apr 2019 11:02:21 -0700 In-Reply-To: Message-Id: <20190424180223.253025-1-ndesaulniers@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog Subject: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption From: Nick Desaulniers To: ysato@users.sourceforge.jp, dalias@libc.org Cc: geert@linux-m68k.org, luto@kernel.org, Nick Desaulniers , clang-built-linux@googlegroups.com, Masahiro Yamada , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20. Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers Acked-by: Yoshinori Sato --- Changes V1 -> V2: * update commit subject and message as per Masahiro/Geert. To Geert's question about minimum binutils versions; no change needed to binutils. arch/sh/kernel/vsyscall/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile index 5db6579bc44c..6e8664448048 100644 --- a/arch/sh/kernel/vsyscall/Makefile +++ b/arch/sh/kernel/vsyscall/Makefile @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@ export CPPFLAGS_vsyscall.lds += -P -C -Ush -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv SYSCFLAGS_vsyscall-trapa.so = $(vsyscall-flags)