From patchwork Thu Apr 25 20:23:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Leis X-Patchwork-Id: 10917747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D855614B6 for ; Thu, 25 Apr 2019 20:24:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFEF928727 for ; Thu, 25 Apr 2019 20:24:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B01BB28CBD; Thu, 25 Apr 2019 20:24:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 62FF628727 for ; Thu, 25 Apr 2019 20:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:Mime-Version:Message-Id :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=c2+jDhyEkJTeEngfa5KHtNkNupMy3aAuHQYIsFLGlZ4=; b=t8E/LUub5jQeBc te8d8ZHDM+AEqUa23llE/odkvFN9tNCngksYItzGmZeDV7s+TZ03W56brk12yn8atdpu48xpcNScC HsZrLzC+bdlfYY9zDSyKBF7ex4Me4IQX20zp/3t21xx75yMgTe9IGjMyATTffBJA4nOVphnCvoVN6 2yH6VGYnwlQFNTzGod9gChKUKsEep4bjPJT77es1c/ROT2NvOi2tim8w4rDkOv+sdTb+MI27xUPnd sF9j+i5vjSERhZIeCb+IdwgE0XgNvssuzQRE2Jg2S+AzPDU+mmpgrkilgf6SPKzqOITvUK5UAhz6c Ulx3opIxonhEaEm8wuKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJkuV-0000S5-5a; Thu, 25 Apr 2019 20:23:59 +0000 Received: from mail-vk1-xa49.google.com ([2607:f8b0:4864:20::a49]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJkuQ-0000Qz-RJ for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2019 20:23:56 +0000 Received: by mail-vk1-xa49.google.com with SMTP id p129so490442vkd.13 for ; Thu, 25 Apr 2019 13:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=lYPpgNkuYL/UXj4RzVEQzfR0g2A/fW/hCvtNkvFYhqw=; b=J4W5YP5UnwpMpQ7LVf49jdjMSKa9+TuqygYeYA8m199Sy706j9bCaFoaW6REUEL60B tZuOIxsYM2/aCpfr2t5gMx7YhggQxwv2blHrirMWWiDu50yONbFztn48AtU2UODSPGVS vPbjNf4bJr8Cn0z79ZRoac5OP8wZ80a6udaUKfLKCChSr3LMAPeVRle3y29B6ZXK9Gr5 5J55EauRa13oECD0SgvdFqtAQtGvL1eLkeFN/0QZW2eHguVFV7NWNiM1WY9n5O/8fBaR D8iKa64i3vNymuRFQqGljC5MgakHoHvJJhRLo6HoNTBrT57fsT1LfiiLh44S/olVrCK8 /1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=lYPpgNkuYL/UXj4RzVEQzfR0g2A/fW/hCvtNkvFYhqw=; b=Q6myv5PaZ5ZoDIkwqZjVnFVE5IJphG8b2OVcxzbpkgk/vmM+v//bu7OyXEX+lUzY3O BFEngITvnSZn0pk3wDor1p+pBlVwImRnM7VKH1GtCmUNjSJ4XmrroueKnUXntw2XmAJY NB2i3bM8JAz04aiunNlJ8BXw6NAgsIfu0ywYSOBAZfIaUIu2nAkbNItFG1s4PuUls8BX ppXbYgFYLO0eF/snP2T13NmiMteiQrYanXq2fJH6DgRRNpH3MUOQPoYe6uIa4tQilYK0 yzpB+Bo6bcbUjsYJ/NllPV/urNhE+qXGu8ppK+xUvU2PZSwH5x+YBiMMMj1UIoLZudU6 dIVA== X-Gm-Message-State: APjAAAXCscTqFT+MtN3zegvnlyNKE5YBzyve7Dx0fYDwedV0vZx0VC5W UOFH//HnDYXQ4rI0l/S9biumvuPIYqC+ X-Google-Smtp-Source: APXvYqz43J3gj3FJFFk7eWuLDdCsAkB5ssgtC9kn39T9R/ELLx03D9K4hl9FLDXZyDblK1hN4tRBtaVQSWf0 X-Received: by 2002:a67:f30f:: with SMTP id p15mr22276944vsf.158.1556223830537; Thu, 25 Apr 2019 13:23:50 -0700 (PDT) Date: Thu, 25 Apr 2019 13:23:47 -0700 Message-Id: <20190425202347.83880-1-venture@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog Subject: [PATCH] fixup! drivers/misc: Add Aspeed P2A control driver From: Patrick Venture To: venture@google.com, arnd@arndb.de, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190425_132354_909884_47C6B10D X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arm@kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fixup compiler warnings: - 108 warning: ISO C90 forbids mixed declarations and code - 264 warning: unused variable 'value' - 335 warning: unused variable 'res' Signed-off-by: Patrick Venture Reported-by: kbuild... --- drivers/misc/aspeed-p2a-ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/aspeed-p2a-ctrl.c b/drivers/misc/aspeed-p2a-ctrl.c index c0521b2ffc6a..9736821972ef 100644 --- a/drivers/misc/aspeed-p2a-ctrl.c +++ b/drivers/misc/aspeed-p2a-ctrl.c @@ -99,13 +99,14 @@ static void aspeed_p2a_disable_bridge(struct aspeed_p2a_ctrl *p2a_ctrl) static int aspeed_p2a_mmap(struct file *file, struct vm_area_struct *vma) { + unsigned long vsize; struct aspeed_p2a_user *priv = file->private_data; struct aspeed_p2a_ctrl *ctrl = priv->parent; if (ctrl->mem_base == 0 && ctrl->mem_size == 0) return -EINVAL; - unsigned long vsize = vma->vm_end - vma->vm_start; + vsize = vma->vm_end - vma->vm_start; pgprot_t prot = vma->vm_page_prot; if (vma->vm_pgoff + vsize > ctrl->mem_base + ctrl->mem_size) @@ -261,7 +262,6 @@ static int aspeed_p2a_open(struct inode *inode, struct file *file) static int aspeed_p2a_release(struct inode *inode, struct file *file) { int i; - u32 value; u32 bits = 0; bool open_regions = false; struct aspeed_p2a_user *priv = file->private_data; @@ -332,7 +332,7 @@ static int aspeed_p2a_ctrl_probe(struct platform_device *pdev) { struct aspeed_p2a_ctrl *misc_ctrl; struct device *dev; - struct resource *res, resm; + struct resource resm; struct device_node *node; int rc = 0;