From patchwork Tue Apr 30 23:28:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10924383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F55D14B6 for ; Tue, 30 Apr 2019 23:30:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6078828D20 for ; Tue, 30 Apr 2019 23:30:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54C1528D23; Tue, 30 Apr 2019 23:30:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DB18028D20 for ; Tue, 30 Apr 2019 23:30:54 +0000 (UTC) Received: from localhost ([127.0.0.1]:55044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcD8-00051a-7a for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Apr 2019 19:30:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcAy-0002jy-54 for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:28:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcAo-0005x5-FJ for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:28:31 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:16200) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcAm-0005vC-KC; Tue, 30 Apr 2019 19:28:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666909; x=1588202909; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=93qqYGoM2ecY5vFl0HSJ9ujc3avEN9JpEd+kFvUyPv0=; b=KrnD4gc3Pggh8nwiqbd5+64/itujhTW1MUWdfdrXYrKwjaTN9Z5gQTSy Xml+oMvNDGLCjN3+df0Gv02CLQ9jL9LlEXrgpJVwYT60R1xg1gqGzPFmf lpPiMTZkB9pFfg1Zc7cSwtrBir6ex900fu6XMpNe3RcnYnQR+lL+4/swl 7uDNYdP5ABZa/2Cg68oyRqcHZX+hGzDV11a/6OeDKexjSUrV0FdhSwqG/ BxAfnN0Fb081f45neknc4u+OSWXb27LDcVCb8ijbtv00zHRt8gG92aTst JeuJyOQ22YA2sdDbaoFMne8B0oYzqlUj5nCU3L5LtNhpvppVNQMjs7HI1 A==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="107219009" Received: from mail-bn3nam01lp2051.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.51]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:28:24 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93qqYGoM2ecY5vFl0HSJ9ujc3avEN9JpEd+kFvUyPv0=; b=FY1uu/Hmqbq16ipgOMxmXyHAOHhodPJbXDEuCXja3das8sCwDwtKIFvA14JAmo0NMSysXZYIAQe70Uzm3rH/O7+RnixDXn8RHVIsbBxCll/A0nwOjMMIZPBq7WPZgcoxAhlF94vDGJmgV7lpJ3j1aMDOBvYrXnd8julscmpQayk= Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB6217.namprd04.prod.outlook.com (20.178.224.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Tue, 30 Apr 2019 23:28:22 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:28:22 +0000 From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 1/5] util/qemu-sockets: Fix GCC 9 build warnings Thread-Index: AQHU/6xmI5QzeU/lqky3NVrWQUvreA== Date: Tue, 30 Apr 2019 23:28:22 +0000 Message-ID: <002f222d86322a66276de39cb29796acffe384c1.1556666645.git.alistair.francis@wdc.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR05CA0076.namprd05.prod.outlook.com (2603:10b6:a03:e0::17) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 368f992b-0752-47f1-f154-08d6cdc38928 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB6217; x-ms-traffictypediagnostic: DM6PR04MB6217: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1107; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(5640700003)(8936002)(6436002)(53936002)(73956011)(316002)(54906003)(14454004)(81156014)(6486002)(6916009)(81166006)(68736007)(8676002)(186003)(26005)(3846002)(66446008)(6116002)(66476007)(64756008)(7736002)(6512007)(66946007)(305945005)(102836004)(2906002)(66556008)(5660300002)(386003)(446003)(6506007)(66066001)(44832011)(2501003)(2351001)(11346002)(50226002)(478600001)(36756003)(486006)(476003)(2616005)(76176011)(4326008)(52116002)(14444005)(99286004)(71190400001)(71200400001)(256004)(118296001)(72206003)(86362001)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB6217; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IasIo6pJU0qD4goeCIbpGv9qkgjefuslzSMH9zpJbYQZz3Gyjqu8Qtlj7Rr/HPLFbVS2Jj69XSTHkIbCn83ZsIOMkeHEHLnzIST8nund1cGrSPkRc3DxpBcsirjQjOtmouPn066EBM/GjVGkh6P/wWzj58y/OL6FtG49wbE+fZqJDig+dEy2gAJaHTpzVscjFnpG62r2byS24L+MqOu6RAs6h9o1VvMgdeE63hNbKPPur28JmP8dnJqJTsm4WSWCtR6rWajDySGjTqoqXKUB3T6jlOhVLiDG6cAoVtTdmbyTHk8OkI50lXJOF0IvAPBtQPZB9/ptJ7rkdofHOyq7oYN8ux5q2elEhs0zJQw8DMUcpjVUBeBIOPs3+fVKQZl3MrSmopJ9iru+ptnOjEXxsC8o2DNxEQR2X8J0wzhYClc= Content-ID: <7DACA981F99FAD42A18EF4D27F084E13@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 368f992b-0752-47f1-f154-08d6cdc38928 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:28:22.4673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6217 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.42 Subject: [Qemu-devel] [PATCH v2 1/5] util/qemu-sockets: Fix GCC 9 build warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 108 equals destination size [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function ‘strncpy’, inlined from ‘unix_listen_saddr.isra.0’ at util/qemu-sockets.c:880:5: Signed-off-by: Alistair Francis --- util/qemu-sockets.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 9705051690..8c3322958f 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -829,7 +829,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr, struct sockaddr_un un; int sock, fd; char *pathbuf = NULL; - const char *path; + const char *path QEMU_NONSTRING; sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0); if (sock < 0) { @@ -922,7 +922,7 @@ static int unix_connect_saddr(UnixSocketAddress *saddr, Error **errp) memset(&un, 0, sizeof(un)); un.sun_family = AF_UNIX; - strncpy(un.sun_path, saddr->path, sizeof(un.sun_path)); + memcpy(un.sun_path, saddr->path, MIN(strlen(saddr->path), sizeof(un.sun_path))); /* connect to peer */ do { From patchwork Tue Apr 30 23:28:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10924395 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 155BB14B6 for ; Tue, 30 Apr 2019 23:36:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EFD1128D29 for ; Tue, 30 Apr 2019 23:36:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E3DB328D2E; Tue, 30 Apr 2019 23:36:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 745ED28D29 for ; Tue, 30 Apr 2019 23:36:22 +0000 (UTC) Received: from localhost ([127.0.0.1]:55151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcIO-0001P8-2u for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Apr 2019 19:36:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcGJ-0007Z9-Ml for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcGI-0000Ho-Mz for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:11 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:58260) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcAv-0005zQ-DT; Tue, 30 Apr 2019 19:28:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666918; x=1588202918; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xA3pbxiImBevyHhA8XuRcJTiyv2JoAMsxaYs6g7wvcc=; b=ezu4kxmO0cX7PqfqJdVhDDG4vgDk/E/T9hlguhQjBnYS7A9n/q/s/m++ kImuZGd57Snm4BC8zL8f9u4hEpoP7o5bEmC3EoAx3w77IMhYK4deFYjeY HvBWxiZDn//zHiy8RqmjWWFI7/R1XHsoAQLT9Mlh+xCoT5KA7cZhSE5aQ 8vXGWlDK6LObt1JRqzgCHyVp2wtg9ie4Hgpqf//qB6Olq89+KjmShbn7w x4UOp3flQ39AUcIQg+pY/ZNDN8FKX+4Su9EAAwRc78fKMl1Rr1i4rOCBS CFffYlxY0BayPHYgO/qoyHz+VqaOOWdVt1J8D/dTiNSkSh4SK/5k80Idh Q==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="108426282" Received: from mail-bl2nam02lp2058.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) ([104.47.38.58]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:28:35 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xA3pbxiImBevyHhA8XuRcJTiyv2JoAMsxaYs6g7wvcc=; b=gBrOXZ5HjdagQXqPzu/+QH265VaARcLfMo9+bfpbjX+cZJYfT1w2nQR52tlvoeoygmqh4friXEKHRk5jHqql5htUpUDE/56g2OxCHipNoeMTnPSS8lF5H7LHqWXqCLiYTr0bgUXv8pI8DcOsY/UGSupz2fTga83DmkcgQ7Tlb6A= Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB5402.namprd04.prod.outlook.com (20.178.27.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Tue, 30 Apr 2019 23:28:32 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:28:32 +0000 From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning Thread-Index: AQHU/6xs8MY4iO8AKkC1lf7A3j3a/Q== Date: Tue, 30 Apr 2019 23:28:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR01CA0046.prod.exchangelabs.com (2603:10b6:a03:94::23) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87fd24ec-dd2a-4038-9822-08d6cdc38ec4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB5402; x-ms-traffictypediagnostic: DM6PR04MB5402: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(979002)(366004)(376002)(136003)(396003)(39860400002)(346002)(199004)(189003)(72206003)(54906003)(6506007)(386003)(76176011)(446003)(14444005)(256004)(36756003)(4326008)(11346002)(102836004)(99286004)(66066001)(5660300002)(86362001)(44832011)(486006)(316002)(26005)(186003)(476003)(66476007)(2616005)(52116002)(66556008)(64756008)(73956011)(66946007)(66446008)(2906002)(6116002)(3846002)(50226002)(2351001)(6512007)(8936002)(6436002)(14454004)(71200400001)(71190400001)(6916009)(53936002)(6486002)(118296001)(81156014)(81166006)(2501003)(478600001)(68736007)(25786009)(5640700003)(8676002)(7736002)(305945005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB5402; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uUDALsqKXjmNEDqZkLUIT8+Edm+/HKFHKbKgBXldkHJu1C18gi0ASg0nct15dyhb7xAu3NqUsU5ziQnQXx68pVEn7lWexG/wsw9XSXor6u1c3372OE9AhlupqeP9tp2e9lCSVZhAIU1FdXRQdDwsNIOybSYX1Khn3IUlLQEFda40rB892OICGTHEu/c+XFg9HApzRGZTpHAbEtP+yQTIE35hmwet1a/sXqpPliMD53/JxG3I7hi4EyF2hiGf6bgrE7FKAS5X/JNMuhDyQBJ383QCQUthKOQf1Xe8JB1qH/nBJpIVPswnsB2SSJFdW+vTUwP2qj/hyHR7w7Vh4wSqxAI9Jw2DfY5e2jcwGHtljz9rDp8UwOjbK5qt2pmHuZRrjiCnwQcJn6fRRUPpewUj1b248hMJfR4mDIggfwqKW8Y= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87fd24ec-dd2a-4038-9822-08d6cdc38ec4 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:28:31.8700 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5402 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.144 Subject: [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix this build warning with GCC 9 on Fedora 30: hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=] 3339 | snprintf(port->name, sizeof(port->name), "usb2 port #%d", i+1); | ^~ hw/usb/hcd-xhci.c:3339:54: note: directive argument in the range [1, 2147483647] 3339 | snprintf(port->name, sizeof(port->name), "usb2 port #%d", i+1); | ^~~~~~~~~~~~~~~ In file included from /usr/include/stdio.h:867, from /home/alistair/qemu/include/qemu/osdep.h:99, from hw/usb/hcd-xhci.c:21: /usr/include/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 13 and 22 bytes into a destination of size 16 67 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 68 | __bos (__s), __fmt, __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alistair Francis Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index ec28bee319..2b061772b2 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3322,6 +3322,7 @@ static void usb_xhci_init(XHCIState *xhci) usb_bus_new(&xhci->bus, sizeof(xhci->bus), &xhci_bus_ops, dev); for (i = 0; i < usbports; i++) { + g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3)); speedmask = 0; if (i < xhci->numports_2) { if (xhci_get_flag(xhci, XHCI_FLAG_SS_FIRST)) { From patchwork Tue Apr 30 23:28:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10924399 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 396E11398 for ; Tue, 30 Apr 2019 23:38:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2886E28D29 for ; Tue, 30 Apr 2019 23:38:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1C90A28D2E; Tue, 30 Apr 2019 23:38:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A94A528D29 for ; Tue, 30 Apr 2019 23:38:42 +0000 (UTC) Received: from localhost ([127.0.0.1]:55176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcKg-0003DS-1b for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Apr 2019 19:38:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcGK-0007aV-Q8 for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcGJ-0000IX-QC for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:12 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:16222) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcB3-00064c-61; Tue, 30 Apr 2019 19:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666926; x=1588202926; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1SQQMt5THO5pV6WlYA8KAW7IDcB7IjPg+8ezER5gZSg=; b=doPq3HH2HCRsCkWVDrsbYQRtNI0ipiDk8NfKdgCDiTdiq3JBCcWbV6ty i0OrfXso6GYXZ6UcyHB/fyHBaKzJpMu/n1oD+wcVqpjFyFuMV9aeZxQrW G3HTdTsNf4d/o+kICa7IAFSgMt3MFiPbvbqZQwpcyhkXNh3y8Qji2UzUf fDcPyXzjvat3EV4cpwBOTmbAEKSFKO6NZbm5A/27kXEDcNea5S0hbEpvw k+avM4dxUqzAza7CJd+XulmUsVorinz0PUtaboO3BbRiHuFfk9KXr0wn+ RTubT60V0ptP6Q4Ck8yBEhqdYbKwOuupCVf/eST7W5n9CiZWyKCMEuPWJ A==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="107219018" Received: from mail-bn3nam01lp2055.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.55]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:28:43 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1SQQMt5THO5pV6WlYA8KAW7IDcB7IjPg+8ezER5gZSg=; b=PCnnGVkgfsVVfLNJfgKomcYnO7NUh6/VLhITyuBjQADhsInhdC9QT7MJUpnoxQDifrD2gOXyLyu7X0qwiKoM2jHqG+NgKF7H8/zEsUlz/RB0Ny56IeZKKrZSD8/9nenXZYh6s4EuTY8W6t4y1r39TKE9WFotwuIhAkdLj4CQlTk= Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB6217.namprd04.prod.outlook.com (20.178.224.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Tue, 30 Apr 2019 23:28:41 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:28:41 +0000 From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning Thread-Index: AQHU/6xy4BPLUqZ6DUSUqz4nuwVSww== Date: Tue, 30 Apr 2019 23:28:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR07CA0013.namprd07.prod.outlook.com (2603:10b6:a02:bc::26) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb962b1a-19e7-4f29-da9b-08d6cdc3947f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB6217; x-ms-traffictypediagnostic: DM6PR04MB6217: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:669; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(5640700003)(8936002)(6436002)(53936002)(73956011)(316002)(54906003)(14454004)(81156014)(6486002)(6916009)(81166006)(68736007)(8676002)(186003)(26005)(3846002)(66446008)(6116002)(66476007)(64756008)(7736002)(6512007)(66946007)(305945005)(102836004)(2906002)(66556008)(5660300002)(386003)(446003)(6506007)(66066001)(44832011)(2501003)(2351001)(11346002)(50226002)(478600001)(36756003)(486006)(476003)(2616005)(76176011)(4326008)(52116002)(14444005)(99286004)(71190400001)(71200400001)(256004)(118296001)(72206003)(86362001)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB6217; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: q7I/epXAdgLWL5cSHcH231z0IYnTSy/YMBN88ZJYLYTTTuli7zv5Sd29xEQcNyj75XsIyChxJE4OV6LVVOEDGn5Wou7hLP2tqEcTmP4B0h4Fw7/sFUG+E7H4YSGqbHAqke7O9r4l3S/3MIEAsWbQflytnxzkr7FlPS45oN+l05SF6m3JlzyzELTeInSgzy8+pflzc3A3WWOHGi+WweSzCdb1A7M9ShxyZYioo+dousimFDQuHlTgkmJXzsyH5pxJJnzJG5QInSCiwuaIY9f96eT6qaQCrXVJs9b4EREPuh1TtsYBArsMhdTMM+o693n0rXtSQg86xWAr3GcWknnBeRM8A/iJdYiCuxnb1GQtn0R3fOK6hN3lKhLy4I96OH6JrR1wZvg/34m0KAicO7mkmwkUzTeaRGsGE6rbpOdVcew= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb962b1a-19e7-4f29-da9b-08d6cdc3947f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:28:41.5489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6217 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.42 Subject: [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix this warning with GCC 9 on Fedora 30: hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct ’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1715 | dataset->filename); | ~~~~~~~^~~~~~~~~~ Signed-off-by: Alistair Francis --- hw/usb/dev-mtp.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 99548b012d..8233beacab 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1711,9 +1711,22 @@ static void usb_mtp_write_metadata(MTPState *s, uint64_t dlen) assert(!s->write_pending); assert(p != NULL); +/* + * We are about to access a packed struct. We are confident that the pointer + * address won't be unaligned, so we ignore GCC warnings. + */ +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9, 0) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" +#endif + filename = utf16_to_str(MIN(dataset->length, filename_chars), dataset->filename); +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9, 0) +#pragma GCC diagnostic pop +#endif + if (strchr(filename, '/')) { usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans, 0, 0, 0, 0); From patchwork Tue Apr 30 23:28:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10924397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE03314B6 for ; Tue, 30 Apr 2019 23:38:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9722D28D29 for ; Tue, 30 Apr 2019 23:38:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B38D28D2E; Tue, 30 Apr 2019 23:38:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 20E8228D29 for ; Tue, 30 Apr 2019 23:38:27 +0000 (UTC) Received: from localhost ([127.0.0.1]:55174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcKQ-00034x-FS for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Apr 2019 19:38:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcGI-0007YA-SS for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcGH-0000HQ-UE for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:34:10 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:16235) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcBE-000697-3e; Tue, 30 Apr 2019 19:28:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666936; x=1588202936; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=/PI+FLHUDutGpLAfkQ4VDPA7/rpbi7ZyRYW0VU06X3g=; b=cfzvSwDCJlwLFi4gobJla6mqQNgvHjsuZ6z1GaSGNeIUjC89qgfdFbPn yVXbclJQImTJA3LwUYaa+dhPLO+W+cA+jcrNjt5/Oc1e/Hhkt6oIM1HZM BLzBL2BpoY6bew67NzEbM6TjgqCcgj0NchOtBsh+FEj3m/Qe64INpemWw M0uKwZWpF3qTE9RiRjNpqbVCZLijg3PVhpWBAn8wi67idaWBUNoNwR+T5 6mbm0aiqUjeuqgf9PcuEJkVzTWTYBHo6Hrbh1LLrPtM0fE+DPbGVSrr7L T8e2KUgJaFmd7II3nHb9/EaheV84BvVwmJnNCJ3R/90QEE0sOA6xno4Yz g==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="107219025" Received: from mail-bn3nam01lp2055.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.55]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:28:53 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PI+FLHUDutGpLAfkQ4VDPA7/rpbi7ZyRYW0VU06X3g=; b=mwCBR3p3cKWPbpZYyQuPJhvsTOZWIDGSFp/iViPEtQMONE370L1gPNtj2yu9G6pIOlCCCC+3V9IpXM/pittdU04bUrKws7kmgoD959coboYGq5IaHpC2S6DKKwuadMxU1gF3yvfJX7b5liTcwsVXRqQuwKYoHAAO2nj6L7eFOAs= Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB6217.namprd04.prod.outlook.com (20.178.224.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Tue, 30 Apr 2019 23:28:51 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:28:51 +0000 From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 4/5] linux-user/uname: Fix GCC 9 build warnings Thread-Index: AQHU/6x4Qb+c+VmCSUK/Sp9zhg519A== Date: Tue, 30 Apr 2019 23:28:51 +0000 Message-ID: <14aab381eaa678eca875d0b8bd456feb22a21bd8.1556666645.git.alistair.francis@wdc.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR01CA0049.prod.exchangelabs.com (2603:10b6:a03:94::26) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 581cfe8c-5c07-4223-f550-08d6cdc39a59 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB6217; x-ms-traffictypediagnostic: DM6PR04MB6217: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1201; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(5640700003)(8936002)(6436002)(53936002)(73956011)(316002)(54906003)(14454004)(81156014)(6486002)(6916009)(81166006)(68736007)(8676002)(186003)(26005)(3846002)(66446008)(6116002)(66476007)(64756008)(7736002)(6512007)(66946007)(305945005)(102836004)(2906002)(66556008)(5660300002)(386003)(446003)(6506007)(66066001)(44832011)(2501003)(2351001)(11346002)(50226002)(478600001)(36756003)(486006)(476003)(2616005)(76176011)(4326008)(52116002)(14444005)(99286004)(71190400001)(71200400001)(256004)(118296001)(72206003)(86362001)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB6217; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Yk3TlvrK4dOt+zqBO9ylfCV6rVr9gitrHnqsu+qq+lOHBTUIdB/EbFZWH9Aa4h4p6eQUjHl5lXXoy9sp0ZODoaTYYH68TsIck3NcVDqY2jHrjbxM2bJeWV2USlTs65NV29q8cVdBfmeTz1aC2ee2ZYuZwKVlXx+EMvprvoxI0eCNIymbeTejZSNCQcnGvs8AyN6aCFxkJWGsAtghQyCeBO+cmIfwcqm/UQmWQPNZljoGvsxRjQo6Ylmfg2oIVYAgxPbZyb2R4P0RanqPeTx3vH5MIZk3k3p8YjFzUKFu3VN7l4giIvM0pWM4qdS/NIE+/kjJQ1PEy12mnaQTrJtzinq7xTVSngf7Y5IV8W4yQ6dAjEWW3j3r2jRWv2RBI/oSTHBEbhh2WaxShAobpzf98gD4OPHIjMs6wv0fgAS6vJQ= Content-ID: <8DD885F69E374B48B23CF9E3994BDC7C@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 581cfe8c-5c07-4223-f550-08d6cdc39a59 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:28:51.3889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6217 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.42 Subject: [Qemu-devel] [PATCH v2 4/5] linux-user/uname: Fix GCC 9 build warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 64 [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alistair Francis --- linux-user/uname.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/uname.c b/linux-user/uname.c index 313b79dbad..2fc6096a5b 100644 --- a/linux-user/uname.c +++ b/linux-user/uname.c @@ -73,7 +73,7 @@ const char *cpu_to_uname_machine(void *cpu_env) #define COPY_UTSNAME_FIELD(dest, src) \ do { \ /* __NEW_UTS_LEN doesn't include terminating null */ \ - (void) strncpy((dest), (src), __NEW_UTS_LEN); \ + (void) memcpy((dest), (src), MIN(strlen(src), __NEW_UTS_LEN)); \ (dest)[__NEW_UTS_LEN] = '\0'; \ } while (0) From patchwork Tue Apr 30 23:29:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10924393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45273912 for ; Tue, 30 Apr 2019 23:33:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09AEC28D20 for ; Tue, 30 Apr 2019 23:33:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8DB828D23; Tue, 30 Apr 2019 23:33:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6738D28D20 for ; Tue, 30 Apr 2019 23:33:11 +0000 (UTC) Received: from localhost ([127.0.0.1]:55078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcFK-0006be-KP for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 Apr 2019 19:33:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLcBb-0003RR-Ia for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:29:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLcBZ-0006Oi-Lj for qemu-devel@nongnu.org; Tue, 30 Apr 2019 19:29:19 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:16243) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLcBU-0006HX-T2; Tue, 30 Apr 2019 19:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1556666953; x=1588202953; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tXUTsIRiuDGCHyauZRrtG/QeDpa6BCwT3JY/YNrnlkw=; b=LR1CuH+GsDF8jqwuIISnvB7Q6QLzqeAyejAa5CpXo9OOvN3ONrc8B/yv el3//aEgCuGE09NOI4n0LkwX99PS9xcmnQkw+qT/SWFgPNuxsLC4KyUKH bNuKevQClFzydyRmBWTOYMRNr96exbIIPs7HowxvfiHXAU4UYTnq4pMB2 /pAFE6AcbRzuS525n/L3DE6l8ZW5yoxmejpVAMVbxH+AfCBti8icfyUek AbzzJnAGk4r/ETPZ8cAQQWMP5oY3EzEK1imnEL/kIynDZH9SjWkNKblIf /6nGyEdcVs7nWhRqekJhEcqYY2q62CQf+WzzwzziAmn3sUDKB7iUtbjPi w==; X-IronPort-AV: E=Sophos;i="5.60,415,1549900800"; d="scan'208";a="107219031" Received: from mail-bn3nam01lp2050.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([104.47.33.50]) by ob1.hgst.iphmx.com with ESMTP; 01 May 2019 07:29:04 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tXUTsIRiuDGCHyauZRrtG/QeDpa6BCwT3JY/YNrnlkw=; b=fvFYF4D0TP2zit7ldylSVoOesae30ZzrURA+MkW8xKP4zyB11eKamEdawgAqk3OvHGvZ1o++2hjVTMkkGeeuUrfgKiuK36QnZql6kTOhybmnE8uoxU389Ar/AdsmM45NjZuQta5zJWHXZy+0K30K/T96y9wFoO5iczckOj+xdTs= Received: from DM6PR04MB4908.namprd04.prod.outlook.com (20.176.109.81) by DM6PR04MB6217.namprd04.prod.outlook.com (20.178.224.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.10; Tue, 30 Apr 2019 23:29:01 +0000 Received: from DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2]) by DM6PR04MB4908.namprd04.prod.outlook.com ([fe80::9ba:6028:ae27:7d2%2]) with mapi id 15.20.1835.015; Tue, 30 Apr 2019 23:29:01 +0000 From: Alistair Francis To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v2 5/5] linux-user/elfload: Fix GCC 9 build warnings Thread-Index: AQHU/6x+xmB4VEre5EW2C7se/oJgig== Date: Tue, 30 Apr 2019 23:29:01 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.21.0 x-clientproxiedby: BYAPR07CA0003.namprd07.prod.outlook.com (2603:10b6:a02:bc::16) To DM6PR04MB4908.namprd04.prod.outlook.com (2603:10b6:5:19::17) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ea03c69-e3cd-41cb-c2d0-08d6cdc3a07a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DM6PR04MB6217; x-ms-traffictypediagnostic: DM6PR04MB6217: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:773; x-forefront-prvs: 00235A1EEF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(979002)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(5640700003)(8936002)(6436002)(53936002)(73956011)(316002)(54906003)(14454004)(81156014)(6486002)(6916009)(81166006)(68736007)(8676002)(186003)(26005)(3846002)(66446008)(6116002)(66476007)(64756008)(7736002)(6512007)(66946007)(305945005)(102836004)(2906002)(66556008)(5660300002)(386003)(446003)(6506007)(66066001)(44832011)(2501003)(2351001)(11346002)(50226002)(478600001)(36756003)(486006)(476003)(2616005)(76176011)(4326008)(52116002)(14444005)(99286004)(71190400001)(71200400001)(256004)(118296001)(72206003)(86362001)(25786009)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR04MB6217; H:DM6PR04MB4908.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QcvX4ELAxCo1eXfQlDtmxxfhTJn6io18fMIZL7DTqZ0L31MCiZen/OFqmQzGnUlTXdDAHsIlvx1ImNtqDZ2CzGRxjDV2bdnMW99QaNLO9rUoNrupIgapf5BY0lalGuktQLxIlJk7oOblvPPaVd+vB7CWXuidym0c6+W+681SCEfT7/DqWpe1gKB87cfFBjtMsk7Ag3n+e2y7YFso7nfGD/ColbvxmlbqzcC/4Y7kh2T1iXA4jC1cr5MlXc+1p0AAYMp0hJUa+Og90JlS5ujekRBSi59xFAcMaEB2gxQx8tJq48NvH7vPysw7nSN5Mmv1ohNDLcCR1WATDtGXAsoEiInNe8ovLd3Y6HwPO8kJopBPWXtqACayjaEN69MkTclJSejgGWRCJLq9Vpl2fwaJawZ30S2rWg+cHR62KfOI5Ds= Content-ID: <667FC14ACE4DD1458B8B48476394801A@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ea03c69-e3cd-41cb-c2d0-08d6cdc3a07a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2019 23:29:01.6462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6217 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.154.42 Subject: [Qemu-devel] [PATCH v2 5/5] linux-user/elfload: Fix GCC 9 build warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , Alistair Francis , "kraxel@redhat.com" , "alistair23@gmail.com" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘fill_psinfo’ at /home/alistair/qemu/linux-user/elfload.c:3208:12, inlined from ‘fill_note_info’ at /home/alistair/qemu/linux-user/elfload.c:3390:5, inlined from ‘elf_core_dump’ at /home/alistair/qemu/linux-user/elfload.c:3539:9: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alistair Francis Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index c1a26021f8..d08fe23466 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2872,7 +2872,7 @@ struct target_elf_prpsinfo { target_gid_t pr_gid; target_pid_t pr_pid, pr_ppid, pr_pgrp, pr_sid; /* Lots missing */ - char pr_fname[16]; /* filename of executable */ + char pr_fname[16] QEMU_NONSTRING; /* filename of executable */ char pr_psargs[ELF_PRARGSZ]; /* initial part of arg list */ };