From patchwork Sat May 4 00:42:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929509 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9564315A6 for ; Sat, 4 May 2019 00:45:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 839AD287E3 for ; Sat, 4 May 2019 00:45:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77AA1287E6; Sat, 4 May 2019 00:45:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1C89287E5 for ; Sat, 4 May 2019 00:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbfEDApb (ORCPT ); Fri, 3 May 2019 20:45:31 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40536 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfEDApb (ORCPT ); Fri, 3 May 2019 20:45:31 -0400 Received: by mail-wr1-f65.google.com with SMTP id h4so9853590wre.7; Fri, 03 May 2019 17:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sMqlC6T/pDP84f5tXF9/8B2A9RjGIFKJexKEfFDd6F0=; b=NgzaCTuDb+k/M7/bM6wlDXR/9dhXfONj31X9UBQgT+lLYQA0SLouT3nKpQC57/Y3zx RF5nFVE6t0iQ4spEX48ywmtXfVdG/TR+XiloXWIXcu59YB58KWaOOIE3yJdb0390jxRL r9h1D1OGaCEw0/xCpH8qzLFNYlTmO3S5PqZopqsTE8aoz3L/s0DG1fCqnoTAG4tgu3Y5 eR+G+bA3IgZzjo0v9y1uDG+IG4JPuCpx+y0blD5fo0Ez813mSoCRQ2aGqxMdWrUveU/9 82sDXPxrqb3RXeKJo1Ah3B6aEkrlTH6BH2jhfptWtwcTHaGBR8z1cgoMR9HaiBtK8Y3A 2+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sMqlC6T/pDP84f5tXF9/8B2A9RjGIFKJexKEfFDd6F0=; b=fFGh+feyo6Hfq9ElfFn/EQ9erI4S7czdazM1zhZ/c4AoGhpnIa8b6Whd+1tXoFCGnh DwxmCAREm3zxfIbH46tTv+45IanwIDcKSNSJOq0W40XihtNtNNQ3g6kuycGFQNguNaGS tH1SId29ut1Ms/HvMOjsKtFpQx/l/t+yejkgTdZjcyyj5d8IWulFNgfH3im69Qn67bo0 WIO49aIrOUHe9A7S+Sk/U3f5i6YIUZ3CJG8u7DwEYwJ/neIxtcaBZt1pJk4XCXvdVxk9 4Xxoa/7Fq//GBwBWMea7e210N6yFpjIV3Mca4ak6b2vCdr26aTiHwiqQ4ORJkEX133Bt 6XJw== X-Gm-Message-State: APjAAAV2C6o5opXkUr6oxjSeKv81T2RN6Q0fQi3XaZV5H+cyYbHBEyB7 Lt680zv4XK7rjXcZ3tjBVR0= X-Google-Smtp-Source: APXvYqwOyYUVQhhiLp0oWbe1KzrPalyUTE72wkvMD9D6qv4Iz9QMpuvF+7jA/WnKpNhO+yMBhIUD/w== X-Received: by 2002:adf:c748:: with SMTP id b8mr9065704wrh.292.1556930728909; Fri, 03 May 2019 17:45:28 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:45:28 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca Subject: [PATCH 1/6] serial: sh-sci: Reveal ptrval in dev_dbg Date: Sat, 4 May 2019 02:42:53 +0200 Message-Id: <20190504004258.23574-2-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Starting with v4.15-rc2 commit ad67b74d2469d9 ("printk: hash addresses printed with %p"), enabling debug prints in sh-sci.c would generate output like below confusing the users who try to sneak into the internals of the driver: sh-sci e6e88000.serial: sci_request_dma: TX: got channel (____ptrval____) sh-sci e6e88000.serial: sci_request_dma: mapped 4096@(____ptrval____) to 0x00000006798bf000 sh-sci e6e88000.serial: sci_request_dma: RX: got channel (____ptrval____) sh-sci e6e88000.serial: sci_dma_tx_work_fn: (____ptrval____): 0...2, cookie 2 There are two possible fixes for that: - get rid of '%p' prints if they don't reveal any useful information - s/%p/%px/, since it is unlikely we have any concerns leaking the pointer values when running a debug/non-production kernel Go second route to preserve original debug output and minimize the diff. Fixes: ad67b74d2469d9 ("printk: hash addresses printed with %p") Signed-off-by: Eugeniu Rosca --- drivers/tty/serial/sh-sci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 3cd139752d3f..82660f8e6d86 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1434,7 +1434,7 @@ static void sci_dma_tx_work_fn(struct work_struct *work) goto switch_to_pio; } - dev_dbg(port->dev, "%s: %p: %d...%d, cookie %d\n", + dev_dbg(port->dev, "%s: %px: %d...%d, cookie %d\n", __func__, xmit->buf, xmit->tail, xmit->head, s->cookie_tx); dma_async_issue_pending(chan); @@ -1570,7 +1570,7 @@ static void sci_request_dma(struct uart_port *port) return; chan = sci_request_dma_chan(port, DMA_MEM_TO_DEV); - dev_dbg(port->dev, "%s: TX: got channel %p\n", __func__, chan); + dev_dbg(port->dev, "%s: TX: got channel %px\n", __func__, chan); if (chan) { /* UART circular tx buffer is an aligned page. */ s->tx_dma_addr = dma_map_single(chan->device->dev, @@ -1581,7 +1581,7 @@ static void sci_request_dma(struct uart_port *port) dev_warn(port->dev, "Failed mapping Tx DMA descriptor\n"); dma_release_channel(chan); } else { - dev_dbg(port->dev, "%s: mapped %lu@%p to %pad\n", + dev_dbg(port->dev, "%s: mapped %lu@%px to %pad\n", __func__, UART_XMIT_SIZE, port->state->xmit.buf, &s->tx_dma_addr); @@ -1591,7 +1591,7 @@ static void sci_request_dma(struct uart_port *port) } chan = sci_request_dma_chan(port, DMA_DEV_TO_MEM); - dev_dbg(port->dev, "%s: RX: got channel %p\n", __func__, chan); + dev_dbg(port->dev, "%s: RX: got channel %px\n", __func__, chan); if (chan) { unsigned int i; dma_addr_t dma; From patchwork Sat May 4 00:42:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929511 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA59A13AD for ; Sat, 4 May 2019 00:45:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96ED0287E3 for ; Sat, 4 May 2019 00:45:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86273287E6; Sat, 4 May 2019 00:45:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E531287E3 for ; Sat, 4 May 2019 00:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbfEDApq (ORCPT ); Fri, 3 May 2019 20:45:46 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41738 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfEDApp (ORCPT ); Fri, 3 May 2019 20:45:45 -0400 Received: by mail-wr1-f66.google.com with SMTP id c12so9855119wrt.8; Fri, 03 May 2019 17:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=60g1iATd2Ji9UNIIxjfzFEhqI7afmYF8Ktl39ggIO1g=; b=J9AJicIIzmrZS1RV8A8ApEXFDYgYFZmy0gPimbONo0WZ0Uxbyav1EqCO29lQngw46o jk1MNFTosFJYIz5DYFMKX2uIhgnYQZDcIvmkrG7f7enEzPiBLnwlikHGrl0ZJYKQKBfN 1T2mLDjBZTxfBUQJnqWBjAkq8XmeLS8WgLR7w0MNCKiSeIafs4ED1BluZfeQTnJPvKNT dfntUN8thFKYbrjZIsuksPmj3xJKCrJwj3f1hWA+JijOQXfBj1z1uzUC5KwDCwoFwtc1 eoeJ6Jw1QveNwKTMSvmY9gzodU540QNrpb7O6VfOTXfLfsd5hgjUCbxt/aEwr5QnCMqj o4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=60g1iATd2Ji9UNIIxjfzFEhqI7afmYF8Ktl39ggIO1g=; b=G53uT7dGgpeff81BhdGvWipNk+NL0d48CrE8TbFAvqVuLL4kH/TVa/NR05WCvtyDxX S1wWhsEX0cFkZMXNNJfkioydx7GlmgKZVXtGYurWIY6+GeVoaOYvheke6p6BKHNcSbU0 Dd889fIL9xcVErHgt0oFXkRlyUUtQQQVbdri26Io82iwJGZtP1yDvc0L7KjGGU0H4dQx BOZd1ry/7Dg6r452eE6gmATp1MZ0/BTj5ZWriLs1bRPwupLd45/fMwTIg2+H1nUWT8g7 U3fvoZqSdSXJT1jhxSjtY4Tp/nojHjqI2pF57TkCkv99IrRPBvxbwa9qDeinPr3eBC6j /0LQ== X-Gm-Message-State: APjAAAUMo9vaFMBoKOznydnHaMAB+Wj6VeU/d3blyfAvHJFLRiE6w4p+ sdM0JdGFGnWob/sM2XtP+FE= X-Google-Smtp-Source: APXvYqxSm+06HZWrUqJh5A7hSOZ1iUk7orZqT5brMqjy+4kBrsKsgSVdZeE6p6zdgfyM+ChLr0aa0A== X-Received: by 2002:a5d:654a:: with SMTP id z10mr9405038wrv.153.1556930743313; Fri, 03 May 2019 17:45:43 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.45.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:45:42 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca , Michael Rodin Subject: [PATCH 2/6] Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2" Date: Sat, 4 May 2019 02:42:54 +0200 Message-Id: <20190504004258.23574-3-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 97f26702bc95b5c3a72671d5c6675e4d6ee0a2f4. Here is the story behind this revert. Mainline commit [0] landed in the stable tree as commit [1], from where it reached us in the form of regular stable update. After that, Michael started to report occasional (30-50%) freezes of serial console on booting M3-ES1.1-Salvator-XS. Same happened on M3-ES1.1-Salvator-X. Every time the issue occurs, the serial console outputs below [2] before becoming totally unresponsive and printing nothing else: rcar-dmac e7300000.dma-controller: Channel Address Error Git bisecting shows that the problem is contributed by commits [0-1]. While we can't be 100% certain (since we don't have the SCIF design docs revealing its internal implementation detail) we think there is plenty of evidence to assume that DMA is not supported on SCIF2, hence should stay disabled on this specific channel: - Excerpt from Chapter 17. Direct Memory Access Controller for System (SYS-DMAC) of R19UH0105EJ0150 Rev.1.50: ---------8<--------- [H3, H3-N, M3-W, V3M, V3H, D3, M3-N, E3] The following modules can issue on-chip peripheral module requests. [..] HSCIF0/1/2/3/4, [..] SCIF0/1/3/4/5, ---------8<--------- - Excerpt from RENESAS_RCH3M3M3NE3_SCIF_UME_v2.00.pdf (Yocto v3.15.0): ---------8<--------- DMA Transfer: - Support: SCIF0, SCIF1, SCIF3, SCIF4, SCIF5 - Not support: SCIF2 ---------8<--------- - Disabled SCIF2 DMA in official Renesas v4.9/v4.14 kernels, e.g. see: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?id=e79c418fda8c Based on the issues generated by [0-1] (reproduced on H3, M3 and M3N) and the doc statements presented above, we think it makes sense to disable DMA on SCIF2 for most/all R-Car3 SoCs. [0] v5.0-rc6 commit 97f26702bc95b5 ("arm64: dts: renesas: r8a7796: Enable DMA for SCIF2") [1] v4.14.106 commit 703db5d1b1759f ("arm64: dts: renesas: r8a7796: Enable DMA for SCIF2") [2] scif (DEBUG) and rcar-dmac logs: https://gist.github.com/erosca/132cce76a619724a9e4fa61d1db88c66 Fixes: 97f26702bc95b5 ("arm64: dts: renesas: r8a7796: Enable DMA for SCIF2") Reported-by: Michael Rodin Signed-off-by: Eugeniu Rosca Tested-by: Eugeniu Rosca Reviewed-by: Simon Horman Reviewed-by: Wolfram Sang --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index cdf784899cf8..23de63f3d6c3 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -1262,9 +1262,6 @@ <&cpg CPG_CORE R8A7796_CLK_S3D1>, <&scif_clk>; clock-names = "fck", "brg_int", "scif_clk"; - dmas = <&dmac1 0x13>, <&dmac1 0x12>, - <&dmac2 0x13>, <&dmac2 0x12>; - dma-names = "tx", "rx", "tx", "rx"; power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; resets = <&cpg 310>; status = "disabled"; From patchwork Sat May 4 00:42:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929513 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42E1A13AD for ; Sat, 4 May 2019 00:45:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D32F287E3 for ; Sat, 4 May 2019 00:45:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D856287E6; Sat, 4 May 2019 00:45:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE2EA287E3 for ; Sat, 4 May 2019 00:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfEDAp4 (ORCPT ); Fri, 3 May 2019 20:45:56 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41749 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726914AbfEDAp4 (ORCPT ); Fri, 3 May 2019 20:45:56 -0400 Received: by mail-wr1-f68.google.com with SMTP id c12so9855379wrt.8; Fri, 03 May 2019 17:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4mcVmLTkRSUd+7KBv/SWmh/hG34LzRqn8wCf+WbombY=; b=Ya2WVApmvFh+JLNizo1hCcwFuEi6SJAFdo299wTLu43p5du0ggRqVqNsUHMfN1xr3X Q2HaYj0IQZTdKG3xuwBJMzQ0BHoS/zdxq+rvvVpBfC4oJHwKPfI79NerYtT0OqTyTP/K 0Fx0P7EWOElgCGEmPj6mps38RDyOIW2zdaCfVkqswmFqwnkzNyNeQOth/zagO5aNmdab kqwk0oILoO5sAI8+bNsjqPil4TI6M2KOtfUQ+BOAykj63wYUpR5fjPyUMkLRIPFHJ65u Kto39oeGs/OxeLoHVvYCpdkGQ852fPrLlMjAoaxHvRSO4u0SjlRGNrsR8DmgSU3UJDpH q0Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4mcVmLTkRSUd+7KBv/SWmh/hG34LzRqn8wCf+WbombY=; b=atYP76Iw3TgToPCSNwv+jsm5JZKtksRJhCUQYmkCo0YRmwmHHca/hFVprFCqe5TZRb d+w/PJYrCRFH94s9IdU2E97ktVF4nf1YFSQ8kuOFrdMVbXcsg5aPkEIZDlt+W2qQK08s RS1tah48o1TBH0pZzXmejoj5hH5eb/rzhdaWJepexkFho6tKbi7Yxl49JZxmHqwO+9Ct LScQCt7vbWSE/gSezeZWfNvdzgWNkDT0pWC++ZlkCddYqa7aVRilRO6UiTWbCJ5sm20w tJ4WEGEa/P+fujG+yUaeovXl45/Bq/PoNfGL3+TuONS1pAjaxcyMRdTP4343gfOVCpZN Smmg== X-Gm-Message-State: APjAAAXYyhmCyVPNaOZ3nH16W811t9UC9ctnd4nIjuH74wYFkC63XocD yRxw1AVeJKAKsTWfe6PEZIk= X-Google-Smtp-Source: APXvYqwPWn2stQT8D9aqc92KeXI1wnbcDMFq/n7PO0d8rDanJrqvNEQ9oXDN9BSKEWY734qMVNTdGA== X-Received: by 2002:a5d:4acc:: with SMTP id y12mr9259556wrs.234.1556930754363; Fri, 03 May 2019 17:45:54 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.45.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:45:53 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca Subject: [PATCH 3/6] arm64: dts: renesas: r8a7795: zap dma configuration in scif2 Date: Sat, 4 May 2019 02:42:55 +0200 Message-Id: <20190504004258.23574-4-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Both empirically and based on the existing documentation, it looks like SCIF2 does not support DMA. Let's disable it. Full reasoning is given in commit ("Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2""). Fixes: eb21089c32054e ("arm64: dts: renesas: r8a7795: Add missing SYS-DMAC2 dmas") Fixes: 49af46b4095672 ("arm64: renesas: r8a7795: Add all SCIF nodes") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index abeac3059383..7704bd46afdf 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -1323,9 +1323,6 @@ <&cpg CPG_CORE R8A7795_CLK_S3D1>, <&scif_clk>; clock-names = "fck", "brg_int", "scif_clk"; - dmas = <&dmac1 0x13>, <&dmac1 0x12>, - <&dmac2 0x13>, <&dmac2 0x12>; - dma-names = "tx", "rx", "tx", "rx"; power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; resets = <&cpg 310>; status = "disabled"; From patchwork Sat May 4 00:42:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929515 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7115414B6 for ; Sat, 4 May 2019 00:46:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EFBD28800 for ; Sat, 4 May 2019 00:46:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 530CA2880A; Sat, 4 May 2019 00:46:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F125F28800 for ; Sat, 4 May 2019 00:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726914AbfEDAqF (ORCPT ); Fri, 3 May 2019 20:46:05 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55969 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbfEDAqF (ORCPT ); Fri, 3 May 2019 20:46:05 -0400 Received: by mail-wm1-f65.google.com with SMTP id y2so8669324wmi.5; Fri, 03 May 2019 17:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KuwUHQWOOly8GFk7p0yEd8RtBOjjsLVUGKjg2tkNT9k=; b=VmFfCj3rLEsa43520oHTqGeAcIiX9wOw5oCJU7xrvINDnYpa6xtWN0Ef2jXcMGpCLr GX79y/YB61BHEyQju00p16SiPrRp5xNzhn6XYjzrHgyI2QHIDPd2o/5YBf3IStDzfIu2 IOYl36ZVwAxuFtObAb6qTp3nIdrU8Ji1G+WPusb+xQWoceT1Qa5quia3xWVPmHRn2GuU Nug6znuOj8pKehiU2MIP0yFrfHPWBQzSR33MvuysHJXrEm3Au+czFp3NfcJ5Ux9sYG1S WrimlHDQbPWwWF+FN2KkDjgAGvqS/0I/jJk3UglNkC7Iw3ZE8BAJbihKSReJdttOavgt lBiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KuwUHQWOOly8GFk7p0yEd8RtBOjjsLVUGKjg2tkNT9k=; b=muO1vTEGCuT92fAOflGr5DRzuKd4jdOtJpf3yK/dhIS0u5Ls2z3yfR3oqBMXNUTOr6 cWiPpG3Z0UyKaPlc2/k1k9pY7cFfsw0t8nlUiL1q6+NelDbZ0scEJi59ZrubZpKbSxKm DPceZwvP+PxAU1UUem0B8sZLQGBybR7jOJUYLSBXu4+NIhUDdsEFD9TwIZa9oJHGedBX wERl4iTIJPa+r1dsWeZIOFvNmWGa2yHHgwLZzSMHwJga7Himpq557XqRlPP9fGIkxaia 5LTikLREXdREuCeRNi3/f5PzjCO2eJMHQyb+PfLeawlUPFB4JKE6awRXojcf684hRTTJ 0JUQ== X-Gm-Message-State: APjAAAVaaGxNJU7pt3G/TgZ7uT81yw4X7HH4p+otIRFg3ofPLsPq8X8P QpdvKW8xnL4uTHMJ49p5tN4= X-Google-Smtp-Source: APXvYqwy5B09ksg2CRG1ihQkrfSJP8zikUvut2MCM8MDjWrKIKuKIq2cTRI/AfJf71T9Drgfef6nTA== X-Received: by 2002:a1c:c788:: with SMTP id x130mr8416823wmf.118.1556930762963; Fri, 03 May 2019 17:46:02 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.46.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:46:02 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca Subject: [PATCH 4/6] Revert "arm64: dts: renesas: r8a77965: Enable DMA for SCIF2" Date: Sat, 4 May 2019 02:42:56 +0200 Message-Id: <20190504004258.23574-5-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 05c8478abd485507c25aa565afab604af8d8fe46. Both empirically and based on the existing documentation, it looks like SCIF2 does not support DMA. Let's disable it. Full reasoning is given in commit ("Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2""). Fixes: 05c8478abd4855 ("arm64: dts: renesas: r8a77965: Enable DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index 9763d108e183..979f14d1fcc4 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -1068,9 +1068,6 @@ <&cpg CPG_CORE R8A77965_CLK_S3D1>, <&scif_clk>; clock-names = "fck", "brg_int", "scif_clk"; - dmas = <&dmac1 0x13>, <&dmac1 0x12>, - <&dmac2 0x13>, <&dmac2 0x12>; - dma-names = "tx", "rx", "tx", "rx"; power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; resets = <&cpg 310>; status = "disabled"; From patchwork Sat May 4 00:42:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929517 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFAA314B6 for ; Sat, 4 May 2019 00:46:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE2B9287EF for ; Sat, 4 May 2019 00:46:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D259F28800; Sat, 4 May 2019 00:46:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8231A287EF for ; Sat, 4 May 2019 00:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfEDAqN (ORCPT ); Fri, 3 May 2019 20:46:13 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35465 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbfEDAqM (ORCPT ); Fri, 3 May 2019 20:46:12 -0400 Received: by mail-wr1-f68.google.com with SMTP id h15so4161017wrb.2; Fri, 03 May 2019 17:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tZ3Gtl5w/Eg0LvXW6tqh/QnbgWobUfKgk0BmiGgfmCA=; b=UDZx03gxehpzCpAWsCHVoeC6EbHypcLT2kR6aJXqIkje9qML115ZI/XBofgo/qgqgr Nfsg610K4ZXBN48B4fG6D3nbIhat+1SuV6B9XWnFBEZHjRbWTFSV3xN4zZ5J/qDY9JM5 JBe8bDJ36V8fmiacVSpByzpbAY4Hf2/2WE/dsSuZLzWu0cfOZ2KfYyaUmAVUizbAhHKb nrhZ0EUnUQSeYrtEtKmAkw3cyLkn8q9d8bywtBwwV7KrGWyTWGMN8qV1CG9ahisNw+rS 3Q5zNTaLtSpgnBcZQyXYklrm6q2148myeZt2CkVa+DNiPvTCl4gOcpvNT46kViwY1vsA ZLXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tZ3Gtl5w/Eg0LvXW6tqh/QnbgWobUfKgk0BmiGgfmCA=; b=VSmaf5eJh5fYwOXnrA0JXiDFVupIptvENYpU6prLcWWw4ZQonvIrcAEghGEE1qirTO hrjTi+WMbXtmpUjWCLzo5bUt6Tndv8nyfmuU8W6+VkxFI/BQKAJ1ZV8yW3/30uprfqFd aN5OaNQgjVH8p1rOjyRQu7cMgNujheu/TnKTk6SiiDrgSYx4LUpjzjh4H49WC0m/WCXx mRHld4ZbCflpIFSmPgRD78MsCVhRUKZ6dauZuDUSscryIKoXJX77R+/QMo5QByH1fhHD aZxYOZceVhzyUC9QCjmPCE4eVtaTjKsriLS1jGtyaPTZp4p4uzP7lKiZzgyos4WF9JHf x1yA== X-Gm-Message-State: APjAAAVFKWa5QmBLKAPFiLr21HbENBQ5of/A9UMCItdJ0JmoujvwmFgT 2PVUYbhtdwGQQzgWm3t1vqw= X-Google-Smtp-Source: APXvYqwbBHsaTX9SOOE4rBk5ZgiLoUDGCJYNmgRvGEn8zVqkCXmUoKxi1H7uV0i1uL/AGHbNvEQ9jw== X-Received: by 2002:adf:dcd1:: with SMTP id x17mr8669435wrm.91.1556930770539; Fri, 03 May 2019 17:46:10 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.46.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:46:10 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca Subject: [PATCH 5/6] Revert "arm64: dts: renesas: r8a77990: Enable DMA for SCIF2" Date: Sat, 4 May 2019 02:42:57 +0200 Message-Id: <20190504004258.23574-6-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit a99de47921565c233092b0d3c4652b3a10e715ec. Both empirically and based on the existing documentation, it looks like SCIF2 does not support DMA. Let's disable it. Full reasoning is given in commit ("Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2""). Fixes: a99de47921565c ("arm64: dts: renesas: r8a77990: Enable DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index d2ad665fe2d9..4bf32bfaafc0 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -1018,9 +1018,7 @@ <&cpg CPG_CORE R8A77990_CLK_S3D1C>, <&scif_clk>; clock-names = "fck", "brg_int", "scif_clk"; - dmas = <&dmac1 0x13>, <&dmac1 0x12>, - <&dmac2 0x13>, <&dmac2 0x12>; - dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; resets = <&cpg 310>; status = "disabled"; From patchwork Sat May 4 00:42:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 10929519 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E60A13AD for ; Sat, 4 May 2019 00:46:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C415287FE for ; Sat, 4 May 2019 00:46:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50AE728800; Sat, 4 May 2019 00:46:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E724C287E5 for ; Sat, 4 May 2019 00:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbfEDAqT (ORCPT ); Fri, 3 May 2019 20:46:19 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55983 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbfEDAqT (ORCPT ); Fri, 3 May 2019 20:46:19 -0400 Received: by mail-wm1-f66.google.com with SMTP id y2so8669734wmi.5; Fri, 03 May 2019 17:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1a5j4wQOMQ4OWB49dqiWbDIfmn+ssi4ipxGaHFRYmU=; b=J8SSYCiqRozdI7bSGvGOYhm1x7ax0w1b7LaVJmoQVUj+4hhgjbD9miaTBZ5Q+jvmeq fpw8ctvkhxGct9JcLtKw3McSO+cNxEPuDf8OCF/GoeI6dgl6pJvuAH3p6VKrsp9QX8s/ ieLzkHQWxnxeDWyBbjJMTPJNlvEvglCT3Lo3wJBCpy21Ir5cChJjOpcEHdh440djHoIt 1QDVmQ9qbrQBRflEoFQ7c+wWDZD0dV8pCBu9ngRMao/XS6Y+ROcBIuUDC5+gTbUNj1nC yEG+zX832CoZ2CEc0qP8vUEm7J9L/F+ZQADT/BT5IKeEcNVf8SyPTYSknsCV4SA6uISs 3CLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T1a5j4wQOMQ4OWB49dqiWbDIfmn+ssi4ipxGaHFRYmU=; b=PsM6nnRHjRACSoZpVrKZEw+n3KByh0R8VqgIPnvPwOJiXFtsfcXuplMLhTBmPGTOI3 ed5D5ejrQphlMhWsNXc5K/gGgttSEAfzI05wrVpNkbAeLRz2kKqW8x8ZkuiaoNLr++xC L1hFHt1c2YgypiL0RSzRJuRG69k7uRv7F6vKqnQPTAljGNLcGjIjzBXgvEejWiMSj5dG tQSXjklaj9b+veYtrhNJJCfETpOIldxeaU0zZFI6HI839ejIjB3D1SLCAysk8EuGDZ4x 7nWXjSExO5hQ9dIwgQHmTR1QY0V2cse9dmkcBjBttJ2p9LTEkjkSaeVrXi/qj5QCWGft VcLg== X-Gm-Message-State: APjAAAXL7XamNCbVwaF5bMA69pyuJOqZaB39xHafcyf/o6UbAYk3Rt3T fWA4xLKtKOyjAf872UUI6ac= X-Google-Smtp-Source: APXvYqx3TIhVvijrJC3CKiX/ezPH1vUd+L8XwrYGDTC+bcLqV8SpuMTT8tYKf7mYCbmo63u5XCOdLA== X-Received: by 2002:a1c:1a90:: with SMTP id a138mr8239064wma.81.1556930776662; Fri, 03 May 2019 17:46:16 -0700 (PDT) Received: from localhost.localdomain (ipb218f40a.dynamic.kabel-deutschland.de. [178.24.244.10]) by smtp.gmail.com with ESMTPSA id b11sm5979161wmh.29.2019.05.03.17.46.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 May 2019 17:46:16 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: Geert Uytterhoeven , Simon Horman , Chris Brandt , Wolfram Sang , Ulrich Hecht , Greg Kroah-Hartman Cc: "George G . Davis" , Andy Lowe , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Magnus Damm , Rob Herring , Mark Rutland , Eugeniu Rosca , Eugeniu Rosca Subject: [PATCH 6/6] Revert "arm64: dts: renesas: r8a77995: add DMA for SCIF2" Date: Sat, 4 May 2019 02:42:58 +0200 Message-Id: <20190504004258.23574-7-erosca@de.adit-jv.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190504004258.23574-1-erosca@de.adit-jv.com> References: <20190504004258.23574-1-erosca@de.adit-jv.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit af2ea3df851ffa68ad07ff59d4dabadbf33b45ef. Both empirically and based on the existing documentation, it looks like SCIF2 does not support DMA. Let's disable it. Full reasoning is given in commit ("Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2""). Fixes: af2ea3df851ffa ("arm64: dts: renesas: r8a77995: add DMA for SCIF2") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 5bf3af246e14..bd3ac5d00b2e 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -740,9 +740,6 @@ <&cpg CPG_CORE R8A77995_CLK_S3D1C>, <&scif_clk>; clock-names = "fck", "brg_int", "scif_clk"; - dmas = <&dmac1 0x13>, <&dmac1 0x12>, - <&dmac2 0x13>, <&dmac2 0x12>; - dma-names = "tx", "rx", "tx", "rx"; power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; resets = <&cpg 310>; status = "disabled";