From patchwork Mon May 6 17:28:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10931673 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F0CE8924 for ; Mon, 6 May 2019 17:31:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D453F28843 for ; Mon, 6 May 2019 17:31:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0C61287A0; Mon, 6 May 2019 17:31:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4552C287A0 for ; Mon, 6 May 2019 17:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbfEFRbL (ORCPT ); Mon, 6 May 2019 13:31:11 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:41344 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbfEFRbL (ORCPT ); Mon, 6 May 2019 13:31:11 -0400 Received: from grover.flets-west.jp (softbank126125154139.bbtec.net [126.125.154.139]) (authenticated) by conuserg-10.nifty.com with ESMTP id x46HSZCi022951; Tue, 7 May 2019 02:28:36 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x46HSZCi022951 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557163716; bh=rLUuRSyxYbwt0UVs9QzxFKJlZ9BtLeDXvLxtcsNawRY=; h=From:To:Cc:Subject:Date:From; b=JKXYbZcbzekTUoL6mu+jZH4TU3MaGysbzm7unONRIccBJk6/UgXh6Bh9aTWwiW+Ky A2ptFGi+J9bV+RT6ywYeX1Qnt4A6lFmUkq00Nd5GMuTOaW2tNCVATIqA4Fq/HRXLYr WU81SQYU6DOjxjrRMurBKpCpPe/E/INWCawblX04Pp9cEBtDKms2OUowjOq9pQSTQC GFNUMVWSuzcZ8Ufn0cOstMMRyrcrn34nrEuVi3uWWQ5qtTUX1Xyls6gAdGc4C672QN 4zLbnoRXV6315fHrM4TXSMkwwXikidN8W/U5/s7ksKIdmrtuC6xMxxiKny2sqkCqN3 eyh2vCnHuXi3w== X-Nifty-SrcIP: [126.125.154.139] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Stephen Rothwell , Alexey Gladkov , Masahiro Yamada , linux-kernel@vger.kernel.org, Thomas Gleixner , Tony Lindgren , Lee Jones , Aaro Koskinen , linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Daniel Lezcano Subject: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro Date: Tue, 7 May 2019 02:28:17 +0900 Message-Id: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These files do not define (USBHS_)DRIVER_NAME. Yet, they can be successfully compiled because they are never built as a module by anyone, i.e, the MODULE_ALIAS() calls are always no-op. A problem showed up when a patch "moduleparam: Save information about built-in modules in separate file" is applied. With this new feature, MODULE_*() are populated even if the callers are built-in. To avoid the build errors, the lines referencing to the undefined macro must be removed. The complete fix is to remove all MODULE_* and #include like many "make ... explicitly non-modular" commits did. For now, I am touching the offending lines. Reported-by: Stephen Rothwell Signed-off-by: Masahiro Yamada Acked-by: Daniel Lezcano Acked-by: Tony Lindgren --- I will insert this commit before "moduleparam: Save information about built-in modules in separate file" arch/arm/plat-omap/dma.c | 1 - drivers/clocksource/timer-ti-dm.c | 1 - drivers/mfd/omap-usb-tll.c | 1 - 3 files changed, 3 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index d4012d6..5ca4c5f 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -1449,7 +1449,6 @@ static void __exit omap_system_dma_exit(void) MODULE_DESCRIPTION("OMAP SYSTEM DMA DRIVER"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRIVER_NAME); MODULE_AUTHOR("Texas Instruments Inc"); /* diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index 3352da6..2b7cee81 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -998,5 +998,4 @@ module_platform_driver(omap_dm_timer_driver); MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRIVER_NAME); MODULE_AUTHOR("Texas Instruments Inc"); diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 446713d..93177d8 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -459,7 +459,6 @@ EXPORT_SYMBOL_GPL(omap_tll_disable); MODULE_AUTHOR("Keshava Munegowda "); MODULE_AUTHOR("Roger Quadros "); -MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");