From patchwork Wed May 8 06:33:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Flax X-Patchwork-Id: 10934433 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40F7B912 for ; Wed, 8 May 2019 06:35:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FA43277D9 for ; Wed, 8 May 2019 06:35:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 240C826419; Wed, 8 May 2019 06:35:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D683205FB for ; Wed, 8 May 2019 06:35:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6AD81179D; Wed, 8 May 2019 08:34:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6AD81179D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1557297324; bh=PbGeN9zqFMByHRrDcbmRtIxPBzq7HpQJAy0rFKlcSc8=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=mTOjSz2vh1rbb2kluy/xIA6kUWMMtRgVEi0cfStRebdTtB/AlaHdFldkYzHwWESpZ gzJwtLc757caGm9UmMQ7IOTPLeW57pylbgEtEEIMjiJOiWH/xuSTVN3ATeveCa8K5i dZqvwj/FeTyMHdZ0WM09BMLxk/AOgY/AQaFnM+Hk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6E50DF89724; Wed, 8 May 2019 08:33:34 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id BECDDF8970F; Wed, 8 May 2019 08:33:32 +0200 (CEST) Received: from pecan.exetel.com.au (pecan-mail.exetel.com.au [220.233.0.8]) by alsa1.perex.cz (Postfix) with ESMTP id E6AEAF807B5 for ; Wed, 8 May 2019 08:33:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E6AEAF807B5 Received: from 212.199.233.220.static.exetel.com.au ([220.233.199.212] helo=localhost.localdomain) by pecan.exetel.com.au with esmtp (Exim 4.91) (envelope-from ) id 1hOG8k-0003Il-DQ; Wed, 08 May 2019 16:33:18 +1000 From: Matt Flax To: Liam Girdwood , Mark Brown , Brian Austin , Paul Handrigan , clemens@ladisch.de, ckeepax@opensource.cirrus.com, alsa-devel@alsa-project.org Date: Wed, 8 May 2019 16:33:13 +1000 Message-Id: <20190508063313.18099-1-flatmax@flatmax.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Cc: Matt Flax Subject: [alsa-devel] [PATCH] ASoC : cs4265 : readable register too low X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP The cs4265_readable_register function stopped short of the maximum register. An example bug is taken from : https://github.com/Audio-Injector/Ultra/issues/25 Where alsactl store fails with : Cannot read control '2,0,0,C Data Buffer,0': Input/output error This patch fixes the bug by setting the cs4265 to have readable registers up to the maximum hardware register CS4265_MAX_REGISTER. Signed-off-by: Matt Flax Reviewed-by: Charles Keepax --- sound/soc/codecs/cs4265.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c index ab27d2b94d02..c0190ec59e74 100644 --- a/sound/soc/codecs/cs4265.c +++ b/sound/soc/codecs/cs4265.c @@ -60,7 +60,7 @@ static const struct reg_default cs4265_reg_defaults[] = { static bool cs4265_readable_register(struct device *dev, unsigned int reg) { switch (reg) { - case CS4265_CHIP_ID ... CS4265_SPDIF_CTL2: + case CS4265_CHIP_ID ... CS4265_MAX_REGISTER: return true; default: return false;