From patchwork Mon Aug 27 23:46:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10577661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 735615A4 for ; Mon, 27 Aug 2018 23:46:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 705F229B5D for ; Mon, 27 Aug 2018 23:46:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 615FD29B7E; Mon, 27 Aug 2018 23:46:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 082CD29B5D for ; Mon, 27 Aug 2018 23:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbeH1Dfg (ORCPT ); Mon, 27 Aug 2018 23:35:36 -0400 Received: from mout.gmx.net ([212.227.15.19]:56761 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbeH1Dfg (ORCPT ); Mon, 27 Aug 2018 23:35:36 -0400 Received: from localhost.localdomain ([116.30.193.211]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0Lta9E-1fkV5D21zg-010xHo; Tue, 28 Aug 2018 01:46:36 +0200 From: Chengguang Xu To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Chengguang Xu Subject: [PATCH] aic94xx: remove unnecessary condition check Date: Tue, 28 Aug 2018 07:46:20 +0800 Message-Id: <20180827234620.13836-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 X-Provags-ID: V03:K1:+BSjAiSf01JRC/69EZnFrlz2mcRg3oBH5OedZ35c8OFvDgYYc2X lucejuplL8Ep9yzQUK5ooLAxgY4Ubs6X2Ay7ORzXzhJgoLQJPyapILDpLarZCQAcALLVVrX BDMUzfEW6CNlcReEByW8ECU1aJYEJYeGB+03YIZPFnrhh6JCPIGkriFTAityYwaOdrNBz/9 A8xMoNULLWUOn3NaM9BSA== X-UI-Out-Filterresults: notjunk:1;V01:K0:sVz6TZ48f3Y=:uDwqYj/g9m1xP/ixaPFNvI e5oWlY2LTCQt++hSEEdHeeAV5Q6ALijmWnUqGif0PhaJFcPa7/edqvvpTT5tVBb61p/EnNwvU bEtVVfom2m3oeIg0RdYzQW5jTN+PeU3glSVrf7Jo/4Y7v7eqoT8Uo26a92GUU/T1acvSCk7UZ biFohyrwI035ZrF9boA2QBkgCe/tGAoHkQPqVdBOmd9hQaSQO8EPwpjaDBy3k6QnK09UYuKpz Ayk0FCsOP02r5Q1EN5EtzD7g33Y4Y157fjayEdMhWwtEQK4bOL/k/vzfFmxWM3qYuc5FtD34X r/JMbWQf302JMApBKhnMqm+kH0NbrADdd/LbvR3MZvlJh7dHkA4kQTsntb3CE2+sd2NXwLj80 7eAsKQ3QmPx6SAtFdLCzxFO1vuKkCKuwurVgOA+eROMBrwTcH7wS6iJCTWi3S/tNdK7FDOXpQ TAXGYlHuQ10Rnl0KTdf0pUZeU+560kI6Rsi87B2ZygmLGNlhyYOXQ2ItOUh64RHxz+GJdTIDN VlpacbNiK61Wg3slLALl1NONFlg5KxV2kjOQnbuybeN2lmSVfYg3R3WKTI6BfzyCl0NiDDMy8 y/15u2ZM3gTHL9VEjsGyXFmnlDbRkfsWEvZ54D0IfchETuPKBo3QwqJTOzm49pQh1vKCyMZH1 PqSpLAQ1Li+46LHf1yAS23UIockIYfDnqxXsBdmZtEoWMGQkED15otZenlXiOTxU+uynATUlr ndKey/d9t7pB8LN80p/Kg7a5bBJ2MEv/pejrvYntqG85XzRAKuhqgaxwF+4= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmem_cache_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling kmem_cache_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/aic94xx/aic94xx_init.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 1391e5f35918..06a2642b977a 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -660,12 +660,10 @@ static int asd_create_global_caches(void) static void asd_destroy_global_caches(void) { - if (asd_dma_token_cache) - kmem_cache_destroy(asd_dma_token_cache); + kmem_cache_destroy(asd_dma_token_cache); asd_dma_token_cache = NULL; - if (asd_ascb_cache) - kmem_cache_destroy(asd_ascb_cache); + kmem_cache_destroy(asd_ascb_cache); asd_ascb_cache = NULL; }