From patchwork Fri May 17 10:05:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Ambure X-Patchwork-Id: 10947637 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D87E314C0 for ; Fri, 17 May 2019 10:05:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C555E1FFCD for ; Fri, 17 May 2019 10:05:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9F9926B41; Fri, 17 May 2019 10:05:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DE091FFCD for ; Fri, 17 May 2019 10:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbfEQKFZ (ORCPT ); Fri, 17 May 2019 06:05:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37472 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728036AbfEQKFZ (ORCPT ); Fri, 17 May 2019 06:05:25 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EEE7060128; Fri, 17 May 2019 10:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558087525; bh=e7P62AYBNfK5NvPXqx1wEnqqoUsS0GTNzKIU0NvNP3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LXggcu8H7JH0u4Hgy4lrctMRf0z0LmAPs+CFqiKRwHCp6ijHRDjTj89UJWIoQIZ5O VMy1xGn8cWZAy7hymIdvHv4HYRtdo6tG5TExrMfdjJfDlhEWi5D/A5Xf0PMDzKhp9u OSNjKssNjeGj3uYUanxKmm+jReTfx8FHbiIrBI28= Received: from aambure-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aambure@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1E92360128; Fri, 17 May 2019 10:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558087524; bh=e7P62AYBNfK5NvPXqx1wEnqqoUsS0GTNzKIU0NvNP3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DSpqTu+fc/YuPIg27Q36TOwAmzS/gHb9KV1jPOgCeFE7hxy8jhuajP3fiRWEXorRz s213ymVsDTJNTsfEe67JdiIo6JrAJD/bhveRyre5/z+D0H+NUTk4VKEUFo+F0ObtsG 0p7u9aEoLm4I7+geyS0UCyIjiTIpLtZ+kOVkxISs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1E92360128 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aambure@codeaurora.org From: Abhishek Ambure To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Abhishek Ambure Subject: [PATCH 1/2] ath10k: move pktlog connect service before htc start Date: Fri, 17 May 2019 15:35:15 +0530 Message-Id: <1558087516-666-2-git-send-email-aambure@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1558087516-666-1-git-send-email-aambure@codeaurora.org> References: <1558087516-666-1-git-send-email-aambure@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WCN3990 supports HTC service for pktlog. PKTLOG service should be connected before HTC start. Hence move connect pktlog service before HTC start Fixes: 713358c321f4 ("ath10k: enable pktlog for WCN3990 target") Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1 Signed-off-by: Abhishek Ambure --- drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 805a7f8..e2980fe9 100644 --- a/drivers/net/wireless/ath/ath10k/htc.c +++ b/drivers/net/wireless/ath/ath10k/htc.c @@ -893,6 +893,14 @@ int ath10k_htc_start(struct ath10k_htc *htc) int status = 0; struct ath10k_htc_msg *msg; + if (ath10k_htc_pktlog_svc_supported(ar)) { + status = ath10k_htc_pktlog_connect(ar); + if (status) { + ath10k_err(ar, "failed to connect to pktlog: %d\n", status); + return status; + } + } + skb = ath10k_htc_build_tx_ctrl_skb(htc->ar); if (!skb) return -ENOMEM; @@ -919,14 +927,6 @@ int ath10k_htc_start(struct ath10k_htc *htc) return status; } - if (ath10k_htc_pktlog_svc_supported(ar)) { - status = ath10k_htc_pktlog_connect(ar); - if (status) { - ath10k_err(ar, "failed to connect to pktlog: %d\n", status); - return status; - } - } - return 0; } From patchwork Fri May 17 10:05:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Ambure X-Patchwork-Id: 10947635 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D74C91395 for ; Fri, 17 May 2019 10:05:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C56CF212DB for ; Fri, 17 May 2019 10:05:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B933C26CFC; Fri, 17 May 2019 10:05:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A9A8212DB for ; Fri, 17 May 2019 10:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728499AbfEQKF1 (ORCPT ); Fri, 17 May 2019 06:05:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37520 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728043AbfEQKF1 (ORCPT ); Fri, 17 May 2019 06:05:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 81A5160E40; Fri, 17 May 2019 10:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558087526; bh=3FI+6YxD0MYgDR1vZht6lE9W7jGoaioQtNuUb8hI5Xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cz/ghU3ahjbA7G5CeJhZC5pO7SZ5evlFbMeEttDIJ/GwRUnGct3PXlIr/cEC91JRB SrG/OmJzgXWRF+MgXUxEv1LK0ofxCG2MpORQRclhhOGtaGst8ZEzK3sBwEInC58eTN v0Du+IPi/g38/W+7HMHxJuZgkeQXYw9zsAkVN7ms= Received: from aambure-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: aambure@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E1EA060E3E; Fri, 17 May 2019 10:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558087526; bh=3FI+6YxD0MYgDR1vZht6lE9W7jGoaioQtNuUb8hI5Xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cz/ghU3ahjbA7G5CeJhZC5pO7SZ5evlFbMeEttDIJ/GwRUnGct3PXlIr/cEC91JRB SrG/OmJzgXWRF+MgXUxEv1LK0ofxCG2MpORQRclhhOGtaGst8ZEzK3sBwEInC58eTN v0Du+IPi/g38/W+7HMHxJuZgkeQXYw9zsAkVN7ms= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E1EA060E3E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aambure@codeaurora.org From: Abhishek Ambure To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Abhishek Ambure Subject: [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990 Date: Fri, 17 May 2019 15:35:16 +0530 Message-Id: <1558087516-666-3-git-send-email-aambure@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1558087516-666-1-git-send-email-aambure@codeaurora.org> References: <1558087516-666-1-git-send-email-aambure@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PKT log enable command expects pdev id in enable params which is missing in current configuration. Fill pdev id in pkt log enable wmi command for correct configuration. Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend") Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1 Signed-off-by: Abhishek Ambure --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 582fb11..8a209f8 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -2981,6 +2981,8 @@ static void *ath10k_wmi_tlv_put_wmm(void *ptr, tlv->len = __cpu_to_le16(sizeof(*cmd)); cmd = (void *)tlv->value; cmd->filter = __cpu_to_le32(filter); + cmd->pdev_id = __cpu_to_le32(0); + cmd->reserved = __cpu_to_le32(0); ptr += sizeof(*tlv); ptr += sizeof(*cmd); diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h index 65e6aa5..5226283 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h @@ -1923,6 +1923,7 @@ struct wmi_tlv_vdev_stats { } __packed; struct wmi_tlv_pktlog_enable { + __le32 pdev_id; __le32 reserved; __le32 filter; } __packed;