From patchwork Thu May 23 21:18:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Mikhak X-Patchwork-Id: 10958813 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E3BF15A6 for ; Thu, 23 May 2019 21:19:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B00B2873E for ; Thu, 23 May 2019 21:19:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F327528749; Thu, 23 May 2019 21:19:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A54892873E for ; Thu, 23 May 2019 21:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Dtr4hm+s9OEv2TO+6sFz89NnNhNCZzrvnyciK6jyypY=; b=CTlL150NsoE/QzRSFMa2d5I7pf q51gS/syT31fRtEI+2AcpL7dtilwrqKMCAWlk6df/VruMOz9YN/2qAYzObZavcsIt5+PMexIZY8Ge 3AcyZld93hCME7be/CxHvBCBpvvi9PLpQ1wm0lm4Yt7rdLaoT/IQkiAmlJvpSENfNT9+oPG3GQTWe gCPy4DuB1FvENx64DgjtY+6MZ40D4AZpVYe39wcE1vzZTKk8m8K5KcgMGTPjd1jX0yGa+Ee2X3Ws4 ANYmE3r78Ml6mVj0eyqKFM+RhsDM/X+QSD/etv5GKopMkLudAFMhc9aWU7fsC3FBxhXhh0aoveMnB qzhy76jQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTv7O-0002rq-Hr; Thu, 23 May 2019 21:19:18 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTv7L-0002qE-Hv for linux-riscv@lists.infradead.org; Thu, 23 May 2019 21:19:17 +0000 Received: by mail-pg1-x543.google.com with SMTP id i21so3766320pgi.12 for ; Thu, 23 May 2019 14:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MSZ9qLvgnuUWthhRIbf1Cjhkpu+CFOpygVqw6RbqY5U=; b=WIEVJh7TgDCASi/+YnUkSMzEwtd6hlDck+n8tN2K1tMOc34LB1Jh1QvKVxb0cutw3A DH4g4vh5nw8eXnfoR/heSxG5RvW1s4Cu7RyyZ6t4otZ8aHQMWiZqrWSxK+3N7aAy6R+4 l8r6b9AvVpOk1jZ5i+uT/WsV3S0MArSerkECLKNwwo4gMVmHGwsbZ2PrkVXf3810gVjH 4xz9PTduCE02rrpFhwTGSl93D/REB0grsaDhqd9PMcZVxOt1JnTht+mXI17goUcKY5W/ MUmKkcNqR6rdY6EVi4f6uc5ZmjTB//hhHcF8odQI4bMn7jlRbjXi1cGld2z+oA2gXfiR dE4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MSZ9qLvgnuUWthhRIbf1Cjhkpu+CFOpygVqw6RbqY5U=; b=b8LUlHi8SeH8efkFzpty3iv/jVbqxdJ/gNpulgt4hDUMRSdR6l+LJsdpVQlLZtT83m s34T/mmROWJrlXPqYxhwSfp8PS/yIse+bbvEm7wXupuo6Mf5Mm+pUkpTdTickiFPlH7V cPMli6qQpsQd3E9pg2pNYpddiy7U0Wh/Kfp8rScRE44hq9wheWDclRRpnJ7WO7J1iMI8 eo2wKyGTe6/fWJ0DnokSzINzOgoo40AyxktOPJDl9OyWFeyOiNfUytMPni9EfgXA38u4 PZx+jGpeDCHzLyLFQqkfLrGlVegPxQVcyVQ0qd7cl8eCgXl5gmT/GfpIAMjsPO7gM4FF OitQ== X-Gm-Message-State: APjAAAUUW58jnGQVdkprgRS7qc06ZackYPT12N1eMjnBgk/dSVwjCRdc XhLVXZBKdSfOGWM0aUXSWBzRPA== X-Google-Smtp-Source: APXvYqyUyOAczgUqoXWQtDMPqw03qjPB1y6pLPNlzLwxi361TeJoFHwIvI96nXB0BIicaNoroN8SrA== X-Received: by 2002:a62:7610:: with SMTP id r16mr108209123pfc.69.1558646353373; Thu, 23 May 2019 14:19:13 -0700 (PDT) Received: from nuc7.sifive.com ([12.206.222.2]) by smtp.gmail.com with ESMTPSA id t5sm234092pgn.80.2019.05.23.14.19.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 May 2019 14:19:12 -0700 (PDT) From: Alan Mikhak X-Google-Original-From: Alan Mikhak < alan.mikhak@sifive.com > To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, lorenzo.pieralisi@arm.com, linux-riscv@lists.infradead.org, palmer@sifive.com, paul.walmsley@sifive.com Subject: [PATCH v2 1/2] tools: PCI: Fix broken pcitest compilation Date: Thu, 23 May 2019 14:18:00 -0700 Message-Id: <1558646281-12676-2-git-send-email-alan.mikhak@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558646281-12676-1-git-send-email-alan.mikhak@sifive.com> References: <1558646281-12676-1-git-send-email-alan.mikhak@sifive.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_141915_592806_CF35C212 X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Mikhak MIME-Version: 1.0 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP pcitest is currently broken due to the following compiler error and related warning. Fix by changing the run_test() function signature to return an integer result. pcitest.c: In function run_test: pcitest.c:143:9: warning: return with a value, in function returning void return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */ pcitest.c: In function main: pcitest.c:232:9: error: void value not ignored as it ought to be return run_test(test); Signed-off-by: Alan Mikhak Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings") Reviewed-by: Paul Walmsley --- tools/pci/pcitest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index 5fa5c2bdd427..6dce894667f6 100644 --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -47,15 +47,15 @@ struct pci_test { unsigned long size; }; -static void run_test(struct pci_test *test) +static int run_test(struct pci_test *test) { - long ret; + int ret = -EINVAL; int fd; fd = open(test->device, O_RDWR); if (fd < 0) { perror("can't open PCI Endpoint Test device"); - return; + return -ENODEV; } if (test->barnum >= 0 && test->barnum <= 5) { From patchwork Thu May 23 21:18:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Mikhak X-Patchwork-Id: 10958815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C693D924 for ; Thu, 23 May 2019 21:19:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3B9628747 for ; Thu, 23 May 2019 21:19:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7F1428750; Thu, 23 May 2019 21:19:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 625A928747 for ; Thu, 23 May 2019 21:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qCN12y8NQcAcN0fhU3PeBZdThhdf63cPArIgD8HViqU=; b=tHc/mOYXv+G5B5aV0+JfAB+Rf4 bicE43dqInhxgZ4xYqv3vp4Q3Zk5DBTXQkxR86qkdet7EOLDLS0cRJn8unkUofLuP5w/HTNA0NK1n /HFQ+xxs0CRhLcUp1WBsT8jfoTl3H36mKpaiHUgjKZWUO5TwRvNeRg3FFxTkUBcslSYmhNOLLS+O6 6NyHLueT0Tya4YbsrrNR0AxdLu/KO5nRSmpc3ot6YbzEE5F+ewC5FUo74sO/70NYH47MNxIYLmXaK 3gJEvui0IwXAQPIBecfaj1URc3VnrSkA7DO29IvDhUJs0Q1B64gmU/S2zrCbFNZ4fzXGom+mzhaGO ydDTIp6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTv7Q-0002tJ-8l; Thu, 23 May 2019 21:19:20 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTv7O-0002r5-8d for linux-riscv@lists.infradead.org; Thu, 23 May 2019 21:19:19 +0000 Received: by mail-pf1-x443.google.com with SMTP id y11so3921337pfm.13 for ; Thu, 23 May 2019 14:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3mPZbZy5W6TvTMZ2rRqZtQoG8zcRtTAtXl0w7I9OmsQ=; b=lb3Q3VCg/m5117JLuMa++JSdLvUGL28gMgBpbCyPzainZo4R3yf4FezR3ton+QBWBw qbeUryIWnJ9EGSDWTVYxazT+GKhtA4PQ8IkI88idnCrVl9ABOgf+CprD4PwCxIY/PqkG dGeRnERPTtsc7zs8hF2gN4WFv+YtuuI3kpCPAUMO8JYEfqtKOyf2xL+Aa/kMTW2MqPZJ LDjpO72fc3/0lYdTAynbfbGvjsfyZjkr1iqa5UcQCwQGfe956GQR9J8QTyqisW7eQygv irTUjf7y5dKeCnUj+QeYsppmE/YYlpufepBl+z44jiWSRr5kzZvrIqj+3ONbJggMDFLp KAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3mPZbZy5W6TvTMZ2rRqZtQoG8zcRtTAtXl0w7I9OmsQ=; b=hqthswIioydKo1N7VZC4bbcNiP8TvguHUQ2iZD/bF+HJc83J78x4M4iVecOzP/Vdoi X/egZ1hnIxBFwSUmgYomECZjSWqFnc78CHEjlkwHOBTJbQ9uQFeLxqUYOPVUfGLQ/ZY/ wRZpSW2EfoITK0iI6kREwQ2kWQFjT5qc1R66eg8jr9OhzT4q0D3aYlUeVXnGwXxdHyCO xucT47wu/T78ZblSvD0Y8aG4Yf1upzPRtCx1Mh1IKHy1U31o7aZLwZNhPLlxxjjNSpNC ki4rkoZPZseo2pTtLGjK5Y7QBxyZ4MrQjIQoNu5B8l49QqcDCszD862HyxUmOG253q66 D5aQ== X-Gm-Message-State: APjAAAWWJ6H5JKUf7bbekQ6CbJdZeCo0He3yYYfB8FUOzKljWZX+5Jdk GqLwbwe76GepU6Aj/5IjHKsu8w== X-Google-Smtp-Source: APXvYqxQNjLfbHXgT+sdqJIbUkJkB8mHB9tn8FD82DR8EhIiruAY6NJjRaQU9tkKBoJLN+Z8vmgFzw== X-Received: by 2002:a63:c64a:: with SMTP id x10mr99748450pgg.195.1558646357415; Thu, 23 May 2019 14:19:17 -0700 (PDT) Received: from nuc7.sifive.com ([12.206.222.2]) by smtp.gmail.com with ESMTPSA id t5sm234092pgn.80.2019.05.23.14.19.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 May 2019 14:19:16 -0700 (PDT) From: Alan Mikhak X-Google-Original-From: Alan Mikhak < alan.mikhak@sifive.com > To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, lorenzo.pieralisi@arm.com, linux-riscv@lists.infradead.org, palmer@sifive.com, paul.walmsley@sifive.com Subject: [PATCH v2 2/2] tools: PCI: Fix compiler warning in pcitest Date: Thu, 23 May 2019 14:18:01 -0700 Message-Id: <1558646281-12676-3-git-send-email-alan.mikhak@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1558646281-12676-1-git-send-email-alan.mikhak@sifive.com> References: <1558646281-12676-1-git-send-email-alan.mikhak@sifive.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_141918_302564_BBF28892 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Mikhak MIME-Version: 1.0 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+patchwork-linux-riscv=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the following compiler warning in pcitest: pcitest.c: In function main: pcitest.c:214:4: warning: too many arguments for format [-Wformat-extra-args] "usage: %s [options]\n" Signed-off-by: Alan Mikhak Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()") Reviewed-by: Paul Walmsley --- tools/pci/pcitest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index 6dce894667f6..6f1303104d84 100644 --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -223,7 +223,7 @@ int main(int argc, char **argv) "\t-r Read buffer test\n" "\t-w Write buffer test\n" "\t-c Copy buffer test\n" - "\t-s Size of buffer {default: 100KB}\n", + "\t-s Size of buffer {default: 100KB}\n" "\t-h Print this help message\n", argv[0]); return -EINVAL;