From patchwork Tue May 28 04:32:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 10963697 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FA4B112C for ; Tue, 28 May 2019 04:32:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6BB56286D1 for ; Tue, 28 May 2019 04:32:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 59A3E286DB; Tue, 28 May 2019 04:32:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C74B8286D1 for ; Tue, 28 May 2019 04:32:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1F76B0276; Tue, 28 May 2019 00:32:23 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 673366B0278; Tue, 28 May 2019 00:32:23 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 594AC6B027A; Tue, 28 May 2019 00:32:23 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by kanga.kvack.org (Postfix) with ESMTP id 234346B0276 for ; Tue, 28 May 2019 00:32:23 -0400 (EDT) Received: by mail-pl1-f198.google.com with SMTP id q2so5459718plr.19 for ; Mon, 27 May 2019 21:32:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:message-id:mime-version :subject:from:to:cc; bh=nXukZfkXi9PXrxYM6I081R9mWVihxST+vyBNiwxZToQ=; b=SdE5EQOhZYR2RCbf+/CQt+QFqdTMwEr9QIwLgw5G6l532Qrfkqdkp07oGSotsV/pyz jpl/Obxzzduk5Apn8hryswRwWFj6ZEnc0fwyZJVmDLhgvCScNZrDWEmdFKWTqJf9taf3 K67HKxNd3fsyCgTLtB444BdQzW6izysIj0xIGQ0ptfv5sBoMelV8t3aafAh+4r2srics XdjyA3cpRuw3MC8uIKTaREpMemYf1vuSrjP5A6PQY5mBNObx/DEmm16sXLOFgej5p71P 26d/XpFFPpa/HqVAIjW4qK1GZGChGs5R58JOGjS0dUNelmYnbxNMjtCNrdvMyKDOJybE 3rOQ== X-Gm-Message-State: APjAAAU7Tu0Sn/+ppR8s+coKaknHYO9CJCUVfh+Kk8krI4t0zkYW8n4U KhpgxM39kw2NvUq01pQ9ssp6IOME8aGBqp6lVxKwMPE7oHoTFnWROleQJffSC0O9Qor3OUXc096 BTrRZVmH6Lj9AAVmmR8x8ysXE/xlp2NZcLczwJqifhHHSkD+z/5eDPD7ZqJgKFQ3uDA== X-Received: by 2002:a63:225b:: with SMTP id t27mr44597592pgm.25.1559017942594; Mon, 27 May 2019 21:32:22 -0700 (PDT) X-Received: by 2002:a63:225b:: with SMTP id t27mr44597528pgm.25.1559017941706; Mon, 27 May 2019 21:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559017941; cv=none; d=google.com; s=arc-20160816; b=oeDp7jvZs+RMNuMMBYXeCONcI7g3tLfY0YOpeerKce940J6j04yTrbeNODJNCpLCPb BXExMMPF0GiQx+DuGyYjJjjBvhuHbNvPbd+702NyPnExaMc8pxdCe+773OOqe05Ozr/T CALdJdqKmFKhJwgzCcDPI2HWK3GxhYU6UlDf0ek5Cic41UNX8erQ8g5DOeEaVpzLrxKJ 6gnWWblEJswFaPycFSa14G0u4IqDMcj1XKkg1ZXGvgg+U0gZhVdWrYsRLBzozNEhi+3H aQfuHWS3XeurNxliQgtiUrUzxgIOE/3DZry8SR7Qev3Z1PicJHsTSPIry/WvH2G4zzuv EKoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:mime-version:message-id:date:dkim-signature; bh=nXukZfkXi9PXrxYM6I081R9mWVihxST+vyBNiwxZToQ=; b=VY/bQtAIy2PCJBIXwYMlYy3m3dqIGTFzJZXBr9TJNlT/7D9CIeC2rjpOq38nG4RngP C/RYfGMLArDXKEYV2z6rUccPEYiRhCw1X9Cqc70d1JzwZ2qLpGFWS2XhLw+MkbTtJ1e7 Izlf2Q3dYEkpKVP0XVvlnRtDz6lZMJVZ0B0PMgB6sD7Vy7bVMY3PiGrl+lsEE1wWlFTX rKnndsnVSCAujXri3GCyxQhZXPfXoGQBuEjWE38uGPFtcxvyTS/G04tUYm7E3MWxI+n5 M3TAnGdL1CkJyEHD0Rxro5WcN2tU39x1kYoIJFRr/Ofg8yrtFwhN9/v/kVpbysgFaTIb mgaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ZB9Q1Edh; spf=pass (google.com: domain of 31bnsxagkcogcrkuoovlqyyqvo.mywvsxeh-wwufkmu.ybq@flex--shakeelb.bounces.google.com designates 209.85.220.73 as permitted sender) smtp.mailfrom=31bnsXAgKCOgcRKUOOVLQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--shakeelb.bounces.google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f73.google.com (mail-sor-f73.google.com. [209.85.220.73]) by mx.google.com with SMTPS id g82sor13174403pfb.72.2019.05.27.21.32.21 for (Google Transport Security); Mon, 27 May 2019 21:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of 31bnsxagkcogcrkuoovlqyyqvo.mywvsxeh-wwufkmu.ybq@flex--shakeelb.bounces.google.com designates 209.85.220.73 as permitted sender) client-ip=209.85.220.73; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ZB9Q1Edh; spf=pass (google.com: domain of 31bnsxagkcogcrkuoovlqyyqvo.mywvsxeh-wwufkmu.ybq@flex--shakeelb.bounces.google.com designates 209.85.220.73 as permitted sender) smtp.mailfrom=31bnsXAgKCOgcRKUOOVLQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--shakeelb.bounces.google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=nXukZfkXi9PXrxYM6I081R9mWVihxST+vyBNiwxZToQ=; b=ZB9Q1EdhMbEMQMnaSmiQmhcsggplsSuthfrmrh5/e+JmMNjK+bTPrTzFtkblNgXZrm +aetRiOi5x1cc672Y08peUe+WtFYVgK513wOOnf/GDhCbDJdefw4XfhBVhSluTsoHxMS SPadlG5cjYjC4ITdPgYlc2VezNl2qGvtrfqo6RLUzecc/kqjl3l22dRhgRvUwm5+IRp2 Wz25pboSmrUWlg7cqJByWYBKVsRqGzPeyRkiH/ODnyD08hvpjxfRrGD3o5kjkNw7RiyC dLPFibVUvUl4FGZZnP8/PJfrBH2WNN6wKD7B4+ybi0zZm7sn+WztwnnLVQNhqhNnDuD5 S3Jw== X-Google-Smtp-Source: APXvYqwytf1qBZjKBb8f7c+lPPFyGQLNV0DxPBbuMzMX1/pVMWPQZKlYgkW4p2DbQRkVymjU5c+QYeOmhFLFiA== X-Received: by 2002:a65:5248:: with SMTP id q8mr6095475pgp.92.1559017941057; Mon, 27 May 2019 21:32:21 -0700 (PDT) Date: Mon, 27 May 2019 21:32:02 -0700 Message-Id: <20190528043202.99980-1-shakeelb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.22.0.rc1.257.g3120a18244-goog Subject: [PATCH] list_lru: fix memory leak in __memcg_init_list_lru_node From: Shakeel Butt To: Kirill Tkhai , Vladimir Davydov , Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt , syzbot+f90a420dfe2b1b03cb2c@syzkaller.appspotmail.com X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Syzbot reported following memory leak: ffffffffda RBX: 0000000000000003 RCX: 0000000000441f79 BUG: memory leak unreferenced object 0xffff888114f26040 (size 32): comm "syz-executor626", pid 7056, jiffies 4294948701 (age 39.410s) hex dump (first 32 bytes): 40 60 f2 14 81 88 ff ff 40 60 f2 14 81 88 ff ff @`......@`...... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000018f36b56>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<0000000018f36b56>] slab_post_alloc_hook mm/slab.h:439 [inline] [<0000000018f36b56>] slab_alloc mm/slab.c:3326 [inline] [<0000000018f36b56>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<0000000055b9a1a5>] kmalloc include/linux/slab.h:547 [inline] [<0000000055b9a1a5>] __memcg_init_list_lru_node+0x58/0xf0 mm/list_lru.c:352 [<000000001356631d>] memcg_init_list_lru_node mm/list_lru.c:375 [inline] [<000000001356631d>] memcg_init_list_lru mm/list_lru.c:459 [inline] [<000000001356631d>] __list_lru_init+0x193/0x2a0 mm/list_lru.c:626 [<00000000ce062da3>] alloc_super+0x2e0/0x310 fs/super.c:269 [<000000009023adcf>] sget_userns+0x94/0x2a0 fs/super.c:609 [<0000000052182cd8>] sget+0x8d/0xb0 fs/super.c:660 [<0000000006c24238>] mount_nodev+0x31/0xb0 fs/super.c:1387 [<0000000006016a76>] fuse_mount+0x2d/0x40 fs/fuse/inode.c:1236 [<000000009a61ec1d>] legacy_get_tree+0x27/0x80 fs/fs_context.c:661 [<0000000096cd9ef8>] vfs_get_tree+0x2e/0x120 fs/super.c:1476 [<000000005b8f472d>] do_new_mount fs/namespace.c:2790 [inline] [<000000005b8f472d>] do_mount+0x932/0xc50 fs/namespace.c:3110 [<00000000afb009b4>] ksys_mount+0xab/0x120 fs/namespace.c:3319 [<0000000018f8c8ee>] __do_sys_mount fs/namespace.c:3333 [inline] [<0000000018f8c8ee>] __se_sys_mount fs/namespace.c:3330 [inline] [<0000000018f8c8ee>] __x64_sys_mount+0x26/0x30 fs/namespace.c:3330 [<00000000f42066da>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<0000000043d74ca0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 This is a simple off by one bug on the error path. Reported-by: syzbot+f90a420dfe2b1b03cb2c@syzkaller.appspotmail.com Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Reviewed-by: Kirill Tkhai --- mm/list_lru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 0bdf3152735e..92870be4a322 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -358,7 +358,7 @@ static int __memcg_init_list_lru_node(struct list_lru_memcg *memcg_lrus, } return 0; fail: - __memcg_destroy_list_lru_node(memcg_lrus, begin, i - 1); + __memcg_destroy_list_lru_node(memcg_lrus, begin, i); return -ENOMEM; }