From patchwork Tue May 28 21:52:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pradeep Kumar Chitrapu X-Patchwork-Id: 10965859 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D41992A for ; Tue, 28 May 2019 21:53:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1999328893 for ; Tue, 28 May 2019 21:53:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DD9828897; Tue, 28 May 2019 21:53:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DC8E928894 for ; Tue, 28 May 2019 21:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=T66xBW2WAwWDtVfFow63MrkPyeLTlz+1GjKKljn0F+Y=; b=HejE4GToAMiM9LDz9H/cdGh0NO sjoXCfCTf8rJes+qfODx+IdW+DcihAl/fZcfP3FLyXKDMLydNKAjWkZbE1Q45vW4M8NRCr0Z7N67P eGyFvE5UXCOuj2wVGZyg3dYixo6KR7rtImN7ju5ycamAW1vjxWUCKEQkZoon5eg1PXDxHY4UfMsyO hwGE+14IhlThf+RVspirGaz9dQVGwNH7cwoinzmsLsJ3hHGfKvKV4UaEjeTmflHDJNWr05sAcRUam zT8JJM0rYP1K1re7h89ihjh7tDfrtcyxD6jXI19x031u8iiD0Zo9tW9UYPdV4VpSG0PVifxHysx31 jOsGno2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1u-0003zT-2v; Tue, 28 May 2019 21:53:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1p-0003vg-2X for ath11k@lists.infradead.org; Tue, 28 May 2019 21:53:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9EBA360C72; Tue, 28 May 2019 21:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080382; bh=AAK1eZ5oGMsHSnL+TPdlsM8DID6qRKbgeVlDAuE7uKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MomgjoouZ5IPWCNOXRsNT2Ex1q7+umxP6IPAKvXqLcwsUgK+1vxU14VB7h56gfEKI 1l0QaJ4/xUSKriRY86ukYYNWFv3aM0XCsSP+x+6uRtuvbOL4BKlFGmW8SWL4846Hjo Z5pp6zXvCUTpAabzFLqMAkY7iezU1vf0JRKwUyqY= Received: from pradeepc2-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pradeepc@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2343160A63; Tue, 28 May 2019 21:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080382; bh=AAK1eZ5oGMsHSnL+TPdlsM8DID6qRKbgeVlDAuE7uKI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MomgjoouZ5IPWCNOXRsNT2Ex1q7+umxP6IPAKvXqLcwsUgK+1vxU14VB7h56gfEKI 1l0QaJ4/xUSKriRY86ukYYNWFv3aM0XCsSP+x+6uRtuvbOL4BKlFGmW8SWL4846Hjo Z5pp6zXvCUTpAabzFLqMAkY7iezU1vf0JRKwUyqY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2343160A63 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=pradeepc@codeaurora.org From: Pradeep Kumar Chitrapu To: ath11k@lists.infradead.org Subject: [PATCH 1/4] ath11k: reset qos control bit after stripping qos field in iee80211_hdr Date: Tue, 28 May 2019 14:52:53 -0700 Message-Id: <1559080376-26817-2-git-send-email-pradeepc@codeaurora.org> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> References: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_145305_131607_65769493 X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pradeep Kumar Chitrapu MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP fix resetting qos control bit in frame control when qos control field is stripped from native wifi packet. Signed-off-by: Pradeep Kumar Chitrapu --- drivers/net/wireless/ath/ath11k/dp_tx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index 55a19a05558f..2a15ca33d83c 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -32,6 +32,7 @@ static void ath11k_dp_encap_nwifi(struct sk_buff *skb) skb->data, (void *)qos_ctl - (void *)skb->data); skb_pull(skb, IEEE80211_QOS_CTL_LEN); + hdr = (void *)skb->data; hdr->frame_control &= ~__cpu_to_le16(IEEE80211_STYPE_QOS_DATA); } From patchwork Tue May 28 21:52:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pradeep Kumar Chitrapu X-Patchwork-Id: 10965853 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 17071933 for ; Tue, 28 May 2019 21:53:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 08D6928893 for ; Tue, 28 May 2019 21:53:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F14EF28897; Tue, 28 May 2019 21:53:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA79528894 for ; Tue, 28 May 2019 21:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ua6UoU8MRDA4InTTmdOwrqkvNB3mBr8X2c/Ahlb9BXU=; b=CDRSRrqf3XcF+80PgvwHneW59B EjYinbjP4VK/B5bGWB53PeBCwgTmNpxIZ83uc81kB4eyP5Xh944HM5G2QBkBjMybqF+0Jb5uex81s 2Gh9F/NH1Yfkx/3PWSo3dU5FMnnyz7dwVHuLbjXYRkWsVerOwLY08z7cUpNkFnW7r9T8vkbCZIWKv dQINGKCtBmD0bPPMcjxA64qplsUYz0TLlgHfu8dbPEOFAH+pmjkoxbjWXhMMqx5MU/Z/eTe51BLxn FN0vK7ccAmNp6Fy1Ynk12V/RbOxVaJzlhk2Ba6IC3Z9EpwgG+p0/BJiMc45oM4qLTTRZqxybJSJNh bgEcOq3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1r-0003y8-Nt; Tue, 28 May 2019 21:53:07 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1o-0003vj-Tw for ath11k@lists.infradead.org; Tue, 28 May 2019 21:53:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1179C60A63; Tue, 28 May 2019 21:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080383; bh=2LFPksrtfXZJ9bZeb5Yg1VOlPOzcr/+MiMR1vNe/RCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FfhE6RYLfDeqDs2NTgSHp4VWH0JBeoXka8CtOe61ODwegQ20ZJQopDVegP6HcxZxO isx8eKJ8FQUGVhkKt9CpB6TT3r3A8+A2D3GkyR0FEHnmZy3QMTdexeSI/boGcT2flK xE1shkOpSd2I29V1CtrAycsFC1rL9KJWgqtShGOQ= Received: from pradeepc2-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pradeepc@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 845B660734; Tue, 28 May 2019 21:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080382; bh=2LFPksrtfXZJ9bZeb5Yg1VOlPOzcr/+MiMR1vNe/RCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SFsE0/FntQxhv44Vh6oHpxZqHn2w/61DL09sj8MLaPGkp+9BjRRdxUgbz1wRNZ51c tBftLjpsK+rS/kG4shatTQz8qA9AHBvSdXE/PWmquEa9bnPXu1lLSU4LQjSNXXDjl+ 2p6mhaA/3bXOWjxxpS3LLwExnXFgQMmN9iBhN/fE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 845B660734 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=pradeepc@codeaurora.org From: Pradeep Kumar Chitrapu To: ath11k@lists.infradead.org Subject: [PATCH 2/4] ath11k: pad mic len for protected action frames Date: Tue, 28 May 2019 14:52:54 -0700 Message-Id: <1559080376-26817-3-git-send-email-pradeepc@codeaurora.org> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> References: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_145304_979715_6BA18C2B X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pradeep Kumar Chitrapu MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP padding mic space is necessary for firmware to generate mic len correctly and to not run into any memory issues. Signed-off-by: Pradeep Kumar Chitrapu --- drivers/net/wireless/ath/ath11k/mac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index cb0de8e2aa60..c78c1481fe7f 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3179,6 +3179,7 @@ static int ath11k_mac_mgmt_tx_wmi(struct ath11k *ar, struct ath11k_vif *arvif, struct sk_buff *skb) { struct ath11k_base *ab = ar->ab; + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; dma_addr_t paddr; int buf_id; int ret; @@ -3190,6 +3191,13 @@ static int ath11k_mac_mgmt_tx_wmi(struct ath11k *ar, struct ath11k_vif *arvif, if (buf_id < 0) return -ENOSPC; + if ((ieee80211_is_action(hdr->frame_control) || + ieee80211_is_deauth(hdr->frame_control) || + ieee80211_is_disassoc(hdr->frame_control)) && + ieee80211_has_protected(hdr->frame_control)) { + skb_put(skb, IEEE80211_CCMP_MIC_LEN); + } + paddr = dma_map_single(ab->dev, skb->data, skb->len, DMA_TO_DEVICE); if (dma_mapping_error(ab->dev, paddr)) { ath11k_warn(ab, "failed to DMA map mgmt Tx buffer\n"); From patchwork Tue May 28 21:52:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pradeep Kumar Chitrapu X-Patchwork-Id: 10965855 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D66A292A for ; Tue, 28 May 2019 21:53:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C701D28893 for ; Tue, 28 May 2019 21:53:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB6A9288A6; Tue, 28 May 2019 21:53:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BCC5528893 for ; Tue, 28 May 2019 21:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4JnB+vB5VEe/Sd/Cl7+N7My5t6/sw02OTZkv7HoqFcM=; b=D/147ZWSPJ8IYMwH6+HIUsLQ6g w1rrWDAdZaMkvmDWxBPUESxm9L5aIDgEn488xO5JMkjhdaOa+wsZPf0qyeAXRcYVPyuAKaoxYKEK/ SvoYVPIXs4wqIdEG2SaocfDTmXzm/DurIj22Ya4Uu5KCQNXlRxTQR2Oy8iSgvxmo6DKk2pqEeMs0x AdGCRGFP/EuduplxuBL9PjTHXE7Ik2Q0rMYf8qY8NSamRDZyBPWFP6zjnZQ/VxkkcPTJMDzBHQPcg OVHW9Ms/AT6bK1RPmHq3HrETsT7aFOMIA90t+IwjvTOJgY8pl3OtEf1tNgIgto3z5sRq1+k6HYXd0 ttjDJI2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1t-0003zM-Tv; Tue, 28 May 2019 21:53:09 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1p-0003vx-20 for ath11k@lists.infradead.org; Tue, 28 May 2019 21:53:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6607060DAA; Tue, 28 May 2019 21:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080383; bh=NHkClgk+KomvfIYgFMsoAtaebiQ/tVqhTQIy/+22ebc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncg3xikdebsIk3ceJmujLah7/qkll58RbAOlsR4uNNUhM0lUo1t/h8cWfBGCPWzKL oCoOR0qfo0+AyrS4f5G4ljPFqOajPi17kaFJ8BhTN9imFmx1NcS1/3pZe10tw2T6C8 x7jmErVNDdYLv0svtpIhmACXpVx8CmBN2PK+prCI= Received: from pradeepc2-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pradeepc@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DB7E160AA3; Tue, 28 May 2019 21:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080383; bh=NHkClgk+KomvfIYgFMsoAtaebiQ/tVqhTQIy/+22ebc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncg3xikdebsIk3ceJmujLah7/qkll58RbAOlsR4uNNUhM0lUo1t/h8cWfBGCPWzKL oCoOR0qfo0+AyrS4f5G4ljPFqOajPi17kaFJ8BhTN9imFmx1NcS1/3pZe10tw2T6C8 x7jmErVNDdYLv0svtpIhmACXpVx8CmBN2PK+prCI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DB7E160AA3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=pradeepc@codeaurora.org From: Pradeep Kumar Chitrapu To: ath11k@lists.infradead.org Subject: [PATCH 3/4] ath11k: fix multicast txrx for secure 11s mesh support Date: Tue, 28 May 2019 14:52:55 -0700 Message-Id: <1559080376-26817-4-git-send-email-pradeepc@codeaurora.org> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> References: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_145305_113245_4CEAEBA6 X-CRM114-Status: UNSURE ( 9.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pradeep Kumar Chitrapu MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP setting MESH_MCAST_ENABLE wmi param is necessary for txrx of multicast action frames in 11s mesh. Signed-off-by: Pradeep Kumar Chitrapu --- drivers/net/wireless/ath/ath11k/mac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index c78c1481fe7f..9730c077149a 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3373,6 +3373,14 @@ static int ath11k_start(struct ieee80211_hw *hw) goto err; } + ret = ath11k_wmi_pdev_set_param(ar, WMI_PDEV_PARAM_MESH_MCAST_ENABLE, + 1, pdev->pdev_id); + + if (ret) { + ath11k_err(ar->ab, "failed to enable MESH MCAST ENABLE: (%d\n", ret); + goto err; + } + __ath11k_set_antenna(ar, ar->cfg_tx_chainmask, ar->cfg_rx_chainmask); /* TODO: Do we need to enable ANI? */ From patchwork Tue May 28 21:52:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pradeep Kumar Chitrapu X-Patchwork-Id: 10965857 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C2511575 for ; Tue, 28 May 2019 21:53:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BA5628893 for ; Tue, 28 May 2019 21:53:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1003528898; Tue, 28 May 2019 21:53:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 404E628897 for ; Tue, 28 May 2019 21:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wOXRaRlP9VgRFNtxIiWr6dhXkAPZAmE6jLTv/9+qgeQ=; b=rvBLzokNUJl3nmZHm8pbJ+IMVl KAxgZzpK52xccrDDRqJruiybm+XBkEP3XP/cMC+bSDG2NQeUiQz46znTiiuYbkIzpEjVzzJSstA7A YYDO5nlsAwxRldxiNV2PTwo87E+ZGn0GL6BZZfEvgwUlJ4ZU3WFYG2TuXo/evPnN1su/9j+Eqmy0+ jTK+YqU9GZmWX7wcy6iFmuacamu0Oz5tc1vcYgN4n2daIIPd+NCiF+wu2n+F8042jYZicYl9dMYzr 2pgYdHC6iJH5igIArbQo1gBAqozOlWndgY2jqlfYSfBbLCvOX1yurrg6dlJJIIjkLLiiqnztDRJep +vIrq6RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1u-0003zi-8j; Tue, 28 May 2019 21:53:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVk1o-0003vz-Sj for ath11k@lists.infradead.org; Tue, 28 May 2019 21:53:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B7B5C60E5A; Tue, 28 May 2019 21:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080383; bh=/uh7l+rsmoE9PoTYvCwIsUGWRTW25hzlOWnxqjgiaDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+EZZ+9mFNYpAIURBSAO5g7+4YHd2PiZ15P+VzTZftowQMP+HWNNkAcYAauTbn/8l 20cu0QthZnQancal/gCPewCAR02MdUG74TfXYmfxjedvw423hBJ49kjs4uLspmjGR3 z9oMdF7FGdhPSJAMxJHHshUbIrSLNIqX8UOUX+4w= Received: from pradeepc2-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pradeepc@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3E99660734; Tue, 28 May 2019 21:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559080383; bh=/uh7l+rsmoE9PoTYvCwIsUGWRTW25hzlOWnxqjgiaDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+EZZ+9mFNYpAIURBSAO5g7+4YHd2PiZ15P+VzTZftowQMP+HWNNkAcYAauTbn/8l 20cu0QthZnQancal/gCPewCAR02MdUG74TfXYmfxjedvw423hBJ49kjs4uLspmjGR3 z9oMdF7FGdhPSJAMxJHHshUbIrSLNIqX8UOUX+4w= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3E99660734 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=pradeepc@codeaurora.org From: Pradeep Kumar Chitrapu To: ath11k@lists.infradead.org Subject: [PATCH 4/4] ath11k: fix action frame rx processing Date: Tue, 28 May 2019 14:52:56 -0700 Message-Id: <1559080376-26817-5-git-send-email-pradeepc@codeaurora.org> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> References: <1559080376-26817-1-git-send-email-pradeepc@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_145304_958503_CBA2019D X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pradeep Kumar Chitrapu MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Firmware/HW delivers broadcast/multicast management frames as encrypted and it should be decrypted by mac80211. Setting RX_FLAG_DECRYPTED status for these frames is breaking mesh connection establishment. For unicast protected action frames, HW decrypts the packet, however, IV and MIC are not stripped in HW and same must be done by mac80211. so fix that. Signed-off-by: Pradeep Kumar Chitrapu --- drivers/net/wireless/ath/ath11k/wmi.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index 9ca44c4b24f8..07a6fd4d2f8c 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -4905,16 +4905,19 @@ static void ath11k_mgmt_rx_event(struct ath11k_base *ab, struct sk_buff *skb) status->flag |= RX_FLAG_SKIP_MONITOR; /* In case of PMF, FW delivers decrypted frames with Protected Bit set. - * Don't clear that. FW also delivers broadcast management frames + * Don't clear that. Also, FW delivers broadcast management frames * (ex: group privacy action frames in mesh) as encrypted payload. */ - if (!ieee80211_is_robust_mgmt_frame(skb)) { + if (ieee80211_has_protected(hdr->frame_control) && + !is_multicast_ether_addr(ieee80211_get_DA(hdr))) { status->flag |= RX_FLAG_DECRYPTED; - status->flag |= RX_FLAG_IV_STRIPPED | - RX_FLAG_MMIC_STRIPPED; - hdr->frame_control = __cpu_to_le16(fc & - ~IEEE80211_FCTL_PROTECTED); + if (!ieee80211_is_robust_mgmt_frame(skb)) { + status->flag |= RX_FLAG_IV_STRIPPED | + RX_FLAG_MMIC_STRIPPED; + hdr->frame_control = __cpu_to_le16(fc & + ~IEEE80211_FCTL_PROTECTED); + } } /* TODO: Pending handle beacon implementation