From patchwork Mon Jun 3 17:11:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 10973541 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 682E5912 for ; Mon, 3 Jun 2019 17:11:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4788726222 for ; Mon, 3 Jun 2019 17:11:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B14427FB1; Mon, 3 Jun 2019 17:11:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA0862873C for ; Mon, 3 Jun 2019 17:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B90CB6B028E; Mon, 3 Jun 2019 13:11:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B1A286B0290; Mon, 3 Jun 2019 13:11:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BAC46B0291; Mon, 3 Jun 2019 13:11:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 491E96B028E for ; Mon, 3 Jun 2019 13:11:31 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id r16so8802944wrj.13 for ; Mon, 03 Jun 2019 10:11:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=HfMZm97BBBVN/Akj4ZX56akpwbWPXy5xSk8GJLfRVB4=; b=JgjcsHCcRM4p13QtON//p5sURZ+6xcUl7hzWKmE7pD9DlqHtlHgwp4PDdxpkd8iSsw Oquq+v2T1DmCKPsshMiB6mnrulWuLJ6YpefVhmne9xKlSr1LPOo70vmcT7X/xi68I3yw 4MoYsaXjnlQ11fvm/reT+/P5GfiTthlDigI83Ob6rDoZkrDLV1b5+47LrR8CwvINk9F/ PfTX9in28Khiz1P4jAZv3eKC7E7Kxl8B9cZ2eHYYVlSaoHP+YufuEbOGLbicmnVx6AH5 7eJ4j+R84ZrscTcHzext+sLOvSotMklwVCY2ViMno/VFGliYvwRfUwbqbvZHSZ7MTo/t e9NQ== X-Gm-Message-State: APjAAAX2q7Q0W3m27g4TVHBqVDHzn8fbu1hT5GixX71XtoT0E19Qy/1j ipB586NMkIh0J3xNs0RtjxRQB0WQeWFE5O/L817oSarwvK2OzRgh59ArKlO0oVEnTu+ayFSmYid FHsmY7xcY4PGLVjx1Dfpe1UsiiSyF2EQOd9rdsRd7Vu+GYZco/7DFeGPpe8NudR9+Og== X-Received: by 2002:a7b:cb4b:: with SMTP id v11mr14393871wmj.85.1559581890772; Mon, 03 Jun 2019 10:11:30 -0700 (PDT) X-Received: by 2002:a7b:cb4b:: with SMTP id v11mr14393800wmj.85.1559581889058; Mon, 03 Jun 2019 10:11:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559581889; cv=none; d=google.com; s=arc-20160816; b=oaYFeH+H2iiBboFjrhG0fXdN+zj+1yVxiT7Y09lnd3FFKna3aIYfRgugcIB2H2WN4W 3BOM7oxBaKeGGIjmqLiyzSDDSUsJAwh02gFUXRpAJdYAzh+/B3KXKIj7Vy/KOk0KX6e3 GdkRf+Z8lY+RPS52iF+1w1PHPaSPCeTUG/HEN1aRPcU5yCnZvnf2b0piO1ht4yEmppXY dG84N963ltzok+GvsUYH2FL7YQ1i1CUsLRrVhnElywgRZHcXrCqdQKK0T0OlTlxk888H VeE9S4R+X6XWPtQmU1tp2ET0JlbhmQxJ+qFge3Y5QJJAdilBKVKin62LVXLfGikuUZ81 1QMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:from:to:subject:content-transfer-encoding:mime-version:date :message-id:dkim-signature; bh=HfMZm97BBBVN/Akj4ZX56akpwbWPXy5xSk8GJLfRVB4=; b=R1jR/MDVDQa940kCNJm448yMalb2HX0B1epJlbaZANSZ5pCpgJdu+OvWI5Pyf7YUcJ oaEatF2Q2mM2spDImmiP+z28yzMkC9ZxXD8qHbo2tBsPqap3Dd6ri/IM6H4vTP1vS2Kt 2zWuMCu47VT0y3u4VxyGW0NJWRW9thjtpNa5nxOvyXQbjdRdsQOjI1gyBZpDrt76nAo3 CUO/hgzuWFbEPh6HwBLGOwiDHBkjzM4y7EwOOhs8O0Oys0O50+P/KIHXc9MrQUzSgbq4 4H7NJVm/9+WZRBg4SiKDplJ7xpyv/UAlJ+KEre+EmYPnffZXH0ham+Y3jKakyRj/Ml4K I33w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=ZcmEs7c6; spf=pass (google.com: domain of bot@kernelci.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=bot@kernelci.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id a15sor1645827wmd.11.2019.06.03.10.11.28 for (Google Transport Security); Mon, 03 Jun 2019 10:11:29 -0700 (PDT) Received-SPF: pass (google.com: domain of bot@kernelci.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=ZcmEs7c6; spf=pass (google.com: domain of bot@kernelci.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=bot@kernelci.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=HfMZm97BBBVN/Akj4ZX56akpwbWPXy5xSk8GJLfRVB4=; b=ZcmEs7c6fnfgurJJhQ8swRowMqvfM1d1aToAi1IBQX8PjP+72694Kz5ydGcmeZMrHK vhqBAHnY2+CqzdIxhswFfXzAR7dmqNrph4VMCPGVPQwuMyEaYkjjzCcCKbhyCCcN6DMQ 61vvbQg4sbI839hKiJM+jhj9NIXtdqXLRf9RIQv2JBFOR0Iv27Fv3bibpyRJUENHn3YD Z481Tx+4uZ8dpFFJntARJCnzBPwt4uZMfGmjotcVwmHBM/oyMMi/Rbbe0gbgmX3LDUU4 Dx4udN6PEWugFLgz0GsVPzFQXuxZGHXkIxJNSpaQVrcma1SjXSHsBRnU6pAAduGCotv7 I3gw== X-Google-Smtp-Source: APXvYqyeRxdFQwhBL7xhyX75h0tjMNcW0x5MdFT80+6a5BnsE9USodq0FgyWwnPyz+46G0qYXCT2tg== X-Received: by 2002:a1c:f416:: with SMTP id z22mr14196739wma.44.1559581888645; Mon, 03 Jun 2019 10:11:28 -0700 (PDT) Received: from [148.251.42.114] ([2a01:4f8:201:9271::2]) by smtp.gmail.com with ESMTPSA id f20sm11029386wmh.22.2019.06.03.10.11.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 10:11:27 -0700 (PDT) Message-ID: <5cf554bf.1c69fb81.956a8.9d1b@mx.google.com> Date: Mon, 03 Jun 2019 10:11:27 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Report-Type: bisect X-Kernelci-Kernel: next-20190603 X-Kernelci-Branch: master X-Kernelci-Lab-Name: lab-mhart X-Kernelci-Tree: next Subject: next/master boot bisection: next-20190603 on jetson-tk1 To: Stephen Rothwell , tomeu.vizoso@collabora.com, guillaume.tucker@collabora.com, mgalka@collabora.com, Uladzislau Rezki (Sony) , broonie@kernel.org, matthew.hart@linaro.org, Hillf Danton , khilman@baylibre.com, enric.balletbo@collabora.com, Andrew Morton From: "kernelci.org bot" Cc: "Uladzislau Rezki (Sony)" , Chintan Pandya , Mike Rapoport , Andrey Ryabinin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Roman Penyaev , Rick Edgecombe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master boot bisection: next-20190603 on jetson-tk1 Summary: Start: ae3cad8f39cc Add linux-next specific files for 20190603 Details: https://kernelci.org/boot/id/5cf4e76059b514265fd51501 Plain log: https://storage.kernelci.org//next/master/next-20190603/arm/multi_v7_defconfig+CONFIG_SMP=n/gcc-8/lab-mhart/boot-tegra124-jetson-tk1.txt HTML log: https://storage.kernelci.org//next/master/next-20190603/arm/multi_v7_defconfig+CONFIG_SMP=n/gcc-8/lab-mhart/boot-tegra124-jetson-tk1.html Result: 728e0fbf263e mm/vmalloc.c: get rid of one single unlink_va() when merge Checks: revert: PASS verify: PASS Parameters: Tree: next URL: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: jetson-tk1 CPU arch: arm Lab: lab-mhart Compiler: gcc-8 Config: multi_v7_defconfig+CONFIG_SMP=n Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 728e0fbf263e3ed359c10cb13623390564102881 Author: Uladzislau Rezki (Sony) Date: Sat Jun 1 12:20:19 2019 +1000 mm/vmalloc.c: get rid of one single unlink_va() when merge It does not make sense to try to "unlink" the node that is definitely not linked with a list nor tree. On the first merge step VA just points to the previously disconnected busy area. On the second step, check if the node has been merged and do "unlink" if so, because now it points to an object that must be linked. Link: http://lkml.kernel.org/r/20190527151843.27416-4-urezki@gmail.com Signed-off-by: Uladzislau Rezki (Sony) Acked-by: Hillf Danton Cc: Ingo Molnar Cc: Joel Fernandes Cc: Matthew Wilcox Cc: Michal Hocko Cc: Oleksiy Avramchenko Cc: Roman Gushchin Cc: Steven Rostedt Cc: Tejun Heo Cc: Thomas Garnier Cc: Thomas Gleixner Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a] Linux 5.2-rc3 git bisect good f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a # bad: [ae3cad8f39ccf8d31775d9737488bccf0e44d370] Add linux-next specific files for 20190603 git bisect bad ae3cad8f39ccf8d31775d9737488bccf0e44d370 # good: [8ff6f4c6e067a9d3f3bbacf02c4ea5eb81fe2c6a] Merge remote-tracking branch 'crypto/master' git bisect good 8ff6f4c6e067a9d3f3bbacf02c4ea5eb81fe2c6a # good: [6c93755861ce6a6dd904df9cdae9f08671132dbe] Merge remote-tracking branch 'iommu/next' git bisect good 6c93755861ce6a6dd904df9cdae9f08671132dbe # good: [1a567956cb3be5754d94ce9380a2151e57e204a7] Merge remote-tracking branch 'cgroup/for-next' git bisect good 1a567956cb3be5754d94ce9380a2151e57e204a7 # good: [a6878ca73cf30b83efbdfb1ecc443d7cfb2d8193] Merge remote-tracking branch 'rtc/rtc-next' git bisect good a6878ca73cf30b83efbdfb1ecc443d7cfb2d8193 # bad: [b2b94a9c4f8fc4229cd8b14d8417fc491e5f5d7c] mm, memcg: make memory.emin the baseline for utilisation determination git bisect bad b2b94a9c4f8fc4229cd8b14d8417fc491e5f5d7c # good: [e824d3a072bd3f93a0c7616dee4bdb3410e0a767] memcg, fsnotify: no oom-kill for remote memcg charging git bisect good e824d3a072bd3f93a0c7616dee4bdb3410e0a767 # good: [83f89893bd05fe97b43cbe7f5c2eacbb0fdc966a] drivers/base/memory: pass a block_id to init_memory_block() git bisect good 83f89893bd05fe97b43cbe7f5c2eacbb0fdc966a # bad: [8d388102126d935b8d7294162f6b4ebf6b0494c5] tools/vm/slabinfo: add option to sort by partial slabs git bisect bad 8d388102126d935b8d7294162f6b4ebf6b0494c5 # good: [df18a3805de35506cd05da7aceba3704c8ec6962] mm/vmalloc.c: remove "node" argument git bisect good df18a3805de35506cd05da7aceba3704c8ec6962 # bad: [adc7c46cd31f1a3ca27508cb9435187b3c6539a4] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned git bisect bad adc7c46cd31f1a3ca27508cb9435187b3c6539a4 # bad: [728e0fbf263e3ed359c10cb13623390564102881] mm/vmalloc.c: get rid of one single unlink_va() when merge git bisect bad 728e0fbf263e3ed359c10cb13623390564102881 # good: [1ed20f4bc22412db94535d4df384082c98903da9] mm/vmalloc.c: preload a CPU with one object for split purpose git bisect good 1ed20f4bc22412db94535d4df384082c98903da9 # first bad commit: [728e0fbf263e3ed359c10cb13623390564102881] mm/vmalloc.c: get rid of one single unlink_va() when merge ------------------------------------------------------------------------------- diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 899d73a27d13..6a490c35801a 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -719,8 +719,8 @@ merge_or_add_vmap_area(struct vmap_area *va, /* Check and update the tree if needed. */ augment_tree_propagate_from(sibling); - /* Remove this VA, it has been merged. */ - unlink_va(va, root); + if (merged) + unlink_va(va, root); /* Free vmap_area object. */ kmem_cache_free(vmap_area_cachep, va); @@ -746,9 +746,6 @@ merge_or_add_vmap_area(struct vmap_area *va, /* Check and update the tree if needed. */ augment_tree_propagate_from(sibling); - /* Remove this VA, it has been merged. */ - unlink_va(va, root); - /* Free vmap_area object. */ kmem_cache_free(vmap_area_cachep, va); -------------------------------------------------------------------------------