From patchwork Tue Jun 4 04:23:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 10974169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E39FB912 for ; Tue, 4 Jun 2019 04:23:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEAE02832D for ; Tue, 4 Jun 2019 04:23:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BED4328565; Tue, 4 Jun 2019 04:23:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D81F52832D for ; Tue, 4 Jun 2019 04:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=upuCxpCKiwIJoVQUNpTTrs60V/OCXLRY2L3INolyqi8=; b=X5EEWoj6wdkeFo lKeBESRi0bR5txA6QBlBlQ2t9BehCiI9rW1qtdEFgSPj0nxV0ZA2CJWuQSTQT7jJAv28opFH4gpYf M8Gh4M1JVdxvqTdVkAUiW4R0+EraOqsGwtfG0SVVG9FhbDXKOznNqSFGwGtrL8tUBKLSzJzeiJL6I 91J0+d6Iq4D8dDH0yQbVZs6LDLKPT/yjK6U0e6fjKchOOY1aMQNQBUIkXE/2OG0ISN/roL6/GeONI Nb0/3t9X7Vu00BTksYtzStN3dLm/zQQU9IeJn5mEm8pq7HTBeyMxuGys1gsB/9UhqNVPfEWKNnGhb uVy7/UOnozl8ZlSxiO+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zH-0000hL-8A; Tue, 04 Jun 2019 04:23:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zD-0000g3-Ee for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 04:23:48 +0000 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8955D23D8E; Tue, 4 Jun 2019 04:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559622226; bh=TA3ORGPusOAVXEJ7tR/bGFjdPY1t0Xg2lFwT8zhNkb8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=svMGH/MF4gDI8GSS9P8qsFor88Pdh0Nye0AT1FhYmBF2EmCf9Xj7cc26EojX/NLF6 E+bz9AkmBIczle8sjjt/cgLKKndk3KSwRVTSH1edmYiXENR+QcipT4nQ/9UJmFF3d/ ZforGa8bb/j7LwPHiHr0XblHFo9XOrxFnJg0CpRQ= Received: by wens.tw (Postfix, from userid 1000) id 7371E5F80C; Tue, 4 Jun 2019 12:23:43 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Alessandro Zummo , Alexandre Belloni Subject: [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method Date: Tue, 4 Jun 2019 12:23:35 +0800 Message-Id: <20190604042337.26129-2-wens@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190604042337.26129-1-wens@kernel.org> References: <20190604042337.26129-1-wens@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_212347_515067_A05865EE X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Donnefort , Chen-Yu Tsai , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chen-Yu Tsai The PCF8563 datasheet says the interrupt line is active low and stays active until the events are cleared, i.e. a level trigger interrupt. Fix the flags used to request the interrupt. Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support") Signed-off-by: Chen-Yu Tsai --- Not sure if this would cause issues for other platforms. Ideally we'd take the flags from the device tree, but it seems not all platforms support this. --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 3efc86c25d27..e358313466f1 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client, if (client->irq > 0) { err = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf8563_irq, - IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING, + IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW, pcf8563_driver.driver.name, client); if (err) { dev_err(&client->dev, "unable to request IRQ %d\n", From patchwork Tue Jun 4 04:23:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 10974175 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09D3D912 for ; Tue, 4 Jun 2019 04:24:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB2BE2832D for ; Tue, 4 Jun 2019 04:24:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC2AC28565; Tue, 4 Jun 2019 04:24:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7EDAC2832D for ; Tue, 4 Jun 2019 04:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cG/cr45aMxC/L/RKcWE9tFj2oY5k/hwbYkYM4PWdhlg=; b=ElTrjBCVBEWujd JL4dUiggMkYM2Qf5n+fWF3mooISGGow/BUWK5dBPrzHZquCPJP8DI46Zir2c17NnGjwBUAbKMqYSQ bl3fpGe/CtVkTx06rwb1gVfKek5MBnJNCHfaHEW8ZljAWEMMcyu3MbvK9ztI05n4g+8qgB86ROEnt /QwdsOES6OtZ9KI6mIlu6XUQYB26J/h46SOYJR7lKRQQ3OSUOEgLTaajYaQUsoPGXRm+NRl+QoMVp wrLkydAOJ4yqQ3Mxt9lBaVdeuWUAsk2ZIooa7kEOqLGvB+xp1adhp/UNyJSO+tF3j6G+kV5wWE2cI 9hCu9n/5YMtbGrJpnPtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zh-0001Jx-Ql; Tue, 04 Jun 2019 04:24:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zD-0000g5-Ec for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 04:23:50 +0000 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A779A24B35; Tue, 4 Jun 2019 04:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559622226; bh=yqUxi72cn1v3RF2Lmp76OrRJen60rKvo6j12vc0QZgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qxh797YMgBBIdnhM38VPWd4XptoS7s+5V+9jb9asjHs9ZyRMeayka9YgsZm6kZEl8 1e10CXDcznefASbmL3beJTTe5ezhQ77C+Sf1qqSSIjtCXQvR6Dc+e9J4Hu+o0670WK NYbXWVQWQWBN7pgJ/9+XY7NzP1+7FDDXLEJvGat8= Received: by wens.tw (Postfix, from userid 1000) id 7CE025FD5F; Tue, 4 Jun 2019 12:23:43 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Alessandro Zummo , Alexandre Belloni Subject: [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq Date: Tue, 4 Jun 2019 12:23:36 +0800 Message-Id: <20190604042337.26129-3-wens@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190604042337.26129-1-wens@kernel.org> References: <20190604042337.26129-1-wens@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_212347_515914_E15215B7 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Donnefort , Chen-Yu Tsai , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chen-Yu Tsai Besides the alarm, the PCF8563 also has a timer triggered interrupt. In cases where the previous system left the timer and interrupts on, or somehow the bits got enabled, the interrupt would keep triggering as the kernel doesn't know about it. Clear both the alarm and timer event flags, and disable the interrupts, before requesting the interrupt line. Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support") Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time") Signed-off-by: Chen-Yu Tsai --- drivers/rtc/rtc-pcf8563.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index e358313466f1..d8adf69b6697 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -563,7 +563,6 @@ static int pcf8563_probe(struct i2c_client *client, struct pcf8563 *pcf8563; int err; unsigned char buf; - unsigned char alm_pending; dev_dbg(&client->dev, "%s\n", __func__); @@ -587,13 +586,13 @@ static int pcf8563_probe(struct i2c_client *client, return err; } - err = pcf8563_get_alarm_mode(client, NULL, &alm_pending); - if (err) { - dev_err(&client->dev, "%s: read error\n", __func__); + /* Clear flags and disable interrupts */ + buf = 0; + err = pcf8563_write_block_data(client, PCF8563_REG_ST2, 1, &buf); + if (err < 0) { + dev_err(&client->dev, "%s: write error\n", __func__); return err; } - if (alm_pending) - pcf8563_set_alarm_mode(client, 0); pcf8563->rtc = devm_rtc_device_register(&client->dev, pcf8563_driver.driver.name, From patchwork Tue Jun 4 04:23:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 10974173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D0CE933 for ; Tue, 4 Jun 2019 04:24:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A0472832D for ; Tue, 4 Jun 2019 04:24:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E85C28565; Tue, 4 Jun 2019 04:24:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A4B002832D for ; Tue, 4 Jun 2019 04:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYK6umVtUW9VuWlVVk20MwKE8gZ2i0Ly4sKT96hVmwc=; b=AvZzBVbRyB/g49 1dhfuos79kdkZBKnXZNrPzu9SNPzrd+nJZYoN1gsgoF/EdulEXuiCpD+dpmnQPykabUp+6XCFBlt6 3/Bg6HarvVtsjURAI7TNl0jUTRe+wsdJbQzOH1YsznNGfW6yMX6W3qfnnguQEp4Qb5a2IiHIwkpS7 4qensuNckPlHErKS/XoAdWtWhaxl36uaGUQJQRPCjBTRfmYFtg1RxOyFI0AiwxXW6gyjhASpbnyY4 J7uXyc3sh7gCJHQxlFE+yvZXFo7HrHtaWp7oVsXGeBAKB1Rh2Cm0U6oD9ioWk3LcUJm+soHvdJPf0 WvvTidvOLJYbeUW2h6dQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zW-00013e-FR; Tue, 04 Jun 2019 04:24:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY0zD-0000g4-Eb for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 04:23:49 +0000 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 937A324816; Tue, 4 Jun 2019 04:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559622226; bh=VYtcvA3wowRbQVxy9lVDS7Qdt8923RidXJkN2GiPjNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L2w2CTySlmeFLqYTfQqwzXF+cyaN4lSifCfVRBMfgAOsdzJTwKbRQBYmTRTiEKute BgPzXbzJKmdNg9YxeGopYySVpBQYW36b8jdND1tLPSL3PGOdlq+5SxNOfvGE69PMaq jxSicoEVAYvfLxbKNcYhxxklPU5DoZyUDCI5SbTI= Received: by wens.tw (Postfix, from userid 1000) id 8698D5FD46; Tue, 4 Jun 2019 12:23:43 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Alessandro Zummo , Alexandre Belloni Subject: [PATCH 3/3] arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC Date: Tue, 4 Jun 2019 12:23:37 +0800 Message-Id: <20190604042337.26129-4-wens@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190604042337.26129-1-wens@kernel.org> References: <20190604042337.26129-1-wens@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_212347_515067_97811F7F X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Donnefort , Chen-Yu Tsai , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chen-Yu Tsai The external PCF8563 RTC chip's interrupt line is connected to the NMI line on the SoC. Add the interrupt line to the device tree. Fixes: 17ebc33afc35 ("arm64: allwinner: h6: add PCF8563 RTC on Pine H64 board") Signed-off-by: Chen-Yu Tsai --- arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts index 9e464d40cbff..189834518391 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts @@ -249,6 +249,8 @@ pcf8563: rtc@51 { compatible = "nxp,pcf8563"; reg = <0x51>; + interrupt-parent = <&r_intc>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; #clock-cells = <0>; }; };