From patchwork Tue Jun 4 22:31:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10976201 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9502D1515 for ; Tue, 4 Jun 2019 22:32:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 836F128825 for ; Tue, 4 Jun 2019 22:32:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 748A228834; Tue, 4 Jun 2019 22:32:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1641928825 for ; Tue, 4 Jun 2019 22:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=c/4MmiyvtdCQuVDdp2wz9189fU6QvXy5LMnJvs4fVh0=; b=Hey4awDv/NIwQH bQZtvyxUkbv8DJbpdBecOUCgmBrD2XwVIQjwLeGMZhjx46yURk34IPz1tEc79zQnlcPM8rUFlKWKg y5a8UQyqTJmbkvtx12Qa+tIJ1gg01MJDHmXgsHNgb/FcNgbKxDmj8Q0O6P3K5fhphFgDGaNQy2WKM MJzJ6ZKBVxTNrSeSIjuWXSyNkQaMMPF9xD+6r57QsfmhBIrcuTzQ0GmPFyH0q0zOSjqndrIZ9RaGQ NZt16s3ATUzaqPZTS6gAKn31+V3vOiYrjZeuKtI9m/We5Yyit10u9DAWep212El+r4jcB7JSl/bzR Xprv76Hqv5/o0VgcwA2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYHyb-0002rv-3R; Tue, 04 Jun 2019 22:32:17 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYHyW-0002qv-MC for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 22:32:14 +0000 Received: by mail-pl1-x643.google.com with SMTP id g21so8913091plq.0 for ; Tue, 04 Jun 2019 15:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7LrsWOu9H08D9VnyWoK4aMKFSqz39fLtN0sqw4NiYmE=; b=a6SMCfW3Grszq2AuhWerX+Qret6+CW6/s7WM7ae6WCeNv1pzOjPcAAjhxtm4SMJcGw bep+z6ve4HsBKKv2+9WzO3L68i4ehYfGyamPfhQOqc4dcrn70qgWiT9PBsSdV4ohOYs5 63QbziAKVPMzQ/8C7IHZCEsYkvSNHeIsA6E/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7LrsWOu9H08D9VnyWoK4aMKFSqz39fLtN0sqw4NiYmE=; b=ZSib1y80IbNFSsMQPrKIpcshMSmt3ATHzUML3kIGvBVFNDS2TfHpWhhxaV41kIINs+ u6fN6cPz7xTEGoz9RhcZIQfp7Fh6j/8JDaYRQH8ng+GYFK0ia5ov5G/A5M6pO0hT+T4s 6BJAvW85ztzIeLTfXfKRQ0THc9nD32cGs9A2qWeMBsV7r+HhPK2Y+a9yD9yH9e8kv20/ jme+JwDuC6ry37trjN2iwnXKc9/oytuhrqUFlY2gx9wD3pkPRRgtCivG5lhCvNTNaXpo c2Dxfi0IujJt9KT1eBC+G0ZIbzthE27ds2FtbpD/u9fSkxXwzAe9boDuRZLntYBzi1iA ALkw== X-Gm-Message-State: APjAAAVCpSnnRq+5fchM424tk22KZBzF/sxOo8eVf9tDk/pVeWyHwwiJ pcWLxmyvVvJojEGf2rvoYRkeZA== X-Google-Smtp-Source: APXvYqyP3mL6L3hXGIHj9/i/mpdSFQYcVM5JqdDzD0ZqHoQlEFBlN2xJ2cgV7XcUdPhRNGofv0hBsw== X-Received: by 2002:a17:902:6ac4:: with SMTP id i4mr37076584plt.75.1559687531967; Tue, 04 Jun 2019 15:32:11 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i5sm642508pjj.8.2019.06.04.15.32.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 15:32:11 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner Subject: [PATCH] clk: rockchip: Remove 48 MHz PLL rate from rk3288 Date: Tue, 4 Jun 2019 15:31:59 -0700 Message-Id: <20190604223200.345-1-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.rc1.311.g5d7573a151-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_153212_724914_C0DBB3BE X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , Douglas Anderson , linux-kernel@vger.kernel.org, Urja Rannikko , linux-rockchip@lists.infradead.org, mka@chromium.org, seanpaul@chromium.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The 48 MHz PLL rate is not present in the downstream chromeos-3.14 tree. Looking at history, it was originally removed in ("CHROMIUM: clk: rockchip: expand more clocks support") with no explanation. Much of that patch was later reverted in ("CHROMIUM: clk: rockchip: Revert more questionable PLL rates"), but that patch left in the removal of 48 MHz. What I wrote in that patch: > Note that the original change also removed the rate (48000000, 1, > 64, 32) from the table. I have no idea why that was squashed in > there, but that rate was invalid anyway (it appears to have an out > of bounds NO). I'm not putting that rate in. Reading the TRM I see that NO is defined as - NO: 1, 2-16 (even only) ...and furthermore only 4 bits are assigned for NO-1, which means that the highest NO we could even represent is 16. Signed-off-by: Douglas Anderson --- drivers/clk/rockchip/clk-rk3288.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c index 152a22a69b04..51a26ff600a1 100644 --- a/drivers/clk/rockchip/clk-rk3288.c +++ b/drivers/clk/rockchip/clk-rk3288.c @@ -101,7 +101,6 @@ static struct rockchip_pll_rate_table rk3288_pll_rates[] = { RK3066_PLL_RATE( 216000000, 1, 72, 8), RK3066_PLL_RATE( 148500000, 2, 99, 8), RK3066_PLL_RATE( 126000000, 1, 84, 16), - RK3066_PLL_RATE( 48000000, 1, 64, 32), { /* sentinel */ }, };