From patchwork Wed Jun 5 08:48:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 10976487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C0DEC92A for ; Wed, 5 Jun 2019 08:48:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B335228834 for ; Wed, 5 Jun 2019 08:48:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7C2328861; Wed, 5 Jun 2019 08:48:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4B54128834 for ; Wed, 5 Jun 2019 08:48:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6776C896A3; Wed, 5 Jun 2019 08:48:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9F56896A3 for ; Wed, 5 Jun 2019 08:48:04 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id d18so18560321wrs.5 for ; Wed, 05 Jun 2019 01:48:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wLk/6EHVseWKSD89x+s3EZxLh+XcrFPOfmLMorC8Hwk=; b=OqQEOCc6DgyMVX+kBXVG4E+6DNRwUsZdUoiG5fiUjfKOfC/jk60yMefLMp2QAqDVm2 qDYmCbUE1ylekNSYfjcK4iPGgv/iQhMvKRWCskrPz30bbg/xY1IvMcYI7Suda5Gqx2yh BXWGTmTlc8rQieUD8R4kY5vdgwBvRRPgwGfKIT6xDwsZcnCf8P8/3gvk1B9sLx2bVFc/ EM6FKzrnjbakFAzNv+odH+rH6WbdMVnFWU5XlxTS4Hs6BHB2/hmNRYWO+QF6sdnaJmeM FSBzgUBpdk8+0ilOUWj/H88jfcLijxSVv9dZCgAOLlAyyJJ9wmdrEcTL7mzjOStl9Vpi 36xA== X-Gm-Message-State: APjAAAWFOWZjOuHXGz4vSngPaoBLkPuvbgxOlt5gfCu7P8lc8gXzV6hJ qN6XyQhf68WIlApXnFORMfZ9VKh3 X-Google-Smtp-Source: APXvYqzAs2MZwFX2wGsjtZBX8fbegNZm4Mv+J28FDMAKcVtKSTFypko4EDuavoOdhkcFAuRg+T3eqg== X-Received: by 2002:adf:90e7:: with SMTP id i94mr9618483wri.213.1559724483290; Wed, 05 Jun 2019 01:48:03 -0700 (PDT) Received: from localhost (p2E5BEF36.dip0.t-ipconnect.de. [46.91.239.54]) by smtp.gmail.com with ESMTPSA id k66sm9919966wmb.34.2019.06.05.01.48.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 05 Jun 2019 01:48:02 -0700 (PDT) From: Thierry Reding To: Thierry Reding Subject: [PATCH] drm/tegra: dpaux: Make VDD supply optional Date: Wed, 5 Jun 2019 10:48:01 +0200 Message-Id: <20190605084801.12599-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wLk/6EHVseWKSD89x+s3EZxLh+XcrFPOfmLMorC8Hwk=; b=PrKEISpyPxOcX/IyMTXMTKCqxj1eULOxK8PgVX26HS5ur47qHvfJyDSTMHnh8b+uEG ueCrq0N4yGcZxXJnAqWvcc0fMDYatwNvLNTeOqK2B1yVFlg01n0HcUoIlD05Nl0UBnYv CHkZSHVZP5cXeEfVIyolGl8TUVCFnTTpX9TUmgbGtBtXumgbWDIgpLT4piIKPXDIr7A3 5a+nL5/p5KVy6KfGBTIKfmsrEm8mzwj4PRr4AzSASSY6Om2Cfsz7bgAsKMtU97k1q2Xi wmiC2mM/7d4ctgjnPOkqa0auso2olbXp9VZOgf7izorADpjMRUEkF5+XBCCggCvEfy2L vj+w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding The VDD supply is only needed to supply power to eDP panels connected to DPAUX. Technically that supply should be dealt with in the panel driver, but for backwards-compatibility we need to keep this around anyway. Also as a bit of background: the reason for why this supply is attached to DPAUX is to make sure the panel is properly powered early on so that it can generate a hotplug pulse at the appropriate time. This may no longer be required given the support for deferred fbdev setup that was "recently" introduced in DRM/KMS. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dpaux.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index ee4180d8db14..65c389d9c85d 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -485,11 +485,16 @@ static int tegra_dpaux_probe(struct platform_device *pdev) return err; } - dpaux->vdd = devm_regulator_get(&pdev->dev, "vdd"); + dpaux->vdd = devm_regulator_get_optional(&pdev->dev, "vdd"); if (IS_ERR(dpaux->vdd)) { - dev_err(&pdev->dev, "failed to get VDD supply: %ld\n", - PTR_ERR(dpaux->vdd)); - return PTR_ERR(dpaux->vdd); + if (PTR_ERR(dpaux->vdd) != -ENODEV) { + if (PTR_ERR(dpaux->vdd) != -EPROBE_DEFER) + dev_err(&pdev->dev, + "failed to get VDD supply: %ld\n", + PTR_ERR(dpaux->vdd)); + + return PTR_ERR(dpaux->vdd); + } } platform_set_drvdata(pdev, dpaux);