From patchwork Wed Aug 29 14:41:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 10580431 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E2CE139B for ; Wed, 29 Aug 2018 14:46:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 194B72A750 for ; Wed, 29 Aug 2018 14:46:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D4152B41E; Wed, 29 Aug 2018 14:46:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 676B22A750 for ; Wed, 29 Aug 2018 14:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S243YdhvOp96/1FFTRacZJPf9Ha3G3ak2GZTg1H7dgo=; b=QmZ0j5M4GVLv9e 03+Eju6RiiC6cHlH3hPmX5sIoGRSKgmuCNwgOytw+NBWO/nAcMRWqv3GJzedlHKIZvUkYa6fBD0OX NnnHUkWaDHsMMSD8aT7qKvRhez4xW0LZH+JU/MaN6f3YIJdMi2qPH/jxj+gEAaEQS0xPnqCfl3ZJC PzBIv4k3ZIPNgbKxwb/t0N9zRe1oqFYFSY9KY04Ys55x9NUXvOZrbDCQB9m73+Yr1jWH7W0cDlf8x vLcAyAX1MxeVW51T01al2/Sr4lsNPdJ+mbn1guNblhMc1kpRAQZQhPvUFSbeey7CAwHDVo2oKCG1j ReDhDc+9URaBeX5LJwBg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1jH-0004sK-1h; Wed, 29 Aug 2018 14:45:55 +0000 Received: from mail-eopbgr20078.outbound.protection.outlook.com ([40.107.2.78] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1iX-0003MY-4i for linux-arm-kernel@lists.infradead.org; Wed, 29 Aug 2018 14:45:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8lMrKi/+vt2xJ54YJ0QBIBy7vs8gaLUNa0N+REDGwI=; b=Q04Oj0+LV2G3uSLwURsXe2VIGXoyl54xYbY8j2OINHbsoUsL37NhaQHJ2g980uIyniRC6hEm3q303e3iywygS6bizg/TTB54zGeyk/X36bJYgdA5IoxH7sJgsGkjyMir6u5sUVHY5qwGK1AyAAGBkB390Ph/HoDdQ4ko4yFKKMQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; Received: from b29396-OptiPlex-7040.ap.freescale.net (119.31.174.66) by DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 14:44:53 +0000 From: Dong Aisheng To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 1/4] clk: bulk: add of_clk_bulk_get() Date: Wed, 29 Aug 2018 22:41:06 +0800 Message-Id: <1535553669-30250-2-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> References: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: HK0PR04CA0010.apcprd04.prod.outlook.com (2603:1096:203:36::22) To DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 344055d4-fee5-4597-9495-08d60dbdfd81 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4219; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 3:zLGWvRcL/uejOo78HB77+qyiZTaQ9mpuifPZgDrR+VrCJpMhKKx5PEMA2Odb9JFF5yD/zZ7WYe1iQLE3oT57kmvJSjHKTMjRGkAcYEBBjFr/YD4pXN4PelQw7PCSqRl/rkg+W4KdC/oLADGG9i304JI0M1XS6PM2ic+/bXWkGNpt07D/5ofmsEIcuGAXADwqOn1ilHpXzd9+e4BlfJPNNApru/5dOm8fuoFTQ5xvqJ28Xca3rG/FkA/sP6/Uys4U; 25:9YiiScGcntHfhIJXNuZV3rZTfC7LLTwWiS9uftkOj6xu4H4QkcbUFY8MwjE80QvddTDITMXanRtg1P6xFlTQQNJp8IkRMkCwlBG62YzMtASptzeKnsreoG+hKrTXL2I7JotFMrA+3d2CuVFl6JLjGRdGShJaSmtxhrkwuQt+NjavSBAzYClsvvPVq4TAVL9ZsY+nRO0Us1+4JNVYlFd8Bud6T7ssw9lyfYwtXj2KYJ+Mgs9GK5RHgP5snJ/TlD7FlZQnWLsmS347PfttnksJjpAk7IB222vMFdC8i+4vjM8hDHeVmcgdM78Q00ZwmVpXNQh8WxKUTmeOivNbk9tvqg==; 31:Yr+LIUQYv27fynqVNiNSJ9V3ji71S0ne3W9TFuM0LZOw5gE4l3wiED55fWs2blH7KayiTuuSbBd5istChT6pomJTkV0JXThTUOjG7amiMlesiExU5bgaI1hMvOfHjsLYL69+/nL97ZsR38mNW+Vk1A07XmdhjwB5Kerte2/iPdoU+dSFtm3ZS7g5P/yA9zVU88GjBKx3laKplOYpsNXkFKcxxr/ckN6EEJJCSXr6Bfw= X-MS-TrafficTypeDiagnostic: DB7PR04MB4219: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 20:TB2GYp32m3twLf77sia0XSnB1jzw11pcie5A6XqrJ3eQIqYULYxccUs6QxPEfcmG5ZTMZQF/j5lpzw7Ot/4NBNpbjLWdqYeAyoXilWhzBWP/vrd7q2//eH96RYjNAxw6q1RdjmXcJPvyzIhpWgN67DSAnqfSb5BNJYTvzJABQFwg55uptP7Xi2lg0+f1ArlRWKOmYcGdMAI8Ro/dNp3/0ymjTmQDlLCACfcFPpMRbp8h+jwJc/61ejMxT642K+Im52E3tcbUq5RmCSK3mDbn4RD95rR8KPcD7TuN1NUMBo+prOOfXc/ZmG6HzBJJYiod7JOvyNGx9eFayURU2TbA48jmgaE3PCNqzGUfelT3Kf4rhhRLVbRapdJB6OPVBpVXBWVfKlYWia5RGR0FEG5lu3ihR1tw0cJZ6hrg5hidqHl7Aeh9v1BnFfQQ4gbCTZmyGR0p5DkCKOLzJuqBUx/c9P6k4wfxlpcDnXJNteZ/flweLljTAR4ms0EcL5CSjp6L; 4:taoMzLYffN4SI52ak0rzite6RPs0NwmO3BOdNO6RUlRMgt+2PE+VX0nBomAWyTB+vuCrVP/OhryOalHeyeAigJRM1cI7g5YUUUARJTUg7P7QxSr5rCPAvAYYqQUa9ZMKy1AkI0koI8HT+Fu3ywXdTdwwmRyYFzcuS1Brm6wtSfscDrXA2Wqy2BYhf/dDnP+a3tMwA5FGkSZcIN7I2p/Sp9TXuq6r+b4M52VP22owVLe81yPga81090/Mm6Q9j1FQWGWCiNBDtm8WYs/MSSEqJyD7O7SQx0aAma2rwQ3HV2QjxnbFSPKeOo+YQTDXw2MqISQ9tXw8AH9IXHNzTh5cawblg22Yj44UsbzKuZBXQXs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:DB7PR04MB4219; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4219; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(189003)(199004)(478600001)(76176011)(51416003)(52116002)(6512007)(53936002)(8676002)(81166006)(50466002)(48376002)(81156014)(97736004)(16586007)(316002)(11346002)(8936002)(446003)(476003)(50226002)(6916009)(486006)(6666003)(2906002)(2361001)(86362001)(956004)(2616005)(54906003)(68736007)(6486002)(2351001)(39060400002)(66066001)(47776003)(5660300001)(3846002)(6116002)(25786009)(186003)(7736002)(16526019)(26005)(4326008)(36756003)(6506007)(386003)(105586002)(106356001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4219; H:b29396-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR04MB4219; 23:m2kYb3NXwyoLXzgFdtJt1N56Ae+sFy3jVUmK5iwR6?= BH7xkNTAOo5Z+xedFSU9vSGw8X3S+qSKe8NchNH5fzngeqKXaHU/KRqcUgcnQc0g82SL9DGcmtRh5t1UFbMd216iuKaj0D4cc92doRNayG0dA7xphIE1T/1qUc4Beq+EMvq5CbaL9aZLeoQoEr0Nx+PcSppW8s3A7V6V72Xprvs71B2N9N1hwbh5MmB8K94k/nZim3EdCfkTAIgHkVUEIMPVittjdkbufTWrNailZQ/PWe+zXAygPwULloBhr3DUxleK9n5VMKJEyZFZY+ePX66V0AWghhM3VQyICSUS2EhsiMcDLGZSkpfEUlk5qg3z/YKZs1NdJYUqMd2rZe5uRwXO5phdP0hepS5PGRfDhSAf73mZWPbPl1Oi97a1xhkjYzZWstsR8BQVd6L75y7mxXmd/cPKK58mVPxEw+j5xloUwK+51mIkMktFY+nTJBxj/ZKoV/d0Prj7T6j/lYTNPRpSyvvT0cRvn7Ol9Ll2vux7jKd65v+YikGrMZDHpH7eoxhyohQ13mkH1mGTgfewXvKRdvGlwGNb6uRPcG4VrJl9lqa2vuKSHQNjhWiSfn4JfaQEGUFLjkyQUzpMjUMoZQ+wIdl7SLXYkmte8CVpVfEcQb1mBAU2aFJP0md5F71aJx4+3Zes2obQ9Vc5Q9+cgi2HONEPxaHHSLkDK/MUJggXGtAOauW/HRPUNftZRuIGMI7gu/zi5INMOfTK3CgkaarR+MXxOqdhCSJyS8s7UTq837m5oZhoVei/8ej/6j609laIU3o4HGUzLCnvO0QAMtMQuVCM4RhlCp+aBk3sD8/BA3OW04kjYh8zXN2iEozUTkXRPSI3H4e/+V6GD+XFCUsRbJ50W7NmBeIakZpV3/vWslGcz8j9HxFbv0Eyiriz6Kc8ujQqp8S+ph2/x/VHwhuYpZ8yvg3O+cuNs91jQSZn/rG60f48E7luqJU/4uxNKoR3u0dOt2UqkSy6CHxAgXhu78ltZWmHCQUKwePbj7kNIOwsPCUU5ZYwtEDLOl2Da4YH1G1PzONauVAxhbkNrn5DBDS5vCNG7p1DkDn7pN+rc02jju6KXI+Yqq+Q4Tr24nQddaV+O80b/CjshYuAUn8fuCTa7tqcfumi07OE9BkTbWp4HsuR3KxK66Hx7sIoVL/DOxMSnTd9rr1jROqUksqk+oS0Chu9NtIEnnW5687/S6gU5X3M1agmpZ2aef0KFM= X-Microsoft-Antispam-Message-Info: j13lCnGt0M7cLWr6FUj2MoFgygGts1tV6/d9YmvcEWAlEkVaBpKi840h0UevIqbuj8xyevndceQJC7IVyFiNaJq9oCUjYBbl1P3WzCLATcmhj8TEmA8zTjruRg9SNT1Es2mq3in5vsiKXUyEfJxLgvz/ukZer6GlvUUwot9Jg5eTch7BqELP/KvduFlu3xxqCCP0YSSDGefBb4CfWRagQDryQjeg9eGKAR4aY3UdI9de6CzX+ED+penOM3todTZpJwsoyZIKrR0QlUlT0idwyOgdS3tGhsCVrV1U86Lm35P5coiA438M1+MjhAukwnOzCwCTprV3XnW2quAh5UqguAsmvDSvCALqFT+7EtK8oUQ= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 6:nSv0hQk+tRuuExnYt7Qr+QyQfniTUhnIJJT6ykMp1xox7fMOSY+ZrSgoFAJArkogk6QMnl4IoSlm8/xDQukPNLHfYBaN06RIO2kw506DQms2TthHQMRi3v8zqK8PJgMKpY6BAffffoedpIYyhGLA3BFw3C8XO/0ebotbFqdiwT32yAoHFeoZ3x5rZ9JJ6YuBvHB4lfLXVKJpq4JlNELWoHm2Ucxb7xlwNpqutVwYw247/MSUHx+PPDA7Su1wZ0D4w+Z7JrV9uiWvLeTrByZz4Ya06Ee1Qkhr1S3dR9UaIatJrZ6Zv7zev3V41rWsGd46yIdnbtJ1iiVLQkZPhNwCaw/2l96XByBQ2VByYgX4Zn+acT2DxWbKQ+Zr1pwcqNbBZp/8X3VIQMTW6F5cRZ5WWX8yRL4C0H64qyjdjV012X0SpaxW02qp+j2n6C7pcIsWEheQXl8YxrUe8BteQP5gKQ==; 5:hnL/zs4AlqGi8mh6UyLIJxfAL9otWPNf2oGihW3SiRFPjWOtVkPRpypDnygjE5J+nVhuGrCVRgFATytkOqz5eZL5FkaoXBTrbBBYKXDP/OU+vxI0+LCsOrhlepKLDVJJanoKmb6DMC1TfxE+pQYqxgsI4saCM1est7/Nf96TZyg=; 7:OwYRWD8XP55KRj4ESdfg51CtgZGF5EogMja42DxEVq0xYI3NRhwmSiTQsAZSgmec5NKuZAHmQ012G+jt1RCXTdDFjVSRtvU9hxJfDjk1u/tbIeFRxLAC/3BZ8A28VvQSeuwVA9+I2QLMbpzUX7jydlbOWoglJzLM9ehBvEenk+vjH8hsu47MT0zOHiHl+GGP29IakCvBogpjGcm6hl0vycjf5aunQwM3S+GDDP050Nyib3KnBUJRUzfQ84J8dY8Z SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 14:44:53.7504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 344055d4-fee5-4597-9495-08d60dbdfd81 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4219 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180829_074509_229547_62B22327 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Russell King , dongas86@gmail.com, Michael Turquette , Stephen Boyd , linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP 'clock-names' property is optional in DT, so of_clk_bulk_get() is introduced here to handle this for DT users without 'clock-names' specified. Later clk_bulk_get_all() will be implemented on top of it and this API will be kept private until someone proves they need it because they don't have a struct device pointer. Cc: Stephen Boyd Cc: Michael Turquette Cc: Russell King Reported-by: Shawn Guo Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v3->v4: * no changes v2->v3: * remove #if define condition * remove EXPORT_SYMBOL --- drivers/clk/clk-bulk.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index 6904ed6..4460ac5 100644 --- a/drivers/clk/clk-bulk.c +++ b/drivers/clk/clk-bulk.c @@ -19,6 +19,35 @@ #include #include #include +#include + +static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, + struct clk_bulk_data *clks) +{ + int ret; + int i; + + for (i = 0; i < num_clks; i++) + clks[i].clk = NULL; + + for (i = 0; i < num_clks; i++) { + clks[i].clk = of_clk_get(np, i); + if (IS_ERR(clks[i].clk)) { + ret = PTR_ERR(clks[i].clk); + pr_err("%pOF: Failed to get clk index: %d ret: %d\n", + np, i, ret); + clks[i].clk = NULL; + goto err; + } + } + + return 0; + +err: + clk_bulk_put(i, clks); + + return ret; +} void clk_bulk_put(int num_clks, struct clk_bulk_data *clks) { From patchwork Wed Aug 29 14:41:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 10580433 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4EAB2139B for ; Wed, 29 Aug 2018 14:46:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C26A2A750 for ; Wed, 29 Aug 2018 14:46:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FC6E2B41E; Wed, 29 Aug 2018 14:46:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7590D2A750 for ; Wed, 29 Aug 2018 14:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/wxwMwp8jh2pXjcxZwBRm9WL6EBAWVL5fTJ4LCwD/h4=; b=mMof3DskXAtlB9 ffIOGR23ZWT82xg6+1snhPnfqlNCiEXqtf2V3W36cNjJTvY94WUewLoWhKtkGrY6EmU5IbNYJJfFN AMXqPpRkRd4EyMHR7wMhXt8ba9Q8XkKGqj0qdUHjL0RRC+RifiBOm0cGc05jQ6DOao2V9bJqvBec+ mhqYZBWeD+3HeNlZhGacujb8AtDb5i86X6wKo4TZPHNJ58YZN1IaYTYwNNJJ2q+weRnSlYIqS2qrh YJM2xDCsIpPvEA1shU8bco6n3J5s/jLOrNlfqO0Z89Le40WW8+FOyNiHjQJ+dBJauFs6cTmmLxD66 FcjEyK0YUgaxp3Hf2QcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1k9-0005F1-UQ; Wed, 29 Aug 2018 14:46:49 +0000 Received: from mail-eopbgr20078.outbound.protection.outlook.com ([40.107.2.78] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1iZ-0003MY-9e for linux-arm-kernel@lists.infradead.org; Wed, 29 Aug 2018 14:45:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rw9+YfSA6MDu1qVOhtAIGv4iDtfo3XsUT5Y+EGVeicw=; b=yHi2gf50eOzbD43qIT+/KRxxdzloq6suufsuxArpGiKJMBnqdTiLl/5dPjnQCx/vDrI/1oEYcOER8f/Ga7tc6dRKXq44NKnIHNBce2wGbAZPuXbXknVYHtQuBNUW/PYqx3+Ief56L1YWaEgxUnFI3tUxpDdOwSo/6WKtfWZKkZE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; Received: from b29396-OptiPlex-7040.ap.freescale.net (119.31.174.66) by DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 14:44:57 +0000 From: Dong Aisheng To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 2/4] clk: add new APIs to operate on all available clocks Date: Wed, 29 Aug 2018 22:41:07 +0800 Message-Id: <1535553669-30250-3-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> References: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: HK0PR04CA0010.apcprd04.prod.outlook.com (2603:1096:203:36::22) To DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 140cbf15-26c6-432b-b90e-08d60dbdffc3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4219; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 3:uys7KOZ4nAHxzhrdVMWKMRT8hIg1qD5V4OfXwyzBv2AIk420ZKLKlOtOmZ5XEe37hBxOvdQachrSfCGhiHzH/MNWHut1fNbk81SmIQWS92PfJEVXvBp7jMjzefm8+K6ZgEnceOmmsW4lndw0Y0V+B8FvsyZmkf3+ECWs0f/jxkHeUBccrSLFvljK0wH/bBIb/fC7f9Mos9lfld3zigq398DcRjMw9uwT8SswgK1ApDoK5MUK6co1Dn/VDaGu2Vem; 25:HTpUyLroQrupx2JYegDF0seV297pG3aFcHeUTrKw2I4Mun7J4Cyd6pAC5LfU+Aql4HjGVNesVqvd1nMmGmOvFZmyyJiethVZrJpc29bDtc302GhsdW7C/rQryVQ3r9IvIWUtY1HfYeR6/eqVHDTrnJS7gXRMnnrcKtVkLfxddIS4RV1SuVlObj/3CUi1hwDJixocEulIdDD/49rSiDxR6s4/zEoNS5bCKsV4qjiGkZUPKZ90Os3dln14zTYjKGKqFMWOwXtwHKtgdq57WFMm9805Lpz4E05ed21UBc1e9AhDSwDnwX4klaIB7sCE+iU50r9dsCi9c81cOCUf7pDCPg==; 31:KqeyB7mVwEOZaCFtKxEws3KC7gXwCCG0L29UThUPOm3upCbNNN3CyCuwlueoEPN+gS7nVmxu0R1FnxhF0ToBuDObRnu6x2NsZF7mdso3ANwuFvjGvuGl7DsqbOnAEjKSe9fFhzmtOgraHPlxZrid2CzTbXVVvASNt86J+QNNGdwr+dAeJPFdq2DwVRaJDyrp8BhH1Kw+1GsC6YqypMaqzmFZRLUYYxMEcB+oE0KFgis= X-MS-TrafficTypeDiagnostic: DB7PR04MB4219: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 20:Y77WLbsfiu9YdFlFPSiDu6YkvyCdhVqc/lOV7ZsBVfN7pJMgY8+PemAw92towTsT0msxclGCWLeP1c/nqGRSfW0MGDH+77IYNJrw6iQTGf6NAt55RmRC4+jJQ9unpIIX/grNA+7UKOBaWuqdDR6ZFcNMBDViqoruySIgIhEMhGh5rcQo6IYmfYyoWqCpG7WkoZ6iYGmbWdA93x133tGSD8ahNN5cfatvJSejs0KIHyDfsanP81dL2gNsZg50skjJyacPO6Nm0oD/iHq7eTHAtiTjbQF+4gzgyy1GY/M2hmXluTxAV4sAFCYIJgIrYW8KfLJ3SO6x5UrXMcKGTg6fK8peWZZ2+w1D4zkv6LAMsOsVaoF+BoCOUS+buYbaFmOLTexg+jt3TqXXedq46EUNxRnrm16I0jU/d6txYAO3k3JaSe89aVBVV4EHuwDXpKxtXt3MJJR12RQWztRgC/u9XEUhWY8R+eExg52v9C7aTBzbruhAwTXaMsu5XgQjxeMi; 4:/YhbDpw3i0W+r4WcXIS3hkbXyXfydVmLbdV4qCot00GjSXTHjrGQrGopXSeYVsbhd9kiCibZ0TDNx4HMEov17NCDJ+Srba0bkD6Vpf18QQB/RzmgGBCkSN5FoYAelf16fZPxOuie4ysyr0o5ZIBsXrnPxYbsB4MVznF2wdAKN6L4/ZAkJYksKC44nMCItkozE72d6cTHThkzipn2qxzJg01Uyir0GDp1NRwFs5BRTxxEW3muHQLDZDh8zbumSq3B6n3J2NwAXTivglq2C8gpEdBABn00+l9j7uKNa0TwaramFIqev/Gf7rFMaow+lwj16Lhucmat558/QUSmzHc4yNjeF8xkQRpotJy/p5cprG0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:DB7PR04MB4219; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4219; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(189003)(199004)(478600001)(76176011)(51416003)(52116002)(6512007)(53936002)(8676002)(81166006)(50466002)(48376002)(81156014)(97736004)(16586007)(316002)(11346002)(8936002)(446003)(476003)(50226002)(6916009)(486006)(6666003)(2906002)(2361001)(14444005)(86362001)(956004)(2616005)(54906003)(68736007)(6486002)(2351001)(39060400002)(66066001)(47776003)(5660300001)(3846002)(6116002)(25786009)(186003)(7736002)(16526019)(26005)(4326008)(36756003)(6506007)(386003)(105586002)(106356001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4219; H:b29396-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR04MB4219; 23:SkZozbOjxpaF7bI037qsc/Ufu20gdT4YeyDiIrISM?= MjJe+VRRelxdp8ZWuvyeWbBUKxD7RIFw56zOoWrs0OY53lwnpy0krKq8vnbk434FyyXnj9v1A0jVjhmNb8aNK2aAumZW5PNcTFKkmd9h/9AVsUKALEh/aIHuFP3unHcs3LXCcC0z9UEbtogPEvVhQ5FHJepfDnrsYQTR3v2wdM9FFE4FRaE2h/LvgMgnIlxVpD4SWCrhFRWiPeKgObbxNWZRYHY8ECoakuIAFHoUwFGQbKlQgC8FBB9jC/eTs4hFETKiIOHzOd42+C2n7I6dVMP76q7KLEBPHGKZi0nKvL8nACawW+laOuc94c7rUFWsUCoMgIpy/mgGDT1GO5o/umA0rRQH07IkgKxPdWn1XftIiwaOc5qk50m2FlISlg5gRePh/WN/rZplPnkvyawMBWOp0aC+3pZi48CeNmsfEFqchWeMK4VWvcEBolGaKuu/pFO5I2/RzOl1eA8stW6arwsfLycN4IR7C0/eCDcS5475jRpqBv8cm4aFEvqL5AQgtxJueRVeDl5l/4r31w3MuOkX62ixiN5Yi/ewOx0/B0Up/7g2sYnClA2GYSPO4jQr3G/lkSNWfAGO6EAfbSmYsYaM2jvk1Q5HVZan/6sSEHtmTqaO/OWnAZvbg47sHlwL4dSoBp0dzMaW7cbPOo/0BXsYUe3Jm+k0d58YxEpf2r2QySR7avlVDeQlKAEzdPyvB4wUyVaCD1fSeFEu6PdNOqw3pGM1Zu9yFYo5FUVYSZeboMkLIExt8q/g/vkGsDL7u+WMjcIH2A/rJE8hu5r/n2hcKyn2huLjllcqE2Omy1cjMGu1Oqtl5ooh9UOezGD2rl0N8tpAbBb7Pf/9/SS4ETzFOAXRundQnn6TQv+Z6CpREqkB1oBvvDOmd6KORPN7s60WGEiDazXBlQh1doBOIz7mBLPXSfNHAWo4hMusM9tK9IpcxCV1ZZ/rf7Ja3LGm1JF9ufklSLmvjXwdSzEIc4qzguxpW34/bT9HygEixAImH2GGkbzkv/7KHtPJREJgSy2zi9B5+iz2x1+8+lWsMOlL+2xkJRRRkkiNVLK3HkNkAhooMYFy7YQb6qUuK7TXdD7WyMUF3KFTo3dYPhFLNSwi5kVx+hOhb3Zu+2XFTETyP8yHuuRU6zCoVVTP4571/wm8WUX38sfd3aVCd7VvMsU5OKS0I/OcH21lwDTYtnIugv6cV/7ZEhmX6Zrdnob3Qt+3peeAjIwikUCV4ieJdXi X-Microsoft-Antispam-Message-Info: HQ6NY8gadY9HIOomEfZXdzmYudl3A6W81yOlsQAElUTP60Xm74jbiIK8CRFLMUrdpBPaPnOu/ccGtkHSG//36K9sE8IJT415RUfJ/yDwPVi0OFarDbZ0hFD72XsC2rbLvkDMXGkXFvxVWWET46Bqpp2j0Qzwugwy8HeAHpdb7wVutA3WoqFVpFAk8GZMmbITrdwL1O5xLApNor1ZqQOojbjDk8WimolJBo/jV6rxP/a4/MzP9hO4WmbhjyxDiSn1eJmgpeUwdzX2OyYvQhptiH5iLc5lnUf1UXCglvuuWp8ktghXJT1B5nFmkZh7RIimk7N8wWCjUIBjVtQR/CnquZe6YmNg7DeLqvdfQCnEF+4= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 6:0EzjDhrCSpIxDXBTwjKsEic344740ONuEkEvz1XG6pAs5woftEF6Z9O430vkbuN4Y4XSEQNSKZXLz6J3iJGw2q6i2clYHY9CINXmy8QqDH8u4SZCToqI0gpvK+4M0JrBgRtJwoHMV1Xkr03yd6yYl1Gi6ILiDQvP//jPmw9mqZY0AgkWUWoQmuoQcUMHCnB76TBmXxtDL2JeHTdjR+89e609+OyzLcgwakQU5RyLUlLa77m98HWPP9YhYLw+VReeAE+VxBrLhIomIWZ1Si/1qilg23yfYclgBdb2zqeAFQlSpxaKGn9ISeuD0JqS7Fgb7l6R836qb+BrhakQFKi6UU6Bj/wZLmlyzkElxVjHIVD0X4amo1MzZyZyC8oxsg9o5iutIORH/ifDEBdE+WncqwxrmydOabFT+weXOimxuX9MnL6mQ5pD2QIWvfK93P2PMnrU4fqiRKphxb8HKxKenA==; 5:Q4kYrbCMDqWJQMeQ3VwTIg2wQI9yNsonc2M5DK0srhF1MbJoJKILB4osx9M7fRRy4JtK1Yw5/9qN7OEk61dNOYn9g5ybHHYgIPAL9bWZ71cssR38W+CQu1D2QkhtLog8IP7mUPHnrmiLNoVZPLRJlWpN9bwepHY4ckgal9BoTbQ=; 7:vdhmn01ASlfZ3tbq5oOkOta7LocPjAp6K9OhHeD8Mz+L3fbAwUqtFcEwhi3ybSOBrnINQ/vLcXNloMsjtOUuXDPhB6T+bdxhBgK74PYKFq/wK8myIJn0VafDGJzFqaEZk2JNDEuO0bOSDUIEXPRSeGyCdfK42v8l5GmUfge2veH9xt2ImkranVt9ieKhYjMdir/150/oq6JhWojCGkUemptfWapZtDLST2hTfr9zi1fos4x4q50cWmQ9IYFQFp3U SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 14:44:57.7955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 140cbf15-26c6-432b-b90e-08d60dbdffc3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4219 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180829_074511_363611_6844BA06 X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , dongas86@gmail.com, Stephen Boyd , Masahiro Yamada , linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch introduces of_clk_bulk_get_all and clk_bulk_x_all APIs to users who just want to handle all available clocks from device tree without need to know the detailed clock information likes clock numbers and names. This is useful in writing some generic drivers to handle clock part. Cc: Stephen Boyd Cc: Masahiro Yamada Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v3->v4: * no changes v2->v3: * remove #if define condition * use kmalloc_array v1->v2: * make of_clk_bulk_get_all private * add clk_bulk_get/put_all --- drivers/clk/clk-bulk.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/clk.h | 42 ++++++++++++++++++++++++++++++++++++++++- 2 files changed, 92 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c index 4460ac5..6a7118d 100644 --- a/drivers/clk/clk-bulk.c +++ b/drivers/clk/clk-bulk.c @@ -17,9 +17,11 @@ */ #include +#include #include #include #include +#include static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, struct clk_bulk_data *clks) @@ -49,6 +51,32 @@ static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks, return ret; } +static int __must_check of_clk_bulk_get_all(struct device_node *np, + struct clk_bulk_data **clks) +{ + struct clk_bulk_data *clk_bulk; + int num_clks; + int ret; + + num_clks = of_clk_get_parent_count(np); + if (!num_clks) + return 0; + + clk_bulk = kmalloc_array(num_clks, sizeof(*clk_bulk), GFP_KERNEL); + if (!clk_bulk) + return -ENOMEM; + + ret = of_clk_bulk_get(np, num_clks, clk_bulk); + if (ret) { + kfree(clk_bulk); + return ret; + } + + *clks = clk_bulk; + + return num_clks; +} + void clk_bulk_put(int num_clks, struct clk_bulk_data *clks) { while (--num_clks >= 0) { @@ -88,6 +116,29 @@ int __must_check clk_bulk_get(struct device *dev, int num_clks, } EXPORT_SYMBOL(clk_bulk_get); +void clk_bulk_put_all(int num_clks, struct clk_bulk_data *clks) +{ + if (IS_ERR_OR_NULL(clks)) + return; + + clk_bulk_put(num_clks, clks); + + kfree(clks); +} +EXPORT_SYMBOL(clk_bulk_put_all); + +int __must_check clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks) +{ + struct device_node *np = dev_of_node(dev); + + if (!np) + return 0; + + return of_clk_bulk_get_all(np, clks); +} +EXPORT_SYMBOL(clk_bulk_get_all); + #ifdef CONFIG_HAVE_CLK_PREPARE /** diff --git a/include/linux/clk.h b/include/linux/clk.h index 4f750c4..e9433c7 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -312,7 +312,26 @@ struct clk *clk_get(struct device *dev, const char *id); */ int __must_check clk_bulk_get(struct device *dev, int num_clks, struct clk_bulk_data *clks); - +/** + * clk_bulk_get_all - lookup and obtain all available references to clock + * producer. + * @dev: device for clock "consumer" + * @clks: pointer to the clk_bulk_data table of consumer + * + * This helper function allows drivers to get all clk consumers in one + * operation. If any of the clk cannot be acquired then any clks + * that were obtained will be freed before returning to the caller. + * + * Returns a positive value for the number of clocks obtained while the + * clock references are stored in the clk_bulk_data table in @clks field. + * Returns 0 if there're none and a negative value if something failed. + * + * Drivers must assume that the clock source is not enabled. + * + * clk_bulk_get should not be called from within interrupt context. + */ +int __must_check clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks); /** * devm_clk_bulk_get - managed get multiple clk consumers * @dev: device for clock "consumer" @@ -488,6 +507,19 @@ void clk_put(struct clk *clk); void clk_bulk_put(int num_clks, struct clk_bulk_data *clks); /** + * clk_bulk_put_all - "free" all the clock source + * @num_clks: the number of clk_bulk_data + * @clks: the clk_bulk_data table of consumer + * + * Note: drivers must ensure that all clk_bulk_enable calls made on this + * clock source are balanced by clk_bulk_disable calls prior to calling + * this function. + * + * clk_bulk_put_all should not be called from within interrupt context. + */ +void clk_bulk_put_all(int num_clks, struct clk_bulk_data *clks); + +/** * devm_clk_put - "free" a managed clock source * @dev: device used to acquire the clock * @clk: clock source acquired with devm_clk_get() @@ -642,6 +674,12 @@ static inline int __must_check clk_bulk_get(struct device *dev, int num_clks, return 0; } +static inline int __must_check clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks) +{ + return 0; +} + static inline struct clk *devm_clk_get(struct device *dev, const char *id) { return NULL; @@ -663,6 +701,8 @@ static inline void clk_put(struct clk *clk) {} static inline void clk_bulk_put(int num_clks, struct clk_bulk_data *clks) {} +static inline void clk_bulk_put_all(int num_clks, struct clk_bulk_data *clks) {} + static inline void devm_clk_put(struct device *dev, struct clk *clk) {} From patchwork Wed Aug 29 14:41:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 10580435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AAC7C175A for ; Wed, 29 Aug 2018 14:47:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 98EE02A750 for ; Wed, 29 Aug 2018 14:47:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8CAEC2B3F4; Wed, 29 Aug 2018 14:47:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E180B2B439 for ; Wed, 29 Aug 2018 14:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2RY+x9Pi/ahX4I8xbZUpeUqLV8J88qxpA1OJIQpR2Qs=; b=XYLmwCETF1NSrU SehSxgRC48/0fZHD8DzZOZPswU2AmQxzm9S29S2L2b792adnkrVE0dTcBW29yN9/zur5IdM0JmIgw kJwvjmppXgb1MycqgwGjqi8wjkA+a7lr7Gk/bLttCniXU3NPsd99Xpb2J3a3UCu5r0ARVoX8PyNps LO+a3+Syy+vYf6byPLw6p61vZSomwVkDbyOiJvxsapELdlfQ+mrakqUqCGRzgu+eB7eMvetQqwJHe AFnKIOekyedhdJPJipUapYGCWrUgTWr4rQM3O4Qjlc3dsQB6Z4ylgtby9q+WFN3YxmsxbEeylUS9f kTmZq9Gaq+tJHo7yLo3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1kp-0005Y0-Kc; Wed, 29 Aug 2018 14:47:31 +0000 Received: from mail-eopbgr20078.outbound.protection.outlook.com ([40.107.2.78] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1ic-0003MY-6y for linux-arm-kernel@lists.infradead.org; Wed, 29 Aug 2018 14:45:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+iN9uc1R4Ctt5/eBOt/haNNMwfWSxMKXuI49Pwtddzo=; b=ekeIZjWF4+pJbaXtttwHQJad7e/amotcKBBz1OM25MhPW7AF0N/pJNU+MwVouhJc8oo70cb1LVp/UC1v0UNUZuLzyJxT9BeakZMhGzHeHE7KybMwoq4xCxFeN57kpRBt2ZSmWWS6aTngUIQ0PmD2+AeqCNqAGWbbm6C9tSrfrhk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; Received: from b29396-OptiPlex-7040.ap.freescale.net (119.31.174.66) by DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 14:45:01 +0000 From: Dong Aisheng To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 3/4] clk: add managed version of clk_bulk_get_all Date: Wed, 29 Aug 2018 22:41:08 +0800 Message-Id: <1535553669-30250-4-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> References: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: HK0PR04CA0010.apcprd04.prod.outlook.com (2603:1096:203:36::22) To DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7684fdf1-750b-402a-6e4e-08d60dbe022b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4219; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 3:u7dl56wwAmVUMIiB3PQRg3pbh+75VppoMReA4FI3XggnDV3vIwsOA9+Bq7Pl7Hd2ekm+gvXgaUiEGz383nLkP+ENkiU/fSfP+iTPBXYjJt12zfce0otCeDYsQyxEV2PEE4GBMh0A5OkAi12IQ7j6MAroqZu9uBJTAeLdB8l8OQ/gzljYX6nsdQ4cK3f2s+zklKtHidQgT8pDAhRyW7V9cZZzTTnKZ/nh0G8H2TeF/6SsFwItgwV0ZtWYvHD5udlU; 25:6cQtRHWHzEbxtVpDAccm5untpAF1Rvhc1ZYmf1TIfMnpfXFjUkc6NiT14C97QJCYvNf1L4aoN9LHSgeDMBHHWPpZYB1z2l6jsYtcmDahAwef9J39pwZ9KAo+euHAC94AoNC1emXaFRRetDAu5VS0Yi+Xz1lBmgfTQwChBKQZmpK2dCWsGim6AViaZc5Gb2sW91/pA/IqL/WjwrvPv9HG8Ro2sGvk7V4+URqFUEQZXvxMxnLVsc+t39IQLuElA9QZpGosxg70Pr/BfRHvv4HPxZbTq6kkV9U6OqrAjWDPez5ps5yT7VRUkaPWjvMXDCw4tDL5k6WDrYXEN8WsLvjnaQ==; 31:gfveJgecfli3YUiph2japUoubxm2zMJOP924ahfHiKU4bDBfoWKhpjFTlKFJNO4Jk53S4pjLY43/vAtyuM5Gff7Gchsthfkin8OM5CB1PvigvG3qVJO/h36tNvZglh4fSaUxAPNpHdDOUXbowluLhKT9U9QeiGicf1PmFfakO8xmRTIPz/zol+PTpajSX2aFobtWjvuQIngyVMokBmSzq6xPn5zw8rDeRE3lLACxO88= X-MS-TrafficTypeDiagnostic: DB7PR04MB4219: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 20:znZ37c6bnGzdzdk6Z8cflHHi+5Hr1NX8h6wDGYTGsc1nhKfE1uKmsBfKqkNJLw7ThDoP3Mu6v1B5YNVe+bASA9OAP+MSc38cZ0oxHgz/4Mx0GdrUlaQssKvKKLjKN0LQhnIShJQsH0VADVVSeknJ2EiVnivP8hNyfDF854pw8GsrgAyGn7W67KpdDroid3MqeRDOxCOo0igjz+y+UIL+esDhYpipHfTjoKzcaCs70Nz/4KN1maeuQ7fMh+rTgvsVvhlDhw0P21E9kteKu/L1faiIRffrQkmLjR61yfiOLOEapgI06eVh02Ix8OKog5tqxcFpwRJ5PG6a+0wbZh2bU5em3zlx139a7cwYGxgxmCM7o/LfKlaXjUNvdxO+5pU9VxvldR1vyuH/2x1p/mfuCpyAHkUkGTvPXWq8FodKnMu6Y4XemiqpPLElIIDs/6uNIux0qL/LuVjoiknhCpAz8492tEp7uPOEH7O2/SC/LWtu8VTasvSj/pZ1nKVYgbR5; 4:ANY1DzLfC2UogL42ZcWorgA/5ytxXedOpvAH57KqK8DS+i9kULWo5mA8HA5mJ1/2ZtJWfeRxARGGttqhVWjBXDPvj9AYF0Igul7vU9oNy16BJRndZmCgC5zBygzk7MwHE+uXaxLw3arTSA/GVcpBpP/QLN+ps+Dc1uzTwlVEQzEp0JJyHpU0RWaATu+Z4t6cBgDmGSG608Rr155+nkf1fOVspIUgv+1oi8Q2HPc8X8tk8pphX6WtkJC4V3DeV7YNE5lLW5+rPlDbcAzZYo/SzwjhPrwfP9QlJoQ8mGPpxhpy4eKBhdsuTzAwlIxeonQjXO33srWhraKiho5YkXFm48SNGFkrE2Wg0TfGF2InH80= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:DB7PR04MB4219; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4219; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(189003)(199004)(478600001)(76176011)(51416003)(52116002)(6512007)(53936002)(8676002)(81166006)(50466002)(48376002)(81156014)(97736004)(16586007)(316002)(11346002)(8936002)(446003)(476003)(50226002)(6916009)(486006)(2906002)(2361001)(14444005)(86362001)(956004)(2616005)(54906003)(68736007)(6486002)(2351001)(39060400002)(66066001)(47776003)(5660300001)(3846002)(6116002)(25786009)(186003)(7736002)(16526019)(26005)(4326008)(36756003)(6506007)(386003)(105586002)(106356001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4219; H:b29396-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR04MB4219; 23:aoHo6bBgP6hTQIBFRMjBH1c3CMWyqD78US0G9cLTA?= XKW6V99nGgvHpOmJhzxsK85ZbEIOqkwhyarcDlpZH/QG6ASPdyL9VfP6Fyg2WoRUeIZBuy299YQjQzpGZJOrh3n+Ty3znBVSGiDnNcKkERHhpEoidUEvYsE0gs2lKuC1QiKeXk7Ez6yZwg4U2zH6zRO6BVQnBoFnyF0o9v+gR781tKQ8qnv9jGqZ3N8s7eIrGNn9jkcv0g2huYMppxaB8EVCA4RGq1I9W1rXsBLOOIA1LCcTs1l2/GWk+GTi7+CjcS87EcC1bM8ig1lVUdn2uANbMER6Zni3R1Kl43bxlxWgQHoar9wP/fJ8+VSNWAx/KfrndtLdEUTRCMyHL9PFhPHIcK2QWeoJ2VcZk6VtDxUk256kYctAIKn1MfhoemjYSaIszXOlu3IEu5gGj6nBtTyZ7B7MwDl8pSmMcLMU3Q9nHpzIei+tR7IFaE8/VOLout5M5PZtFRfHpIvSrlkYVndPAVdfyUSw9wq/jJIZrNyIKYORU6qe9sP3OmYKlO4ouZ7ncnXmoqaVcmlnTORcVpqdWXwDS/GiWmJ5dK0w4aGn7cjpzXCz/R35pS2X3/vF/4reu9jHZ5enz43G6MDXBIOX1352O2t1rEZFHsvBMU8YUW/ebuFywMI6SVKbGc3GL2CYJ60pp7d2BkOqot3KZXuGx7V35KplhUU6n3VD/L3gs3ayzY1bjEqBif8rkCP74FcqsgOwlz9gPf2x43yb/2p2GPW/cVui1eyqdPfVfjfvXwAYMmIE3zpkIEcnqq1zArgjORdC5JFq+U+Su0OtrlE7bWHo8d/rKaGHgLJuDLDpS0t2EwY3wfKrNN+lDRYIpbi/xOp3cJ6TJw3kZPYlbief+KGmbwrK9cjrtVrW+yuVGsItCXbkR7YvQmadRiIiZmsvIIKsB7a1PYHhTyzQAjQdk6PzBbOke7jnbb4fwxIZvcMwYe9Ln07zAptn6/hoGwDmQtccrzKQyQg1O+CnGbtwRPOPwkxwtSLe+62UUW8dQh/iI6df+Q0QYHpf+B6ZG/vzdaoeHGDl8uYcwSxKH06mhcoBo6tSNkHpad+XzWujT2zsUgt8ZqAcnmT3kNVP8J5CWYGUWYNj3LUgoW5SvpqNF96ZsuZKV33IpxhxZkVH1Sdq2p70auDJ3t68UlqZD/k8zr1KuQEEx4K+oalkPIUfmUBalKkOxOUgZFpfwpBYLp/koRhjLSampwiqH0lI4c= X-Microsoft-Antispam-Message-Info: PijQP7ehEl1yHnTkLOvkWDGpLDxRvkF18YiaF4oYe2VVXEqPuf7iaL0k4tbopWsxkt6yqTTHujoaHyk5R8UA3xBozAJTC6bOwvFLeNh+4+aI8/YvZDip8Q6z590zSViMCoKRnEwcPWiHFMjlvxaZxVZDyV01XA/OD2fYZC5ydTaxqHvGmksQrrg9UNjKnPa8Y53c8EJn9UEUqB1gDkSp1ywqtWthgWPnk9NKPVdVqEMPsigWoitgZJuRMUDx4J1+o6HUMww/IfPyIfPDXkiEOhr90KHtMmCmTgggzFTz+jJpAHJ4Np9lO+ZsY/CEcrjdmIeobfLzbhtYrnuXXCw2WhcXRjgq0znE6sWHrLq1E2o= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 6:6j6i9DxKaXw/iD5Gmp4FzR484/VqkEu8eWWfUcPngb52wn6FHbvQIXTZykTQyFmweSaXmFcBh+ldBB5+SR8yfCnem1nS95G8fsUadeWDhW/ZjiSY9SrK6o24TPA1mOSR8Z+6Gbb12Sp28QSJKNpszzhZhvOrHqhjQYfO6UmkPLkwjN7DH8BIORKALcjZ5qfX0Ay8325eKdG1eWx8z53LOgDETXzb4wOTMDb0ru/jgcYyVvvXna+GF87ovBmXKJ0/p01ZEvxP3QL9p8elKTPFwWYAU/osRY0J7+cWqrEIQmsemtdiN0CEOChUuQlbiz0FFgqjVoZN+YFyGt8AViMqLgD+VFQ3sNddBYPcvLFuOjuCZGPiR3xBUXuTV96Rxv7/vPHXq5L6qx6Wkgw1UP1FqHo7YeNitwJBJPzwkN6ptf/f6Fwo0gRyRMl5qvS/aZEJHla5ln7229k6fTTN/N0dpw==; 5:6BHUZSmxu4wFr6dUWSYZ5C7/LIPxJKQKi7cDqxAuDO7LjYDQf1VBUxfzCQujtBwjZyuRsYky4AHrJwrEGucMyj7LxcUPd+s5g+7FrkYsHv0gg1aoNj1RAGQgrSuFchRrDIguI313Qs94RsXYef090G+nERr6ch45RvWEoL5uN3c=; 7:g0MHTN/plnQlE3F+zRB6TVvfVkqVsq7DNcR7Tr5+8Az4v9gi3A9sac33fVFmeQsNSgdIPsowK0JTI8DwwQX9Pw/kxA3kXRcZYDll2gue8uzhSGflKHCdJIz6JcsN+9mob9hVYKZzkqK15s6Mppfizdr92wyJANlwM4REblxEG+65wZTw4OkpF5CubRBDsvjT1j7TQemsIGipBui/GGwk10I2sZ+OAa/1SWV6sLIXGNZ3IewZyjFXnG0yv6p0U1B2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 14:45:01.8657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7684fdf1-750b-402a-6e4e-08d60dbe022b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4219 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180829_074514_351786_48D663E0 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , dongas86@gmail.com, Michael Turquette , Stephen Boyd , linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch introduces the managed version of clk_bulk_get_all. Cc: Michael Turquette Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v3->v4: * improve 'devres->clks = *clks' according to Stephen's suggestion v2->v3: * a minor fix of build warning on PowerPC platform. v1->v2: * new patch --- drivers/clk/clk-devres.c | 24 ++++++++++++++++++++++++ include/linux/clk.h | 23 +++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index d854e26..12c8745 100644 --- a/drivers/clk/clk-devres.c +++ b/drivers/clk/clk-devres.c @@ -70,6 +70,30 @@ int __must_check devm_clk_bulk_get(struct device *dev, int num_clks, } EXPORT_SYMBOL_GPL(devm_clk_bulk_get); +int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks) +{ + struct clk_bulk_devres *devres; + int ret; + + devres = devres_alloc(devm_clk_bulk_release, + sizeof(*devres), GFP_KERNEL); + if (!devres) + return -ENOMEM; + + ret = clk_bulk_get_all(dev, &devres->clks); + if (ret > 0) { + *clks = devres->clks; + devres->num_clks = ret; + devres_add(dev, devres); + } else { + devres_free(devres); + } + + return ret; +} +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all); + static int devm_clk_match(struct device *dev, void *res, void *data) { struct clk **c = res; diff --git a/include/linux/clk.h b/include/linux/clk.h index e9433c7..c705271 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -346,6 +346,22 @@ int __must_check clk_bulk_get_all(struct device *dev, */ int __must_check devm_clk_bulk_get(struct device *dev, int num_clks, struct clk_bulk_data *clks); +/** + * devm_clk_bulk_get_all - managed get multiple clk consumers + * @dev: device for clock "consumer" + * @clks: pointer to the clk_bulk_data table of consumer + * + * Returns a positive value for the number of clocks obtained while the + * clock references are stored in the clk_bulk_data table in @clks field. + * Returns 0 if there're none and a negative value if something failed. + * + * This helper function allows drivers to get several clk + * consumers in one operation with management, the clks will + * automatically be freed when the device is unbound. + */ + +int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks); /** * devm_clk_get - lookup and obtain a managed reference to a clock producer. @@ -691,6 +707,13 @@ static inline int __must_check devm_clk_bulk_get(struct device *dev, int num_clk return 0; } +static inline int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks) +{ + + return 0; +} + static inline struct clk *devm_get_clk_from_child(struct device *dev, struct device_node *np, const char *con_id) { From patchwork Wed Aug 29 14:41:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 10580437 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4E8495A4 for ; Wed, 29 Aug 2018 14:48:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C9D22B3F6 for ; Wed, 29 Aug 2018 14:48:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 305D12B403; Wed, 29 Aug 2018 14:48:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 976082B3F6 for ; Wed, 29 Aug 2018 14:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AlE5egKYnyfbJf4Nb7nkAnT+gjl1w4opHyO/eW+4mxU=; b=MViLVMy7mGZqPy FVfWEUv5B/MwloPwgbNvWNIsrfvvjAS0DkNfRcv8112gpeyx372QmGwhTzvjL+H0wweuFL8WeiKyi 88JPXYgKC8wCBEHlXDbN3wWqKfTeq97H+LcwnIT/Odmec8qjDwlnKcqSNB7XYd8D0SCVKM4looMON s4eDZ5J/RSdASLO8ZZH5NOBnwaosb1Ied9s4T6wTNzGrAPr63lDs0XJA+Y7SdleHqU8E6O9c1nr+j 9XxKgjGnoEJxT4RusSOltGEiHZLcJyUL+orApfnzsI/X90FCbeiMuQOW9CXCX3zd10owlGBujL7bi v15YasjPd2B7t0RGZofA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1lY-00069U-RP; Wed, 29 Aug 2018 14:48:16 +0000 Received: from mail-eopbgr20078.outbound.protection.outlook.com ([40.107.2.78] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fv1if-0003MY-0N for linux-arm-kernel@lists.infradead.org; Wed, 29 Aug 2018 14:45:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8iTMETEn7KSoArPSgEEclCn4FhbGLFQMHj5o60S6bA=; b=mKPoyFnYxQq9xufLcvy5YlVSkw1a1/3jRkF8CnM4ASfJzGbGJqDgf4YrmtYdaPxo8MFh6DwFyJu4KBYiwKh8vxzErhhaH6PjfdTpibpeWsSqXQhJFUWt0qTQ3OYl5W2LucnTRniazodq9J1I/4CMVQ1jjctspvSHZ5XWfSFTJz0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; Received: from b29396-OptiPlex-7040.ap.freescale.net (119.31.174.66) by DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 14:45:05 +0000 From: Dong Aisheng To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V5 4/4] video: simplefb: switch to use clk_bulk API to simplify clock operations Date: Wed, 29 Aug 2018 22:41:09 +0800 Message-Id: <1535553669-30250-5-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> References: <1535553669-30250-1-git-send-email-aisheng.dong@nxp.com> MIME-Version: 1.0 X-Originating-IP: [119.31.174.66] X-ClientProxiedBy: HK0PR04CA0010.apcprd04.prod.outlook.com (2603:1096:203:36::22) To DB7PR04MB4219.eurprd04.prod.outlook.com (2603:10a6:5:27::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d5659f4-5eb6-4bed-c559-08d60dbe0516 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4219; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 3:knevGdvWdaQcs/4ZvrbESRNrE+zBiW6ltl4+74TTqkcqgQEbZyOxy3V5Sd6McPX3Pj5dBvyp+KPl1KrYEziXfdxWpCk0P0pBEYNWnTeTzFbc6+OzoABBXheD5tY1RjK8anGFQaJejX/RrWQxziKE4AlgIN+fPSH6SY0cjvhgXYATEURYGWURFdcLwIiDaXlyDCZ6GuG0bZJbwXouUVJLtUPLTrI8xdBi6ZkeiPDSb1rIgfikZ60anyQ7m5tfd7SO; 25:SKJseWNS4xHS24BvJjo70eVxiOcelDcrNo29PNx0x3ALXRKw4kzF982TqT7BnWnuKKTX3C9gbMI7HugBEStMizCu8vTxvrcOy2qXgFsh7r3L3cAAUAIUcRORchoXK3yJ+sOLgw5FSNJaRbzCWLBoxQkcjS2TjMD7WxzPgzDKF+IV3UPuBNaH9AV7xeSmXSH2nFQOuq8pcym5brt6L63ByOi7hFdzpCdcTH45kqJd2TyBFHQ4bFcd+zo0pVHrvF+v7vsfipO0giQPXzUznSmj6s4jxN2c1U+o47P7sOmYoH/7hp+pW6GzUCTKyRa3UwGoc28Rvsp6xvxVW8J/++tmLQ==; 31:iMY5HMXpBeFEKqcoqifAo83mWWmDv45czr0QSVHIhvPUNk6Um8Rrng3+YYlrmJMQS//ydINzBXLA+IQTnAizYDYfNcenxmik+kdGITejv4HfYwJaikPnuwfQKSJN0SA6mDk5IWkB1DEFAIWXukudIEoVuiaOP1hhVsN87YAeOvWDpDIihXQhmiVa80G5YAfUSu20iL63tlJ1JW7i52z0UQ4a6lheFX8e98RLBm3N+Cs= X-MS-TrafficTypeDiagnostic: DB7PR04MB4219: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 20:7amXQlBJByuc0P/JvQCHZfbgBy6XRk5albGU/+b8Smf5JYzi86wFSzpKowU8YzdbHsb5AlYIGfjTvGKrRqEm/FojU5a+YALHtoxKaxc/LwYNrf0W7yJ86j6sCoLrx+8y30IV2zg9/Go9UKINYnZ2Ord6s8t+DvmJAZ0u3cjYlFVlLXzRLUpMv30PgcKTWulS0qM0dGakvPgQxQ/srhvctzuILqVYEEZVbsay1fkG/KEXi679IMwz1SRw7ct7LvIviGaId7gy0WLTKuX3Y1gYBkcS/gjdP8CliBarGBO8oUY3Ck2G2Hx7FAetkkFLPq2Uv0TOLtfKN9itJt6I1l+pv1h/KVSxi8IWoPfauljUlj2xWoVwEqVeLvxgYnsCRSw+uD3GLSF7suI6yVvbrDiS/gKvv5/nOemB3jeogDOWV4gqGDWVri0xr+lFfaBtJJ3xrv0jJ//Pxb+64KcKCKmsaM7RodEbma18PCGc++53qOOJoUV/iYiu3s4+Td8c+W5h; 4:DpRJejb9E+jWuOsbGGgHh2Pw0VN+eQyAExToaLDpv7pY+HfogK0NsvLulN2h18uA0XJgQ3bHQ+MnmJ91P9vKq3XSdk+A+HHdaL/PaUKX59RiNko8oCbrQMdxx6UuRJwkkku0G8XifUXUIvjPK+NJVggHZbqGrd6lwrvADZAb15Mw3N/qZZ/jfvMwpPhsDq4ERw3ay1jiNcoCwYTCeh04Pdw0Zs3Joi4ZuaaGsx86EQienEa1KPsN65nyD6/MsYva4S8p9KpXZKbUIsQc/YV8dLNQ203y1zErnAKN+QwxMXLy+kobM6MMApZvfwJWZpALQfIdfjJ3Pq+pblJPScSxht+OcvJuRDj+HhQy6pq8PaqVpXTr2Lw6QWdYVkvpC3RuTFBszendDy13CG6g2NX0ZnrAAJtPbqwxbOKzp1TgSYs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(185117386973197)(7411616537696)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:DB7PR04MB4219; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4219; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(189003)(199004)(478600001)(76176011)(51416003)(52116002)(6512007)(53936002)(8676002)(81166006)(50466002)(48376002)(81156014)(97736004)(16586007)(316002)(11346002)(8936002)(446003)(476003)(50226002)(6916009)(486006)(2906002)(2361001)(14444005)(86362001)(956004)(2616005)(54906003)(68736007)(6486002)(2351001)(39060400002)(66066001)(47776003)(5660300001)(3846002)(6116002)(25786009)(186003)(7736002)(16526019)(26005)(4326008)(36756003)(6506007)(386003)(105586002)(106356001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4219; H:b29396-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR04MB4219; 23:c+UPlCxDVbdFJ7PoDHSC4VmpKIrGUf3T5LDX5cBVZ?= wjo5KchCRJbTkCji2igZAE0+HMH0casoHOOmdkjz4otmWAW2pdiat6YlFHuec11NAk1P+J+LJfNbuJee5OeITlFkLoxI5uft0AStlg9nwQp2w2C4pDieoilv1ilNtmGncqZMprFCxe+Nyee//QS1p6mrs9GfkqsQIhyv0eZYRC50sboW6ad0JpDbEvMEZ0aQuRA5JULljHGMv05W+UImpdyd2A9KlyRCIvEQLwbQlzjIPsvkE43AxZKGuI8kzhAkGPviZo9OyuaDhA26urkMMu/xH4yefUmVoWmnqapg1Q4okR1ZSk2QU3bNdQwV4Pu5JS6V2lLH4NJvihA7E8fq0xnuVWChseNQEE4wPUk5X/MZO3GnQrgdmAzv7So+ub+ee20qb7jhMItjKNPUc7+ZZYvsksqFj33Vn1OUJz4lo58CKUFjZYUbszaQT1nForKuuZQnSjEu977th9um/xlyB3cZ7+UG3n9SavNgmXsKcoIZH3qxXsTMAKIGlz7ac+0VV+PBXlvPBh986/lH36s+jKnTH7iMxsi95vbK2bYEDxdl+ntWlyme5TaIBF2AppE/hqsQHOoQXEDWNhWzNrBmGh+FahkFd56/NPJD7E7stlq5J518zdqwGc+Mt3K53JCHamNVMwV9z4mqL4oA41DdB4E0wD4Mt2H3pHXlP3s9Ws2TNvwqlGfPZ4zEwiFInumfWvRqq3kgkqn7OuhJqT6pDBK0fTkHTMjW3EvE+qF96cJDxD2ojt2kx+VU/upOFjPmejD6UUkTMJq7xcmglrlrKfiadhKFoptnqW6Ms44mG2tCERFCAmDRyHhnAFgOrjeIYkQuSGLaafNxrkZeXS4xcZE5Nn2eTX6IeSW4nn1wP11MCLoinNx6uXJheYm0oQtj5hXYnSIo3K5a9WZtD1qCRKJlGD2ZBemXM1uz+5YQKoqq7ZNN7isfOodv7KsN3gQtvxy93ycte5vAg2qw0Sw/P7J6LYXhBfkOjBLBh2Dmn4+uJKKtKwBVDb7cuSXpITC45kBdt8E7oT9IThF4qGI64ObShko+YdLUlvzNJHEkX5tk9prx4Wo3+zs1HqGGvXSMiDofevqFOQ5Fx6zcYqlQE0mtz5WFNgeNY5sy7igtPcZImFCxXseItbShp52ykTnDmigsPuYYk7hJRliwsM6sK+c91qtDp76bGyWqMezHjvjbFs2OwRzo1/cTftwu8NGTu0= X-Microsoft-Antispam-Message-Info: LeD/097Or/PT92exSpKJvYXJJcSU6uYgdZ3BT8DyzO9LKbvjYbVlLsHFzkWjfYsIWaueYr3TDJ9ibLmrk65L9nUBo4l9wko82BVU16QkCPOdi0xivV0CfTD25AIFUtiYvdZCnxP0STdblTByLmsTz9XeCq/a8RGUpv1Lkj7nU7lh2Wmtra09c3W/yKqnnYauJBHqXPz9xR146skDKj/DSpQrqImMsBoAWasLlmszMTy3vPLVXX8V/qBYpoG6rED3D1r1IG8+9ejbTKMMn+/AI8gJWbDjkZM8rxkZoC6wEsTim/CdqY+Qjcae2AnJ/nl78jdBdcPEinUXl7mhlENE4ARSXX5dcWm6e0JMZcHU2M0= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4219; 6:XoxMU35iPu6OAy4KoHuj6XIcp/Lbzi0JF+O4f9GPCnfWrWPNwGBwzjvO7EjhRjYw0Pmzm+rXBIdhHYrHEklA0M6Jy/ecpGZHPpNBzWOvdRBLac6nwylIy59StOHKp63qaG37oPDalyui7RzUTXpGGrWbYJWv6dZSX1X+WTthH8TuNlQD17NQ/Sf3u9HC+C7bHOsp2rIAsTfzZpo8ZLZ5v9bfpvxlgxRR1R2NZHgV2TGJvxrJQN5sAkyNJitDzOfrFyH7YmjEClJIXkhOAcShbEiH1cgiMC3LPkeULMykCHIEirZIjlbTaGBR3scvJXpHM9PIkdcFrmEOiomOjko+gOUX6Kt6Z8LOtwDHZNnMlGvmKG+ajaFRFakRjpIP/ST4hm9XU48Qai+WoT3WfMC5oBW7xDWp11AjnIxYBrN5Q/ed30McbuX2D6+3h2823VG4XP8Dc7T2gg04v4ugTbbrUA==; 5:mWdbZnLXxSfCG8g/iMi08iLiOeUMgkrilaVLHC6wH1IG28FiJO1vhR1PJ8iVrVyztd48zSMZ6FD3VDFfp3vOEfprcN7nfLq/mvzn0WIGGd6pC+A8v1sn2u7cJU5MvkL6V759eBzT4Z9kW8Sc7KEX+903EIdR5LjfOlfj8r1PwLA=; 7:ak/gang6o1gWRwEEUltMTnPcGt7n7nhL4NzICDnwgkrnNPw6tSal4HjSYVqy4PrScyEXVKBmus9V4NN7Abbxpp0tHX80Kcd5HgDs+0N6nvJ28BfHJpApoIps+1FKAbTPH4eaJd82cDDPe56WI27d/zGR11Twtbpkq5Z0xkOML1SINiWbXHfKk7at9yGqMY1iK2qROu46CoBlq1gZICQVrLCxE87TrxgpAsiMgEWpc6e5hmbnUDMrXG/5lZUI2TS2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 14:45:05.8477 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5659f4-5eb6-4bed-c559-08d60dbe0516 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4219 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180829_074517_135659_A125CCD9 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , linux-fbdev@vger.kernel.org, dongas86@gmail.com, Bartlomiej Zolnierkiewicz , Masahiro Yamada , Stephen Boyd , Hans de Goede , linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Switching to use clk_bulk API to simplify clock operations. Cc: Hans de Goede Cc: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org Cc: Masahiro Yamada Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v4->v5: * fix wrong setting of par->clks_enabled v3->v4: * no changes v2->v3: * fix a build warning on x86 platform due to a wrong of the prototype of simplefb_clocks_enable v1->v2: * switch to clk_bulk_get_all from of_clk_bulk_get_all --- drivers/video/fbdev/simplefb.c | 68 +++++++++--------------------------------- 1 file changed, 14 insertions(+), 54 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 9a9d748..8d1fbd6 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -182,7 +182,7 @@ struct simplefb_par { #if defined CONFIG_OF && defined CONFIG_COMMON_CLK bool clks_enabled; unsigned int clk_count; - struct clk **clks; + struct clk_bulk_data *clks; #endif #if defined CONFIG_OF && defined CONFIG_REGULATOR bool regulators_enabled; @@ -214,37 +214,13 @@ static int simplefb_clocks_get(struct simplefb_par *par, struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; - struct clk *clock; - int i; if (dev_get_platdata(&pdev->dev) || !np) return 0; - par->clk_count = of_clk_get_parent_count(np); - if (!par->clk_count) - return 0; - - par->clks = kcalloc(par->clk_count, sizeof(struct clk *), GFP_KERNEL); - if (!par->clks) - return -ENOMEM; - - for (i = 0; i < par->clk_count; i++) { - clock = of_clk_get(np, i); - if (IS_ERR(clock)) { - if (PTR_ERR(clock) == -EPROBE_DEFER) { - while (--i >= 0) { - if (par->clks[i]) - clk_put(par->clks[i]); - } - kfree(par->clks); - return -EPROBE_DEFER; - } - dev_err(&pdev->dev, "%s: clock %d not found: %ld\n", - __func__, i, PTR_ERR(clock)); - continue; - } - par->clks[i] = clock; - } + par->clk_count = clk_bulk_get_all(&pdev->dev, &par->clks); + if ((par->clk_count < 0) && (par->clk_count == -EPROBE_DEFER)) + return -EPROBE_DEFER; return 0; } @@ -252,39 +228,23 @@ static int simplefb_clocks_get(struct simplefb_par *par, static void simplefb_clocks_enable(struct simplefb_par *par, struct platform_device *pdev) { - int i, ret; + int ret; - for (i = 0; i < par->clk_count; i++) { - if (par->clks[i]) { - ret = clk_prepare_enable(par->clks[i]); - if (ret) { - dev_err(&pdev->dev, - "%s: failed to enable clock %d: %d\n", - __func__, i, ret); - clk_put(par->clks[i]); - par->clks[i] = NULL; - } - } + ret = clk_bulk_prepare_enable(par->clk_count, par->clks); + if (ret) { + par->clks_enabled = false; + dev_warn(&pdev->dev, "failed to enable clocks\n"); + } else { + par->clks_enabled = true; } - par->clks_enabled = true; } static void simplefb_clocks_destroy(struct simplefb_par *par) { - int i; - - if (!par->clks) - return; - - for (i = 0; i < par->clk_count; i++) { - if (par->clks[i]) { - if (par->clks_enabled) - clk_disable_unprepare(par->clks[i]); - clk_put(par->clks[i]); - } - } + if (par->clks_enabled) + clk_bulk_disable_unprepare(par->clk_count, par->clks); - kfree(par->clks); + clk_bulk_put_all(par->clk_count, par->clks); } #else static int simplefb_clocks_get(struct simplefb_par *par,