From patchwork Wed Aug 29 20:01:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 10580869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 526E217DB for ; Wed, 29 Aug 2018 20:01:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BF552BBAE for ; Wed, 29 Aug 2018 20:01:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A2792BBAA; Wed, 29 Aug 2018 20:01:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C64302BBAE for ; Wed, 29 Aug 2018 20:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbeH2X7k (ORCPT ); Wed, 29 Aug 2018 19:59:40 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:37821 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727245AbeH2X7k (ORCPT ); Wed, 29 Aug 2018 19:59:40 -0400 Received: by mail-oi0-f68.google.com with SMTP id p84-v6so11397228oic.4 for ; Wed, 29 Aug 2018 13:01:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ixv0XfjyNvse1t/oR19mDsgqYhyJHApzPGYBfpF2zSY=; b=rY98Z45u4ZfSqYVrs7Vp2Ar0pAvZKdUg4O79UUGOymQ9RmqBP6oL3m2piim+GDAmpf 9toCK+v7T1wFra7G5I5I/fTM9eFdPNhFNMJhsI23AVoFO6TMyATVVcPMjO1S/HAyohzT iOYrtfj2ylx7iFAOnymXhCGXfgoixxPPjt8n+e7NhSXrv22+nquEX8uYsNORcOll+RV8 lIVwAqhXpwc0Mq8t2aBOGVuv18Viwks26eWb7BYp7CSJ5ialCJwUGGweUFc4F4qM6LWu A5VIquK+u3pjwnG5222U6uaA4c5g57C4tOQCSr6CHuYeYlg14j9sRoprQ5E3yJ9BPaup oCDg== X-Gm-Message-State: APzg51AUE0zQ3cZ18ULvwYzW6Nl1tOukX4ut6whc26LqjFareplBi0GO QMzprsd9+aTohseTD37fautyIwk= X-Google-Smtp-Source: ANB0Vda7m/GrSKgPw+uELdaXfzcn0Arn5lqh+6JvNYzmVqLAkolskcpkVH93/8cA0bQsefWlGzXE5w== X-Received: by 2002:aca:eac4:: with SMTP id i187-v6mr4396335oih.256.1535572873166; Wed, 29 Aug 2018 13:01:13 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id 1-v6sm2590337oir.19.2018.08.29.13.01.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 13:01:12 -0700 (PDT) From: Rob Herring To: Felipe Balbi Cc: Nicolas Ferre , Greg Kroah-Hartman , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH] usb: gadget: atmel: remove pointless retrieval of DT name property Date: Wed, 29 Aug 2018 15:01:11 -0500 Message-Id: <20180829200111.11891-1-robh@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The name is always non-NULL and then is not used anywhere in this function, so remove it. Cc: Nicolas Ferre Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: Alexandre Belloni Cc: linux-arm-kernel@lists.infradead.org Cc: linux-usb@vger.kernel.org Signed-off-by: Rob Herring Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 17147b8c771e..5729935c5eb2 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -2004,7 +2004,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, struct usba_udc *udc) { u32 val; - const char *name; struct device_node *np = pdev->dev.of_node; const struct of_device_id *match; struct device_node *pp; @@ -2094,11 +2093,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, ep->can_dma = of_property_read_bool(pp, "atmel,can-dma"); ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc"); - ret = of_property_read_string(pp, "name", &name); - if (ret) { - dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); - goto err; - } sprintf(ep->name, "ep%d", ep->index); ep->ep.name = ep->name;