From patchwork Wed Jun 12 11:14:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 889356C5 for ; Wed, 12 Jun 2019 11:15:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E55228870 for ; Wed, 12 Jun 2019 11:15:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B75628A12; Wed, 12 Jun 2019 11:15:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 850E428870 for ; Wed, 12 Jun 2019 11:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=aeXMfBe3DHz1Y+HGnERUkQ3n5I2Y/jUom9QH2jPcGlY=; b=l79UAj1qYloL7fftb3ajQ3UCq4 wsn5xsyTu0ynaDZcDw8uRxn9MypZwrAP8qYRtWEbl02QvbwzcpF16B5kKd/VFFPla18VMGxK6ZrJT rtfAWnB8AXHtBA66Yf8kb4nBm05HTaAGtvCxQmP7H+q53ZZEMQz1alDt9biO+TMgWHuwgQCOLOrNY gki8YE4HPTlP4nRv2Kwb8TSowpmUI4RmmB/ZzL3aXurTKRW4EKW8ZF/W5T7uTvTQob+u5Fu1VUdNw iUQAXPfwbIxi0ZQ4CqJFhyXUJC0Uk5o6ZvJ5ELhw8wa0OjVGTbYBDthedaBHhxoW5HoHf7F/GYYGf JMJ3FN7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1Di-0006Xb-GC; Wed, 12 Jun 2019 11:15:10 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DP-00066r-Km for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:14:53 +0000 Received: by mail-wr1-x443.google.com with SMTP id d18so16434811wrs.5 for ; Wed, 12 Jun 2019 04:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=NnFm9RoxHS8m0lojdUsIdKlkIcGlKRsn/Qls2kl7Du4=; b=vJ8MWs3xCAP10O+/tw+ajXf/Z9z0zjuN6S/iODK4BARmr0JqC7ItWkKbW+uJ99UCvA YeOQ5IezMKgR3fuYHyKHzHAUyDZ8HrCWG3+xIgNk/7FYSdLJoxPhJ7a0m9j5pTqD27gH nkNVzQVSGJ0vdDrjuSEgM7HrFL8BnqGggijp3gJkg3s372J38utK69Oeiu+1DllfJLYJ npIAWwBXk4lCJ5w+q779GctHtwfgbB2t/J3Nkugp3d4XClKjZZsVQ1lEhQe5PTWs1vL6 iCjoBvtzcD9ZV9EBGi4SyeTOFWqf+++Ixxi8tv7xdA671+urlkeYGAwbMxru+s26Vgoi OACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=NnFm9RoxHS8m0lojdUsIdKlkIcGlKRsn/Qls2kl7Du4=; b=eEfg1L0ZB3pl/qsT6FrbSTwB5DQ92V/gjnScVfMXkv5oClE30JgrklX+iLTWGiRWCI iMeGGL2i01xLxTaU4EsqWK6VvtPRGc6NabkolQ2j30Q9YRifPnRI4jvxznC7/LBUxo6a nwFJ+qQIYveGmyEyRcr6cvl1Ux5l19ZvcOUur489gyhs/s8w4yCsmShJrFX6M54HhZIu CWlcXJMlKBulLfovNghs0+3ue/CacZl3tJK1PqtKJdQQacQeoVZml8aCUrakA8MCEAv1 3U23HBIVLmVjgwUgPyc48F3EU87GlMSICzlEjBJdLFrzZVEPqVOkOnymjehWCb2K2zVD q1+Q== X-Gm-Message-State: APjAAAWwrMUni7PVuCzjOAWWXFRQtsCJYMV90wYeeZ2PIFYm1fCzxK8n Ty7+tRGfi1xCpk+z9aa6okWDUw== X-Google-Smtp-Source: APXvYqwbi8W/UYkCzMJLaCklKQBfeHAQMEcDaMqD7GdpzWuZQ8QpJkYincPYnwzm8UpBd5aiyruS6A== X-Received: by 2002:adf:fb8a:: with SMTP id a10mr18835589wrr.235.1560338089973; Wed, 12 Jun 2019 04:14:49 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id r6sm10675891wrp.85.2019.06.12.04.14.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:49 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 1/6] serial: uartps: Use the same dynamic major number for all ports Date: Wed, 12 Jun 2019 13:14:38 +0200 Message-Id: <6bacab58ca88dd08c766b571f19d0b26378099fb.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041451_696001_60C4B5FE X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Shubhrajyoti Datta Let kernel to find out major number dynamically for the first device and then reuse it for other instances. This fixes the issue that each uart is registered with a different major number. After the patch: crw------- 1 root root 253, 0 Jun 10 08:31 /dev/ttyPS0 crw--w---- 1 root root 253, 1 Jan 1 1970 /dev/ttyPS1 Fixes: 024ca329bfb9 ("serial: uartps: Register own uart console and driver structures") Signed-off-by: Shubhrajyoti Datta Signed-off-by: Michal Simek --- Changes in v2: - Fix typo in subject line - Swap patches compare to previous series - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 605354fd60b1..9dcc4d855ddd 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -29,12 +29,12 @@ #define CDNS_UART_TTY_NAME "ttyPS" #define CDNS_UART_NAME "xuartps" -#define CDNS_UART_MAJOR 0 /* use dynamic node allocation */ #define CDNS_UART_FIFO_SIZE 64 /* FIFO size */ #define CDNS_UART_REGISTER_SPACE 0x1000 /* Rx Trigger level */ static int rx_trigger_level = 56; +static int uartps_major; module_param(rx_trigger_level, uint, S_IRUGO); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); @@ -1517,7 +1517,7 @@ static int cdns_uart_probe(struct platform_device *pdev) cdns_uart_uart_driver->owner = THIS_MODULE; cdns_uart_uart_driver->driver_name = driver_name; cdns_uart_uart_driver->dev_name = CDNS_UART_TTY_NAME; - cdns_uart_uart_driver->major = CDNS_UART_MAJOR; + cdns_uart_uart_driver->major = uartps_major; cdns_uart_uart_driver->minor = cdns_uart_data->id; cdns_uart_uart_driver->nr = 1; @@ -1546,6 +1546,7 @@ static int cdns_uart_probe(struct platform_device *pdev) goto err_out_id; } + uartps_major = cdns_uart_uart_driver->tty_driver->major; cdns_uart_data->cdns_uart_driver = cdns_uart_uart_driver; /* From patchwork Wed Jun 12 11:14:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE3C413AF for ; Wed, 12 Jun 2019 11:16:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97E191FF87 for ; Wed, 12 Jun 2019 11:16:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8C39628A2E; Wed, 12 Jun 2019 11:16:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 865291FF87 for ; Wed, 12 Jun 2019 11:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YXHyRE7LlsFCiaW4Rel+M2MUP1+qMYBzFZpb8Fy3mu0=; b=bgDsG70/HbzSClbtZwRJ8UkRNM 4pYjHSe1itrKXkbl3AVEi01Pvkuq6ynqzBWbr3y5f21Sfmz5gPp1SH7xFaX20r2MHIBmDfiKRmUTK WXLzCTv1GxKMNqNF9kcuGDWaQd8KE1sgHZSsiL485he8tyRH8p23+5pcaJ/YEXr7ooYqI02P8GmQq Hs7eCbONQ7/KX1wiOtW/Y9qxkaWDTuE211F/mfxY/eq0K3BcIRcPfVSpcVmo3ccs1LSJ9Gh89jHwG TqUGssdnYB/ZxFW8BJUjx2AwaSTBIqdJ4vP4Q/mXZ01NKRFI/Vw6fbJH7gii7GY1VjcTgBOZpnKT0 HFmZwgVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1EF-0008DW-UI; Wed, 12 Jun 2019 11:15:43 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DR-000699-NG for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:14:55 +0000 Received: by mail-wr1-x441.google.com with SMTP id n9so16498856wru.0 for ; Wed, 12 Jun 2019 04:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=pL4z/swoTMwbTbMm+CZTE8PZN5IahPwWK1oKgA44Jw8=; b=P6xquQrececmcvLrvYX6swykHVbte7Nk4tMjJVlxC/IGkE5po85UR/FmEjTmBnjHBN 7UXsptqBv4hijV+N6F7edAiOxTf+ZQZme0r0cEUHESbi9S7GOm+OyYpIq+HZMZ7IMpaq 6ch1uIpSIvD6d0ZiSPH22yyqoPcWc7c9wkfkEyGcRJ60ehHz5PhiMhayyoZbvOGsBrxQ bZ2LzFT48JTUjjm41S5ZNe7RbvRK+iVQuVV4NibXS0K6W/FVhfanPVOkDruhGfEIqS47 1jK4ZdVTE3QhZyH/G2nPRAGWdjbcedgLKigKS00FyWB3fRstKP6kgEUlfiNPaDWDxIQB SlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=pL4z/swoTMwbTbMm+CZTE8PZN5IahPwWK1oKgA44Jw8=; b=Dw8y7FrQFX540fNN2TRRFla/vsFEe/uL8hBLUWrL37yjvNwYpPI12eeHewjQPnsjWH Nm4TWqqFhrJG4zVLrn8M4OhnxwGmv5MD9AzMutc3AG28UzIEzwzhgOxq83ObCn1Cyg2s tREuUoTLCZAgVKW89n641/11d2DsYx4VqdpumzmqfICDGjmRxnnCErpOkNWFiItEhbXR bd4qGUYZ0MqihBchXjWYzS+V+M5//ns4wUSspHC+JbTAgvjD6uUO6N7un0jLILboWtXI OFcMf7ye+pAzNqhl8ykKRCZ4x2K+Py7IvxjLoSqkb4e6ZxULOomD1vHaOJxVDI15i6wJ twJA== X-Gm-Message-State: APjAAAVK6F/ZIa7mOdi1W744uQXQdQOaDNv6qtvvUfbTY4niQJehYJ2v LtwaDaSPpMuTQp6htwEYY+MfLg== X-Google-Smtp-Source: APXvYqwF+qopOc/h+NW4uHI2iFfpMRXvQ05mIybiixrrOldDG1ljO4J1jrhB5kuhJ/jptlEuRoQ9rg== X-Received: by 2002:a5d:4ac1:: with SMTP id y1mr1818664wrs.183.1560338091629; Wed, 12 Jun 2019 04:14:51 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id y2sm17676131wrl.4.2019.06.12.04.14.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:51 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 2/6] serial: uartps: Use octal permission for module_param() Date: Wed, 12 Jun 2019 13:14:39 +0200 Message-Id: <159139864be4ab81e75f20f7fdad604ce270f8cf.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041453_763148_FE539BCB X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne Octal permission is preffered compare to symbolic one. This patch fixes checkpatch warnings: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Fixes: 85baf542d54e ("tty: xuartps: support 64 byte FIFO size") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Fixes second S_IRUGO usage - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 9dcc4d855ddd..c84db82bdaab 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -35,12 +35,12 @@ /* Rx Trigger level */ static int rx_trigger_level = 56; static int uartps_major; -module_param(rx_trigger_level, uint, S_IRUGO); +module_param(rx_trigger_level, uint, 0444); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); /* Rx Timeout */ static int rx_timeout = 10; -module_param(rx_timeout, uint, S_IRUGO); +module_param(rx_timeout, uint, 0444); MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); /* Register offsets for the UART. */ From patchwork Wed Jun 12 11:14:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 252851708 for ; Wed, 12 Jun 2019 11:16:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1154B1FF87 for ; Wed, 12 Jun 2019 11:16:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05EAA28A2E; Wed, 12 Jun 2019 11:16:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AED261FF87 for ; Wed, 12 Jun 2019 11:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4U8esPvKfCfUD3Rx7MzlPHELDrWtSJ+EEk8+XtkqogU=; b=e+/uVEZyw9cLwmvbxaxQDW1hmw zJLmk13nJrDtSSquv1R99iNwqNZzjnPqgVhbCdPr/+GZHTL9rXkDrgUUzMAtrjK0pf3Kv4F8xkmg6 +FNGyVIqYZYHA9LaCpdgwPgJoUeHHmiJsY/fVICN+ISqznAyCHWu5vadRrXgtT8Qb9MvZmZX/kpeI ESskFoELsztCqz/0YGz1lUG6vG/mTM+rUbkEzYKelwfpnLneKWsYfwctkEwrw4bW3x5QnU+JLDGuu d3QIqep6cBO0gPena5gcZfo+cNNz1S/RmFaG2m+K/DJrR2FzCYKmisU0tb/6k5yy0wPz0doWbHXHI wOsmt57Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1EY-0008SV-2d; Wed, 12 Jun 2019 11:16:02 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DT-0006BA-4w for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:14:57 +0000 Received: by mail-wm1-x343.google.com with SMTP id c6so6119054wml.0 for ; Wed, 12 Jun 2019 04:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=RX9kf328gim4qTbNApKo0P/QFvgZZ5niZju8LY4fMbw=; b=RlNbC4v8AQPmlZyHhHsjf3AqOF0nCui8MGbGfB153yQHQOxseZbCxE0QMP/j/ohMQx ubuXlfJE9JC6bcuD7MXezh0pcQ9Vxvbse8B6PBLdLZeik3ydqmdEVYWByfIegFIug0JI 2rytqyr3HAgqTNiaQSFhmbVXFtGd22lz/fONwnA+eHCGfIiuyqEqvDSVy7e+kJ9asdDf /OkIFO7eGS9K6+12vteUCFt3vOWn1M003QCmhSkU4icWAQXTY3ntEVUrviQ3UVLencga yXXSpsfU13FjIDGHaTwCcvTsWo06MtZqUXWmyFM2XPRxdL0wub+wZXIWCVaWWlBQo9yc /img== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=RX9kf328gim4qTbNApKo0P/QFvgZZ5niZju8LY4fMbw=; b=Mz++5VBZbePlAHfNacqe0T9UdxK+4gEmscP+LpK6NokYd5FWz1ZrYhADAy+QuhqhX8 Lb6NSRL8ev9PdVRUAmq4l0M5n+pJwasz0bhkQxAxrujyWCejF/Ry7OFacyS11nd22SbX m1KjvY38WKfsGvGHbC/hmbTdJQGzFC/lNKax122jaI3U3OvZDgISYMnYetE7viG7rxUr xn/L0w+h9fJ4k7Ik2l6Bqb2nEOK41HWWT2YqTIH5VSeXbS8puhsIZYHQvKZy+Os116Fx TeG5WbqVXzPF7PiTa+TLCaq+aB2MyAN6ZfLtcYMhzmsbKnD48CacXS8bAwM8PQQjvXEj IRPA== X-Gm-Message-State: APjAAAWKPEcHsBl0zieFcNEJMkNpw/f6TAG7h5Y9/O0V//o8cV/7ktWZ SqaJtosp4OmyDunDdFzGqmSzXw== X-Google-Smtp-Source: APXvYqxfSaq6CTixvYxa76VBxtjwsDr/CJ8DUniRUVH+idG29OzBqKzhBE3pa8Y9Mws4pqelMSUz8A== X-Received: by 2002:a1c:e0c4:: with SMTP id x187mr20735822wmg.177.1560338093505; Wed, 12 Jun 2019 04:14:53 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id u23sm5055140wmj.33.2019.06.12.04.14.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:52 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 3/6] serial: uartps: Fix multiple line dereference Date: Wed, 12 Jun 2019 13:14:40 +0200 Message-Id: <3a5b27987c5b4fc5ec7dc7f58485db63057edbfe.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041455_883582_AC2ACB16 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne Trivial patch which fixes this checkpatch warning: WARNING: Avoid multiple line dereference - prefer 'port->state->xmit.tail' + port->state->xmit.buf[port->state->xmit. + tail], port->membase + CDNS_UART_FIFO); Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index c84db82bdaab..4cd20c036750 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -319,8 +319,8 @@ static void cdns_uart_handle_tx(void *dev_id) * register. */ writel( - port->state->xmit.buf[port->state->xmit. - tail], port->membase + CDNS_UART_FIFO); + port->state->xmit.buf[port->state->xmit.tail], + port->membase + CDNS_UART_FIFO); port->icount.tx++; From patchwork Wed Jun 12 11:14:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D97613AF for ; Wed, 12 Jun 2019 11:16:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDD771FF87 for ; Wed, 12 Jun 2019 11:16:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E21A928A2E; Wed, 12 Jun 2019 11:16:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 91FD31FF87 for ; Wed, 12 Jun 2019 11:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gF3E9ckB24uS4qFlFtYURX+drrV2k83aBWGL0/yF9B4=; b=f9xiTFniQj1tGMZjMN7GAW7Pzm Gu5db4XkNTqJne8yW2YFCJ00z7OL9cNKwDy51gKyfeiBjPkuxWUQZ/jPR0bR5RcHU/+g5TK5iV2WO 2w3p4iXoZD3glyLDXEdXjHC4h6VtegFABOlizIAMVRxx3yXHBYVLiD951Yghu5vEeluau3ONS+lmv aBjSZGr4W/WA4hUGcCy6F3/RmE+wYJB5ei6yhnO8UUMOmGtkbOGcupnKw4fk4NBVGh5H+7lUtlS7y LlBW4u+bHaXyOfYY5EduRgNnsuZvnLWA+Rze1dR9/IbRGRtJjtrszqs8Lm0FAsrvyazrJ7KE9UD6b 652nHczQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1Ei-0000IL-14; Wed, 12 Jun 2019 11:16:12 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DV-0006CN-4T for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:14:59 +0000 Received: by mail-wm1-x342.google.com with SMTP id c6so6119140wml.0 for ; Wed, 12 Jun 2019 04:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=bYhm6q2mQOQHxwpH1cNDyslfzzaeNb5NDBbPExBr2hU=; b=gUz4s4x3wAGkHBCidbCda40ZHrM+oc5MtKFf8IFar51RKlJuK1zOLWaojoQZUxDrdT w5897ogwbbZPOnHWEZrig35pkYl3fmCEvcMf0ROCNClQ9Q8hml1Adv3IMHjMickCUPwU 3UaHIWLyQmnprriSbA06WUAowV1Uuq+/7V7dhatbGWhVC/GXDc4o7CXsGZ3RsEWZGWMP vt2hylAoq102zrYvnqKX1TUeoOZ3S5M0L9icqq1CuDzPFeCuahixzClKF2/ooA1+TXV0 aTRhJzAKqP5JG4oPxNYGTOUwo0Ewgn159jICgnUkhW+8i72KHQCQ6i8tkDVmxmJDEe0o LU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=bYhm6q2mQOQHxwpH1cNDyslfzzaeNb5NDBbPExBr2hU=; b=Hz1bjCCcwx98ObgvLiSmlGevGXbuNkJ15wYBfaZG62+YzkZqkk7k4nzN2Npx2s/NqF e3OY/C6Xh6FOTkVXQ9LVSg8XRuKaxV6ubtIdtGYJHpb3jV4dKZ2S3aLn4qY8m63xncpv f8xDZvqoNOfXdxUWr3q4Yw2YEjHqCTTphQ2yOEba4SQt4zWa/X8HrDS1Q23CW6xJuXBj 8cQF2x7TsY4HC2QlejxPkolNJMdA1qv6AxiP6HOOftvQYCO9l7T0Gi+prq9pkQdJUFZV v5T56fbLtPjocPJ8paApnbLbMDVF+yL1AF2/isYc8WZKADlQVoR7JbvRfiTprT634xn2 YISQ== X-Gm-Message-State: APjAAAU+pUytQmufH3SAuHEKO2TS2Au0stUGFtBfj++u8ow542AzAGn1 VYQCJ9kk817xkGxMG1hFTyW/G3vuJ1BTTw== X-Google-Smtp-Source: APXvYqyGMKCnljobGJkFGV/NdFNdLPAxnN5nwF08PzReraHvnNcveanzCoORDBgv7OzKCjvRD9L/bg== X-Received: by 2002:a1c:3886:: with SMTP id f128mr21530360wma.151.1560338095263; Wed, 12 Jun 2019 04:14:55 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id d10sm19536766wrp.74.2019.06.12.04.14.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:54 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 4/6] serial: uartps: Fix long line over 80 chars Date: Wed, 12 Jun 2019 13:14:41 +0200 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041457_213371_35D09D26 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne Trivial patch which fixes one checkpatch warning: WARNING: line over 80 characters + !(readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL)) { Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 4cd20c036750..c3949a323815 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -312,7 +312,8 @@ static void cdns_uart_handle_tx(void *dev_id) } else { numbytes = port->fifosize; while (numbytes && !uart_circ_empty(&port->state->xmit) && - !(readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL)) { + !(readl(port->membase + CDNS_UART_SR) & + CDNS_UART_SR_TXFULL)) { /* * Get the data from the UART circular buffer * and write it to the cdns_uart's TX_FIFO From patchwork Wed Jun 12 11:14:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 26B1E6C5 for ; Wed, 12 Jun 2019 11:16:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D4141FF87 for ; Wed, 12 Jun 2019 11:16:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F33C028A2E; Wed, 12 Jun 2019 11:16:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A522F1FF87 for ; Wed, 12 Jun 2019 11:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HDVu+4gn4MTKBeqjWYjVRkAW3ZI7pJJFrpPtEunwM8A=; b=HLnOBIUZY/MJaqCu9PnezYM++2 7nVQHdst3vR6fsS3L3AvwcS7WrJ4FWize/UrWC5JND/hmUamnmON/qjpvNFG9qt+8S2/o8hPDGvCy UCvixQNX3tge6E516DC+B3a7KtUIOgJamtvWqUz2AwkDco/eNVjA8gC8GjCu6BGuD/wmPESyay2md ORNUIQZg7V5cFEwhSS+IF5qiM8tuPUD8qWXVPYmunaQ0mJZ7vNvVB86/JQn3qlzZ/RdNZ6gDLlt4e khIKN8HAdGSNqGDMPHdm3yVHPHQtmvAAnPz5ImGVJxL/NOW7YnwtqkRs3ydz5O6LZqHaiFm+oHKqf BAuU7U3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1F3-0000b3-QR; Wed, 12 Jun 2019 11:16:33 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DX-0006EH-30 for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:15:01 +0000 Received: by mail-wm1-x342.google.com with SMTP id z23so6091714wma.4 for ; Wed, 12 Jun 2019 04:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=JC6Q8CjmGdxzS1r/l1ugJJUHGuJAio4YE7r12Sbrm1Q=; b=dfHnZnm/KeAKx0Y53W8U+Gve09GK0RsLcHKGzBp8skf8dieoVp+3rfiL2YnQayFHcb Lkfz1A+SwK7w+BUs52YV74L3fZLP3J9loLnVg+o9gWVgFH0oSAU6JzR3FOXHo2SkklyO s1WZEV1YfCDAmEPtAm3S/PpyLCfDN8f+/eiUzFsjKKNirIBLFta9bZocKUHJW3iuYWXk Kvz+A4Ujf8PryyBkA08Z4eCmgbflrI4pyjgutp3y8C0zfcrFW2FNAaPnpCkrMY3Tw/ly enYA/42NpbShVA/yMX21VKyJWtjCP4rreyRiWs0ec1wfiByCbkYA970s8PpE6ujeb/pq wq5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=JC6Q8CjmGdxzS1r/l1ugJJUHGuJAio4YE7r12Sbrm1Q=; b=Gq9wGxFYo+mmtBsex5LNMmgYainvA9SXR6WzKkYUGrn2fK7yYjpWlDRX50omYJRfl7 9Tl3QHEZ10Fztqqil34/gtN7S7fZmKZ0KxVQP1joG2DxjIcHE+VZlfSIP5QBXM0NypOT fn5ZYD5qh30S6fFeN+o6NXbakp6u9uACr/Pb9kcdX/XzjOCbcBIa279ydJRzPN3ZTwDd z4d2haNxCY4DpAohYnym0yhMfHiH1Z6u96hgBcgP/yyrM7vSlIGG07TwYfBzxSOVa7QM PYAprF2/jEXSeaq8ScsBe5mhi5TFxIyGA1Hak1TSQ7SkSnCsFB0b77xDzmuzl3HDWoPv U6Kg== X-Gm-Message-State: APjAAAVXZjW9CEJeykYtsXIBKtpQiykBKCzBTx25YuL1sEy3JjO7bll7 lS9kZ8nvtpipknfTqPR1BXKUNQ== X-Google-Smtp-Source: APXvYqxhsrtt2KXOawEWbugdsCleP2uygG0LIu+9qXaDXVByC4OzGpQkIVhgSA12n1EyQRy68HBOsw== X-Received: by 2002:a1c:3d41:: with SMTP id k62mr19765359wma.61.1560338096902; Wed, 12 Jun 2019 04:14:56 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id j16sm38159921wre.94.2019.06.12.04.14.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:56 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 5/6] serial: uartps: Do not add a trailing semicolon to macro Date: Wed, 12 Jun 2019 13:14:42 +0200 Message-Id: <5d938d34c3c4710577df898dbf4b70c74d2e6730.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041459_258938_962C14D5 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne This patch fixes this checkpatch warning: WARNING: macros should not use a trailing semicolon +#define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \ + clk_rate_change_nb); Fixes: d9bb3fb12685 ("tty: xuartps: Rebrand driver as Cadence UART") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Add Fixes tag Origin patch which introduce this semicolon was c4b0510cc1571ff44e1 ("tty: xuartps: Dynamically adjust to input frequency changes") --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index c3949a323815..d4c1ae2ffca6 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -199,7 +199,7 @@ struct cdns_platform_data { u32 quirks; }; #define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \ - clk_rate_change_nb); + clk_rate_change_nb) /** * cdns_uart_handle_rx - Handle the received bytes along with Rx errors. From patchwork Wed Jun 12 11:14:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10989489 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 50B8F6C5 for ; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C1B91FF87 for ; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FF2E28A2E; Wed, 12 Jun 2019 11:16:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B013A28A2D for ; Wed, 12 Jun 2019 11:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=339CYgs/GB54ZA5noSRLmi/hWSGKOf2TxuEIf7ODFmY=; b=qnqcKcxWlDoVJVj6fnwW2egFFr KpsZP/iFBKTLO3flN32w46uSVWUZpsvoJMoRMsUrZpuYVHpPfNIICv+9/zQqiNC3qIFIlvfvgjt8J xAdV0rSkNeLcirCLHcZuzroTDilwiFW7Oyz8MGyEKxse6AOUgBQ74JYcPWkzDQtM3ppymPpcTEoxQ tEarbYXHDGmnHb0B99h5xQY4fGY53wlvdq8Z5gyv1ySSLPR7EVXbI2clMEpYWYaZLdPCXBY4HOAog WD0eeMc2F22VHspph1sbOBNgh/bb/sWCHPZFv/5TYb41v3E8nyDh/EIpXkRbpjW23K5Q3l0/SAog5 wCGYl6Ig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1FB-0000mP-2S; Wed, 12 Jun 2019 11:16:41 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb1DY-0006Fg-Bg for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:15:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id a15so6118180wmj.5 for ; Wed, 12 Jun 2019 04:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=N7TfMirow0WLkJ8Qk5sTGDNuiXjkVvo5PhKfS+WN4/0=; b=TvHkcos3aVvBmtDnRVLiF8pREYuprtIOehZYrLYdAyjZP7EdbPz6anRT6UL2bn+1lt iRSNcVbOmYQ+kkQ3JbVs1+N1QXgzSkLX7YOg4L2t2XY70f8q+rjIVRsJ4twJwhJN5UVZ 5vJXv8Lim0Z9xob8xQk0ZvGfB+Z70kXkXVtj9Vo9sPNZX6nj6jRDgEYn1CZRGWviaBdS 8d2kZlRPWm/+iACF30dR/3uZm/5FVD9NxZ0mvNShAZQiO33Rxhr5EDslpWhYAWS2n20q sZ86aP63QHnIW66uQRUQxsSNaaLrpUhja+T3uqyEQLfK6EbRGrP9SJ6Yvc6TpIiuxChN 7asQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=N7TfMirow0WLkJ8Qk5sTGDNuiXjkVvo5PhKfS+WN4/0=; b=pMiIYfQ296067pumwetXYVbAbEOQ1Lb/u0ReP9ms3sdyLaqd6B9+d9sdO520QfwQ2K vtkP77Djix9r1xOTZiHRoSFX+QbfFUyYlfycL46vXvGkdIWofncGLqAjjjkcycaRzJ2E se0vAYuPgUsQGfhmWvaYf7JCBHZQNgky5h0BIb06lIW3nPAMf+u87iBSAwj76k/qIPjF AmRboH3RfT1kNAW/L0PrugwJ9jS6Rs8yRYDlM6wlTaSgdf+Vg3SCB4r2m6OV11wJgbQx BMGSvtVKzpv1852BPvg4IEP44y2kjtX2lqovV9By1GBQWdJyqQH2wjcPI5PI1yJY2vXY bh5A== X-Gm-Message-State: APjAAAXiqT29rTiabRltw9xaj/d9TT1x6nykVKQaI75xNX6sl/XjABfZ Hlds9+9H5e4Jb6VtR8fYw0jamg== X-Google-Smtp-Source: APXvYqxDqteBduXIGovJOsGxQCU7BEXqUQmBQgzI25tvhIXaofsgXxbwQoEvBU7rTYV1bD0qZFpatw== X-Received: by 2002:a1c:1b81:: with SMTP id b123mr21041986wmb.144.1560338098580; Wed, 12 Jun 2019 04:14:58 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id g19sm6514083wmg.10.2019.06.12.04.14.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 04:14:58 -0700 (PDT) From: Michal Simek To: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com Subject: [PATCH v2 6/6] serial: uartps: Remove useless return from cdns_uart_poll_put_char Date: Wed, 12 Jun 2019 13:14:43 +0200 Message-Id: <19a9f67770e1896dde57d94b093273b503610eef.1560338079.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_041500_582413_99974FF0 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nava kishore Manne , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Nava kishore Manne There is no reason to call return at the end of function which should return void. The patch is also remove one checkpatch warning: WARNING: void function return statements are not generally useful + return; +} Fixes: 6ee04c6c5488 ("tty: xuartps: Add polled mode support for xuartps") Signed-off-by: Nava kishore Manne Signed-off-by: Michal Simek --- Changes in v2: - Split patch from v1 - Add Fixes tag drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index d4c1ae2ffca6..bcef254fa03c 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1074,8 +1074,6 @@ static void cdns_uart_poll_put_char(struct uart_port *port, unsigned char c) cpu_relax(); spin_unlock_irqrestore(&port->lock, flags); - - return; } #endif