From patchwork Mon Jun 17 16:32:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10999767 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F33814E5 for ; Mon, 17 Jun 2019 16:33:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F4B2288A0 for ; Mon, 17 Jun 2019 16:33:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 734DC288E5; Mon, 17 Jun 2019 16:33:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A3562288A0 for ; Mon, 17 Jun 2019 16:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nVcnvKZradULKjSzTDQMivrJymIXSBUOiE+NvbUvIsM=; b=BomG7NbdoZOWLV alhM29GcYqkIsi335Fafg6JaBYVaZLBExkxw9dUORrGIOmfecOY2Rp6Uvl+cHIpWv0+zFOPykWl6z Zbn4x+1wi6DPEgwUvoKBjfna0eLYPVWJTZyuybODluU8NSVk4WfPqp2W5H6jhmb4MfFvv6VaFxm6A 4wU2cq4LAYRiVuTSaDQXz0+pa61jEdx46iXyifN6TAvXXYFdjkldqOWP024/kaB7eqvZF9X5Pg98o 2Pa7zNIdeIMZ/OjrO2zGxUYWZCA/yvbnWRk8/9SlKm0ZKbHbgRkXoupvx/eW9m9pvWhRHCt/8rliJ h2Qe3Qmt9yqCWwGoitEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZ9-0005pJ-Ov; Mon, 17 Jun 2019 16:33:07 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZ7-0005nx-GR for ath11k@lists.infradead.org; Mon, 17 Jun 2019 16:33:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8B0E260F3D; Mon, 17 Jun 2019 16:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789184; bh=klJ6od96N7bpOtWTOjbZzGtPlL1QBzjHQKAJ+iJ3r5M=; h=From:To:Subject:Date:From; b=Nvn6JE4CP+mm1/PP7SkHT4c64YQHXPCWgrZlhLx3WLzzvzRUhp+qzTHNRZt7aeRA1 eiovUXoKgANcnt2xuEGyHRtkPtcOnl7vGuVwKgT1pybu9fxYrfjHqh2SMIzFyV4nBk D6WIxUGw+O8uG9PJZJdX5hNjnnW4IBwXAdeJmpk4= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E718F60C60 for ; Mon, 17 Jun 2019 16:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789183; bh=klJ6od96N7bpOtWTOjbZzGtPlL1QBzjHQKAJ+iJ3r5M=; h=From:To:Subject:Date:From; b=XOsN3MP0XR++M7wx7XGSXurshOy8GMeNFVWhQ6op925BcK8WpgF6bxVBUhvFH3fBt W4AXmjlptwJ4gNXjp/972C4vUbsI4ZBXa3GjuOw4eW37stn7EAsp0A5Yy26Xe4HRWP XHCxMqyLjpkQnjpB78gOcGzuf3PEWCHHWff4NudA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E718F60C60 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath11k@lists.infradead.org Subject: [PATCH 1/5] ath11k: 'static' is not at beginning of declaration [-Wold-style-declaration] Date: Mon, 17 Jun 2019 19:32:55 +0300 Message-Id: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093305_562296_24A91923 X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix gcc W=1 warnings: drivers/net/wireless/ath/ath11k/mac.c:5375:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] drivers/net/wireless/ath/ath11k/mac.c:5380:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] drivers/net/wireless/ath/ath11k/mac.c:5386:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] drivers/net/wireless/ath/ath11k/mac.c:5392:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/mac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 919668967ef6..ab71e121e107 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -5372,24 +5372,24 @@ static int ath11k_mac_setup_channels_rates(struct ath11k *ar, return 0; } -const static u8 ath11k_if_types_ext_capa[] = { +static const u8 ath11k_if_types_ext_capa[] = { [0] = WLAN_EXT_CAPA1_EXT_CHANNEL_SWITCHING, [7] = WLAN_EXT_CAPA8_OPMODE_NOTIF, }; -const static u8 ath11k_if_types_ext_capa_sta[] = { +static const u8 ath11k_if_types_ext_capa_sta[] = { [0] = WLAN_EXT_CAPA1_EXT_CHANNEL_SWITCHING, [7] = WLAN_EXT_CAPA8_OPMODE_NOTIF, [9] = WLAN_EXT_CAPA10_TWT_REQUESTER_SUPPORT, }; -const static u8 ath11k_if_types_ext_capa_ap[] = { +static const u8 ath11k_if_types_ext_capa_ap[] = { [0] = WLAN_EXT_CAPA1_EXT_CHANNEL_SWITCHING, [7] = WLAN_EXT_CAPA8_OPMODE_NOTIF, [9] = WLAN_EXT_CAPA10_TWT_RESPONDER_SUPPORT, }; -const static struct wiphy_iftype_ext_capab ath11k_iftypes_ext_capa[] = { +static const struct wiphy_iftype_ext_capab ath11k_iftypes_ext_capa[] = { { .extended_capabilities = ath11k_if_types_ext_capa, .extended_capabilities_mask = ath11k_if_types_ext_capa, From patchwork Mon Jun 17 16:32:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10999771 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 84DB61580 for ; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 799C3288A0 for ; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E002288B8; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 87641288B4 for ; Mon, 17 Jun 2019 16:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bjz88iSABWHz5FJG77HyG8V+bOmn6ALfVYse9cgUcdU=; b=DMc6dVCIbz5f3o s6Oe8uCnUOU4zO/ODeViAxtN0dQNv3KLHTEKuRQXwA9iH5xjSTkoAWi1jzMR+etJAN/9+GRrKpO1c 92lKn19EogMcPZl0IkwVLHPy9vTCLH9OPC810JhLUMLgzXrDm3HJ1jIbaKuZvH0SB9gANQLpdzM++ jBYUjft3gn8UaQDWLvRWebOmNqZ3hcAkevVdLipmd4FB5eXfxJwb2njO42PLHjigQlwI3BmdXr3NC d3GbVRoo0foxCISeCNpUEnQzo03La2KbQ1oYp/Ln7fCFa5e9n6VJMzbo59Zp5He2ZfOeqC+x2fZ8x 7ywO/UoVqoWjHzSFcMQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZB-0005qG-64; Mon, 17 Jun 2019 16:33:09 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZ8-0005oD-L5 for ath11k@lists.infradead.org; Mon, 17 Jun 2019 16:33:07 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 149B460F3E; Mon, 17 Jun 2019 16:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789186; bh=Agq0fS2PRCtJFqDIv9pKqvMRnA07qdntSbM5aUzvbYI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Z8LJNRTfp0ada7egEUVv31UeoAvHmIv0PqVU+B280e0/kKB0cIGuCReHSkLYB5UUD E4nJJIOiivLYT+x2y4qa5ntUPL4ugPhx/gUijqRSYf3M24vLI5ANdBzGH0KJiVH1io ioDL2DMkd7rfmub/oNon/KuwZEPi1rGDbIPEBfh0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 48AE5607DE for ; Mon, 17 Jun 2019 16:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789185; bh=Agq0fS2PRCtJFqDIv9pKqvMRnA07qdntSbM5aUzvbYI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=iLgW9+xpb8KZKR7DnHiyzsWl6GVakpR8HOrGTj1pbpt+0s4SJha0dJhIkXuCKj0Oi kE2UL2swPWrJYYEzYuriiGhKiAMXHLoZSdhgQ3nEH/HE8GkolHsNnf9SdRoqpN9Grz NY24WAonYBN3yLpwyXF5KXerV4OIMlCofmynd5Wg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 48AE5607DE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath11k@lists.infradead.org Subject: [PATCH 2/5] ath11k: this statement may fall through [-Wimplicit-fallthrough=] Date: Mon, 17 Jun 2019 19:32:56 +0300 Message-Id: <1560789179-3857-2-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> References: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093306_731453_C442FD3C X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP With W=1 GCC warns: drivers/net/wireless/ath/ath11k/core.c:757:14: warning: this statement may fall through [-Wimplicit-fallthrough=] vers/net/wireless/ath/ath11k/mac.c:1332:25: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/net/wireless/ath/ath11k/dp.c:133:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/core.c | 1 + drivers/net/wireless/ath/ath11k/dp.c | 1 + drivers/net/wireless/ath/ath11k/mac.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index be4f86a0f83b..26fdcb161965 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -755,6 +755,7 @@ static void ath11k_core_restart(struct work_struct *work) break; case ATH11K_STATE_RESTARTED: ar->state = ATH11K_STATE_WEDGED; + /* fall through */ case ATH11K_STATE_WEDGED: ath11k_warn(sc, "device is wedged, will not restart radio %d\n", i); diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c index 0aec840fc360..be10e98b0bcd 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -138,6 +138,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring, break; } /* follow through when ring_num >= 3 */ + /* fall through */ case HAL_REO_EXCEPTION: case HAL_REO_REINJECT: case HAL_REO_CMD: diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index ab71e121e107..fd133813636e 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -1330,7 +1330,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar, arg->peer_he_tx_mcs_set[WMI_HECAP_TXRX_MCS_NSS_IDX_160] = v; arg->peer_he_mcs_count++; - /* drop through */ + /* fall through */ default: v = le16_to_cpu(he_cap->he_mcs_nss_supp.rx_mcs_80); From patchwork Mon Jun 17 16:32:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10999769 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 56D1813AF for ; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B0A9288A0 for ; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F41D288E5; Mon, 17 Jun 2019 16:33:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BE089288A0 for ; Mon, 17 Jun 2019 16:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aFfJtPNrCr/T2NjHo+SeCJRJSQmh7FQ6LtHvYlXLiQ4=; b=FAyrY7w3UHnSj2 zD01nzBqxceF0m3/0dyK9C6R4dnj9D1x5OIsSE6+7HEQu3RGRF05jkldaBeGRiizGi5JuqML+Lak+ LTA1XTcFbff55ZPT3xzYHoyjZvbQFuUHU4KcIs3RKhCYrQ2iA3JYsdiGKwagkNCrKTabLFZngCjZ/ Az98aGua+DOn57Ym/KTqDENyuCTjHdenYTTGNRnaJzu5zzX57YFghJlhJ99U0e1V+pKS5X3mMpfBq pWD3yB3TY2ur3HLvyKtnx9dp/E8a7JhDsDwTE36aSm3XivzCEtRTMhnIqUAU/6thz1mZFQOAlBzsI QJWwW9CVjsVzrUdNPbZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZC-0005rG-HC; Mon, 17 Jun 2019 16:33:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZA-0005pn-Av for ath11k@lists.infradead.org; Mon, 17 Jun 2019 16:33:09 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C116B60F3F; Mon, 17 Jun 2019 16:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789188; bh=bM69sI61Cl6Fhsmz00lgoEozXTQF8UVHZ5KPAGXumf8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=WFlgjfo4mAK/Xtp0occTneYOwQRGpXzSmeO33Csvkc10yH89vUN1dPZkjxfbihPQn ILy/L3r5iAMle5MCvbP27RtnEViDo0fIVUesFvLd3uZEps8KPKfIuBHgLnb9po7JOL 8HZMU3P8R41My9jPOt/oPL46EUh7b2bex95xqutY= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C15C960CF0 for ; Mon, 17 Jun 2019 16:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789186; bh=bM69sI61Cl6Fhsmz00lgoEozXTQF8UVHZ5KPAGXumf8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DFFrAA/rS18abmxBAzD3TKJ2KIDr8/Pk/d59D1jmF99LSV7S41zlcXpq9yijUsGak pt+lA+O6wfexBPMGUOpK37SbG99uWVOXJ9t2lt+l+7b8uUoRrLSwhSp6OVxzOAhFFK t58MjRc86Nee++Gh7moIPBmVXCvPAjfiB9uNrMyE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C15C960CF0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath11k@lists.infradead.org Subject: [PATCH 3/5] ath11k: variable set but not used [-Wunused-but-set-variable] Date: Mon, 17 Jun 2019 19:32:57 +0300 Message-Id: <1560789179-3857-3-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> References: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093308_415187_14F2839F X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix GCC W=1 warnings: drivers/net/wireless/ath/ath11k/htc.c:204:6: warning: variable 'orig_length' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/htc.c:203:6: warning: variable 'orig_buffer' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/htc.c:745:24: warning: variable 'ep' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/wmi.c:4422:9: warning: variable 'num_vdevs' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/dp_tx.c:448:5: warning: variable 'tcl_id' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/dp_rx.c:3675:6: warning: variable 'data' set but not used [-Wunused-but-set-variable] drivers/net/wireless/ath/ath11k/dp_rx.c:4070:6: warning: variable 'rx_tlv_start' set but not used [-Wunused-but-set-variable] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/dp_rx.c | 5 +---- drivers/net/wireless/ath/ath11k/dp_tx.c | 4 ---- drivers/net/wireless/ath/ath11k/htc.c | 8 -------- drivers/net/wireless/ath/ath11k/wmi.c | 3 --- 4 files changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 748059542459..0823f6761426 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -3672,7 +3672,6 @@ ath11k_dp_rx_mon_mpdu_pop(struct ath11k *ar, u32 rx_bufs_used = 0, i = 0; u32 msdu_ppdu_id = 0, msdu_cnt = 0; u32 total_len = 0, frag_len = 0; - u8 *data = NULL; bool is_frag, is_first_msdu; bool drop_mpdu = false; struct ath11k_skb_rxcb *rxcb; @@ -3752,7 +3751,7 @@ ath11k_dp_rx_mon_mpdu_pop(struct ath11k *ar, msdu = NULL; goto next_msdu; } - data = msdu->data; + rx_desc = msdu->data; rx_pkt_offset = sizeof(struct hal_rx_desc); @@ -4067,7 +4066,6 @@ static void ath11k_dp_rx_mon_status_process_tlv(struct ath11k *ar, struct hal_rx_mon_ppdu_info *ppdu_info; struct sk_buff *status_skb; u8 *rx_tlv; - u8 *rx_tlv_start; u32 tlv_status = HAL_TLV_STATUS_BUF_DONE; struct ath11k_pdev_mon_stats *rx_mon_stats; @@ -4081,7 +4079,6 @@ static void ath11k_dp_rx_mon_status_process_tlv(struct ath11k *ar, status_skb = skb_dequeue(&pmon->rx_status_q); rx_tlv = status_skb->data; - rx_tlv_start = rx_tlv; tlv_status = ath11k_hal_rx_parse_mon_status(ar->ab, ppdu_info, rx_tlv); diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index d9f1a953daec..75d5629c3979 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -444,8 +444,6 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id) struct dp_tx_ring *tx_ring = &dp->tx_ring[ring_id]; u32 *desc; u32 msdu_id; - u8 pool_id; - u8 tcl_id; u8 mac_id; spin_lock_bh(&status_ring->lock); @@ -477,9 +475,7 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id) ath11k_hal_tx_status_parse(ab, &tx_status, &ts); mac_id = FIELD_GET(DP_TX_DESC_ID_MAC_ID, ts.desc_id); - pool_id = FIELD_GET(DP_TX_DESC_ID_POOL_ID, ts.desc_id); msdu_id = FIELD_GET(DP_TX_DESC_ID_MSDU_ID, ts.desc_id); - tcl_id = ath11k_txq_tcl_ring_map[pool_id]; if (ts.buf_rel_source == HAL_WBM_REL_SRC_MODULE_FW) { ath11k_dp_tx_process_htt_tx_complete(ab, diff --git a/drivers/net/wireless/ath/ath11k/htc.c b/drivers/net/wireless/ath/ath11k/htc.c index b42d950b78e3..7b58276bac1e 100644 --- a/drivers/net/wireless/ath/ath11k/htc.c +++ b/drivers/net/wireless/ath/ath11k/htc.c @@ -200,13 +200,8 @@ static int ath11k_htc_process_trailer(struct ath11k_htc *htc, struct ath11k_base *ab = htc->ab; int status = 0; struct ath11k_htc_record *record; - u8 *orig_buffer; - int orig_length; size_t len; - orig_buffer = buffer; - orig_length = length; - while (length > 0) { record = (struct ath11k_htc_record *)buffer; @@ -742,7 +737,6 @@ int ath11k_htc_start(struct ath11k_htc *htc) int ath11k_htc_init(struct ath11k_base *ab) { - struct ath11k_htc_ep *ep = NULL; struct ath11k_htc *htc = &ab->htc; struct ath11k_htc_svc_conn_req conn_req; struct ath11k_htc_svc_conn_resp conn_resp; @@ -754,8 +748,6 @@ int ath11k_htc_init(struct ath11k_base *ab) htc->ab = ab; - ep = &htc->endpoint[ATH11K_HTC_EP_0]; - switch (ab->wmi_sc.preferred_hw_mode) { case WMI_HOST_HW_MODE_SINGLE: htc->wmi_ep_count = 1; diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index 3473c69b7bea..1477247fd573 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -4419,7 +4419,6 @@ void ath11k_wmi_fw_stats_fill(struct ath11k *ar, const struct ath11k_fw_stats_bcn *bcn; size_t num_peers; size_t num_peers_extd; - size_t num_vdevs; size_t num_bcn; spin_lock_bh(&ar->data_lock); @@ -4438,8 +4437,6 @@ void ath11k_wmi_fw_stats_fill(struct ath11k *ar, } if (stats_id == WMI_REQUEST_VDEV_STAT) { - num_vdevs = ath11k_wmi_fw_stats_num_vdevs(&fw_stats->vdevs); - len += scnprintf(buf + len, buf_len - len, "\n"); len += scnprintf(buf + len, buf_len - len, "%30s\n", "ath11k VDEV stats"); From patchwork Mon Jun 17 16:32:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10999773 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09BF714E5 for ; Mon, 17 Jun 2019 16:33:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1F3F288A0 for ; Mon, 17 Jun 2019 16:33:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E5431288B8; Mon, 17 Jun 2019 16:33:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 771AC288A0 for ; Mon, 17 Jun 2019 16:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hOo/uazdTWF4UVqgizJkkTlRRrVnl3nrdIUail4+rqg=; b=C6XApEuKpWEtaS ROzWBlletgwtFyEW3eU7hbVlb1vrcByNn6JebRbeP6iefRE03YzbD+6zyarUE/5Z9Ds1eKP8thhXb CEvXIWJGwonkLZ1XdE/JC+nGg7rzGwJRPrV3fe5EYT2q3CtM0cut+9fqgPPk6zuJgIwWAHJHoubZR WSkZMyF9D6F1lVP4WxLLFePhVO+KXst8qFanwNVFcTUEGeHYVCy9v6qU3jDxpXEQQGwKQrps/RmBE txIrDsT8U9gSpx4RQnSvzv1Ojwm8fSkHYR3mRVCyTbtrBo5e4U78DwbSKX2RjSfv0zmktpoOVRZ4m QPojLI4WCkSAF0US2k9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZF-0005t1-7f; Mon, 17 Jun 2019 16:33:13 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZB-0005qm-UC for ath11k@lists.infradead.org; Mon, 17 Jun 2019 16:33:11 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5F9ED607DE; Mon, 17 Jun 2019 16:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789189; bh=NQr1Rc5ypLIYDH/9Y0xxmtMBZ6UevqddEfWEqmPn8tE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NoqGaBss+9qbe5z31buTxSj/7/bvNOSzqe+rERzcAJgK9CuLPcP9e/m8mEDedZ6sj VAhh1xrN00qAxfBL+O3Owzt4ViXr3MEvO/lwQkN+XHNHdbK/UcBfZnPMf/F549lT7H W/wzA0+LOQ/rP5BED24U/XNvVUHcBBDUeyMwbHSc= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49EF6607DE for ; Mon, 17 Jun 2019 16:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789188; bh=NQr1Rc5ypLIYDH/9Y0xxmtMBZ6UevqddEfWEqmPn8tE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TzrYaVMWVKPkHV9wRCWDhxrAw/DKJHajx1uj0oQw99Xd8ZKoMcb6QS+ncUfTTKupw 0Mv0MPvfVu7FFsKqLdzPXdVUc22CS2mp3PMqX2VdHwkp2y+RQg5g0koI+YT/KL9PZc RnJsLCyBQV8mP+XyuokysvcKWFaeeofAyneVDBxc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 49EF6607DE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath11k@lists.infradead.org Subject: [PATCH 4/5] ath11k: comparison is always true due to limited range of data type [-Wtype-limits] Date: Mon, 17 Jun 2019 19:32:58 +0300 Message-Id: <1560789179-3857-4-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> References: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093310_017804_B62359EE X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/hal_rx.c:57:18: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2375:21: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2378:20: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2382:20: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2385:22: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2389:21: warning: comparison is always true due to limited range of data type [-Wtype-limits] drivers/net/wireless/ath/ath11k/dp_rx.c:2396:32: warning: comparison is always true due to limited range of data type [-Wtype-limits] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 2 +- drivers/net/wireless/ath/ath11k/dp_rx.c | 18 +++++++----------- drivers/net/wireless/ath/ath11k/hal_rx.c | 6 +++--- 3 files changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c index 9558c6ada6d8..22d44a59be14 100644 --- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c +++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c @@ -52,7 +52,7 @@ static inline void htt_print_stats_string_tlv(const u32 *tag_buf, index += snprintf(&data[index], HTT_MAX_STRING_LEN - index, "%.*s", 4, (char *)&(htt_stats_buf->data[i])); - if (index < 0 || index >= HTT_MAX_STRING_LEN) + if (index >= HTT_MAX_STRING_LEN) break; } diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 0823f6761426..2c7a3585059a 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -2372,29 +2372,25 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta, if (ppdu_info->nss > 0 && ppdu_info->nss <= HAL_RX_MAX_NSS) rx_stats->nss_count[ppdu_info->nss - 1] += num_msdu; - if (ppdu_info->mcs >= 0 && ppdu_info->mcs <= HAL_RX_MAX_MCS) + if (ppdu_info->mcs <= HAL_RX_MAX_MCS) rx_stats->mcs_count[ppdu_info->mcs] += num_msdu; - if (ppdu_info->gi >= HAL_RX_GI_0_8_US && - ppdu_info->gi < HAL_RX_GI_MAX) + if (ppdu_info->gi < HAL_RX_GI_MAX) rx_stats->gi_count[ppdu_info->gi] += num_msdu; - if (ppdu_info->bw >= HAL_RX_BW_20MHZ && ppdu_info->bw < HAL_RX_BW_MAX) + if (ppdu_info->bw < HAL_RX_BW_MAX) rx_stats->bw_count[ppdu_info->bw] += num_msdu; - if (ppdu_info->ldpc >= HAL_RX_SU_MU_CODING_BCC && - ppdu_info->ldpc < HAL_RX_SU_MU_CODING_MAX) + if (ppdu_info->ldpc < HAL_RX_SU_MU_CODING_MAX) rx_stats->coding_count[ppdu_info->ldpc] += num_msdu; - if (ppdu_info->tid >= 0 && ppdu_info->tid <= IEEE80211_NUM_TIDS) + if (ppdu_info->tid <= IEEE80211_NUM_TIDS) rx_stats->tid_count[ppdu_info->tid] += num_msdu; - if (ppdu_info->preamble_type >= HAL_RX_PREAMBLE_11A && - ppdu_info->preamble_type < HAL_RX_PREAMBLE_MAX) + if (ppdu_info->preamble_type < HAL_RX_PREAMBLE_MAX) rx_stats->pream_cnt[ppdu_info->preamble_type] += num_msdu; - if (ppdu_info->reception_type >= HAL_RX_RECEPTION_TYPE_SU && - ppdu_info->reception_type < HAL_RX_RECEPTION_TYPE_MAX) + if (ppdu_info->reception_type < HAL_RX_RECEPTION_TYPE_MAX) rx_stats->reception_type[ppdu_info->reception_type] += num_msdu; if (ppdu_info->is_stbc) diff --git a/drivers/net/wireless/ath/ath11k/hal_rx.c b/drivers/net/wireless/ath/ath11k/hal_rx.c index 0308089c88df..ca55855db2bc 100644 --- a/drivers/net/wireless/ath/ath11k/hal_rx.c +++ b/drivers/net/wireless/ath/ath11k/hal_rx.c @@ -54,10 +54,10 @@ static int ath11k_hal_reo_cmd_flush_cache(struct ath11k_hal *hal, u32 *reo_desc, u8 avail_slot = ffz(hal->avail_blk_resource); if (cmd->flag & HAL_REO_CMD_FLG_FLUSH_BLOCK_LATER) { - if (avail_slot >= 0 && avail_slot < HAL_MAX_AVAIL_BLK_RES) - hal->current_blk_index = avail_slot; - else + if (avail_slot >= HAL_MAX_AVAIL_BLK_RES) return -ENOSPC; + + hal->current_blk_index = avail_slot; } tlv->tl = FIELD_PREP(HAL_TLV_HDR_TAG, HAL_REO_FLUSH_CACHE) | From patchwork Mon Jun 17 16:32:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10999775 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9EA8D1580 for ; Mon, 17 Jun 2019 16:33:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93370288A0 for ; Mon, 17 Jun 2019 16:33:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87571288B8; Mon, 17 Jun 2019 16:33:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 38872288A0 for ; Mon, 17 Jun 2019 16:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lN0aIc1oI2oH49TYGTq46WZHwMnvWa7NZI1kfqHR5iA=; b=UXOZR8LVqSDqK9 tHUVkI0+uiDpVJnVG0ZyROSHFpkDBeCPhrA16aJAsSX8wgY7w81k41Vj2MxGydSmo7IgBy4cI5NnZ 0chMKC0DIiNe3+cQi/mQqynhW/f+yyH/uMS4/K0JAoQDc+ZZKhxk7xqptqWBxsCEYUGLsYyKYfw63 mMFuUqSy/2W/Sl/BpsyD1WdxmJxtRZxfXjQE2mWQujiXxTRnxr1z1OaH95v/44ZvAH/ZgmiR3jRZP sNoa8xHx/Sj80JXuy7/40EXUCDUmkLMC6LNf98m6isUowptH4Y36G+SKK7MLCqRpCuufCr5XyIVT+ HQ3+kWdYemgCH0HTvy9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZF-0005tO-QU; Mon, 17 Jun 2019 16:33:13 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcuZC-0005rI-Lr for ath11k@lists.infradead.org; Mon, 17 Jun 2019 16:33:12 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 349D761132; Mon, 17 Jun 2019 16:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789190; bh=imIiFI+DwWbiij2yWx9OcKj8BYfhXVkmXyFB84f0sPg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Fe6lZYknRhOReYiZh3viEctAOZQHwE3lEtLaWphf7NpEhgVKDAO6FhldvXJ2P5+sV Sc3e14pxv4FHfV19e9KXLuUu5lOjmj4IdkEJ7DhZ+yuPflrjmx/dx5V59ru6XXropf D+UTSKhVUUFIKNi+fozcsMzLXBK/Qf0iw9vY/e0A= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A57C460C60 for ; Mon, 17 Jun 2019 16:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560789189; bh=imIiFI+DwWbiij2yWx9OcKj8BYfhXVkmXyFB84f0sPg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=B5oVLG9X1btX+0QSBZjL/hxypg5O0Y57pY0HcyN5J7GQe25O1B/QnJIaemrNDK+u8 5dXVLt1YLHHVQLiU5JC8SRJYrFjelnLwKe5ZDuTmfXnnrpnbvyvKaaCAoQoL6lVTdl hITEjvRkEjEG7RpknCxrU9EKmYzfl9aHAO6vzjpE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A57C460C60 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: ath11k@lists.infradead.org Subject: [PATCH 5/5] ath11k: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Date: Mon, 17 Jun 2019 19:32:59 +0300 Message-Id: <1560789179-3857-5-git-send-email-kvalo@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> References: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_093310_759968_224DC7EA X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix gcc W=1 warnings: drivers/net/wireless/ath/ath11k/dp_tx.c:654:20: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] drivers/net/wireless/ath/ath11k/debug.c:808:13: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/debug.c | 2 +- drivers/net/wireless/ath/ath11k/dp_tx.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c index 97ecde81559c..95bf80d38ea7 100644 --- a/drivers/net/wireless/ath/ath11k/debug.c +++ b/drivers/net/wireless/ath/ath11k/debug.c @@ -805,7 +805,7 @@ static ssize_t ath11k_write_extd_rx_stats(struct file *file, goto exit; } - if (enable < 0 || enable > 1) { + if (enable > 1) { ret = -EINVAL; goto exit; } diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index 75d5629c3979..202dba40ba4f 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -650,10 +650,12 @@ int ath11k_dp_tx_htt_srng_setup(struct ath11k_base *ab, u32 ring_id, cmd->ring_base_addr_hi = (u64)params.ring_base_paddr >> HAL_ADDR_MSB_REG_SHIFT; - ring_entry_sz = ath11k_hal_srng_get_entrysize(ring_type); - if (ring_entry_sz < 0) + ret = ath11k_hal_srng_get_entrysize(ring_type); + if (ret < 0) return -EINVAL; + ring_entry_sz = ret; + ring_entry_sz >>= 2; cmd->info1 = FIELD_PREP(HTT_SRNG_SETUP_CMD_INFO1_RING_ENTRY_SIZE, ring_entry_sz);