From patchwork Tue Jun 18 08:58:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viktor Mitin X-Patchwork-Id: 11001217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0954B1395 for ; Tue, 18 Jun 2019 09:01:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E9AD928A15 for ; Tue, 18 Jun 2019 09:01:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D89CA28A18; Tue, 18 Jun 2019 09:01:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 753F928A15 for ; Tue, 18 Jun 2019 09:01:21 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hd9xK-0004Lj-DM; Tue, 18 Jun 2019 08:59:06 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hd9xJ-0004Le-O7 for xen-devel@lists.xenproject.org; Tue, 18 Jun 2019 08:59:05 +0000 X-Inumbo-ID: 520fd00d-91a7-11e9-8980-bc764e045a96 Received: from mail-lj1-x244.google.com (unknown [2a00:1450:4864:20::244]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 520fd00d-91a7-11e9-8980-bc764e045a96; Tue, 18 Jun 2019 08:59:04 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id k18so12226635ljc.11 for ; Tue, 18 Jun 2019 01:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=JeAVoKVdxRsJHzqaTaj0ucciRItQnDQRDeWNsCNLp8I=; b=s4hR0WW0txu8emku4HoV/OJsMlpLQYvy+xpoQfvI+/bRIqBZJ4PziDiHQW4X+Lomv/ FyUydRb4PwqLxHHF37MGS75rnjBtCt791ZwtGfT07C/iR6OhpeL6SYRqd2FZrTY1u4Ff +8W0sEX8w+8b17UZ/IlraoUPIxidGVEPfB7XHXeoEzdmwLh7X3aHg64A/dDrqZ5iwfKk dKXxHkJvTm5z7SBzB5wmrewMkljWPPY39J7na7wCGN6q0iRrPsc83VoVP09dzarTPKl7 kypEFpa0uIBYCwotazCnscKrnEGE6MTGO4VW+7t+WHbktLDikZe36QERMnMfxUBrenVN TCCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JeAVoKVdxRsJHzqaTaj0ucciRItQnDQRDeWNsCNLp8I=; b=dRGviVfWdnqxsg563nibiPiOkKmoBeucRJWQmd3JhieH9tsdpE+Tzp/OaACO67CyG1 Jr2LWVoWjNwvA0hWAVAuQzoevmPcp3cI45DjeW7VHkGlImGJs+ag0prgvEaLRMK5yqJw IZEmPwdNlnKkDgsgnfUY1ZN3YTUTpQYImWZBrvqmyKmCEtMRUUsbKnhfLjI+dpB2Tso6 i2XLv6zZbRgkBiQDN3mevRpNzpoDmsIBCGG5NKxpkXDyNGQan3q93TMfoaujUJoMU4Wm 77BsbgV/TD1XLMmtKX5tCtxOlVGmA4THELGFbhQu8KKNxFn7M45WlnYP96Om0A07raMt erAg== X-Gm-Message-State: APjAAAUmoNnUmUPDvzNI0v+3k0q8Po7KouEvzni93XB+eK6g7IRanIuJ zQNmPcpobwl5VnlezdmWWigtaVzP X-Google-Smtp-Source: APXvYqxGYoxvZLCvZeC6j+Zl9RLaN9DzV1t+HXko57q82FnzXhsUJw/4UtRXGcPe4w8q2Pwk1WZ4sA== X-Received: by 2002:a2e:4b12:: with SMTP id y18mr14982081lja.238.1560848342521; Tue, 18 Jun 2019 01:59:02 -0700 (PDT) Received: from 3489.kyiv.epam.com (ll-22.209.223.85.sovam.net.ua. [85.223.209.22]) by smtp.gmail.com with ESMTPSA id r24sm2764598ljb.72.2019.06.18.01.59.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 01:59:01 -0700 (PDT) From: Viktor Mitin To: xen-devel@lists.xenproject.org Date: Tue, 18 Jun 2019 11:58:51 +0300 Message-Id: <20190618085851.22902-1-viktor.mitin.19@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [Xen-devel] [PATCH] xen/arm: remove unused dt_device_node parameter X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien.grall@arm.com, sstabellini@kernel.org, Viktor Mitin , Viktor Mitin MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Some of the function generating nodes (e.g make_timer_node) take in a dt_device_node parameter, but never used it. It is actually misused when creating DT for DomU. So it is the best to remove the parameter. Suggested-by: Julien Grall Signed-off-by: Viktor Mitin Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d9836779d1..7fb828cae2 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -742,8 +742,7 @@ static int __init make_hypervisor_node(struct domain *d, return res; } -static int __init make_psci_node(void *fdt, - const struct dt_device_node *parent) +static int __init make_psci_node(void *fdt) { int res; const char compat[] = @@ -779,8 +778,7 @@ static int __init make_psci_node(void *fdt, return res; } -static int __init make_cpus_node(const struct domain *d, void *fdt, - const struct dt_device_node *parent) +static int __init make_cpus_node(const struct domain *d, void *fdt) { int res; const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); @@ -962,8 +960,7 @@ static int __init make_gic_node(const struct domain *d, void *fdt, return res; } -static int __init make_timer_node(const struct domain *d, void *fdt, - const struct dt_device_node *node) +static int __init make_timer_node(const struct domain *d, void *fdt) { static const struct dt_device_match timer_ids[] __initconst = { @@ -1380,7 +1377,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( device_get_class(node) == DEVICE_GIC ) return make_gic_node(d, kinfo->fdt, node); if ( dt_match_node(timer_matches, node) ) - return make_timer_node(d, kinfo->fdt, node); + return make_timer_node(d, kinfo->fdt); /* Skip nodes used by Xen */ if ( dt_device_used_by(node) == DOMID_XEN ) @@ -1454,11 +1451,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; - res = make_psci_node(kinfo->fdt, node); + res = make_psci_node(kinfo->fdt); if ( res ) return res; - res = make_cpus_node(d, kinfo->fdt, node); + res = make_cpus_node(d, kinfo->fdt); if ( res ) return res; @@ -1713,11 +1710,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; - ret = make_psci_node(kinfo->fdt, NULL); + ret = make_psci_node(kinfo->fdt); if ( ret ) goto err; - ret = make_cpus_node(d, kinfo->fdt, NULL); + ret = make_cpus_node(d, kinfo->fdt); if ( ret ) goto err;