From patchwork Thu Jun 20 19:04:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11007791 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 505F61398 for ; Thu, 20 Jun 2019 19:04:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4175228841 for ; Thu, 20 Jun 2019 19:04:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3537F28856; Thu, 20 Jun 2019 19:04:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C3D8128841 for ; Thu, 20 Jun 2019 19:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=BVmROnlMpObCELDA/GJaN5jrYOpFyAFrvj1Puqvt5n0=; b=TUS vZcbveH/M2qbBE5kjujrNJ9P2YYBZ9X9owh3aRG/1ucaNcGY+GoTaxji+EzDvYtBnFBclC2BjDmwt grGmYIEn1Hh6gG82AQyYfId0S+DDUy9D6Mz8btNncMfyJlaxgJdZLZO7BcA7AGp6WYf388lnKIN3J CocvnWsQ9vQPh2QQtOLOx9n6A4++T6g13J19IzT9Fp57iQmwDiyHr5vvcXCxDDPZIXddHoACzCvTJ 4ZoFFu5DaQvvrg9dCJPw65qQyff67+KY27qMCDsiyLwdT6X6bmkqZEqOYk9Qi1d5fbMUXCWFdA/p5 LgCA589jimX/7+7zkLWGCRuCuaDvNFA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he2Mb-0005cq-28; Thu, 20 Jun 2019 19:04:49 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he2MY-0005cT-Vc for ath11k@lists.infradead.org; Thu, 20 Jun 2019 19:04:48 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AD6C9602F4; Thu, 20 Jun 2019 19:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057486; bh=6miQrscWx1Kpa6Updf/c+egrAreqAw4BJGqwgfJiOvE=; h=From:To:Cc:Subject:Date:From; b=ZNIf34Mmjh2OAfYhsFcZxxakusx5AsmT3TLclknWtd/UjBLLu3t4pkEsiUH3pKPzU n5uFY80D/Mm3It/IZoLQ9mH0xwaDqemu2cYVTVNDJKG4I4baf12r+1V488/IRRYwHu m/jAKrybG0e0iB1dWrCQL3n0xr++hbgPvi7BpfpI= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6260E60274; Thu, 20 Jun 2019 19:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057486; bh=6miQrscWx1Kpa6Updf/c+egrAreqAw4BJGqwgfJiOvE=; h=From:To:Cc:Subject:Date:From; b=ZNIf34Mmjh2OAfYhsFcZxxakusx5AsmT3TLclknWtd/UjBLLu3t4pkEsiUH3pKPzU n5uFY80D/Mm3It/IZoLQ9mH0xwaDqemu2cYVTVNDJKG4I4baf12r+1V488/IRRYwHu m/jAKrybG0e0iB1dWrCQL3n0xr++hbgPvi7BpfpI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6260E60274 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: fix unnecessary brace warnings Date: Fri, 21 Jun 2019 00:34:28 +0530 Message-Id: <1561057468-542-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_120447_054451_5E79A09C X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/core.c:193: braces {} are not necessary for single statement blocks drivers/net/wireless/ath/ath11k/dp_rx.c:1306: braces {} are not necessary for single statement blocks drivers/net/wireless/ath/ath11k/dp_rx.c:2647: braces {} are not necessary for single statement blocks drivers/net/wireless/ath/ath11k/dp_rx.c:2676: braces {} are not necessary for single statement blocks drivers/net/wireless/ath/ath11k/mac.c:5123: braces {} are not necessary for single statement blocks Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/core.c | 3 +-- drivers/net/wireless/ath/ath11k/dp_rx.c | 10 ++++------ drivers/net/wireless/ath/ath11k/mac.c | 3 +-- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index ca80832..1ecbbd9 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -190,9 +190,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *sc, bd->fw = ath11k_fetch_fw_file(sc, sc->hw_params.fw.dir, filename); - if (IS_ERR(bd->fw)) { + if (IS_ERR(bd->fw)) return PTR_ERR(bd->fw); - } data = bd->fw->data; len = bd->fw->size; diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index a505e91..cec27a8 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -1253,9 +1253,8 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab, goto exit; } - if (ath11k_debug_is_pktlog_lite_mode_enabled(ar)) { + if (ath11k_debug_is_pktlog_lite_mode_enabled(ar)) trace_ath11k_htt_ppdu_stats(ar, skb->data, len); - } ppdu_info = ath11k_dp_htt_get_ppdu_desc(ar, ppdu_id); if (!ppdu_info) { @@ -2596,9 +2595,8 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id, memset(&ppdu_info, 0, sizeof(ppdu_info)); ppdu_info.peer_id = HAL_INVALID_PEERID; - if (ath11k_debug_is_pktlog_rx_stats_enabled(ar)) { + if (ath11k_debug_is_pktlog_rx_stats_enabled(ar)) trace_ath11k_htt_rxdesc(ar, skb->data, DP_RX_BUFFER_SIZE); - } hal_status = ath11k_hal_rx_parse_mon_status(ab, &ppdu_info, (u8 *)skb->data); @@ -2625,9 +2623,9 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id, arsta = (struct ath11k_sta *)peer->sta->drv_priv; ath11k_dp_rx_update_peer_stats(arsta, &ppdu_info); - if (ath11k_debug_is_pktlog_peer_valid(ar, peer->addr)) { + if (ath11k_debug_is_pktlog_peer_valid(ar, peer->addr)) trace_ath11k_htt_rxdesc(ar, skb->data, DP_RX_BUFFER_SIZE); - } + spin_unlock_bh(&ab->data_lock); rcu_read_unlock(); diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index ee187de..613590e 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -5031,9 +5031,8 @@ static void ath11k_mac_disable_peer_fixed_rate(void *data, } ret = wait_for_completion_timeout(&ar->bss_survey_done, 3 * HZ); - if (ret == 0) { + if (ret == 0) ath11k_warn(ar->ab, "bss channel survey timed out\n"); - } } static int ath11k_get_survey(struct ieee80211_hw *hw, int idx,