From patchwork Fri Aug 31 08:09:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10583317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5538920 for ; Fri, 31 Aug 2018 08:28:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BED0F2A817 for ; Fri, 31 Aug 2018 08:28:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADDE72A82C; Fri, 31 Aug 2018 08:28:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 536472A817 for ; Fri, 31 Aug 2018 08:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7C0UBhl+1vvWO47s403j6Sa5fArsTr2OJX66AQydY8s=; b=rvTPxMPlK+h+pa xwGagO1HPd1JMKVP2Idc2Qoh7Cfw9iI8/sel5NGV4XffJsp9i3BYEX7mxi7ldrEZCRvZErLJSrOmp zMHFO5coLJjHf+BLfq+o0Pp0m701NZvDY7Rjzv0/U0Uop1DacjDMKWFZqBD9xryDku6wGt1DnkmkI 7SAsP7X4NNFFvv5rKlPw9rMFeto74gMz2pA2hfKqVmssMjaTTFB+V68QFCxGppu/R4Z1M7IRN92BB PdxsbuGoZ2t9Z4nWO89DJ5RNZOAELlXdALpNXBRu15PXkzgkFSYa45xKk5qLiGZHp7iBzypjSMq5J Tkquk1FwxqOW5rwMYOpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fvemp-0003Qb-Pv; Fri, 31 Aug 2018 08:28:11 +0000 Received: from mail-bn3nam01on0079.outbound.protection.outlook.com ([104.47.33.79] helo=NAM01-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fveXf-0004R0-VH for linux-arm-kernel@lists.infradead.org; Fri, 31 Aug 2018 08:12:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8NzGt4NielWXWd5bk/EEev7uGYmuohMoKTtjY10MSxQ=; b=f61zT7FSuO6hGeUISd0tYZDm8ythcYaplw+Ok4wSIefZDUHQ6dGGxirYt1OTuH76ipalMcKpKUSdJbIEqROR9KfViHWvWJxmwPi7xEPpTWuRzjbv/tPd2T38Vmk81gMy1X8Cuv0XhASL2y7XROcTxomAvw1k9jRzjdoxsQqsPK8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by CY1PR0301MB1580.namprd03.prod.outlook.com (2a01:111:e400:529c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.16; Fri, 31 Aug 2018 08:12:17 +0000 Date: Fri, 31 Aug 2018 16:09:13 +0800 From: Jisheng Zhang To: , "David S. Miller" , Andrew Lunn , Gregory CLEMENT Subject: [PATCH net-next v2 1/3] net: mvneta: Don't check NETIF_F_GRO ourself Message-ID: <20180831160913.325ee36b@xhacker.debian> In-Reply-To: <20180831160810.2539ef4c@xhacker.debian> References: <20180831160810.2539ef4c@xhacker.debian> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: TY2PR06CA0011.apcprd06.prod.outlook.com (2603:1096:404:42::23) To CY1PR0301MB1580.namprd03.prod.outlook.com (2a01:111:e400:529c::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53a29e48-eedb-4f14-79aa-08d60f197886 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR0301MB1580; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1580; 3:d0FiqA338xdkAvV70jqweho0pHy799siWYIffShpQPHb9qVA7ESmgJNFS0YDGpjrRVSetbWot3qtRVo0ejvwHmG7gBAxxpN5JEG4T5wTi6DwHu8tflPnoE1XeGoLrBXjflIognlTgQMRFMTX2F1Ffa/ewWO8jRnrYSCSoslypO0rMo74EtuGldG/jILENqEOIV4e5Sl/onsm46b6vgOEkO/femX9BkMdUfWq/ZFT3DgvEjeyCFdRr7Rc1X51WoTY; 25:35QzpxJa2FlbHOPoNq0EYOmYkVjt9iGe4+LsCrRexPDkwr71NvTOx8fjroZonliqadZZdZwFeXzMcOkadx5I91EUdTQftVe4y1UZ7/UXSLfoRHlvRc/enXP3tMHn5IJarr7/d5RIKVA2Ql2yg9UDtQg7hTBKbbcWirW8KdIht2DyvKYifyxg6oxv7fCmTl1q8R8eitLtX9wJB84qeXo7KMVi0XnQ9mKNg/NDzrjllbNJj0ouc0UoIDKky9VoRIfRQZsVcOkoEWTuX34xdqYxnC4WCpCheln2Be8fgoWHsK+YE0uHr/R7qAIs/2xCmAqPIMvU4Dti9vaCx6CkgoIh3A==; 31:ioIHgXjfOUYGZyA7WQqLLDXs3N7Px6O9KRTq4UUHakWBEz4xSf7kTMjJTghz2V/lIw/LbThGSP70aVBDdyChtmtdykPnv2qBv5qZCiXxOofHAXP8tZ68jr0dtR9WJOXy7fFP/yDTH8x5CLrmUXN9KtTydL2v/LDlawUrJbEkuKr15aX53a+x1vRKhutY0QVLvy4CVfu8oU1pgJKusJ7jc513B4TptTfEWwIEEC3VRxI= X-MS-TrafficTypeDiagnostic: CY1PR0301MB1580: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1580; 20:APzJ6VRztocUe9LLP6aJ3sekrfcZLU/0kO4C47lAGCYOD9HvZ0c03e81a8PAqsHe0R+HHaiH9LHJOPsaGch2lrPzEUMbsR5FoRoB2gIWdXXK4Wz4Oq38xCrRwk7ZNno0r8pYudcVr5UpUKy+wa+ylKIr796KF8JKC4XyASV1CSljEf0L0kuqBtR1eRX1C8IA9fFn2TqX7hOr4tfZGv8W1bO4m4uZS9Ri8p8JLLIGzxAAkGzaDuC5KL4sbDtBWSNVYN8P7auxzfcXmW+bjRz1Uf/6D66s93jlBma6vZdirxfnMT76yfEqxA6H9uKsRRirUvIjQ64/hZSOFCB2PS4gzpWdYG6a8dY6+XmwHZd7fdm6XOBUqiVbh7wuqVVkqZbYmOmg36a5gkdL9RON7yLocv+gUMlLDhjI01VC4faTr5IQ7R62AXkeujctgZDldPXsKO4XtE9cOME6gQguCzLMLrE9jFZ5ZkghBuwmGlqRclCURNbWTG0XG6DNjnwe1+o9; 4:CsofGURmWiRFaDyYFzsY5QNyn14XDhsnHQZ+nRmsEOAYNGlh+c/qsnd8k8igrG/vl0o9WZlWEvxWBGNtqKl5BQQWCfL3okg4m2V0lar7WQ3NHO/ms0biLz9nrV2IHSbIu650eoDCEj+b0w2oO4T/Sg0MsYKcgsFkwgVVzgaTpRLHAiSao89FvbZwuHw3iZjVtTAH2Q/S/ZqO8T7zCBFSE+noi2z2n1Yh9uaUjGBOTrKvqSLIFk5A7MOFFdwulDTrN75IlTw1+nXZIha/WUn2YQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699016); SRVR:CY1PR0301MB1580; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB1580; X-Forefront-PRVS: 07817FCC2D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(366004)(396003)(346002)(376002)(189003)(199004)(11346002)(8676002)(106356001)(105586002)(956004)(446003)(476003)(25786009)(2906002)(26005)(4326008)(305945005)(97736004)(186003)(68736007)(6506007)(50226002)(16526019)(386003)(8936002)(7736002)(7696005)(52116002)(76176011)(66066001)(33896004)(110136005)(1076002)(316002)(47776003)(72206003)(50466002)(478600001)(230700001)(5660300001)(6666003)(486006)(81166006)(81156014)(9686003)(23726003)(55016002)(86362001)(3846002)(6116002)(53936002)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB1580; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1580; 23:DQm/37xw6ecjk5BlH9G77IA6ZNeBtTnuNe8fxZJ?= Y6YaJbuZ8xS5ZqZdehJIO3oDa3qmycpMz5yC4bc+OiHiO6Y74E1FWBVEgvUgq7c1M20rG3W/S6W85TWWCq0xENrQ0bTCx/vUfjr2uPCrviGCtKeExzZ9QMq/cF3DQ9fHqm4HM/W9j2O53rsEoG1VdN1zDjumWK1xTZ6Snk13xc7At/2A3QBbKXm3Qh7sOgPUUBFz1kOz70cvYtwMb3KVGu7SRpO5NfdIiUfwGf/4EoCj+1xQYlUjdTeAfuZ9C4fg5A7AXVIaZbjErMNQpK9YrqKkNXSsiV6xYolLxXT5FT29bGcY34vKbZMGSfPcPI1h5/vb0ULnMsVUrhMv21Bzjg9ZIgI3t3xBSUe7jpMhvzu0bMN4xNFWToP5DyuF0B6EfAcIpCZCPrmwPIse4ENOJiKkXJlBX/VwFI6COXG2ntfT8AG3TcvfYVLx1gXHVnwgvrJUz+kV1nGIXlWWI6FoWBfbdkCyLGZr3a+tlS1WkgzCOPWQNe10vs0wfpjWgPSRMX8Qqe+IuliDtKGds1lnLXI6PFrkaFiCMcwnX6YzScJ1GLzP3hCkZC0mDq7Cdc/JJrqvu26wLrQqghqMgJDHxZqgm8OmSQfh6nkKf+fsSSlDUMW3PC20tJqKHgzxX7jdzQm1vQPuCkiKvc+ihDbhdM+bBUUMozSLLkdMkDlZeA018BEMUAlDExXtcTHOV2/9BH65faAkI+26T9MtdeqGwdQXoT+WpaZaMDc+2B5wox/kz1bHl9pC/Biy8pwlqqlJTiRZBrccB6DRaCfK0o1D7aqfcCVw5CejGomzetWnWzFrYSoGPENmkB8ym2X4xGnpONdPa6Q+x//20G6zqA75SXs7k9oaTxVZR0kNlol8HmmnX8bfM7wqIkj6Lhwz8sarLhOmcZ6tHW5QK1mvWlhDFnZbkiFb5x3iqX9Sx7kEPN/r4bRHBNQeQzkVLO6fhHKLw1uO3l2FNfgWFxuOwk66n6BtPKvariIVsmRgh/O2mIh1ZgDifRWhBl/6r43965j/deLmk1uGBT18ysxxk3XFot0Wv8WLCLAmB75I0NQD+n9bMIGPSQJ4cxCU05kOwOGpInXlulTwdpwRiVX/YhkpcsVXETJ62KmWovBV0NCSglFWcSyYdyo2yksTKXuTqVnaZSwcp1FCKYNcoHPsPFmfRkGEE4SJcnpzOl+FEyPzPz1KkEA== X-Microsoft-Antispam-Message-Info: Zr2/vKvDM4rdxLSJMHxChjj2m1UAcpPvNRvcYnnq0p6AwyG8MOwYbavZKDwqEP/rLxg5S7RDt30GZeJ3rXHQRp8fFbUlBTS+8V4zG/NKx3afpZBZ0rVVr7AprVGbpXkjNSwfKFuLfYEjuX3jAUnsHuKWQo6arKJJCw3kODwFNnt3+028ZRmPyHtpqq5ej+kEDeNdy7t+nKwSlne9qC1Xcg4dzn461fdN8Jljn/OM/iELS4NGiLzzX0cd9nxhNbvwyoFJFj2xf2Oh6cR+tLwjmeu5xLkfhDinuHrw9rVNz1EQhnbw3uWSvLlSz3jnN+Ev7gV4mrl6egLZTfqFeNM8rto4POHHj4LRsEkJ76ridGw= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1580; 6:D2oFU/1W+7WtEwCb6DZthwRpYGK289J8Ieg0OC15Kbz7WBY1nLGC5SZx685vM1oRa6QBgJjXPkqSCAk1h4lidqMuaZRvBnSnx+l2kq7Ws7tufQZCuTjuagtheqzoBHmYY66bHcHLN1QwPGPCsCM4Ahw5k8Jxu1DpgEiIcY+yKRfeRL3J8ox2sOn/xFj+3M2i7fnFhC17oE2oTAYTUSL8A4/lx6aFdAaAl0D+L5BplU2L3Pl9ff9CzfqeSoz7T491IZTKqCTTbSopPYCf3abu0pKsP0WBIgWtzMfxoo32oK9UBMhVedX8B3smcL6xJkC7ReHzj2j2abW2xkPoX+i8dn+z3MiMBdusOlh3v3ERm3iNP0iqDfLh+JChCpBrdf9vegUmc0F8sg/7QEVRpZ/lnlqKaLpiBUQ4mDohBe04gf+Kck+ef6GqEJhL/sPV4Rq80q4Fn40MzZ6v1ZoO7+bYuQ==; 5:QMn+onaAS0ugz2M35Dh9imm1SNd5iw34jN7lwR5pJP30lPJsoibdEAgDht+FFZBhszT0Of6tXUI+cvui7FaR9/8vH8xh/9rrHatBeMHlBAt9WjBdrW3iFpG2pdJN7lS9KDfPwKR9EEjak8DQQsaE1ZOqlORiyw5DFw4hmHQ+q7k=; 7:w4R40LhYfo4kUbRVLJBVzoAAdJVPHUNLd8zc27GeoAOijH6IwVscv7dY6DCMFHeHFmKEw3L7uoZjY2YRuFnYVyE0c8KzgucB1n3MxLGv/0LeMojm7Nh0RKiNMOsJWKgZBAoivAAPjmuJNdsE5fTcJQ9u3/37a7fKHG5UYumSCaXfHqqGgysGRNGCGkOjGGnpqBGWUsGrXK4sDXHbgsD3b8hYJpZ09KlUsUmA0XlsVZthDFCoUjOMPMnuLBAOn5f/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 08:12:17.1236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53a29e48-eedb-4f14-79aa-08d60f197886 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1580 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180831_011232_133177_6B72CEBF X-CRM114-Status: UNSURE ( 8.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP napi_gro_receive() checks NETIF_F_GRO bit as well, if the bit is not set, we will go through GRO_NORMAL in napi_skb_finish(), so fall back to netif_receive_skb_internal(), so we don't need to check NETIF_F_GRO ourself. Signed-off-by: Jisheng Zhang Reviewed-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index bc80a678abc3..814aee92a1d3 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2065,10 +2065,7 @@ static int mvneta_rx_swbm(struct napi_struct *napi, /* Linux processing */ rxq->skb->protocol = eth_type_trans(rxq->skb, dev); - if (dev->features & NETIF_F_GRO) - napi_gro_receive(napi, rxq->skb); - else - netif_receive_skb(rxq->skb); + napi_gro_receive(napi, rxq->skb); /* clean uncomplete skb pointer in queue */ rxq->skb = NULL; From patchwork Fri Aug 31 08:10:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10583303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02CB5112B for ; Fri, 31 Aug 2018 08:14:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3BCF2B994 for ; Fri, 31 Aug 2018 08:14:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D58CA2B9C7; Fri, 31 Aug 2018 08:14:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4AED82B994 for ; Fri, 31 Aug 2018 08:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VwaObhBtoFf1pSt0hybnTaVmdbV3sHDSNXSV2yqwXQ4=; b=CyFU6vwMvmG5VB XGdAO8jCSLKLhR8jLBRJIpT65oQedYcb37PAoZfVGIW/fHAku5DsqI9nHXVWUYzsdg6aB8/w6wAOU z5CoWojLBqMnDS8aLmKc/tYUFdEpw4/vcinu2pPV0OZg+96HtP0myCHXkzy3TvgY6+tEOf4ytM2TE wl/u0I/lcL6DwsGHL3qNMNjxonGUSuuH3peLunv9L5gVPuvDC+uMj6pUE6BAFLaiI6wh4/cpvAdi2 0AhTiDt7taGWuDFUwf/a0B/KA8JU7fWaVn+ATUwzIBssaOYV5mKusT2IvRWv97GMO7s3s1nfV9U4G KjRYt/BOfYUomdCV2Szg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fveZ2-00051k-0D; Fri, 31 Aug 2018 08:13:56 +0000 Received: from mail-bl2nam02on0048.outbound.protection.outlook.com ([104.47.38.48] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fveYV-0004lg-9B for linux-arm-kernel@lists.infradead.org; Fri, 31 Aug 2018 08:13:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tk/3BBOGvSH8mjzrpmZNyvfjMH/ibe0Pb5ZBdJjw43Y=; b=c5/fvgMT5lHEIl7/tB14JUy3pvOcpIsISjCx1y+wiVJhj/1UQqsTqL7ZoOfnsrIUNJ+mrjdutOVXkag4tjiEXqPfz2h7ucTGkC3bDgH0nCnjpBmb2Q4F6z1m/Fis3hTtZ82ha7csubaPopPFO0Uoo92MZOQM3aGXVEouncM4ung= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by BY2PR0301MB1573.namprd03.prod.outlook.com (2a01:111:e400:526e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Fri, 31 Aug 2018 08:13:07 +0000 Date: Fri, 31 Aug 2018 16:10:03 +0800 From: Jisheng Zhang To: , "David S. Miller" , Andrew Lunn , Gregory CLEMENT Subject: [PATCH net-next v2 2/3] net: mvneta: enable NETIF_F_RXCSUM by default Message-ID: <20180831161003.3f0dc351@xhacker.debian> In-Reply-To: <20180831160810.2539ef4c@xhacker.debian> References: <20180831160810.2539ef4c@xhacker.debian> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: TY1PR01CA0180.jpnprd01.prod.outlook.com (2603:1096:402::32) To BY2PR0301MB1573.namprd03.prod.outlook.com (2a01:111:e400:526e::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8e9cbb7-cb50-4147-f4c7-08d60f199689 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BY2PR0301MB1573; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1573; 3:jOBJI3mx0U+5tTNN+y80vf1r2er32zTYmYicf1wkZYOK+9PIt5avVuXtv4s3XOeEVDsm7LDWhCd7df0Wnhb67Sz3hZyX7wSUcBSvYN3FFaOHuPLrRKklKDUSIz9302oPcKfN0vSEyNU/g+n3i/uykh436HqiEjAC1f4MsYkobBZnv2FyZkMEJkXIhyeEGz6iDEdKoWTnpnFqVSA0vGwjREEzmFo7A7whome+I5wsH2uVsYrRl7LcLY/cTeIo7WmU; 25:FHfflU2Cp4XgErIBY1xoE5Tepo1hj8YioTYOuWyHsx7vPORzuX3v/wLjV5TrO9Km3ybAa1CT8ha1zKEMKFGQRe6Q9fSz9kl0M1/RtQEIuVyBOfQcyrolOBhOoyylcWBcnSIITV6EGPERryvPirA8vnZVoA+GoQlewF/oYnbDwykLMjhIYXjzcb0MiHOzSV65J7WLxLKyX6T6d+1UK2G5nguA9+UAS3dd324hPRwxT1KIhJoRMcI7y6tR2egVg8sUF6lPRlfpFXJ5j780WztBGtnKBnweBRKjO2yjkgISNKH7xFPV2Iz8YOiqRf5O1jlpeogn5ca/bwQVA1nNDoHLJg==; 31:7fVHChj5bv5uQSIRGnwZEx3hdvqWI5RvqosC5j4gvH9vzR8CmUQwIm62fr8tIVkLn2LYB6ktZe5+cVr64J+l3spf9icgWAvl2vr0A23sijL6ZI5YDXNw7vK6B36kgbOX7QbtMvyS6qgSjnk/GUHuZx85TpXApwYOXhNfJKX7cKgBizHm8mNO69cNh+LaQLH6Y1CkDkTw3HvRowS/Dmi239jbXhOejMyJ79H294fVqF0= X-MS-TrafficTypeDiagnostic: BY2PR0301MB1573: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1573; 20:29nvxAXo5aLLAjtg9zcucY3VmZRQs1KC5QihNZFtL4g6K/vkXQXjmOTIsbR50WQctXzHM6KT+PdzrkXA5/uuyEhE9KQJL+nkE0nawsVWIsNWfstc4UINfACbRr0gpkDA/5lMFS0pk2wHsBOvUD0PvSVQk6fDYLK2MWkwrbWhlNAcjfIpa122XU2ftgm2Y4YKRzhyaJngzmVmZpYMHypJBDD0m+5Jr+UBXsq0sRggT7qkiLO1YhAFV22FFEmuYyJtSSVL5AO8BXPa2cKsS3MNoyreslt6M6T9OG+22qYEWkB8y+o9nBThyiZZDT2/ZRmq/GupBe1X9ufFuZn9c3TCSm9arpFhv1RZ+aCZT7OIai/rUq7SLoZXF6TXJHeb3+J2LLuEW1WiqcvBn1Bf+IBAKlfQTbLMDPDuUSJOysJhBuwZ1r3OYeAv51qOXJ3BMTgp/pVlJGqn0mLeiBSxZU9lMa6zhPYpFjgq7x8Ybp3R0SCGgACXOxibKr77QsRF3HeW; 4:B8ZhU7WVGBUa0AfA3bPj2k9qH1orZYGmbnYDNII2YejE61mauy3AHUar3V5lXHuMOZD2lnKsLQzWraBQ58gplcYVxAigGedvEcCqw0+muWQajyZpDZbngYu51Sm1frGT9Ea9Yo9yzk5bMxTqSsKT6+lxvgw0yXewNHOQfN8nfNNjZz076Qz9SootSy8zojJ2SlcmuQS73ULuNppNMphkus81WCX4MqCDNsPl6cYI0k8qHhMkmxKK6YGge4Ne2xqlC5d/cvdlQMmOJcZamF8CDg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699016); SRVR:BY2PR0301MB1573; BCL:0; PCL:0; RULEID:; SRVR:BY2PR0301MB1573; X-Forefront-PRVS: 07817FCC2D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(346002)(376002)(366004)(199004)(189003)(110136005)(25786009)(316002)(52116002)(97736004)(7696005)(16526019)(47776003)(486006)(76176011)(66066001)(4326008)(26005)(186003)(50466002)(386003)(14444005)(6506007)(86362001)(81156014)(305945005)(2906002)(8936002)(50226002)(9686003)(8676002)(6666003)(7736002)(106356001)(72206003)(81166006)(3846002)(55016002)(105586002)(53936002)(478600001)(6116002)(11346002)(446003)(33896004)(956004)(476003)(68736007)(230700001)(1076002)(23726003)(5660300001)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0301MB1573; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR0301MB1573; 23:j3uPlZtRxsyQ0Rvf+FGznfjZ3xrkYUYOFvf0AiP?= hOOAhe9tqOK4dbPbrWU76XtAmHbNw9TGYhV3yT1o81bZ3RwWDk3BA/9ootITwD8M4rD4Q6CBwCEjeHrZS5ivOtrJOKID4p4G/49WUTmihetfNKDjcbforEDWH/mR/3yyZsGCQWy+LKI5D5u8DOOEeZz14aD3xYkTglZHBz5mDAT8Vom6fUfjD8hP84TsR1Nb6dDq/J0kBpvB/I5JotCPVFmj0Kd5mgUCb9b+svBUvFmWWWZjFkCRM5xlLqwoF+c+/qviP55uInPsTtD9uM9DK8FWBfYKYi/uF/zxZ9AGc2R6Lx2Rgc1HF31xcNOaUpux/7hP7wNie9kTN+UPGDcc+/J/JOPbX8uR2QMsgbhTnIMlffYGijqA/NivNnbylZQGX+DHno90HYzJ6t1JKfAdqGz3/RSAB8qisagPSqgf/xsD88FEGnFn1+EC21YBT2FgeaSlpI6DXSESYboRKPu5B2Go8K1z/pIE35eigIlIIWjUFF+J+jDFqhZ4loMNaZqvt45IfWTLiS6m09v58VoeqysDiwuE4UnSO1FGS5Yak97JeQldm2I3cSfjE8XaQ15TzO3AgXv+CCfZu1j29JJyilJg4E+GoAXib4/jyPLv5n7jXuS15mwPFXYdMYcF+Dvyhpr+AcGJkBxRnFRySkqmxzPr2bOvBJvczjS59sVZZg+GD2Fhju6fWcutXpSkUH/FohRpGBaEda4xYbKdo1peszSg6Wqz7GD+efXuuHfIIO2HKPSGLittmHzoQFMlv91xgjUWXbvprSNPlkZzEyAXid0TV2Tc3Hpv60lEctyIOdaOEdjSPFEzCwrs1wvH5GFdRTBpJ/0mW4eXquCUvMthqsT47ybLAP64rTLo7bblX1CtggZuiYEO49o9TJywRL66U7flIbqHUvixdPVRU+ZMXbJOS/mzyHH0YwCxSmLKDqg8eWBi4GpDBXGBxNX0Mh8rlb+fY3eg+gOjSZcbG2fGwhrVsOez66+L1BRuAVRa3aMu+ikmWXBlXl53sr2dUjiixRzPKter4TCPpnShyOp6kmLbaGVbQqOj9E3YNt93wz/45MeUu61pBlNBlwA5lXXvkCmsfxup1tOI+flJAENtMImudmPb/5EqfR2QuHbRHFShsBkjWKC3mZC+QQJvjkzF5f1exc0KjQqHGKUsl6Cze1PzrUnKO5hNcqS0o71taMLWYiM0NHJ5IsM5OoCbwmnxYT/Q= X-Microsoft-Antispam-Message-Info: lyE9I0LuzlBaiFrcjJqedgUoawIyrdeYNvFJbu7W4/UyyFOjm0b6BS6rB/x0eo0KEywe+rqpYqPzGGpuQoqyOWoN8+9Xna9XCjurqDxRb5NOFfrPXkI6a5o9oJvxxny/qXDkSHhZ6lgXAERFLX752Yi8wiCWKICGiKLRWn3SRX9f9dG5s3jKd8sQp3aQrZJcK+6AAL6axkFEW+sFTR8LpsDIebPzrelunwft9TTaXiZf1jOnous456xSgR+ynNuGwA5p4HD1eKOAEs3nWfXeg6AiE0+vh5gW67WYkiK/uxKlEeKdW+chI2hRLNdDeuVhJcMQtm+hSiTaJq9uQHyMDeCZkhxpYZwdsTEzmLGkwHY= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0301MB1573; 6:cIIqQYoeg+DAHXK3zSFtFy9wEsgB5EzStPyCPPzLRYWEmfd/E9SSWxxfkt7uvQQ1N6kjRLa3UnfEKuTbbWYdQ3UvZ6O1cSIs1ZTIVhBQ8SynHy71puT4TsBE45pCZ3Io+Xu05SI983TKylh6PwgYTI7J6zfeotvs4fprPpwSyYT5vFgZgUdItjje+Eqwk9K1KON/1N3aWLrrhjK9NIDVwbOCw8FQRJZyY5Qg8BDCJTj/5a1cFV3M+RCjkofdudjYqc5PtJnD/YTbSS6+zlfUtbqubmVMXWrcL8B/qjY+obmAmCRVt7O2piAFb/lDFCJI2uhcT0DieNgizFSBfL5VzW0gMv2QQxxLxr+EVLNSwnYhtxN7bAcONaj91RvdPJAn0D9teFNt5f17dezuT4lG7850oHv6fVs5VMVpAr3L4Y/2EzOqBm/n3xrrphwAOFmRKRYB5irKB5rEExiuFuyW5A==; 5:2RLHCzsrw7XFa48kQ5yrZqaFGrYHsA+zkYF34AfIFSsHolmaBvVtjTnLeX31pdi/RixJ1JRUAeXAkqWJk1mVAkTIxbqo2mc21c9pNsBU1yBEW2fBudl3sc/a0qPTBRydanWsDPsXKOV6yopCK5YBiHY3Lf5LMpZJqGwbwe5SILQ=; 7:X3SMzlbGLpn5oU/Ap2Llddl85Gdemoyx/VOJXovNaVC87fU5DFyOgmgdd0lqwpOMk27plsWquaCGB/FoRJf20GHzDShVxZkigejF/HGnvqHmQ43nLTBkiIi0BS16J24kAKNOxT5ZzBSOUN9skHDTKoiP6uU534eAszKcrAqGl4foaGmjcQyKCNBUtB0WL7h5ki/fgx92h8rc2UXCf0z/zgWeGSceI5Z5MTtB9YMUPe/69SZ+2yb4bDMQb8wUSeWH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 08:13:07.3079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8e9cbb7-cb50-4147-f4c7-08d60f199689 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB1573 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180831_011323_431641_42955F00 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The code and HW supports NETIF_F_RXCSUM, so let's enable it by default. Signed-off-by: Jisheng Zhang Reviewed-by: Gregory CLEMENT Tested-by: Andrew Lunn --- drivers/net/ethernet/marvell/mvneta.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 814aee92a1d3..bcd20ebb2ebd 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4595,7 +4595,8 @@ static int mvneta_probe(struct platform_device *pdev) } } - dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_TSO; + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | + NETIF_F_TSO | NETIF_F_RXCSUM; dev->hw_features |= dev->features; dev->vlan_features |= dev->features; dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; From patchwork Fri Aug 31 08:11:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10583305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79AB213AC for ; Fri, 31 Aug 2018 08:15:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6881F2B9C7 for ; Fri, 31 Aug 2018 08:15:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5A7B72B9CE; Fri, 31 Aug 2018 08:15:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D5EAE2B9C7 for ; Fri, 31 Aug 2018 08:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=efGUH4FTAFHi+ZLP2gE3pgQJryiY5RLdz2o4zC9H00U=; b=DEKWcqMOgZe4IM H1ovBbK1JLKfHxt+OK2AHcOc8RJqRrWn+AldzJSaAGAQuguiqD/iQsYPqGyQ4ToCEqsuX06/5UaNe x6IjOYFf7dWdZ8qt+gPMsaGbOrmoNpKwYbWC44A9pLaRE7SXnikhBhySqZ/wfTc2JLnDGd73WGCeK pW8CiRyUfF1EOryPcl70O5rQkmJOvwXcawz5VhVC4dfzaGtqBjiz3R6NkhXxYvCJgX1Wk4O249Ej8 x8jq4PPcerZvmXcGcgHd3D/7dDPJl/D1c7UMkG6PfXixLnRceYCdoUke+dnQ7jUTymNbl48QRboNz O9x6Es+uRw8VREnvOZoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fveZx-0005Lz-3Q; Fri, 31 Aug 2018 08:14:53 +0000 Received: from mail-eopbgr680044.outbound.protection.outlook.com ([40.107.68.44] helo=NAM04-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fveZe-0005Cg-KH for linux-arm-kernel@lists.infradead.org; Fri, 31 Aug 2018 08:14:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HFn8rgeC1vgsMFnOwppdlgQ10jgxRC9rr9awKFyZhsY=; b=QDubzUykpuixDTLy9EnPBdNntAjUGoiRsflkbUFdA8N1FvD6lftZmEuAAoMOYMV4YRRR9sIKC+Ik5ycUkVU9u7VQT5o2xdxHE6FBwLLzgFbaWGhQafXV4QOsA5ebzSMW49eLi0u6gm4l43buRnBHXFqk//8NNmvdsyDIMu5T57o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by CY1PR0301MB1578.namprd03.prod.outlook.com (2a01:111:e400:529c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.15; Fri, 31 Aug 2018 08:14:18 +0000 Date: Fri, 31 Aug 2018 16:11:09 +0800 From: Jisheng Zhang To: , "David S. Miller" , Andrew Lunn , Gregory CLEMENT Subject: [PATCH net-next v2 3/3] net: mvneta: reduce smp_processor_id() calling in mvneta_tx_done_gbe Message-ID: <20180831161109.23db0901@xhacker.debian> In-Reply-To: <20180831160810.2539ef4c@xhacker.debian> References: <20180831160810.2539ef4c@xhacker.debian> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: OSAPR01CA0172.jpnprd01.prod.outlook.com (2603:1096:604:c::16) To CY1PR0301MB1578.namprd03.prod.outlook.com (2a01:111:e400:529c::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84e9e948-e200-42f3-c6dd-08d60f19c0f2 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR0301MB1578; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1578; 3:DlIc0YFZsDBMpbAsB8g6yqNuREw2NFjhpWSAl5bdtA4Etcqj7eDgaPfBwbscFeJ/muoXt6ovSB9jdclISOyVMuzSXjtn1gUOfy6hYgbCmnFTEWL+szWRmYbFoSxzb6a7D37iDDVhK6Xn1sMYJlGTiBoEYr5j2nuYeUeTBEJWPFUyc4IjYxyw/BoWPKgt97J9s55DCA3msGnlVaLrJEQKWQYVLi31sxWunyT7jVHdX+UQ6vHfIwZPn83on85o6Is6; 25:6EeIkQbBa6aEkXuBrUGCpcMo4iNtqvGMTxW6eGPIxROLYMmz/qafDpFCEsZ2HxkP6s+Zn69hgd4+1ISBqjMa53S1hipCUJYlxXGJhHezXuxMvV2usI8bBNC1zRKD1MU/ujeVnZtvkVZdRi49AVBe9aWmnpkvVT6CXQHUfk94H0TlQ1zH09Hwl7AMvZRZgahuFOSLaae5wn+sU58g6l1k3kNev37OP2jaFEDzFmLgJT8/du0W8H/YMcmc+65ULnfjkfSnqw+T0E7hRC0DY1CLFncQolwBga0bmJ/MbWOyyg53KeMGdsCIsYWnjNbHt+crmdHKl+tLx/pLZi09jSShqQ==; 31:ZkLr6AJ+0qwtwQ5MfnvZC01PArnAUbwHyaej/UXa3GHkywtReztLqDTzGv9dT7h+uma++a2Vdh8I8dzl9CIGIK5uI7wOP3g6ji8lpCmp+nrPOCWIvumn2n90HYOL6CahNzLgZYCO4jn8sIcACa0jOZZBEJ5N134UAp4bnCkldLImCcPVEYef+Dc6aJ8JuXJZ/DwQeVvNG8fQ7WLSA3qYHXKN9gUCiMkEninzVNvJLwA= X-MS-TrafficTypeDiagnostic: CY1PR0301MB1578: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1578; 20:0+NgwjKiolxfnfx5ZYQsfjaIpEUiJhKOvrcE8N+RbUNymrSOv5l6deXe8tcgtxYvFBm5VhYWgPeBRiQfzqojBXAtOwTcmjbL10W/9++Myf6H1H8jc5clLaam/jN3nWyIUtSdggJwl6hUcpfeilk0eJdmMXjtYYH4/oZn/QStxKlDZCSAWmAP891o8VMW74XN77ylKjpNrykvOZQhAk9iouE6FdahnsaKxRb0TxqU2HPQnkXrOThQ6mM5OBzPAATWilVjZgxfo0htYYM+6gWmELKRIJxYEEErY+nZ0iN0ml382juy5/udmAcEQHoc1LdoEBsl4CTaEFR4TMSBYcMbq5OAbRsT/dpCyyC3TFHXOn9AXPJ4GIklO7f4b1+BS29zRPeTfZUvWZx4ZB+sQbrufKgIUOidPTo19aXytL/EgqIMmtt5w++B4kJMZNDMk6qEbfz0dn9hB3G5RnNki6YA2HMVR1pMHtchlcFkLSI9EpSz1J4hMZXcVhBTAR3eWcpX; 4:OzAhYZvf0dhQONxrdgtlosHxCsgyimCW8yW8JVIkVT4wahILwr3a5BhiNzHbU3zFjHNNoUqfitaqt8dNcGrlEbBC+xSSQ+nmsvbOl+bDz4LMohkrJ8Rrr+O40fXhgjHRhKNb6ixnM+tQQzxDavhCVg2HvjhCAOTVzPXSmYqPVFoXN4enhYTe5zsH9q/D40L6RvhHDINucUboA9auIxEmr5/UeHX9mYNKTL3bD20Z+ndgvWeR90Mvvc7DPg6FykSM+7KddznZFLRnpTPYLoTb2A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699016); SRVR:CY1PR0301MB1578; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB1578; X-Forefront-PRVS: 07817FCC2D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(39850400004)(376002)(346002)(366004)(189003)(199004)(53936002)(55016002)(956004)(476003)(11346002)(9686003)(486006)(386003)(47776003)(106356001)(105586002)(97736004)(7736002)(6506007)(66066001)(4326008)(33896004)(81166006)(25786009)(5660300001)(2906002)(8936002)(26005)(50226002)(81156014)(8746002)(72206003)(14444005)(16526019)(316002)(1076002)(7696005)(52116002)(50466002)(110136005)(6116002)(6666003)(3846002)(86362001)(23726003)(186003)(68736007)(76176011)(8676002)(305945005)(446003)(478600001)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB1578; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1578; 23:EQLxBRhP3ZSbXnhEYVqJxiKiTJtoSnGhmm2uW61?= hy+GDuwrkBSmOumMo5i607yNrXHEwsxLcxd/8e6NtUm3LFG/MoJQJLFF3Mi4fOh/eCcv0LqfZnd4kq4sGzFBA7h8ku5pQp/JDxNELx9nqEx7bAcsTPT2p7Sqo5vGKemJmKAdPYaV7ANYoAbV+xRtOOzYRJsBswDa5fY3P4Mku6cUAY2PbCsFy+1/e17D3nbJ5z42yXBydN4A564DFw31h+gqjLRq/dhganFzlhORVpsaNvHmEQ/uBqRNNtilFYXPaKZNilyfq1MhNgqwGU68kTJuIAcW8ytiVkGG3ObW4+cwO9caNA19bh00Oql+yySeWtNZi5kgjT9YeAgtRNI0AawUcw/bVLZUNfMmXuNpX4esRvz/e5nhW4d++rrsMywoS1jby7ZhN5jOpNz2DH8eqejmPdWGivjJKbUkcFM3gld6nwDRxgcaDLW9kzNzZIyt54y43/sbWcvv4DhpDbni7Y6RN83TpyUWYyzv9FBQPbvKi5nrS6oNwVTgVo6JPp84tYS9txhBlj4ocnfESjfFoZEA5yu1SysvyLZ5UHZepjIGjOryLNjT+s16ekVJzAQDAtEd2bR/3EAQLVuVClKp7cD56+roX+cFuwRjCsZPkgkrvqNyoEPvFomoeWREWBx+pr+Wab/571skEFb2yy+IuJg6gkBBpMhO5VyRwUMQmP+0UpXO6FRvtghhQ1sjcsJdT7do1X9KnH1eWt1bZ1l2W2VZFZI0sj+v6a9c5gK8avB9Zd+M8v2b2T0pHwNRcPWPzUoSHSpERnNlXds1TX7obvv04b3XU5i5edq0J6O+nAB+CEUdPTXd+kNTTjD/650t7VVkduGp/CbQDzD+nxUGjtXil83KEsd+Pj0sdjcVE4c4FKj359VjXzvZ5M2VXhikuxTSVJEke5dzKy51mSHhDdzY2n/DDjp6WzagzGlLWz+H7DG05EFt2c1bA2LbwwjoeImZ+IETernmg4ttFpHA3O+7VmmLVyW80HL/yHd6u10YSHhpRz6Ee418WqUustyiwIduykp0Ru0g2EtAKaxpQEpSN5c6Nkhp1ufMnyputR+geE7yQFz8ITu5e9pt0it83T4yUovQ+lPb+fNneYNGtTy1r4erePzDjPuYrEtczgoDRFYnB6okRgnWwUXkq+nlpQTVFU1fYTyDtjrz/Uc5OXG27rq3raB9hB7xoN9wnfOK4gw== X-Microsoft-Antispam-Message-Info: YmczNd/kPny1tyzI7ZPOzgdnKa0XZNP+CIYe+3TNVyde3t54KNUzO7gk9wBkkOjx7wTMkT5B4HQea/HzzaiL14xxmVVA82OJIpXziiuKjIIFxQMgg5z4RjrZmbtbFApMTnWnRClHWb08MzFuMT79hW+trRtEDPMqltrtha5z9OohDH8UKLaktOagYO9snPO7hculXTgo26PcBye9o8Ju8EXYI0+/DXJczj/Cn7buoyEf8ViAIDlgHjLUoO1UBwLCctqVGPxhXy6Q+8N+XX6+op6CN8eEHguP8eHyIZ9rw+oJME2YSTMFcwQmE803U/R8beoIStCEF+Lc0X0+Xyq27ao3IjrtgJTvQGXMIAmWbmY= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1578; 6:1TWmNJl9r+pd4wq1xhgsk+CPMhEu14DquXEWazO5BJu/QLbTTWnp8E3rMDTVNICyyCP6Cok1rPvzIA4sUihggMUY1XgBw50E92pM34XrcKk85wLmmKGLp04MZsEpnfB1inE/BKGTnC/uDHQAMNGi6bHNQ5fI4TijzzCjYDz3aSvUEUexjqq/b7Y8jqj8bF0ogaBxtA7Ch5NikB3POELHTCzveRgBnZBqdiaI299kYkNipEmCxMGShYcL63v7cNDnC2Mw6vpWwe/Ff4lXG/Y8votEcHb+AzNtP3+yXt24+nEWxhO7zjxq7cn1q+PxHnX9crKQldmlM4rt5Lm8ev/asysI6E/9KHq5TS4pDscYd11bC9j1i87y/GzXeN2jiFg6vXLA3fmRZJ6M7pfA++Ey9ll54ZWbS1ACuZMRwFO01+vY24lBQDk19RY1Y/ha0qlUYh37ZCWplpKv6FU25CGtnQ==; 5:Cz5Y4dXF/dYszrqLNWHPL9KJzX0oOIYhMgexryvALdI66obvRqwX8bseHmnosLtSr5qTpwcJPNnZvZf1XdnW3tYXPm9SyYK3ghTlyz7192eg+/N25BRz/s+QbrblZqLXxXVpJpT/dnsXLMmDNuLpZ79Jy33ysveUeiZWCOTSa28=; 7:AsyznVvcqC34oIP3abXiuLAuU2+Url+EGL1mJ6eDK1vqiOgt1tNt7IY4t5BdDhIWgqfNa6CviYOzO6Qp5IRhKOpQh3f18sEyqozGdIytnyDgOH1bgaZ62NOgKtaHo61iwqDLPbFQzDmknKlgS/J/XQi8Ucosw3dHQwZ6SBMT22gsZjfd0IQ0dyAA17iXkiBxZf+woDr7R8vS6XkhiFtlm02vxD0BOMpMZ338BvUnrW4vZWyEd+sOgppYm2zQH3hj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2018 08:14:18.5692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84e9e948-e200-42f3-c6dd-08d60f19c0f2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1578 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180831_011434_822519_5849224D X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In the loop of mvneta_tx_done_gbe(), we call the smp_processor_id() each time, move the call out of the loop to optimize the code a bit. Before the patch, the loop looks like(under arm64): ldr x1, [x29,#120] ... ldr w24, [x1,#36] ... bl 0 <_raw_spin_lock> str w24, [x27,#132] ... After the patch, the loop looks like(under arm64): ... bl 0 <_raw_spin_lock> str w23, [x28,#132] ... where w23 is loaded so be ready before the loop. From another side, mvneta_tx_done_gbe() is called from mvneta_poll() which is in non-preemptible context, so it's safe to call the smp_processor_id() function once. Signed-off-by: Jisheng Zhang Reviewed-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index bcd20ebb2ebd..fe3edb3c2bf4 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2507,12 +2507,13 @@ static void mvneta_tx_done_gbe(struct mvneta_port *pp, u32 cause_tx_done) { struct mvneta_tx_queue *txq; struct netdev_queue *nq; + int cpu = smp_processor_id(); while (cause_tx_done) { txq = mvneta_tx_done_policy(pp, cause_tx_done); nq = netdev_get_tx_queue(pp->dev, txq->id); - __netif_tx_lock(nq, smp_processor_id()); + __netif_tx_lock(nq, cpu); if (txq->count) mvneta_txq_done(pp, txq);