From patchwork Tue Jun 25 04:03:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014591 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD11B13AF for ; Tue, 25 Jun 2019 04:04:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BBBF528958 for ; Tue, 25 Jun 2019 04:04:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA9C328A8B; Tue, 25 Jun 2019 04:04:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EE4F28958 for ; Tue, 25 Jun 2019 04:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727605AbfFYEE1 (ORCPT ); Tue, 25 Jun 2019 00:04:27 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:42769 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbfFYEE1 (ORCPT ); Tue, 25 Jun 2019 00:04:27 -0400 Received: by mail-pg1-f193.google.com with SMTP id k13so2057971pgq.9; Mon, 24 Jun 2019 21:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g9gX3zxll6zE+1uSeRtgAyQGhpa5fKumdosEKJfzBW0=; b=p+bcQPG1DVyB7xMBrPkvvc0Ox5Iz9EBMpyV0raFeoKQmP6LJ0QzMVHaAG0yS8+BLqq j6wQjW15M4RY2XkDn07BTZ15lUq4QJuhdY1LF8aZSFj0nao/xFNLqAL7vAA9EDYFysI2 jLMDupU8+Ap51UUyJSIQ/x00FJJ74rWTB5Oa6Db9anDfbGbl1dZ3CatqM8WAgKWxhFBX DdXAIZtkucpinIk+H8T1a3me8wKz5PzH4NkG5YiHcbr5ds+PbhA+NsLIed16ouZzRcHg WcO376mVd1S/qqWEoGnQvFVygb3NAf9CdhttjNtovc2CdIkRDR8onXzQfViYDoSyFYkj 05dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g9gX3zxll6zE+1uSeRtgAyQGhpa5fKumdosEKJfzBW0=; b=RLV1jo2V9xecEi6/+yz4OUCUYGjXxXf+Gg4cTJgwjnL/wtpSAZ6PRCqEs7iB7u79SV ypp8UBjxrtlRozYCyAypwUVrlywkCzfHYDfVKpru/MlBzxxNs1UMdq4wXxRjyN2joJTt Lc6LQhZ8uIGIn1XlZ725XyxPQvlg2ruW+lDDT69OqCAwHaXc0bgQG/93UEy70Hn++KZB z7UEZr8t0CKFaEUhHc9CK9sYNV7N0chmXsp4HbpT4kOjzd9fQkekWtSz9hihsq9rzgci wKDjxfI2NxHx053aNvzvLnyZHqpisFK2coycpy9BsLtRAck0CzQB7mIyejDw1LZnY1DR mTLQ== X-Gm-Message-State: APjAAAXaRg69ROyGANamwt/gB2cmKca8UgKfck8EeicxQzRxzMPX/hbh kdDlMV2vSGxHMqyXDo3Va5Q= X-Google-Smtp-Source: APXvYqyNN77OOXop+gEg4sOeYGo8mqh8bsP9mbQeXWgn4HKyTdkIWs0BlsqL+j9klhaVMVDd5jkLgw== X-Received: by 2002:a63:c006:: with SMTP id h6mr35712535pgg.285.1561435466679; Mon, 24 Jun 2019 21:04:26 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.04.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:04:25 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:42 +0700 Message-Id: <20190625040356.27473-2-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran Acked-by: Will Deacon --- arch/arm/kernel/perf_event_v7.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c index a4fb0f8b8f84..2924d7910b10 100644 --- a/arch/arm/kernel/perf_event_v7.c +++ b/arch/arm/kernel/perf_event_v7.c @@ -697,9 +697,9 @@ static struct attribute_group armv7_pmuv2_events_attr_group = { /* * Event filters for PMUv2 */ -#define ARMV7_EXCLUDE_PL1 (1 << 31) -#define ARMV7_EXCLUDE_USER (1 << 30) -#define ARMV7_INCLUDE_HYP (1 << 27) +#define ARMV7_EXCLUDE_PL1 BIT(31) +#define ARMV7_EXCLUDE_USER BIT(30) +#define ARMV7_INCLUDE_HYP BIT(27) /* * Secure debug enable reg From patchwork Tue Jun 25 04:03:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014595 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E1A113AF for ; Tue, 25 Jun 2019 04:04:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70CB728958 for ; Tue, 25 Jun 2019 04:04:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 644EC28A8B; Tue, 25 Jun 2019 04:04:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 213BB28958 for ; Tue, 25 Jun 2019 04:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbfFYEEi (ORCPT ); Tue, 25 Jun 2019 00:04:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34562 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbfFYEEi (ORCPT ); Tue, 25 Jun 2019 00:04:38 -0400 Received: by mail-pf1-f195.google.com with SMTP id c85so8735946pfc.1; Mon, 24 Jun 2019 21:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DDy1WkQD0dK7gdWmitUgF418A+VoWDfrpb0wHmc1mYA=; b=K7gwR0CyijlbY3YZc8B2x2u0/adB0A+/R04ABH63rc2y+6gv1B68/8FhSZKao0dYp4 mZx0Sn6E8g7yMaMUuxlnw9SnQ6k/XhG4BkSJfPNFKvVg2Fk8KKQtxyvM7+L1htTL3x/k e0Qr2gFAhtRbwdPL1NkDO6gx/VILUsHza0JQLOIJ5LrXvITtdRgz4zrk7Vhapb/lRE+I g5CaWjAYu8sx+pDTOp1mJ5q4+OgGIi7jgbIbu9Ies6tH7GcR/DC4KhavfLBpqhvW/4nx JuYNJMS1Y8L6q1m0j4+cS58+ON+zI4s3ThYtsgjo16wK/LKYYzdoVVPjZm6t4vSLFglT z9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DDy1WkQD0dK7gdWmitUgF418A+VoWDfrpb0wHmc1mYA=; b=PKL0Qv0TBXO1IVAnBEB0F+vpdjSryHsotUN5knOadYoKWBV4ewYIBWFj+HowUVmwuC XFvRck3u2z7xY9sT495jkSaH/7oxELbCIlpsGlMzpClUJa59Wfg08cYVCZrNWX7CRHnC rb0Xh0mFIrDsd9hv1hpAFoJ2OlCAmPgTKHmt7EcwW//oYd2m4+csTAllxJwY3dxpPoDa ygGZ7vGUVdKfpaDkNdngd89+ucoayyQqNjVGCmEsimxgHI96763VAB/fzC91uqUFSxv1 XemZOS8YMslKuAK+CXcU3LX/FoST7DsLmcxZJJKriiuldDZCIb3zXlgmAx+mGurzdNqf tYMQ== X-Gm-Message-State: APjAAAW4Cpv3/kuv4d+PJ/W+IHKMHuPupRBMEWTTtPgIaQzzkFSfsKR0 S9qq4x6SZ17fzj2v3hE+E9s= X-Google-Smtp-Source: APXvYqzE/jneACOKQHIUzLdU0Rs2n+Lx05YqPiShfm/TNG5baavnFWWNvRflijx3fuT44ITIWu5wjQ== X-Received: by 2002:a63:2985:: with SMTP id p127mr34417218pgp.400.1561435477442; Mon, 24 Jun 2019 21:04:37 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:04:36 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 02/15] ARM: davinci: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:43 +0700 Message-Id: <20190625040356.27473-3-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-davinci/ddr2.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/ddr2.h b/arch/arm/mach-davinci/ddr2.h index 4f7d7824b0c9..f2f56d16d7d5 100644 --- a/arch/arm/mach-davinci/ddr2.h +++ b/arch/arm/mach-davinci/ddr2.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ #define DDR2_SDRCR_OFFSET 0xc -#define DDR2_SRPD_BIT (1 << 23) -#define DDR2_MCLKSTOPEN_BIT (1 << 30) -#define DDR2_LPMODEN_BIT (1 << 31) +#define DDR2_SRPD_BIT BIT(23) +#define DDR2_MCLKSTOPEN_BIT BIT(30) +#define DDR2_LPMODEN_BIT BIT(31) From patchwork Tue Jun 25 04:03:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014599 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8C6E6C5 for ; Tue, 25 Jun 2019 04:04:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAA9428958 for ; Tue, 25 Jun 2019 04:04:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E55F28A8B; Tue, 25 Jun 2019 04:04:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UPPERCASE_50_75 autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00DD228958 for ; Tue, 25 Jun 2019 04:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfFYEEt (ORCPT ); Tue, 25 Jun 2019 00:04:49 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37250 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbfFYEEt (ORCPT ); Tue, 25 Jun 2019 00:04:49 -0400 Received: by mail-pf1-f196.google.com with SMTP id 19so8727889pfa.4; Mon, 24 Jun 2019 21:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F8Kb4z8RdLx6raUcS0p8FRcOvdw1X96ihV1Yk72nI3A=; b=gPb6jlDz4n/tvBurH30VLZbX0zlrb2hVHD6iZgQ/n3eTChM21RfGQJNr9Ijsjzmy0O jHmtQK8vIVWSZNlL6jCO3cYqh2EPpy35W977XVJyor8/4MW475rQQyV/ObOzarTgsHmY t2mqSrk/k2p/wlzaw4IRpXQdjFaQoHWqucfYM3MM2b+M8UIn3pnY8E8m+mRpI/Igb7Np dSybFFhRgaKFrs/64ZxAvB6OvV5FSxxlmONXBpSO4x+eVTKVobAXA0PNkSvQJV9dyi9L cmvwu3W1rWM7/nVeVfK1GlvJ1L8iiX3IxDfQ50+LA0xtxjcry9G6bUYrYlJQKIptdRDC FExQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F8Kb4z8RdLx6raUcS0p8FRcOvdw1X96ihV1Yk72nI3A=; b=fGUdMl20rFFoP0eq5AKJDKV5rr7LoVcJev7C5dqzKSTGh0mQD73noZ6wxmMxz0bgew COqA3O61kZ/d3KEhJ0isrxZMA4dtQmfR2p/wIk4Cy0TdMC0uTbNy4xvCDie/2Kpd/qcV mRdZXwtSxaJp62pLgnjp4ZjKvp8+ohAIbMYLeS1Zwd3dLfiLQCiZ3RIl0HJ5b5EwNvSH /F80483WBzanS4UcQd+pqxZE427Rz7fIxgutEEUZbpfAn5BensEXD5oWNaj5CqgUCgGB 3Uy5H/C6Qe/GoLzKCHxe5wBjY+hTqtaBKamH7uZwIwzneJpMHQM01v0xneziv3+lRC7L DTHg== X-Gm-Message-State: APjAAAX3b7YnBfY9uiGvZANDos1OFHGNYgFACwY7Kg+jKHk6r5uNllZ5 9JYn1sxb3toKL6v9+XivTkE= X-Google-Smtp-Source: APXvYqwc4EoRoMUH73TQF3bNRPhcxoElD/rkwtHN5L7evWVM75uoM8ukEdrMmgLzEbhjYHGjDiICVQ== X-Received: by 2002:a63:d4c:: with SMTP id 12mr8614724pgn.30.1561435488268; Mon, 24 Jun 2019 21:04:48 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.04.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:04:47 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 03/15] ARM: ep93xx: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:44 +0700 Message-Id: <20190625040356.27473-4-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran Acked-by: H Hartley Sweeten Acked-by: Alexander Sverdlin --- arch/arm/mach-ep93xx/soc.h | 134 ++++++++++++++++++++++----------------------- 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/arch/arm/mach-ep93xx/soc.h b/arch/arm/mach-ep93xx/soc.h index f2dace1c9154..e580a22ad071 100644 --- a/arch/arm/mach-ep93xx/soc.h +++ b/arch/arm/mach-ep93xx/soc.h @@ -109,89 +109,89 @@ #define EP93XX_SYSCON_REG(x) (EP93XX_SYSCON_BASE + (x)) #define EP93XX_SYSCON_POWER_STATE EP93XX_SYSCON_REG(0x00) #define EP93XX_SYSCON_PWRCNT EP93XX_SYSCON_REG(0x04) -#define EP93XX_SYSCON_PWRCNT_FIR_EN (1<<31) -#define EP93XX_SYSCON_PWRCNT_UARTBAUD (1<<29) -#define EP93XX_SYSCON_PWRCNT_USH_EN (1<<28) -#define EP93XX_SYSCON_PWRCNT_DMA_M2M1 (1<<27) -#define EP93XX_SYSCON_PWRCNT_DMA_M2M0 (1<<26) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P8 (1<<25) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P9 (1<<24) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P6 (1<<23) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P7 (1<<22) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P4 (1<<21) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P5 (1<<20) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P2 (1<<19) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P3 (1<<18) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P0 (1<<17) -#define EP93XX_SYSCON_PWRCNT_DMA_M2P1 (1<<16) +#define EP93XX_SYSCON_PWRCNT_FIR_EN BIT(31) +#define EP93XX_SYSCON_PWRCNT_UARTBAUD BIT(29) +#define EP93XX_SYSCON_PWRCNT_USH_EN BIT(28) +#define EP93XX_SYSCON_PWRCNT_DMA_M2M1 BIT(27) +#define EP93XX_SYSCON_PWRCNT_DMA_M2M0 BIT(26) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P8 BIT(25) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P9 BIT(24) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P6 BIT(23) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P7 BIT(22) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P4 BIT(21) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P5 BIT(20) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P2 BIT(19) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P3 BIT(18) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P0 BIT(17) +#define EP93XX_SYSCON_PWRCNT_DMA_M2P1 BIT(16) #define EP93XX_SYSCON_HALT EP93XX_SYSCON_REG(0x08) #define EP93XX_SYSCON_STANDBY EP93XX_SYSCON_REG(0x0c) #define EP93XX_SYSCON_CLKSET1 EP93XX_SYSCON_REG(0x20) -#define EP93XX_SYSCON_CLKSET1_NBYP1 (1<<23) +#define EP93XX_SYSCON_CLKSET1_NBYP1 BIT(23) #define EP93XX_SYSCON_CLKSET2 EP93XX_SYSCON_REG(0x24) -#define EP93XX_SYSCON_CLKSET2_NBYP2 (1<<19) -#define EP93XX_SYSCON_CLKSET2_PLL2_EN (1<<18) +#define EP93XX_SYSCON_CLKSET2_NBYP2 BIT(19) +#define EP93XX_SYSCON_CLKSET2_PLL2_EN BIT(18) #define EP93XX_SYSCON_DEVCFG EP93XX_SYSCON_REG(0x80) -#define EP93XX_SYSCON_DEVCFG_SWRST (1<<31) -#define EP93XX_SYSCON_DEVCFG_D1ONG (1<<30) -#define EP93XX_SYSCON_DEVCFG_D0ONG (1<<29) -#define EP93XX_SYSCON_DEVCFG_IONU2 (1<<28) -#define EP93XX_SYSCON_DEVCFG_GONK (1<<27) -#define EP93XX_SYSCON_DEVCFG_TONG (1<<26) -#define EP93XX_SYSCON_DEVCFG_MONG (1<<25) -#define EP93XX_SYSCON_DEVCFG_U3EN (1<<24) -#define EP93XX_SYSCON_DEVCFG_CPENA (1<<23) -#define EP93XX_SYSCON_DEVCFG_A2ONG (1<<22) -#define EP93XX_SYSCON_DEVCFG_A1ONG (1<<21) -#define EP93XX_SYSCON_DEVCFG_U2EN (1<<20) -#define EP93XX_SYSCON_DEVCFG_EXVC (1<<19) -#define EP93XX_SYSCON_DEVCFG_U1EN (1<<18) -#define EP93XX_SYSCON_DEVCFG_TIN (1<<17) -#define EP93XX_SYSCON_DEVCFG_HC3IN (1<<15) -#define EP93XX_SYSCON_DEVCFG_HC3EN (1<<14) -#define EP93XX_SYSCON_DEVCFG_HC1IN (1<<13) -#define EP93XX_SYSCON_DEVCFG_HC1EN (1<<12) -#define EP93XX_SYSCON_DEVCFG_HONIDE (1<<11) -#define EP93XX_SYSCON_DEVCFG_GONIDE (1<<10) -#define EP93XX_SYSCON_DEVCFG_PONG (1<<9) -#define EP93XX_SYSCON_DEVCFG_EONIDE (1<<8) -#define EP93XX_SYSCON_DEVCFG_I2SONSSP (1<<7) -#define EP93XX_SYSCON_DEVCFG_I2SONAC97 (1<<6) -#define EP93XX_SYSCON_DEVCFG_RASONP3 (1<<4) -#define EP93XX_SYSCON_DEVCFG_RAS (1<<3) -#define EP93XX_SYSCON_DEVCFG_ADCPD (1<<2) -#define EP93XX_SYSCON_DEVCFG_KEYS (1<<1) -#define EP93XX_SYSCON_DEVCFG_SHENA (1<<0) +#define EP93XX_SYSCON_DEVCFG_SWRST BIT(31) +#define EP93XX_SYSCON_DEVCFG_D1ONG BIT(30) +#define EP93XX_SYSCON_DEVCFG_D0ONG BIT(29) +#define EP93XX_SYSCON_DEVCFG_IONU2 BIT(28) +#define EP93XX_SYSCON_DEVCFG_GONK BIT(27) +#define EP93XX_SYSCON_DEVCFG_TONG BIT(26) +#define EP93XX_SYSCON_DEVCFG_MONG BIT(25) +#define EP93XX_SYSCON_DEVCFG_U3EN BIT(24) +#define EP93XX_SYSCON_DEVCFG_CPENA BIT(23) +#define EP93XX_SYSCON_DEVCFG_A2ONG BIT(22) +#define EP93XX_SYSCON_DEVCFG_A1ONG BIT(21) +#define EP93XX_SYSCON_DEVCFG_U2EN BIT(20) +#define EP93XX_SYSCON_DEVCFG_EXVC BIT(19) +#define EP93XX_SYSCON_DEVCFG_U1EN BIT(18) +#define EP93XX_SYSCON_DEVCFG_TIN BIT(17) +#define EP93XX_SYSCON_DEVCFG_HC3IN BIT(15) +#define EP93XX_SYSCON_DEVCFG_HC3EN BIT(14) +#define EP93XX_SYSCON_DEVCFG_HC1IN BIT(13) +#define EP93XX_SYSCON_DEVCFG_HC1EN BIT(12) +#define EP93XX_SYSCON_DEVCFG_HONIDE BIT(11) +#define EP93XX_SYSCON_DEVCFG_GONIDE BIT(10) +#define EP93XX_SYSCON_DEVCFG_PONG BIT(9) +#define EP93XX_SYSCON_DEVCFG_EONIDE BIT(8) +#define EP93XX_SYSCON_DEVCFG_I2SONSSP BIT(7) +#define EP93XX_SYSCON_DEVCFG_I2SONAC97 BIT(6) +#define EP93XX_SYSCON_DEVCFG_RASONP3 BIT(4) +#define EP93XX_SYSCON_DEVCFG_RAS BIT(3) +#define EP93XX_SYSCON_DEVCFG_ADCPD BIT(2) +#define EP93XX_SYSCON_DEVCFG_KEYS BIT(1) +#define EP93XX_SYSCON_DEVCFG_SHENA BIT(0) #define EP93XX_SYSCON_VIDCLKDIV EP93XX_SYSCON_REG(0x84) -#define EP93XX_SYSCON_CLKDIV_ENABLE (1<<15) -#define EP93XX_SYSCON_CLKDIV_ESEL (1<<14) -#define EP93XX_SYSCON_CLKDIV_PSEL (1<<13) +#define EP93XX_SYSCON_CLKDIV_ENABLE BIT(15) +#define EP93XX_SYSCON_CLKDIV_ESEL BIT(14) +#define EP93XX_SYSCON_CLKDIV_PSEL BIT(13) #define EP93XX_SYSCON_CLKDIV_PDIV_SHIFT 8 #define EP93XX_SYSCON_I2SCLKDIV EP93XX_SYSCON_REG(0x8c) -#define EP93XX_SYSCON_I2SCLKDIV_SENA (1<<31) -#define EP93XX_SYSCON_I2SCLKDIV_ORIDE (1<<29) -#define EP93XX_SYSCON_I2SCLKDIV_SPOL (1<<19) -#define EP93XX_I2SCLKDIV_SDIV (1 << 16) +#define EP93XX_SYSCON_I2SCLKDIV_SENA BIT(31) +#define EP93XX_SYSCON_I2SCLKDIV_ORIDE BIT(29) +#define EP93XX_SYSCON_I2SCLKDIV_SPOL BIT(19) +#define EP93XX_I2SCLKDIV_SDIV BIT(16) #define EP93XX_I2SCLKDIV_LRDIV32 (0 << 17) #define EP93XX_I2SCLKDIV_LRDIV64 (1 << 17) #define EP93XX_I2SCLKDIV_LRDIV128 (2 << 17) #define EP93XX_I2SCLKDIV_LRDIV_MASK (3 << 17) #define EP93XX_SYSCON_KEYTCHCLKDIV EP93XX_SYSCON_REG(0x90) -#define EP93XX_SYSCON_KEYTCHCLKDIV_TSEN (1<<31) -#define EP93XX_SYSCON_KEYTCHCLKDIV_ADIV (1<<16) -#define EP93XX_SYSCON_KEYTCHCLKDIV_KEN (1<<15) -#define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV (1<<0) +#define EP93XX_SYSCON_KEYTCHCLKDIV_TSEN BIT(31) +#define EP93XX_SYSCON_KEYTCHCLKDIV_ADIV BIT(16) +#define EP93XX_SYSCON_KEYTCHCLKDIV_KEN BIT(15) +#define EP93XX_SYSCON_KEYTCHCLKDIV_KDIV BIT(0) #define EP93XX_SYSCON_SYSCFG EP93XX_SYSCON_REG(0x9c) #define EP93XX_SYSCON_SYSCFG_REV_MASK (0xf0000000) #define EP93XX_SYSCON_SYSCFG_REV_SHIFT (28) -#define EP93XX_SYSCON_SYSCFG_SBOOT (1<<8) -#define EP93XX_SYSCON_SYSCFG_LCSN7 (1<<7) -#define EP93XX_SYSCON_SYSCFG_LCSN6 (1<<6) -#define EP93XX_SYSCON_SYSCFG_LASDO (1<<5) -#define EP93XX_SYSCON_SYSCFG_LEEDA (1<<4) -#define EP93XX_SYSCON_SYSCFG_LEECLK (1<<3) -#define EP93XX_SYSCON_SYSCFG_LCSN2 (1<<1) -#define EP93XX_SYSCON_SYSCFG_LCSN1 (1<<0) +#define EP93XX_SYSCON_SYSCFG_SBOOT BIT(8) +#define EP93XX_SYSCON_SYSCFG_LCSN7 BIT(7) +#define EP93XX_SYSCON_SYSCFG_LCSN6 BIT(6) +#define EP93XX_SYSCON_SYSCFG_LASDO BIT(5) +#define EP93XX_SYSCON_SYSCFG_LEEDA BIT(4) +#define EP93XX_SYSCON_SYSCFG_LEECLK BIT(3) +#define EP93XX_SYSCON_SYSCFG_LCSN2 BIT(1) +#define EP93XX_SYSCON_SYSCFG_LCSN1 BIT(0) #define EP93XX_SYSCON_SWLOCK EP93XX_SYSCON_REG(0xc0) /* EP93xx System Controller software locked register write */ From patchwork Tue Jun 25 04:03:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6099213AF for ; Tue, 25 Jun 2019 04:05:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5375328958 for ; Tue, 25 Jun 2019 04:05:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 478D428A8B; Tue, 25 Jun 2019 04:05:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0486328958 for ; Tue, 25 Jun 2019 04:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfFYEFB (ORCPT ); Tue, 25 Jun 2019 00:05:01 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33077 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfFYEFB (ORCPT ); Tue, 25 Jun 2019 00:05:01 -0400 Received: by mail-pg1-f195.google.com with SMTP id m4so7627081pgk.0; Mon, 24 Jun 2019 21:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tcmSm3hw/C8D+isK27AbfqRPmFCyR1+5B65dPM4uqtg=; b=mu1QVdM1AkIn8/v63c/WAWX38xkY+s9zX86yN8ezeyi38zz7UMXQqXRAIrpWTdEj22 ADYxJkjVzJW29+m0cOYfIWcJOZA+McBGv5n8cPFyZl9zUPkHTxX+tQzyN3u3lLIHB+B+ oNrOHO4FTVSc6kt0xEaV+IpEkz7SzzjlgCQyIRnQJC8GQZfo2cGKyG7h2slh/aSdeSV1 /C9nywHxGxtnmDOEqS4uis4AwMoHyPFM/XdWkvUQ9Ivv52gi1SXNJmv496LD4z/IxnNO xporYbqLrwnulcN+LQ+D5OsbqKDLwkUP9J0OhPxVw50LvUAGHHx8jL8n98ZfT6sGQsY0 HvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tcmSm3hw/C8D+isK27AbfqRPmFCyR1+5B65dPM4uqtg=; b=nVvqeZuv5FB1EPngznMVca0DqtSAJLWA1+dwv7fkFKtkRZ4j+guo8H4S5fyq8plnUZ ClXA07wzgPrKvFUOlgw4tyRegCfKWlMz9h/t/eCUooUMGdGzX647DHCigN7Vs140uAqu OUfBOjdimQw2N+EYWSjJ+3SwPO8XW+ccXRxEszIAGe/EdXMFHSDZNKZaFApm82WEUJZG KE5cV12Ipm4NMzyuytOVjjTBkRCiqve0UT0mTRWe1gfA25i6SXwbIKKzUUBx2IQ2/b1s u/k7TvgtHo+qvYsSo5RyMunIRlGHGwLgeXzUuijUI+HFqui3BLq0bvuzuprfInCsNXzv yCIw== X-Gm-Message-State: APjAAAU0Yp9/i62mJ2l7z46YqqpkqVCjeooibCye0mPQ8KlnPV2U7lAP DvCJ/JTbl6yixBUqT2hDYu4= X-Google-Smtp-Source: APXvYqx9oMj075qmx/aNwhyyhT7MNXmzmt1m9Bg4eZQVB6M3zczaguDlo2yDNPIf5Ye91pmut4aS2A== X-Received: by 2002:a17:90a:360c:: with SMTP id s12mr29602003pjb.30.1561435500184; Mon, 24 Jun 2019 21:05:00 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.04.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:04:59 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 04/15] ARM: exynos: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:45 +0700 Message-Id: <20190625040356.27473-5-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-exynos/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index be122af0de8f..983d5f1d0c29 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -285,7 +285,7 @@ static void exynos_pm_set_wakeup_mask(void) * Set wake-up mask registers * EXYNOS_EINT_WAKEUP_MASK is set by pinctrl driver in late suspend. */ - pmu_raw_writel(exynos_irqwake_intmask & ~(1 << 31), S5P_WAKEUP_MASK); + pmu_raw_writel(exynos_irqwake_intmask & ~BIT(31), S5P_WAKEUP_MASK); } static void exynos_pm_enter_sleep_mode(void) From patchwork Tue Jun 25 04:03:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6B2796C5 for ; Tue, 25 Jun 2019 04:05:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B13628958 for ; Tue, 25 Jun 2019 04:05:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D61828A9C; Tue, 25 Jun 2019 04:05:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03BE528958 for ; Tue, 25 Jun 2019 04:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727859AbfFYEFM (ORCPT ); Tue, 25 Jun 2019 00:05:12 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33115 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfFYEFL (ORCPT ); Tue, 25 Jun 2019 00:05:11 -0400 Received: by mail-pf1-f195.google.com with SMTP id x15so8746469pfq.0; Mon, 24 Jun 2019 21:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NwvK03LyNmiunrWDZlJJgmSS8YZo2C1RqTMo9dix3Fs=; b=AAoNPyt3mDNtyitZPCM2n9R1V+8lOxDrljEZ9C4uePvYyDM/UJsfFgcIlJM3WtkGkI /oWTlZnnBCoIeJwiJ0/htBXQ9r7aGBcPEVXERVZj0lqExPoE3RsTEvWGrHFhU3As3WBC X1MWbeVNF//UzWsGYwNFDKmkYbQFP9QWlTlVi73U4C7ORLit+UBWKBGVF/eJGYqUykSZ EFXlvTI2lYGJbXPMBrXQwpZOvOhPAgAa3UUu4keLtM8PKiKs0hzkLkG+LypHuwlj8+VO Hn2f5kRJ3Tkfzgj+4/5f9IDpKVgUtO3y+x6IuL8gaprH6VYg/4H8Vh8blaihIkKxk9XE Q7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NwvK03LyNmiunrWDZlJJgmSS8YZo2C1RqTMo9dix3Fs=; b=YQfv2WvpW/b2cSzYRw2QLFFbeRTnS/OHAlMW9UVgqzW0O1C/zdcH2f55RvJ6n1Wrme GxlgR/jL6H5JqwHYzuMCPPaPJG7pC1EILfDpPumR47hKCblSvD/i3uiD21ZAxDfHBKuF FSsKkxgcjUUmCnwf9HyhYjFP0yepNtLPesDZHrLwHUb46tAjEyIzedH1m/pYK1NXOlsP ThjeUeZjkqPBstXQVAF7XLuXl46ZVetR7Bj7JBnGDQwV3wUqOsGVuuzk5GmM+pN8JxIQ 8BRGTMAk1qkt94E0XgcILWCPbrjpY8yqnnwzwKEbD0Hgkk0XKJfFelKxbjGRQe7+eeXT Cjcg== X-Gm-Message-State: APjAAAW2wVtUuA8VI2B2FzRYM1xYRkpgkQ9A9Pc5gtZTCzJPNsDaIDUC 5QCcYxfwcyK48VHPrUMdJtc= X-Google-Smtp-Source: APXvYqwl9bb5pqm7bGxTCo7Jmg3L12Vp3eOl6vq5TM2UCQhs4IfP2UhLaSguPxoJaJVj6MMigvLLvg== X-Received: by 2002:a63:d1d:: with SMTP id c29mr26905708pgl.251.1561435510818; Mon, 24 Jun 2019 21:05:10 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:05:10 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 05/15] ARM: footbridge: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:46 +0700 Message-Id: <20190625040356.27473-6-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-footbridge/dc21285.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-footbridge/dc21285.c b/arch/arm/mach-footbridge/dc21285.c index 8b81a17f675d..edea41e0256f 100644 --- a/arch/arm/mach-footbridge/dc21285.c +++ b/arch/arm/mach-footbridge/dc21285.c @@ -230,7 +230,7 @@ static irqreturn_t dc21285_parity_irq(int irq, void *dev_id) printk("\n"); cmd = *CSR_PCICMD & 0xffff; - *CSR_PCICMD = cmd | 1 << 31; + *CSR_PCICMD = cmd | BIT(31); /* * back off this interrupt From patchwork Tue Jun 25 04:03:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A79B413AF for ; Tue, 25 Jun 2019 04:05:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 98A1A1FF7F for ; Tue, 25 Jun 2019 04:05:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A7DE28A9C; Tue, 25 Jun 2019 04:05:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UPPERCASE_50_75 autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED0D428958 for ; Tue, 25 Jun 2019 04:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727954AbfFYEFX (ORCPT ); Tue, 25 Jun 2019 00:05:23 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37301 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfFYEFW (ORCPT ); Tue, 25 Jun 2019 00:05:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id 19so8728648pfa.4; Mon, 24 Jun 2019 21:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P5ZfvrfdpwcPdxORGRAqSpAtYRzseINlQkpUQtY2Ws8=; b=H/thxvAkmhccSFOhdG4Yzyj4HFw4dRw1wxnLtEeN4H220s85dFXYPB7QQoQgqhDSYz lQe3VralzjZtjvNhiTGnPLni35yOy5T5/BmHSLIpE2DEoJZ+xB7CDJu83rnkJXQUTpDn N6Oeahun1Pm1f1Q208+sOa1h4bdICS3pudLVvwkMzM+ivMk77jlOEkhuoiJ+/lEFAxgl khUkctK0fBgPhCw+8JrcXV8wJz5KaZV5pufJ8ccLm4LKtlzwaeCcRHSk1Ru+CMkcam5c LIVdHGvZBwVUa7elusJjg/2VwAZx2ZW8hJg8Lsp4y4TrqivRiwA/4HoqQWHJNnyZq7LI faag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P5ZfvrfdpwcPdxORGRAqSpAtYRzseINlQkpUQtY2Ws8=; b=nyWHOqUqH6Je7ON8IkDBKYn0PxbWPkn7sUv/QSYjLQC4Hf8fcUjIKFzLblEde5aWRj 4kk5vO7vm5UC0x9g5c8DY9Q4DwuoTs/Fim7sTTlKwQXDaVHdOPeNmpzGWOfMwC07Z1GR HwZDOEoigyoBwBXhkM/vgjeRrWiFoJBp+7Lt9pgs+/plM3OxzOGPHRcQ3kVtSejtuPQj T8RLSfruoS9ZRvy8y9ly45XO1PTpG6BirGnLyiJF+NuWf/toHtYauRuduIxszLb1xSXo nefR7UEUXHV2FEm/46mLd7XJq6K49IrjpoNrAYopogg0WMFCfkflY6L5LMAol7JduqCl /JCw== X-Gm-Message-State: APjAAAWX8yDLRXaLJtItUNHwaSUseaQ9leUhxhLG/usqOk7HZQ7ApJk5 5hSh/x+Uypgntp1qe1AtS0k= X-Google-Smtp-Source: APXvYqzVX9z21NZUDUWfhMfzAAEyTfaGnYblo7+GzElYdVodS9Is62qTVne1bUjZ83rqmOFc/ZytwQ== X-Received: by 2002:a17:90a:ac0e:: with SMTP id o14mr29411138pjq.142.1561435521875; Mon, 24 Jun 2019 21:05:21 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:05:20 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 06/15] ARM: imx: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:47 +0700 Message-Id: <20190625040356.27473-7-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-imx/iomux-mx3.h | 64 +++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-imx/iomux-mx3.h b/arch/arm/mach-imx/iomux-mx3.h index 99270a183d47..028b683866c3 100644 --- a/arch/arm/mach-imx/iomux-mx3.h +++ b/arch/arm/mach-imx/iomux-mx3.h @@ -59,38 +59,38 @@ enum iomux_pad_config { * various IOMUX general purpose functions */ enum iomux_gp_func { - MUX_PGP_FIRI = 1 << 0, - MUX_DDR_MODE = 1 << 1, - MUX_PGP_CSPI_BB = 1 << 2, - MUX_PGP_ATA_1 = 1 << 3, - MUX_PGP_ATA_2 = 1 << 4, - MUX_PGP_ATA_3 = 1 << 5, - MUX_PGP_ATA_4 = 1 << 6, - MUX_PGP_ATA_5 = 1 << 7, - MUX_PGP_ATA_6 = 1 << 8, - MUX_PGP_ATA_7 = 1 << 9, - MUX_PGP_ATA_8 = 1 << 10, - MUX_PGP_UH2 = 1 << 11, - MUX_SDCTL_CSD0_SEL = 1 << 12, - MUX_SDCTL_CSD1_SEL = 1 << 13, - MUX_CSPI1_UART3 = 1 << 14, - MUX_EXTDMAREQ2_MBX_SEL = 1 << 15, - MUX_TAMPER_DETECT_EN = 1 << 16, - MUX_PGP_USB_4WIRE = 1 << 17, - MUX_PGP_USB_COMMON = 1 << 18, - MUX_SDHC_MEMSTICK1 = 1 << 19, - MUX_SDHC_MEMSTICK2 = 1 << 20, - MUX_PGP_SPLL_BYP = 1 << 21, - MUX_PGP_UPLL_BYP = 1 << 22, - MUX_PGP_MSHC1_CLK_SEL = 1 << 23, - MUX_PGP_MSHC2_CLK_SEL = 1 << 24, - MUX_CSPI3_UART5_SEL = 1 << 25, - MUX_PGP_ATA_9 = 1 << 26, - MUX_PGP_USB_SUSPEND = 1 << 27, - MUX_PGP_USB_OTG_LOOPBACK = 1 << 28, - MUX_PGP_USB_HS1_LOOPBACK = 1 << 29, - MUX_PGP_USB_HS2_LOOPBACK = 1 << 30, - MUX_CLKO_DDR_MODE = 1 << 31, + MUX_PGP_FIRI = BIT(0), + MUX_DDR_MODE = BIT(1), + MUX_PGP_CSPI_BB = BIT(2), + MUX_PGP_ATA_1 = BIT(3), + MUX_PGP_ATA_2 = BIT(4), + MUX_PGP_ATA_3 = BIT(5), + MUX_PGP_ATA_4 = BIT(6), + MUX_PGP_ATA_5 = BIT(7), + MUX_PGP_ATA_6 = BIT(8), + MUX_PGP_ATA_7 = BIT(9), + MUX_PGP_ATA_8 = BIT(10), + MUX_PGP_UH2 = BIT(11), + MUX_SDCTL_CSD0_SEL = BIT(12), + MUX_SDCTL_CSD1_SEL = BIT(13), + MUX_CSPI1_UART3 = BIT(14), + MUX_EXTDMAREQ2_MBX_SEL = BIT(15), + MUX_TAMPER_DETECT_EN = BIT(16), + MUX_PGP_USB_4WIRE = BIT(17), + MUX_PGP_USB_COMMON = BIT(18), + MUX_SDHC_MEMSTICK1 = BIT(19), + MUX_SDHC_MEMSTICK2 = BIT(20), + MUX_PGP_SPLL_BYP = BIT(21), + MUX_PGP_UPLL_BYP = BIT(22), + MUX_PGP_MSHC1_CLK_SEL = BIT(23), + MUX_PGP_MSHC2_CLK_SEL = BIT(24), + MUX_CSPI3_UART5_SEL = BIT(25), + MUX_PGP_ATA_9 = BIT(26), + MUX_PGP_USB_SUSPEND = BIT(27), + MUX_PGP_USB_OTG_LOOPBACK = BIT(28), + MUX_PGP_USB_HS1_LOOPBACK = BIT(29), + MUX_PGP_USB_HS2_LOOPBACK = BIT(30), + MUX_CLKO_DDR_MODE = BIT(31), }; /* From patchwork Tue Jun 25 04:03:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3AC4D13AF for ; Tue, 25 Jun 2019 04:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CF4828555 for ; Tue, 25 Jun 2019 04:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F26428640; Tue, 25 Jun 2019 04:05:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D28F928555 for ; Tue, 25 Jun 2019 04:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727651AbfFYEFd (ORCPT ); Tue, 25 Jun 2019 00:05:33 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36237 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfFYEFd (ORCPT ); Tue, 25 Jun 2019 00:05:33 -0400 Received: by mail-pf1-f193.google.com with SMTP id r7so8736594pfl.3; Mon, 24 Jun 2019 21:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YRyG2m/HTgUXvb9XPa4NKmZS68q/D8dq2TH6hCDyN6g=; b=MD8nMSyWkqgB9886a77oHe9Ojrkt37f+JaT0Og5afSgCAJEAzkBVNZXdmWchGl4NCa yP1bAIv9Rx40J9EDvwT2D+LvbN8zwdBSQfsOkLf/0tUOsO7zX+Rg6Ne4q8Ggkd5nxrTn A2uViA0BsQQpw5hl0COiSXM5vSMRKQeodOZB/x6Un4p/jRnbfJBNUaYdePJ8fOJWCiE6 tOzWC4oXE+21kpAawt33vXU6s6pFWnNujwFf8UK47wxlnyttO/s6wg3HWZCxuJzZaXSp uf/k1lIYp6hM/mNIIPkU2dBqyu1jniXQsDGE/AxhS3KJGEJvQ7P1PxMY2Wjg9gutgHRH vFAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YRyG2m/HTgUXvb9XPa4NKmZS68q/D8dq2TH6hCDyN6g=; b=qi+nZga1AUMXBzRPqTLhBFR+kj0PEYWYyiyqW6K4zyIrTxHAAxG3WnDfRHzaJUxer6 oHB0r3O/Y5+8nsJIaykNFmxSTrpJM2c3OxWScvbBSkSWQ6l/HIJgdU3p5gV1eJyyplPT HRsdvY7scYpZ6V8o9eojtAttZgqUyFhONEsecudTk+SZf1KldM6NqnVL4IzquXhs6xI7 aolO8HVMf0OR7fWdJ75+gYUlG7zUur2kwKiIdLDz87XjRKJDbgHgoq3pYRlHzzcQOt3y 04G+4sPwf2LT6qxwxlOo6vxTGBkqMWWkh+Uqn2EJuwjkbQ23pybN9OgSo77pr1mluVv5 2Zbw== X-Gm-Message-State: APjAAAX3sQaOsx7lfawnp3lxBEX8kYeHksqBbjXLg/sGcPGJyh5O1xGD xNIPONEfI9CgsIiZX57YfpA= X-Google-Smtp-Source: APXvYqy62/xvfadVbHvWl8aZK6eiO4mnUmJVdf2xlhll5ZmBu5m7hFTBzduvDIwyiC7ECD26+EBqBQ== X-Received: by 2002:a63:c106:: with SMTP id w6mr36891650pgf.422.1561435532450; Mon, 24 Jun 2019 21:05:32 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:05:31 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 07/15] ARM: ks8695: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:48 +0700 Message-Id: <20190625040356.27473-8-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-ks8695/regs-pci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-ks8695/regs-pci.h b/arch/arm/mach-ks8695/regs-pci.h index 75a9db6edbd9..7d28a83bb574 100644 --- a/arch/arm/mach-ks8695/regs-pci.h +++ b/arch/arm/mach-ks8695/regs-pci.h @@ -45,9 +45,9 @@ -#define CFRV_GUEST (1 << 23) +#define CFRV_GUEST BIT(23) #define PBCA_TYPE1 (1) -#define PBCA_ENABLE (1 << 31) +#define PBCA_ENABLE BIT(31) From patchwork Tue Jun 25 04:03:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014619 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3A8F6C5 for ; Tue, 25 Jun 2019 04:05:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E294328555 for ; Tue, 25 Jun 2019 04:05:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D35E128640; Tue, 25 Jun 2019 04:05:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UPPERCASE_50_75 autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44BC928555 for ; Tue, 25 Jun 2019 04:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727521AbfFYEFo (ORCPT ); Tue, 25 Jun 2019 00:05:44 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37863 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEFo (ORCPT ); Tue, 25 Jun 2019 00:05:44 -0400 Received: by mail-pl1-f195.google.com with SMTP id bh12so8065436plb.4; Mon, 24 Jun 2019 21:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3hDPzui9gf1WJ+/ZpgOxbemW+83id6X2TA1vUibRHx4=; b=Fo1NHV0BJqLJ4S96AdDzTs/jSOHPt9gmqGZ8TvWo98NAqyU0YU0nvg71DBudR/9RqE BartdV0MEmoB/P/G0UMqx5ERrP68S1hoVUwY4UZP/gu0w4zkqZ7u56a2C0PoMDXjBfuE wXMAvxc/yPFZwTNfG0QAemkvpZI5iDDlBcZnG5RWU0YE2vSMgeok50hEJzDd2ZfFQb2N ubSgi2HR/a6acvCT1kBlNinKNCu4KWpOZo6zDzJEJuC9eZkhde4FdYcdcfTs7STELFQ2 aK3qTmP0jKsVIieMIEk+ODIXe+ap456VPMW1e8jv38MCxI4y8GMw8kdfV6OJD8H0WpaM 7ElQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3hDPzui9gf1WJ+/ZpgOxbemW+83id6X2TA1vUibRHx4=; b=rRFnkFi9Udl21uLd00V41UJzs5v1lVzFkdPSJ6KjmvQEg0meh0lOGeCHe16slqKpsH 6TpFZPA+h7uDMhZBr7nRGw62uKTDClmVxUScFPPGO2QDFu3tcTNrmZv8Qbv5WQJ1ooH5 pTdG8XlvMSOTCEXMB8o/Br/U87J8C3NUWMpi0QlQJaIrMFJPTgFmciWXoGGII3+slkSE vlTtq6VUOyRPJvh2fXP3Lf6ifutLLWtRNIpWpEe5tp0zG2Yo3JWQw7JoUGo+qDvf9dpB FlH75GEpCW9ryAdXz29ze8VgC/ID7FM+nTHXPqXcIFXbSi3ZDMMDIQKC4fMMiYT5TER2 nEVA== X-Gm-Message-State: APjAAAWfhuuCU8+flQ+siWASeWKfn1OmN9bg64kkWj/CuDhmUNX4Nj5u gPPy9sLqWjoNIH4U4HbzNGk= X-Google-Smtp-Source: APXvYqwZ8lBUH7HPfJB7xYWCYlHNQRAMCUJlf+u6GBRLPOz4OFDdA7pKSMVTok+/Obo6WBtd0L5bFA== X-Received: by 2002:a17:902:2f:: with SMTP id 44mr91323064pla.5.1561435543196; Mon, 24 Jun 2019 21:05:43 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:05:42 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 08/15] ARM: mmp: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:49 +0700 Message-Id: <20190625040356.27473-9-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-mmp/pm-mmp2.h | 40 +++++++++++------------ arch/arm/mach-mmp/pm-pxa910.h | 74 +++++++++++++++++++++---------------------- 2 files changed, 57 insertions(+), 57 deletions(-) diff --git a/arch/arm/mach-mmp/pm-mmp2.h b/arch/arm/mach-mmp/pm-mmp2.h index 70299a9450d3..8b1d91543676 100644 --- a/arch/arm/mach-mmp/pm-mmp2.h +++ b/arch/arm/mach-mmp/pm-mmp2.h @@ -12,37 +12,37 @@ #include "addr-map.h" #define APMU_PJ_IDLE_CFG APMU_REG(0x018) -#define APMU_PJ_IDLE_CFG_PJ_IDLE (1 << 1) -#define APMU_PJ_IDLE_CFG_PJ_PWRDWN (1 << 5) +#define APMU_PJ_IDLE_CFG_PJ_IDLE BIT(1) +#define APMU_PJ_IDLE_CFG_PJ_PWRDWN BIT(5) #define APMU_PJ_IDLE_CFG_PWR_SW(x) ((x) << 16) -#define APMU_PJ_IDLE_CFG_L2_PWR_SW (1 << 19) +#define APMU_PJ_IDLE_CFG_L2_PWR_SW BIT(19) #define APMU_PJ_IDLE_CFG_ISO_MODE_CNTRL_MASK (3 << 28) #define APMU_SRAM_PWR_DWN APMU_REG(0x08c) #define MPMU_SCCR MPMU_REG(0x038) #define MPMU_PCR_PJ MPMU_REG(0x1000) -#define MPMU_PCR_PJ_AXISD (1 << 31) -#define MPMU_PCR_PJ_SLPEN (1 << 29) -#define MPMU_PCR_PJ_SPSD (1 << 28) -#define MPMU_PCR_PJ_DDRCORSD (1 << 27) -#define MPMU_PCR_PJ_APBSD (1 << 26) -#define MPMU_PCR_PJ_INTCLR (1 << 24) -#define MPMU_PCR_PJ_SLPWP0 (1 << 23) -#define MPMU_PCR_PJ_SLPWP1 (1 << 22) -#define MPMU_PCR_PJ_SLPWP2 (1 << 21) -#define MPMU_PCR_PJ_SLPWP3 (1 << 20) -#define MPMU_PCR_PJ_VCTCXOSD (1 << 19) -#define MPMU_PCR_PJ_SLPWP4 (1 << 18) -#define MPMU_PCR_PJ_SLPWP5 (1 << 17) -#define MPMU_PCR_PJ_SLPWP6 (1 << 16) -#define MPMU_PCR_PJ_SLPWP7 (1 << 15) +#define MPMU_PCR_PJ_AXISD BIT(31) +#define MPMU_PCR_PJ_SLPEN BIT(29) +#define MPMU_PCR_PJ_SPSD BIT(28) +#define MPMU_PCR_PJ_DDRCORSD BIT(27) +#define MPMU_PCR_PJ_APBSD BIT(26) +#define MPMU_PCR_PJ_INTCLR BIT(24) +#define MPMU_PCR_PJ_SLPWP0 BIT(23) +#define MPMU_PCR_PJ_SLPWP1 BIT(22) +#define MPMU_PCR_PJ_SLPWP2 BIT(21) +#define MPMU_PCR_PJ_SLPWP3 BIT(20) +#define MPMU_PCR_PJ_VCTCXOSD BIT(19) +#define MPMU_PCR_PJ_SLPWP4 BIT(18) +#define MPMU_PCR_PJ_SLPWP5 BIT(17) +#define MPMU_PCR_PJ_SLPWP6 BIT(16) +#define MPMU_PCR_PJ_SLPWP7 BIT(15) #define MPMU_PLL2_CTRL1 MPMU_REG(0x0414) #define MPMU_CGR_PJ MPMU_REG(0x1024) #define MPMU_WUCRM_PJ MPMU_REG(0x104c) -#define MPMU_WUCRM_PJ_WAKEUP(x) (1 << (x)) -#define MPMU_WUCRM_PJ_RTC_ALARM (1 << 17) +#define MPMU_WUCRM_PJ_WAKEUP(x) BIT(x) +#define MPMU_WUCRM_PJ_RTC_ALARM BIT(17) enum { POWER_MODE_ACTIVE = 0, diff --git a/arch/arm/mach-mmp/pm-pxa910.h b/arch/arm/mach-mmp/pm-pxa910.h index 8e6344adaf51..fc2f9c4b9d94 100644 --- a/arch/arm/mach-mmp/pm-pxa910.h +++ b/arch/arm/mach-mmp/pm-pxa910.h @@ -10,53 +10,53 @@ #define __PXA910_PM_H__ #define APMU_MOH_IDLE_CFG APMU_REG(0x0018) -#define APMU_MOH_IDLE_CFG_MOH_IDLE (1 << 1) -#define APMU_MOH_IDLE_CFG_MOH_PWRDWN (1 << 5) -#define APMU_MOH_IDLE_CFG_MOH_SRAM_PWRDWN (1 << 6) +#define APMU_MOH_IDLE_CFG_MOH_IDLE BIT(1) +#define APMU_MOH_IDLE_CFG_MOH_PWRDWN BIT(5) +#define APMU_MOH_IDLE_CFG_MOH_SRAM_PWRDWN BIT(6) #define APMU_MOH_IDLE_CFG_MOH_PWR_SW(x) (((x) & 0x3) << 16) #define APMU_MOH_IDLE_CFG_MOH_L2_PWR_SW(x) (((x) & 0x3) << 18) -#define APMU_MOH_IDLE_CFG_MOH_DIS_MC_SW_REQ (1 << 21) -#define APMU_MOH_IDLE_CFG_MOH_MC_WAKE_EN (1 << 20) +#define APMU_MOH_IDLE_CFG_MOH_DIS_MC_SW_REQ BIT(21) +#define APMU_MOH_IDLE_CFG_MOH_MC_WAKE_EN BIT(20) #define APMU_SQU_CLK_GATE_CTRL APMU_REG(0x001c) #define APMU_MC_HW_SLP_TYPE APMU_REG(0x00b0) #define MPMU_FCCR MPMU_REG(0x0008) #define MPMU_APCR MPMU_REG(0x1000) -#define MPMU_APCR_AXISD (1 << 31) -#define MPMU_APCR_DSPSD (1 << 30) -#define MPMU_APCR_SLPEN (1 << 29) -#define MPMU_APCR_DTCMSD (1 << 28) -#define MPMU_APCR_DDRCORSD (1 << 27) -#define MPMU_APCR_APBSD (1 << 26) -#define MPMU_APCR_BBSD (1 << 25) -#define MPMU_APCR_SLPWP0 (1 << 23) -#define MPMU_APCR_SLPWP1 (1 << 22) -#define MPMU_APCR_SLPWP2 (1 << 21) -#define MPMU_APCR_SLPWP3 (1 << 20) -#define MPMU_APCR_VCTCXOSD (1 << 19) -#define MPMU_APCR_SLPWP4 (1 << 18) -#define MPMU_APCR_SLPWP5 (1 << 17) -#define MPMU_APCR_SLPWP6 (1 << 16) -#define MPMU_APCR_SLPWP7 (1 << 15) -#define MPMU_APCR_MSASLPEN (1 << 14) -#define MPMU_APCR_STBYEN (1 << 13) +#define MPMU_APCR_AXISD BIT(31) +#define MPMU_APCR_DSPSD BIT(30) +#define MPMU_APCR_SLPEN BIT(29) +#define MPMU_APCR_DTCMSD BIT(28) +#define MPMU_APCR_DDRCORSD BIT(27) +#define MPMU_APCR_APBSD BIT(26) +#define MPMU_APCR_BBSD BIT(25) +#define MPMU_APCR_SLPWP0 BIT(23) +#define MPMU_APCR_SLPWP1 BIT(22) +#define MPMU_APCR_SLPWP2 BIT(21) +#define MPMU_APCR_SLPWP3 BIT(20) +#define MPMU_APCR_VCTCXOSD BIT(19) +#define MPMU_APCR_SLPWP4 BIT(18) +#define MPMU_APCR_SLPWP5 BIT(17) +#define MPMU_APCR_SLPWP6 BIT(16) +#define MPMU_APCR_SLPWP7 BIT(15) +#define MPMU_APCR_MSASLPEN BIT(14) +#define MPMU_APCR_STBYEN BIT(13) #define MPMU_AWUCRM MPMU_REG(0x104c) -#define MPMU_AWUCRM_AP_ASYNC_INT (1 << 25) -#define MPMU_AWUCRM_AP_FULL_IDLE (1 << 24) -#define MPMU_AWUCRM_SDH1 (1 << 23) -#define MPMU_AWUCRM_SDH2 (1 << 22) -#define MPMU_AWUCRM_KEYPRESS (1 << 21) -#define MPMU_AWUCRM_TRACKBALL (1 << 20) -#define MPMU_AWUCRM_NEWROTARY (1 << 19) -#define MPMU_AWUCRM_RTC_ALARM (1 << 17) -#define MPMU_AWUCRM_AP2_TIMER_3 (1 << 13) -#define MPMU_AWUCRM_AP2_TIMER_2 (1 << 12) -#define MPMU_AWUCRM_AP2_TIMER_1 (1 << 11) -#define MPMU_AWUCRM_AP1_TIMER_3 (1 << 10) -#define MPMU_AWUCRM_AP1_TIMER_2 (1 << 9) -#define MPMU_AWUCRM_AP1_TIMER_1 (1 << 8) +#define MPMU_AWUCRM_AP_ASYNC_INT BIT(25) +#define MPMU_AWUCRM_AP_FULL_IDLE BIT(24) +#define MPMU_AWUCRM_SDH1 BIT(23) +#define MPMU_AWUCRM_SDH2 BIT(22) +#define MPMU_AWUCRM_KEYPRESS BIT(21) +#define MPMU_AWUCRM_TRACKBALL BIT(20) +#define MPMU_AWUCRM_NEWROTARY BIT(19) +#define MPMU_AWUCRM_RTC_ALARM BIT(17) +#define MPMU_AWUCRM_AP2_TIMER_3 BIT(13) +#define MPMU_AWUCRM_AP2_TIMER_2 BIT(12) +#define MPMU_AWUCRM_AP2_TIMER_1 BIT(11) +#define MPMU_AWUCRM_AP1_TIMER_3 BIT(10) +#define MPMU_AWUCRM_AP1_TIMER_2 BIT(9) +#define MPMU_AWUCRM_AP1_TIMER_1 BIT(8) #define MPMU_AWUCRM_WAKEUP(x) (1 << ((x) & 0x7)) enum { From patchwork Tue Jun 25 04:03:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014623 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 682FF14BB for ; Tue, 25 Jun 2019 04:05:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5860D28555 for ; Tue, 25 Jun 2019 04:05:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4BB2D28610; Tue, 25 Jun 2019 04:05:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06D6128640 for ; Tue, 25 Jun 2019 04:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbfFYEFz (ORCPT ); Tue, 25 Jun 2019 00:05:55 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40956 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEFy (ORCPT ); Tue, 25 Jun 2019 00:05:54 -0400 Received: by mail-pf1-f194.google.com with SMTP id p184so8724609pfp.7; Mon, 24 Jun 2019 21:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KDwfnX7xwMMDkQMnHt3pFpXnjghwDdHkKtC4VLqB4SU=; b=rDQhi8bGChxtNTh0gJtFuNhA03rAKj8scYAP7zQ3uoDPLFL73c2ylvY99p16axkPaL kbScHvo2weEld0oKeaEF2JxNAe+ielVIRdbMoa+XVd6KR3XbetkuDPI6BO7nEVSVi1fK Hto0YznWmSl3cRt0lQg47xEmErd7f8tDXwQf4gLRkYHrQx9ZWNisKDPYSmr9sae3W34+ lC9yTM8o3eXYvfIG8mvFNWcYDVw9JOQVK8mQP8h+Nr1M2vN+LFgSV0ie1K9dPWXQmqEH FLl5xEktRDb4+x+l3CkIYsi6YLJkwdAJRwWmlSMDXlKEidhZZxF6y9Lvl+6EWWkR+I77 oDXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KDwfnX7xwMMDkQMnHt3pFpXnjghwDdHkKtC4VLqB4SU=; b=AYvagOEriaVTQSZbntBp13zQbhM0Kxkkrg1sbqMauvvZwqfWQPr0WB3mdrgbvJrbKe yL+ohubEzfEh44rF1cu1twnB4ucCo4n7tOkp45j9gc2XokWT80hHdjxNXIXWvNwdVXEd jZ/jPgx6XkKcmT02HPdFNgJXuUP2CYtO4tUlQNneO4FFJZUEr30MrPrt+TMGYQ4zXXJ0 H2272Zv4qjN3u6wqdmvip5Nh1eb4vtuGoC9eAyQRMk/L6jrBIt10Agv4sXlyhpGZ2IbT eCsx8+3XWam72TAzrxoPqmgEv5ypvDlC6lLW9KTINe4wEunHant70t7iCEvenOsSCuHi rfXQ== X-Gm-Message-State: APjAAAV6ae8KKZJuZNYxEi26boc1QCnE0rb+5QU92EkAl3bA5vTG0ZCf +9daAJET0qLNi7AqUBux5HY= X-Google-Smtp-Source: APXvYqwIvSMIpqVD3ElwkpvCRmsXFTRnj87S4mkbg/jIQCkNu8APQo0Y4URhYDaPYz89wZaHPKLEnQ== X-Received: by 2002:a63:d53:: with SMTP id 19mr1887507pgn.453.1561435553986; Mon, 24 Jun 2019 21:05:53 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:05:53 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 09/15] ARM: omap2: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:50 +0700 Message-Id: <20190625040356.27473-10-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-omap2/powerdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c index 1cbac76136d4..886961726380 100644 --- a/arch/arm/mach-omap2/powerdomain.c +++ b/arch/arm/mach-omap2/powerdomain.c @@ -35,7 +35,7 @@ #include "soc.h" #include "pm.h" -#define PWRDM_TRACE_STATES_FLAG (1<<31) +#define PWRDM_TRACE_STATES_FLAG BIT(31) void pwrdms_save_context(void); void pwrdms_restore_context(void); From patchwork Tue Jun 25 04:03:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014625 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E92014BB for ; Tue, 25 Jun 2019 04:06:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EE2A28A9C for ; Tue, 25 Jun 2019 04:06:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10EBC28AAC; Tue, 25 Jun 2019 04:06:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AAC0A28958 for ; Tue, 25 Jun 2019 04:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbfFYEGF (ORCPT ); Tue, 25 Jun 2019 00:06:05 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38005 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEGF (ORCPT ); Tue, 25 Jun 2019 00:06:05 -0400 Received: by mail-pf1-f194.google.com with SMTP id y15so4086204pfn.5; Mon, 24 Jun 2019 21:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7+uT5l4SI9KUGhnGj8pF0zC23hQ8u8aSZYqwmnqFj+w=; b=PNlyZWSoCU7l5uDic3Knn28MqbfxUiHK4vRg2k9s5new2imIWuYxxYzc2KUG6h7bZJ xtg9GiD/Z99BkkXe1vbzqVGUb/2+5MzOCOLTIh6qi3GEEQ3TTvocnZj2q/HRnX8f/5Vj NeaHoK4yjxNkTgrxzKDQuJh1/+ayo9px3D+LfTdJN+8G4Xbn8/C8F47PJqXJtzrmFy3e gP1dJ932jvHmv8FTIOsy/5bLVHZH40zATj+mDJZzVreCUKvyRY2QjYBqVatOC3pk6Nod G37fTmWNrl8RY4Flcqld8MovGl8uJcj2Ak/vw+ythRSAHILLkYSTRRxT5CO+scg5JGRt rfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7+uT5l4SI9KUGhnGj8pF0zC23hQ8u8aSZYqwmnqFj+w=; b=jL8TN4B69XGHyHUaHHwbhtnhbzB/Qp36MzI4tM/0CEInTknHtGpgQX3+v2G8tvu9HR WbJA5wwHuKLeb/y1SNYm8y/7qfAyofq9FLulr5xyfHqMQYOPDaG1Cq/1EJbX9wcQt801 Q4WyS7xu047j8johMDv2Nf6IqCVFjm7DTFDKIGjja0hRu3NlLT6F9jYQD8jgYmVK4A2q DAnlUAM71LT7xQo86Bu2XFK6F/5D2BcoJhj+kFFhzsSWp3HEDrY0Yf8h7N6ueK0JAH0Y MTAY7TAOahsZrNDFbW53VHLvQrJWFyxpxXNSxhx5mW2NWEly2lmqbpiaZb0xHO5/UrUi x9/g== X-Gm-Message-State: APjAAAXjAP3bJzDwzDy0MBIE1ncgTaeDaLh++jxJyKYGh5L7for0jV9P um4rbZPleFOW1wnoU7zvnHY= X-Google-Smtp-Source: APXvYqxDpEvH6x3GHM0J9Nas5JkbUnDtRpo/mtpP9ZL404it433mB9RPxi/8HhaPU+n0KCgsqBSp+g== X-Received: by 2002:a63:130c:: with SMTP id i12mr1386060pgl.316.1561435564661; Mon, 24 Jun 2019 21:06:04 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.05.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:03 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 10/15] ARM: orion5x: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:51 +0700 Message-Id: <20190625040356.27473-11-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran Reviewed-by: Andrew Lunn --- arch/arm/mach-orion5x/pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-orion5x/pci.c b/arch/arm/mach-orion5x/pci.c index 76951bfbacf5..f47668530d5e 100644 --- a/arch/arm/mach-orion5x/pci.c +++ b/arch/arm/mach-orion5x/pci.c @@ -200,13 +200,13 @@ static int __init pcie_setup(struct pci_sys_data *sys) /* * PCI_MODE bits */ -#define PCI_MODE_64BIT (1 << 2) -#define PCI_MODE_PCIX ((1 << 4) | (1 << 5)) +#define PCI_MODE_64BIT BIT(2) +#define PCI_MODE_PCIX (BIT(4) | BIT(5)) /* * PCI_CMD bits */ -#define PCI_CMD_HOST_REORDER (1 << 29) +#define PCI_CMD_HOST_REORDER BIT(29) /* * PCI_P2P_CONF bits @@ -223,7 +223,7 @@ static int __init pcie_setup(struct pci_sys_data *sys) #define PCI_CONF_FUNC(func) (((func) & 0x3) << 8) #define PCI_CONF_DEV(dev) (((dev) & 0x1f) << 11) #define PCI_CONF_BUS(bus) (((bus) & 0xff) << 16) -#define PCI_CONF_ADDR_EN (1 << 31) +#define PCI_CONF_ADDR_EN BIT(31) /* * Internal configuration space From patchwork Tue Jun 25 04:03:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014631 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6165B13AF for ; Tue, 25 Jun 2019 04:06:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5378428958 for ; Tue, 25 Jun 2019 04:06:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 46CE428A9C; Tue, 25 Jun 2019 04:06:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04EB828958 for ; Tue, 25 Jun 2019 04:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728394AbfFYEGQ (ORCPT ); Tue, 25 Jun 2019 00:06:16 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35123 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEGQ (ORCPT ); Tue, 25 Jun 2019 00:06:16 -0400 Received: by mail-pg1-f193.google.com with SMTP id s27so8244727pgl.2; Mon, 24 Jun 2019 21:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=goeM92i1Az854qebwEYGpO+VPnAwIplO3LHWjlZyCPE=; b=PNBTVDHwxTggd7WlWW0fjIC6NjsivutmfL8hHRk9KBOMW4LWYgIthawZKe+LGiasEI G6PC5QLbjU1YGzpY5y7I3c5ChnNNxPIP0SXX+6xVH4XXTcWdiw4nxmhOqXyvgpxFrSCJ Pumu7yQAg04FYXYwlB+hxSXtWpnr62OO2jQACK6/pL1Z0cS9LthgI0wj1GV+O83cAYn0 XqaxkxnsODcUuiCI3DzaImRv3lTmwenvEZ7DcliGviyWj3+n1xc3AmfaP9irWeBw/QXV 2Fn1OYNHAolqRRh3VR6KZMDAcwbceTO0sNAYnAbVB6unEgDZ/kuVgWAiKh4AfMs6yw+U K/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=goeM92i1Az854qebwEYGpO+VPnAwIplO3LHWjlZyCPE=; b=sv9Ngh7JIb4cdcwYFBbsXBCpngnjImhZYPJtZuQsg+wXr+9NvYvBQoui2olFdf21r/ 7vcf76gEg4y/PW5BS+4Xz81ARyCPsIG4GrHI1w+xEXPqEi/Dq8rmBDzPCfsS7G+abJ2n JU3e+hmGhOGYWYPpU3CvEgInTDfgslJXsSxp/ZzCqYmgHUIwuqjfmRdpx9hFG9iIeCmL /XeKNwoUCLwtlVSvER0wAd6IAPjFS4OaGmwCE/SvDiu4me3AaWfUd8V+YSp0bvdVktLN rjQIPxsDiiBgp4z3j/mlCu+0i+NeQbAybfXPtlNJVH8iCfHVLDHv1QIk2steZJBIIQ2k QsMA== X-Gm-Message-State: APjAAAWobhl1hqRXrKbvCdYgyIxGtJZSq0GpRB6o+/TTtZrTNndDDpr8 P+QSKUym9j4EF5E/VJMIESc= X-Google-Smtp-Source: APXvYqzjr3cIxERQsRtrkbahOBfG6zzN5JJAW2g74Ei/K18gXbR4tAtRnx3ZAeAKjbOiYQH09SKUzg== X-Received: by 2002:a63:7f56:: with SMTP id p22mr14017413pgn.32.1561435575395; Mon, 24 Jun 2019 21:06:15 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.06.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:14 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 11/15] ARM: pxa: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:52 +0700 Message-Id: <20190625040356.27473-12-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mach-pxa/irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c index 74efc3ab595f..cbbb5cfecb60 100644 --- a/arch/arm/mach-pxa/irq.c +++ b/arch/arm/mach-pxa/irq.c @@ -35,9 +35,9 @@ #define IPR(i) (((i) < 32) ? (0x01c + ((i) << 2)) : \ ((i) < 64) ? (0x0b0 + (((i) - 32) << 2)) : \ (0x144 + (((i) - 64) << 2))) -#define ICHP_VAL_IRQ (1 << 31) +#define ICHP_VAL_IRQ BIT(31) #define ICHP_IRQ(i) (((i) >> 16) & 0x7fff) -#define IPR_VALID (1 << 31) +#define IPR_VALID BIT(31) #define MAX_INTERNAL_IRQS 128 From patchwork Tue Jun 25 04:03:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C07C14BB for ; Tue, 25 Jun 2019 04:06:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D29828958 for ; Tue, 25 Jun 2019 04:06:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CF9C28A9C; Tue, 25 Jun 2019 04:06:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5F9928958 for ; Tue, 25 Jun 2019 04:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbfFYEG1 (ORCPT ); Tue, 25 Jun 2019 00:06:27 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38678 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEG1 (ORCPT ); Tue, 25 Jun 2019 00:06:27 -0400 Received: by mail-pg1-f193.google.com with SMTP id z75so5628098pgz.5; Mon, 24 Jun 2019 21:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sKdpNSUQdGXxX8wZfroYxmDSvESfGqvaVysgZIwVWtg=; b=DEGqy4zi+TJd12rMQbgrA3DNBj8QdIs6IdKpALCGfew4KjRYSfJmWiiPd7OGR3zuCl zw52yR84tYlKk9RljyOPQjVlH8mZf8EUyZjN6qqA48QuY5IU+RD3KmXNpvjOq7lBtEGT cPQDnh74chBo7asDpEfCs2k5O1df+ozXEZ7vGYI+ch++6vaDxdpV2O15htpiwWZyQwZy abCz3V88allbjP6/VWNmDrFqH/s+jy/obn6Z6dHq9n3JJXWGRdh4xWtKwUy7VrbmwB46 5O86bToNwLX4v8FHiGeUN28Rto9gHb0ebjfiDGv3Ibmdx/sp8nKiewgeYIMsU7Av3NFl YgXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sKdpNSUQdGXxX8wZfroYxmDSvESfGqvaVysgZIwVWtg=; b=nOLetyen4+RkQtqJukAryWducQA1C0np5xxXeWmbAj0utY6hSOwGMmvHJyMEJE2iY2 dMzq4eZ0u5xlKZEZAh/ZAsXSI4+xxUgXeRjN4CW4X4YXEFqGo/EUogjzk35fLucLZ5n5 XRX2hLFfeF2fF3mC3ZqTZ1bjtUscLXoW74wMeKiz4/nlxI3BlNeUmlqxn0ecaMOa7B1t yH01Ff0tt4iGObWHORN0t99Pftd/zCIlgqObi1sDlbkjjYiNF7n5f0fgFcJpLT2cmg9e KsPJjL/PjH4gPXnEtGCTmOnkmY/KqbtHZy89M05fKh69720yNH3Z3GIPOcb/+07K3dwy 4WpA== X-Gm-Message-State: APjAAAVzZTD6utS5QRGcg88WRAeYLsfAwsIdptRjUz4el6BIUvq0KO9Z zuVFVcRKBjiDsLj+41ACmNs= X-Google-Smtp-Source: APXvYqxeIv3TJu9AJVj8LhZ8T/IfwNNmzFXxLFTuqhUVLDzyeiKIc+k9xzlxlALyhQJ9BU15U8jpKA== X-Received: by 2002:a65:664d:: with SMTP id z13mr11453666pgv.99.1561435586131; Mon, 24 Jun 2019 21:06:26 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.06.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:25 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 12/15] ARM: vexpress: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:53 +0700 Message-Id: <20190625040356.27473-13-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran Acked-by: Sudeep Holla --- arch/arm/mach-vexpress/spc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c index 0f5381d13494..354e0e7025ae 100644 --- a/arch/arm/mach-vexpress/spc.c +++ b/arch/arm/mach-vexpress/spc.c @@ -69,7 +69,7 @@ #define A7_PERFVAL_BASE 0xC30 /* Config interface control bits */ -#define SYSCFG_START (1 << 31) +#define SYSCFG_START BIT(31) #define SYSCFG_SCC (6 << 20) #define SYSCFG_STAT (14 << 20) @@ -162,7 +162,7 @@ void ve_spc_cpu_wakeup_irq(u32 cluster, u32 cpu, bool set) if (cluster >= MAX_CLUSTERS) return; - mask = 1 << cpu; + mask = BIT(cpu); if (!cluster_is_a15(cluster)) mask <<= 4; From patchwork Tue Jun 25 04:03:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014637 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECF7F13AF for ; Tue, 25 Jun 2019 04:06:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE6A728958 for ; Tue, 25 Jun 2019 04:06:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D02F228A9C; Tue, 25 Jun 2019 04:06:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 832DF28958 for ; Tue, 25 Jun 2019 04:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727527AbfFYEGi (ORCPT ); Tue, 25 Jun 2019 00:06:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:38050 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEGh (ORCPT ); Tue, 25 Jun 2019 00:06:37 -0400 Received: by mail-pf1-f195.google.com with SMTP id y15so4086873pfn.5; Mon, 24 Jun 2019 21:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7yVxj7qKDtvL1bbpI3Z9+uvLXYYsfj4EfWE4pae8tOM=; b=TgO1bd2E3txQAnLRmmK7nedFUr0FJpwuh/ubKaSgG7b8MsG7RFDKCXwsST+HwENLIl u6kdJClv3IX6Fn3/ErXTChm+Jy9KfhiPBxx4dA2hLtd6zdCJtWSCqrYXfGkKbu2SOUXB rupZZ3OgxlRZtooEg5sWSoFTfsOZXjbkpKk9wEjD9tZ9HPSi4C8Pivuipn0npv5AM9pN OiYAkoGb9v2izLjeXnMmTShUre3BdVyjU0WNXgxDIn6DKeF1oPT7yZ9UM8NjQ6mp4Fy6 Tqm+LdQoYbCaCKCKN97LieN+C7FIsw6OLZ7DfaVpD5xWBoXLKKwGShfjLiohv+vbJlbg 4deQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7yVxj7qKDtvL1bbpI3Z9+uvLXYYsfj4EfWE4pae8tOM=; b=TJfuQZrnAkvGYfk5TsGXkt/KTK43Ia9Kb/oTQJlAbxHc8S37Bm567RNa2rG+aY3Hbk RmdMS7jiFEmxlR3M67C+/mvRrTHsu3q2bgKeEeyXmgUiJVGsL6m1DrMRunF+TY31aA92 yn4um1TGP2lWUDHrB75vQ2CnAsBBsHx5KEoe9ttCu2TQ6XRGeKmdN4LLUTvfeOh5rN1j 5Q79/yb+idIbWrpKf8rdOvRXU2ctXAdUSMF+voEJvWbgVc6LhH1X3N+7IJB2F6sx0d2D zm+dPeWVt87wcOtxW+YZcJFydjo0svzU2vq16EVagppIV+xiZDftXq6Hu+4rcsOm0kRS 4twQ== X-Gm-Message-State: APjAAAUnPRF3al9h4Udgum7zY7X3klus1WLmAKgCstSiOLYJSCuLagkJ o4PFTzuC9GcUGbrsbojF9lI= X-Google-Smtp-Source: APXvYqyxnGl4XLuhQlGi7nSJsX/EE/BeJaywRYOKuiI0RY7sOOkzi2bS3YItHdEFZiG0l4utiPR3dw== X-Received: by 2002:a63:d53:: with SMTP id 19mr1890365pgn.453.1561435596806; Mon, 24 Jun 2019 21:06:36 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.06.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:36 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 13/15] ARM: mm: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:54 +0700 Message-Id: <20190625040356.27473-14-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/mm/fault.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mm/fault.h b/arch/arm/mm/fault.h index c063708fa503..8a706cb7f21d 100644 --- a/arch/arm/mm/fault.h +++ b/arch/arm/mm/fault.h @@ -5,9 +5,9 @@ /* * Fault status register encodings. We steal bit 31 for our own purposes. */ -#define FSR_LNX_PF (1 << 31) -#define FSR_WRITE (1 << 11) -#define FSR_FS4 (1 << 10) +#define FSR_LNX_PF BIT(31) +#define FSR_WRITE BIT(11) +#define FSR_FS4 BIT(10) #define FSR_FS3_0 (15) #define FSR_FS5_0 (0x3f) From patchwork Tue Jun 25 04:03:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79CBC14BB for ; Tue, 25 Jun 2019 04:06:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 68B9228958 for ; Tue, 25 Jun 2019 04:06:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 588B228A9C; Tue, 25 Jun 2019 04:06:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E451B28958 for ; Tue, 25 Jun 2019 04:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbfFYEGt (ORCPT ); Tue, 25 Jun 2019 00:06:49 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40170 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEGs (ORCPT ); Tue, 25 Jun 2019 00:06:48 -0400 Received: by mail-pl1-f196.google.com with SMTP id a93so8093806pla.7; Mon, 24 Jun 2019 21:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5JwRNim3rOSWEmaOkWCuYyX/NF5I/OM/lvjIjZv9TgA=; b=gt4q1QhMb1DH/lpvQ7aBuGothKXXSjA1h2R+DXuEwbbwhT+4GGxBNuQiJrNG3g6wlc 2sOM2sn6kNuDk65YciXdt6FXp9a8zFL91wUsRfPuALOsMq5ulGBgpq5zZ9rYyKFro2ti rkTC2gbwRznm72eBguYZkoLCBhvA7e6ovlEl+KbusRkQdgP8TESDeUnTi1AG9FtaMqhc vpqCQTGnQzukvTtXyn+hJmc6vqUMhESkcLhktKd6SkjsGlKG7T0inoRkqtUyi/xb6dKR lroymLNRVneRrp1OsqI/ooFoV9QAlBsqdsVLMEHsO9Ks9gYXFYWNK8hRHmc9QWbFSosv b4gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5JwRNim3rOSWEmaOkWCuYyX/NF5I/OM/lvjIjZv9TgA=; b=q8Fzg05AWD+2uxbovrEoIkbiocs+elKHz5+KzarfQz+qWkSijuambbdkGewgAtl79N lEWO79yC/TCV99FPN9T9Aoaw5zes4oKVMvhCJndiiausbd3kf2r6HZWFCHwCzQ+fgcmJ wDyxBG2bATyOu0lIViHHPNNkBzk3tHtAdvkh/JbjsOGmSoKnv14rGTIy1i/CxX9Bn+2J VmWpjj2xICkWEE6yYC8ZMqILkxf5oAtBtEGRBeQQIBXIULSHyTPTmie/T7R4U2HC6pr0 xe7KT9zdab/hXsO9xsnpyP5sVli56pYmS+prol8d0NOyn0UrPfyc0vxzqcOhd5awolnT 8jeg== X-Gm-Message-State: APjAAAXqCLMoJTdgltQVUct0LSFM1HYGTN+UFrme4yZllgmPfn5Ceaxk 26RCvalYSrhGMhdKHvZudoI= X-Google-Smtp-Source: APXvYqxe+YkEEX8coxMf/ZLBIurRDaBiUt3OmZVW/IvWX4kLCOfOcSFunco4dZa4p7+f354X1KstdQ== X-Received: by 2002:a17:902:1e6:: with SMTP id b93mr108038324plb.295.1561435607482; Mon, 24 Jun 2019 21:06:47 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.06.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:46 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 14/15] ARM: bpf: cleanup cppcheck shifting error Date: Tue, 25 Jun 2019 11:03:55 +0700 Message-Id: <20190625040356.27473-15-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/net/bpf_jit_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index adff54c312bf..8904d16a8754 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @@ -612,7 +612,7 @@ static inline void emit_a32_mov_se_i64(const bool is64, const s8 dst[], const u32 val, struct jit_ctx *ctx) { u64 val64 = val; - if (is64 && (val & (1<<31))) + if (is64 && (val & BIT(31))) val64 |= 0xffffffff00000000ULL; emit_a32_mov_i64(dst, val64, ctx); } From patchwork Tue Jun 25 04:03:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phong Tran X-Patchwork-Id: 11014647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95C3C17D2 for ; Tue, 25 Jun 2019 04:07:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8790328958 for ; Tue, 25 Jun 2019 04:07:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B34E2896F; Tue, 25 Jun 2019 04:07:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38D2C28AB6 for ; Tue, 25 Jun 2019 04:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728673AbfFYEHA (ORCPT ); Tue, 25 Jun 2019 00:07:00 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:42967 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfFYEG7 (ORCPT ); Tue, 25 Jun 2019 00:06:59 -0400 Received: by mail-pg1-f196.google.com with SMTP id k13so2061214pgq.9; Mon, 24 Jun 2019 21:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AkRO8e5ycrnKuMZ4NjLtJGYkQOt0yCD26N+5kX9ibhg=; b=t2YZaCuhvjFlf7YncEX3gIhPMcL7Iu0FY+acuNPHA6QV81xTms2oc7LIg2W9Bax5+H T5+ekJ51erToESTcK4rhSaiuPsRlYc7av1WygdOg8RB8WAqvsmluOIkrkqRUrDTMlbDr 1zBS12N5VDuDkhmYfGHnDSoc0dAHhIBC8uRDdHN+gluFmuzeoE/Gb2GrC+lJxhMXCTO7 tXjnOr36Ra0/76T3Mp8QEN9oxn1vnlMsRqxu9aOHc1i/HO3f7pG99tfg4o56/r+bj0Sp Gm7qJMC7B9qToK5MSc4MClny4ZBzDcV/c3GxiqOF8WMZsq+VLM2beXAJe1Cxav6uZMFd Q7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AkRO8e5ycrnKuMZ4NjLtJGYkQOt0yCD26N+5kX9ibhg=; b=qBkbFqcCLm8CM36rWJ4oRi2u8VnCTKQedQbzbR8aHlboCyriAMmyGTyPnSzeUVqQPG Fwk1MSF6RzUzLrQ7Sv1wG3KLTHvnxGPsGRRF3iBO9W1JEmA31XoPSTRGepjxz2vnAYFt s8KyNkG2gS+TAnjkWNIpraDWesqr8MELOvwGGBpiKtrgaMO1qJ0a4ezTS0P33lIeTA9b N7AmNmWRdY15m2/3TvwBQ9/yFJpTCBt55QSxkja42dhrHuQFXAzGN87PawnBwr2jMTVs /VhG0gziyI0d5K23MoebG+sXqLGNWEjC9CMn3niu/Z5aUAHJlwgubpwT58zXniKfP313 oUFw== X-Gm-Message-State: APjAAAXgFeb1fErp7t9RdEbVuTTyInPDSjP5H1LSefSNnQ3SauYBEhfr OLbLf1ZZEUbShEwxPm+MeoU= X-Google-Smtp-Source: APXvYqxGPcvS+CgSVL0iAo8yD0dXMNypsdhxM+aU3y+08qc2XIBNbVS4ubqgvBDyXo5VTAuPulM0Og== X-Received: by 2002:a17:90a:601:: with SMTP id j1mr28615892pjj.96.1561435618978; Mon, 24 Jun 2019 21:06:58 -0700 (PDT) Received: from debian.net.fpt ([58.187.168.105]) by smtp.gmail.com with ESMTPSA id b24sm12408944pfd.98.2019.06.24.21.06.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 21:06:58 -0700 (PDT) From: Phong Tran To: tranmanphong@gmail.com Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, andrew@lunn.ch, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: [PATCH V3 15/15] ARM: vfp: cleanup cppcheck shifting errors Date: Tue, 25 Jun 2019 11:03:56 +0700 Message-Id: <20190625040356.27473-16-tranmanphong@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190625040356.27473-1-tranmanphong@gmail.com> References: <20190624135105.15579-1-tranmanphong@gmail.com> <20190625040356.27473-1-tranmanphong@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran --- arch/arm/vfp/vfpinstr.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/vfp/vfpinstr.h b/arch/arm/vfp/vfpinstr.h index 38dc154e39ff..8951637c58ff 100644 --- a/arch/arm/vfp/vfpinstr.h +++ b/arch/arm/vfp/vfpinstr.h @@ -57,10 +57,10 @@ #define vfp_single(inst) (((inst) & 0x0000f00) == 0xa00) -#define FPSCR_N (1 << 31) -#define FPSCR_Z (1 << 30) -#define FPSCR_C (1 << 29) -#define FPSCR_V (1 << 28) +#define FPSCR_N BIT(31) +#define FPSCR_Z BIT(30) +#define FPSCR_C BIT(29) +#define FPSCR_V BIT(28) /* * Since we aren't building with -mfpu=vfp, we need to code