From patchwork Tue Jun 25 04:13:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11014649 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B81014BB for ; Tue, 25 Jun 2019 04:13:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 61D4428A38 for ; Tue, 25 Jun 2019 04:13:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5206328A9C; Tue, 25 Jun 2019 04:13:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4932528A38 for ; Tue, 25 Jun 2019 04:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=VGe2d/xtV9uRdoqhDicbZ/QPkk7IqB0YcFkSt7b7+Ew=; b=KfR EysOZHSpxxmQmYc6iInam9WPKYgk33AGKNF0HhPXls+Sc1n1w5w2IX3omrB+gDYbnqQtBBRbR+sY0 b3B+82XHMoD+C5B84wVgr1qYSK+Ok6tWGG4+ICqGWkrO4Eeo/NZSZI8P0KxmyZJ4z9q0dv9gFIKAG Lgs9wjYTCWNgw1ZW+SL9w1kya8EjSB+Yz1ItqyhrDII3P4zO9ZZT4A/5MLjA4nbEKWCRyxVGU5exi ClksPe8to1yBYNwJCb92h6Fv/YUKsp8rgwSVImEf5sGBfrpbLZr/T6jMck2XXps7gTxh03JZf/cep oD8DtRACgYzZ/DfC0QM5IWJD+MeY4xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq0-0003FB-Gy; Tue, 25 Jun 2019 04:13:44 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfcpx-0003Em-5v for ath11k@lists.infradead.org; Tue, 25 Jun 2019 04:13:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C776460709; Tue, 25 Jun 2019 04:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436018; bh=2nHaNlbRC7P2WCCofuhAS52VSU4AsfQyyL1BY/nAJmk=; h=From:To:Cc:Subject:Date:From; b=PmIgbOifcn4TGOvesPuQoEtVBaI+AZbf6+ych09BoFcfO7Fc1wqlCUwGjrJV/Jh2j Y5HFU3uIqJ3upYg66kvIZTJMg6gJNmXhhatb/wYyyJCwt62sELxLb+8/eEjbaPMTiX 8NRobKUSFXKH8MOsEkm+WLHb2B9rYU89uK72C8TM= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 784C9602F8; Tue, 25 Jun 2019 04:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436018; bh=2nHaNlbRC7P2WCCofuhAS52VSU4AsfQyyL1BY/nAJmk=; h=From:To:Cc:Subject:Date:From; b=PmIgbOifcn4TGOvesPuQoEtVBaI+AZbf6+ych09BoFcfO7Fc1wqlCUwGjrJV/Jh2j Y5HFU3uIqJ3upYg66kvIZTJMg6gJNmXhhatb/wYyyJCwt62sELxLb+8/eEjbaPMTiX 8NRobKUSFXKH8MOsEkm+WLHb2B9rYU89uK72C8TM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 784C9602F8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH 1/5] ath11k: fix variable name warnings Date: Tue, 25 Jun 2019 09:43:15 +0530 Message-Id: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_211341_236886_94E8A175 X-CRM114-Status: UNSURE ( 7.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/wmi.h:2728: drivers/net/wireless/ath/ath11k/wmi.h:2729: drivers/net/wireless/ath/ath11k/wmi.h:2730: drivers/net/wireless/ath/ath11k/wmi.h:2731: drivers/net/wireless/ath/ath11k/wmi.h:2965: Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/wmi.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h index 4e92bf0..779209a 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.h +++ b/drivers/net/wireless/ath/ath11k/wmi.h @@ -2725,10 +2725,10 @@ struct wmi_resource_config { u32 num_ocb_schedules; u32 flag1; u32 smart_ant_cap; - u32 BK_Minfree; - u32 BE_Minfree; - u32 VI_Minfree; - u32 VO_Minfree; + u32 bk_minfree; + u32 be_minfree; + u32 vi_minfree; + u32 vo_minfree; u32 alloc_frag_desc_for_data_pkt; u32 num_ns_ext_tuples_cfg; u32 bpf_instruction_size; @@ -2962,7 +2962,7 @@ struct wmi_vdev_start_request_cmd { u32 flags; struct wmi_ssid ssid; u32 bcn_tx_rate; - u32 bcn_txPower; + u32 bcn_txpower; u32 num_noa_descriptors; u32 disable_hw_ack; u32 preferred_tx_streams; @@ -5122,10 +5122,10 @@ struct target_resource_config { u32 max_frag_entries; u32 max_peer_ext_stats; u32 smart_ant_cap; - u32 BK_Minfree; - u32 BE_Minfree; - u32 VI_Minfree; - u32 VO_Minfree; + u32 bk_minfree; + u32 be_minfree; + u32 vi_minfree; + u32 vo_minfree; u32 rx_batchmode; u32 tt_support; u32 atf_config; From patchwork Tue Jun 25 04:13:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11014651 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7464D13AF for ; Tue, 25 Jun 2019 04:13:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65D9F28A38 for ; Tue, 25 Jun 2019 04:13:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 59E3B28A9C; Tue, 25 Jun 2019 04:13:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0D81528A38 for ; Tue, 25 Jun 2019 04:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1z8MfqLgJiyhgx5wOfq4p+8xdFZEwHd+0K8njDrw8wA=; b=gT5WzCmO45/zsdQgE0TNdbZmhG 9/GEWzYTRpjZSELrA1iqa6lQsaCzCRWRKb/iaZzRoyuXH4CATAxNFFTKfj2MMR7jKAnA5VyKPteCb ixEyxwm0e68jrd9SILcCg4/jC/LYcCmnwcwNYn8SWGI0tykpwstEwbeBfC3Tn7AqYxzchmIoyaNsQ p2kI/mTeFjq8+9MvGmFg8aMfWav3DdiU7BMYK68om5MlzLiSiM53tJKbLOn9W78+fr3PnafofYbuf 0B3dOnNThGYDYYefgwOWPGokDm7X48P8QcjsOFQMk7OR2JAbpOxLHHfBjC8+RBA1uvFBUrv3/Wgue 0iARyakA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq4-0003GY-3F; Tue, 25 Jun 2019 04:13:48 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq2-0003Fa-34 for ath11k@lists.infradead.org; Tue, 25 Jun 2019 04:13:47 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CD81F602F8; Tue, 25 Jun 2019 04:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436025; bh=po1DqxVLoE8ORpNvCV8QiT+Hi7nM8ad6fE4iNpFCPjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BBFucnAduiiPOQKddjI6PVnuUbp9hqe66I/8l1Yjb1cmAmvNfCUj6nDfDIloELxMG 3TEqsi2I+i/mUW5NivNGmfIRUIYd3BfxY0EMkJdYL77U9nSXr4wqe34XWRyPa4g2o5 nPUIDSPX4xCLLe1ePzLSnsUIUkJcmH19uwDfEVZg= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 524E0602F8; Tue, 25 Jun 2019 04:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436025; bh=po1DqxVLoE8ORpNvCV8QiT+Hi7nM8ad6fE4iNpFCPjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BBFucnAduiiPOQKddjI6PVnuUbp9hqe66I/8l1Yjb1cmAmvNfCUj6nDfDIloELxMG 3TEqsi2I+i/mUW5NivNGmfIRUIYd3BfxY0EMkJdYL77U9nSXr4wqe34XWRyPa4g2o5 nPUIDSPX4xCLLe1ePzLSnsUIUkJcmH19uwDfEVZg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 524E0602F8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH 2/5] ath11k: avoid unnecessary 'out of memory' message Date: Tue, 25 Jun 2019 09:43:16 +0530 Message-Id: <1561435999-28316-2-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> References: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_211346_147268_B597687F X-CRM114-Status: UNSURE ( 9.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/dp_rx.c:573: Possible unnecessary 'out of memory' message drivers/net/wireless/ath/ath11k/wmi.c:4528: Possible unnecessary 'out of memory' message Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/dp_rx.c | 4 +--- drivers/net/wireless/ath/ath11k/wmi.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index afe8399..17be3cc 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -569,10 +569,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx, } elem = kzalloc(sizeof(*elem), GFP_ATOMIC); - if (!elem) { - ath11k_warn(ab, "failed to allocate memory for cache flush element\n"); + if (!elem) goto free_desc; - } elem->ts = jiffies; memcpy(&elem->data, rx_tid, sizeof(*rx_tid)); diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index f800c77..085ee32 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -4527,9 +4527,7 @@ static int ath11k_reg_chan_list_event(struct ath11k_base *ab, u8 *evt_buf, u32 l struct ath11k *ar; reg_info = kzalloc(sizeof(*reg_info), GFP_ATOMIC); - if (!reg_info) { - ath11k_warn(ab, "Unable to allocate memory for processing chan_info event\n"); ret = -ENOMEM; goto fallback; } From patchwork Tue Jun 25 04:13:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11014653 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2BEB13AF for ; Tue, 25 Jun 2019 04:13:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D23AB28A38 for ; Tue, 25 Jun 2019 04:13:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C687428A9C; Tue, 25 Jun 2019 04:13:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F97D28A38 for ; Tue, 25 Jun 2019 04:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rCn5tVFvLXa9pqTYvIW7cqOIPVqjv5eSZSz7/XVE5JI=; b=HsmfLKl+P98I+nhmOSqRY9QMBo KU7mnm7qQM2lvEN7hqeocWfOZTFHcN1pxU1F+iWxCHKnXyZOFTLQS0kBaPb/cPHc9KG+4bY13yxmK LNMAu2RKmGuc42tRvnqjmDYxB3RUHI8OS+rqvQCcDEG7SiLgAlkIfimnw0fUSE30qLcsdME1eo495 0qfCiid57hIVOFo7LYXp0j5DvIbL40UTeLRmq4i9sZFupgxsF9+dibM++MHiPfkilS/xha0dnFj+t 9lSEJZaxXKRXMexVtxDpr5CJg2nVO0Mvn41lLpau3kBrR7TEKaiaf2cNE6/mqNlrlJcKsf0FA1Rid ZPnsql2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq6-0003I7-GD; Tue, 25 Jun 2019 04:13:50 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq3-0003G5-E9 for ath11k@lists.infradead.org; Tue, 25 Jun 2019 04:13:48 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2F2D5608CE; Tue, 25 Jun 2019 04:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436027; bh=SH6EMPzbmuGakYzgDX7aoFHLtQRNwEnSSOPwu5wKM9E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fvC0GSh9BwnMlTAZ8tJ/myyuAnlDYTblpaQDvSvMl3wb4yD1/ye9CPrjpRhTjhJHl d8eqL6JHgyXyzg1ShBNIf2Zc/PREfxZrceZWprOPwhssYmjDvoEaMBvo49njKFVnwm ISEp9Y513/7kS/UZksOWj98KA6JWAFW4aR8I3Vgg= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D354D608A5; Tue, 25 Jun 2019 04:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436026; bh=SH6EMPzbmuGakYzgDX7aoFHLtQRNwEnSSOPwu5wKM9E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X3yD4j7BSdGCTCHLLYP3yUVKOYUOIIYX6v6qOI8IpOfcIXdR4vXHA1+87ybai0KEk SUIbQCnpgdAcGe6tb0+hDqDHDLnp+b91kC9aLW9lGP8m38x7aCZFFwVE2Kfsff4Sk3 YfO2kPwsq1zbzCrS/38frfU5HFLN0/7d/wtSsrIQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D354D608A5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH 3/5] ath11k: fix space related warnings Date: Tue, 25 Jun 2019 09:43:17 +0530 Message-Id: <1561435999-28316-3-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> References: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_211347_508879_F0E7107E X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/dp.h:1482: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/dp_rx.c:1072: code indent should use tabs where possible drivers/net/wireless/ath/ath11k/dp_rx.c:1075: code indent should use tabs where possible drivers/net/wireless/ath/ath11k/wmi.c:2321: "(foo*)" should be "(foo *)" Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/dp.h | 1 - drivers/net/wireless/ath/ath11k/dp_rx.c | 4 ++-- drivers/net/wireless/ath/ath11k/wmi.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp.h b/drivers/net/wireless/ath/ath11k/dp.h index d533d7e..bda5ac2 100644 --- a/drivers/net/wireless/ath/ath11k/dp.h +++ b/drivers/net/wireless/ath/ath11k/dp.h @@ -1482,7 +1482,6 @@ struct ath11k_htt_extd_stats_msg { u8 data[0]; } __packed; - struct htt_mac_addr { u32 mac_addr_l32; u32 mac_addr_h16; diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 17be3cc..0158f90 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -1069,10 +1069,10 @@ static u32 ath11k_bw_to_mac80211_bwflags(u8 bw) mcs = HTT_USR_RATE_MCS(user_rate->rate_flags); sgi = HTT_USR_RATE_GI(user_rate->rate_flags); - /* Note: If host configured fixed rates and in some other special + /* Note: If host configured fixed rates and in some other special * cases, the broadcast/management frames are sent in different rates. * Firmware rate's control to be skipped for this? - */ + */ if (flags == WMI_RATE_PREAMBLE_VHT && mcs > 9) { ath11k_warn(ab, "Invalid VHT mcs %hhd peer stats", mcs); diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index 085ee32..f56db77 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -2318,7 +2318,7 @@ int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable) FIELD_PREP(WMI_TLV_LEN, 0); ptr += TLV_HDR_SIZE; - info = (struct wmi_pdev_pktlog_filter_info*)ptr; + info = (struct wmi_pdev_pktlog_filter_info *)ptr; ether_addr_copy(info->peer_macaddr.addr, addr); info->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_PDEV_PEER_PKTLOG_FILTER_INFO) | From patchwork Tue Jun 25 04:13:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11014655 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3443813AF for ; Tue, 25 Jun 2019 04:13:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2566328A38 for ; Tue, 25 Jun 2019 04:13:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19A4428A9C; Tue, 25 Jun 2019 04:13:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C8F1328A38 for ; Tue, 25 Jun 2019 04:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8yV3JFB6J6hAG5GLULHRXFPIdDufCKVbNbgo4lo3nY8=; b=IyFWCDOrfuXblC0wC5xzssjlJY jG4BHXlbD9dXPi2FZbTfGBftN7dOeqkmc6hlLEz81QfuHPhZnCu3Gxo5duy/clgYM4sMG++PhUBBL Dfq900Io/GD/4TRjpFsLa6MStRZclrGeCwhlEwCgsm62+V71BKFs9WAdsv1pHJ1qN9oa/jc+cKYgs 3MrAFLCiG8JeAK7e+aBJs9HTOQadu2p7RBxIP95ANTWMWDe8QyyDLQePeRixy+p818IjquhfUVEmf 2YJle4O9H68MkDGXK95+25T2nfnvyVXeC6Jjwe8Q2G9i5EwzDhz7H+k8v5rsKWGC+KxS/6n2L+vtV BI/J+rNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq8-0003JS-SG; Tue, 25 Jun 2019 04:13:52 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq4-0003HD-S8 for ath11k@lists.infradead.org; Tue, 25 Jun 2019 04:13:50 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9BDC860A50; Tue, 25 Jun 2019 04:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436028; bh=DmqSUYUoyBgYyaYB5wghnUS+EUoRBKQhdeJSFq7N/HY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S3D/ou9ac868oLfxlKpuWDEbH3c0IDrc2qemmFj9587NO/Ff01rRYXsg2/nQ/43jF YTbNu4ZDJQ+VMhazpqP4DleYosjDqWHYrOyyvkLRzIWJvkpZhwuX3JSl4L3120nnU+ cRylrqA1XxR9EIuH1ZCS2xL5Vn7OBkW9wGEE/CSA= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 625DE60A00; Tue, 25 Jun 2019 04:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436028; bh=DmqSUYUoyBgYyaYB5wghnUS+EUoRBKQhdeJSFq7N/HY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S3D/ou9ac868oLfxlKpuWDEbH3c0IDrc2qemmFj9587NO/Ff01rRYXsg2/nQ/43jF YTbNu4ZDJQ+VMhazpqP4DleYosjDqWHYrOyyvkLRzIWJvkpZhwuX3JSl4L3120nnU+ cRylrqA1XxR9EIuH1ZCS2xL5Vn7OBkW9wGEE/CSA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 625DE60A00 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH 4/5] ath11k: avoid min() warning Date: Tue, 25 Jun 2019 09:43:18 +0530 Message-Id: <1561435999-28316-4-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> References: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_211348_927381_A8F21099 X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/mac.c:4921: min() should probably be min_t(u32, ar->num_tx_chains, max(ath11k_mac_max_ht_nss(ht_mcs_mask), Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/mac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 7a6c927..1c437b2 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -4920,9 +4920,9 @@ static void ath11k_mac_disable_peer_fixed_rate(void *data, nss = single_nss; } else { rate = WMI_FIXED_RATE_NONE; - nss = min((u32)ar->num_tx_chains, - max(ath11k_mac_max_ht_nss(ht_mcs_mask), - ath11k_mac_max_vht_nss(vht_mcs_mask))); + nss = min_t(u32, ar->num_tx_chains, + max(ath11k_mac_max_ht_nss(ht_mcs_mask), + ath11k_mac_max_vht_nss(vht_mcs_mask))); /* If multiple rates across different preambles are given * we can reconfigure this info with all peers using PEER_ASSOC From patchwork Tue Jun 25 04:13:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11014657 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBE5C13AF for ; Tue, 25 Jun 2019 04:13:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA88A28A38 for ; Tue, 25 Jun 2019 04:13:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AEDFE28A9C; Tue, 25 Jun 2019 04:13:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6D85F28A38 for ; Tue, 25 Jun 2019 04:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=LqK6cka5h52Mgl09oJZ0M9onvqJ6jIp1RnuvVFHtsP0=; b=ZFM+k9IavKauXvOtmsJMIRy+N1 CLTNHUrws11S0iGI8wxlsQQKU93okE1mufQY3ZbEaeLkdqAI6czS1gtcC/d3XD9lJ5jzT5GNiTExh l708eeXUFyEWX6sXbRg1+56XuYXC7V53sBXvGLXGo/j2WeWKTM8SSE73rErgSy3qapWaZmx0gT6KZ nJWkD5N4RGgAaZxfRhXH6eU5ZFFO+lr3yK0omO50whaL0LpEllok16E92LtKtUy5191V30lFB7zBX /u1SLorj9ZrqznUQOcqPc74jVVEF+PeK0LLgQZKRM2QP6Bp+FcPE0I3g6e7yMThX8xjknGmNCHS4u ai9yCMrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfcqB-0003Kl-Nx; Tue, 25 Jun 2019 04:13:55 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfcq6-0003I5-ET for ath11k@lists.infradead.org; Tue, 25 Jun 2019 04:13:51 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2D59660AE0; Tue, 25 Jun 2019 04:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436030; bh=trdPlS9OmRyQha1E+MiZVfTZSuQi5n6NVwSkg+v4CYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UwEUD2/jHCkaUtzuo4mRwTStCwEPcSGPSIP+jzfhI4jdKh33EwL/kq+kFI9rLMLif DPSUGYGBTmjGVKn/S8k6frfDiA8IpWOXN0hAg0cVgin5McDj0bHLwDDDqlYupbo5/f HNbEE5q9a6HbGcgmxqfyAKdS9kk8Mdav6J1peFjE= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E39DE60A44; Tue, 25 Jun 2019 04:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561436029; bh=trdPlS9OmRyQha1E+MiZVfTZSuQi5n6NVwSkg+v4CYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XZWhv2O9D/sbHEzFD4V1tWZug0F+ECV97ynfd4kMu1fTslig/x/iJJN1HdV/j9Vhx 29rg/aZrdrB+ltUmhOtQ14VLosITywCsFvTt0GWoFzeHbakGJDouYFIlvsMFb8ROtu dplEEKSUfSd/cPfvbGz6H3dQot+MYo2ggkhSdxy0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E39DE60A44 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH 5/5] ath11k: fix brace warning Date: Tue, 25 Jun 2019 09:43:19 +0530 Message-Id: <1561435999-28316-5-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> References: <1561435999-28316-1-git-send-email-periyasa@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_211350_505352_B2B14A36 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/dp_rx.c:1287: that open brace { should be on the previous line Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/dp_rx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 0158f90..7d49b3f 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -1284,8 +1284,7 @@ static void ath11k_htt_pktlog(struct ath11k_base *ab, struct sk_buff *skb) len = FIELD_GET(HTT_T2H_PPDU_STATS_INFO_PAYLOAD_SIZE, data->hdr); - if (len > ATH11K_HTT_PKTLOG_MAX_SIZE) - { + if (len > ATH11K_HTT_PKTLOG_MAX_SIZE) { ath11k_warn(ab, "htt pktlog buffer size %d, expected < %d\n", len, ATH11K_HTT_PKTLOG_MAX_SIZE);