From patchwork Wed Jun 26 02:49:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 11016927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C146112C for ; Wed, 26 Jun 2019 02:50:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6552128437 for ; Wed, 26 Jun 2019 02:50:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E40E28468; Wed, 26 Jun 2019 02:50:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C7A2328437 for ; Wed, 26 Jun 2019 02:50:45 +0000 (UTC) Received: from localhost ([::1]:36386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfy1E-0001or-I5 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 25 Jun 2019 22:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56433) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfy0Y-0001Ab-1m for qemu-devel@nongnu.org; Tue, 25 Jun 2019 22:50:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfy0X-00041Z-5S for qemu-devel@nongnu.org; Tue, 25 Jun 2019 22:50:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34932) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfy0V-0003yr-4g; Tue, 25 Jun 2019 22:49:59 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD85E2F8BC1; Wed, 26 Jun 2019 02:49:55 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-44.phx2.redhat.com [10.3.116.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51DDF60BE5; Wed, 26 Jun 2019 02:49:54 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Date: Tue, 25 Jun 2019 21:49:42 -0500 Message-Id: <20190626024942.29758-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 26 Jun 2019 02:49:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qemu-nbd: Permit TLS with Unix sockets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, rjones@redhat.com, "open list:Network Block Dev..." Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Although you generally won't use encryption with a Unix socket (after all, everything is local, so why waste the CPU power), there are situations in testsuites where Unix sockets are much nicer than TCP sockets. Since nbdkit allows encryption over both types of sockets, it makes sense for qemu-nbd to do likewise. Signed-off-by: Eric Blake Reviewed-by: Daniel P. Berrangé Acked-by: Richard W.M. Jones --- qemu-nbd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a8cb39e51043..ddfb6815fb69 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -931,10 +931,6 @@ int main(int argc, char **argv) } if (tlscredsid) { - if (sockpath) { - error_report("TLS is only supported with IPv4/IPv6"); - exit(EXIT_FAILURE); - } if (device) { error_report("TLS is not supported with a host device"); exit(EXIT_FAILURE);