From patchwork Thu Jun 27 17:46:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 11020235 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 329F514C0 for ; Thu, 27 Jun 2019 17:46:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25EA72859F for ; Thu, 27 Jun 2019 17:46:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19C04285A6; Thu, 27 Jun 2019 17:46:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD51B2859F for ; Thu, 27 Jun 2019 17:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbfF0Rqc (ORCPT ); Thu, 27 Jun 2019 13:46:32 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45345 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfF0Rqc (ORCPT ); Thu, 27 Jun 2019 13:46:32 -0400 Received: by mail-pg1-f194.google.com with SMTP id z19so1335751pgl.12; Thu, 27 Jun 2019 10:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dVK/1jelVWuWKY847Kjv4BLwFO5EKIu+zyNuXBFo2IU=; b=lza6mnLJF6y/bnBWCnpxzby0hMCcbwyNecgphKuLEAetBOmwciNgFFBjcguynyXSpg 9avAMfDZQbHdGsrPfKYzfMzpZDrH5/mZ3xR2ti2n2ZlKlPC2HUINUIib05VJF+1nSkbb 5aicmAb3mnWVwQGu53PKZZ1Z4iU0spw7tcWuU77hVHCKaWoQEGODBsXSHVnpDCm8lTpc 7V1Cp8gAO9V5w2jc/LKtYUFcHDJhlDQT0RfSql4jjyA0gcYsYNyE9yAHb6mpRd1sdi2y WRegHgnnY5TfcypBmtIt7ujIK6vIEfqNMcPRrLXgdJtlbFj39vyjS4Ptoo6KuTc7iQ5t daow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dVK/1jelVWuWKY847Kjv4BLwFO5EKIu+zyNuXBFo2IU=; b=E5bIT2x4yLQMUJgyEqPLQxTyxBPGgyor9JhjW0JW5C210E3fF7PuphajpOXNW41rxi dB3qjjuXRUSzavnUnEJ5EEPMA0z7aUDIuPTZShUz1WC3fwXCgSRM7BFCavcji3jnLLdK gcZ0qmgaQmIA6PpNmBvDXFf8icTjDrgj0mXYfBjmDXsr+y7C94XCLNU64eN8dZrKicaV CMNq2nJG9+yY2b07gUDpq9XtRLkgxs8Xr1TABm9bWPiV0dONlSJqToehChFieFak+RP/ 6UFLN/nGm5CsPgrWqsMY+Da1XrQ0YEQNF0J7KOO9gZ0kynVnJ9jKU1VykpeE/z1EwCKd 6qfA== X-Gm-Message-State: APjAAAV4R7w4WPvQif3G9HTROI9nCQBhAnMNGQ/QWiJ+lTDajThQXnqU NWfvuqn7n38BEMTlKA+qA0nEhNBmEMCYLw== X-Google-Smtp-Source: APXvYqyYw4GJaENpqwyJhxTH3VZZab70A8HPkwSuASaLHiUuZgrb+kuirwvJAdxZ4JuofRxu3kfXqQ== X-Received: by 2002:a17:90a:fa07:: with SMTP id cm7mr7246665pjb.138.1561657591451; Thu, 27 Jun 2019 10:46:31 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id z13sm7780343pjn.32.2019.06.27.10.46.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:46:31 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Igor Mitsyanko , Avinash Patil , Sergey Matyukevich , Kalle Valo , "David S. Miller" , Andrey Shevchenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 76/87] wireless: quantenna: pcie: remove memset after dmam_alloc_coherent Date: Fri, 28 Jun 2019 01:46:03 +0800 Message-Id: <20190627174620.6307-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dmam_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 -- drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c index 3aa3714d4dfd..5ec1c9bc1612 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c @@ -244,8 +244,6 @@ static int pearl_alloc_bd_table(struct qtnf_pcie_pearl_state *ps) /* tx bd */ - memset(vaddr, 0, len); - ps->bd_table_vaddr = vaddr; ps->bd_table_paddr = paddr; ps->bd_table_len = len; diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c index 9a4380ed7f1b..1f91088e3dff 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c @@ -199,8 +199,6 @@ static int topaz_alloc_bd_table(struct qtnf_pcie_topaz_state *ts, if (!vaddr) return -ENOMEM; - memset(vaddr, 0, len); - /* tx bd */ ts->tx_bd_vbase = vaddr; From patchwork Thu Jun 27 17:45:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 11020227 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8219F13B4 for ; Thu, 27 Jun 2019 17:46:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 759632859F for ; Thu, 27 Jun 2019 17:46:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6949B285BD; Thu, 27 Jun 2019 17:46:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11D45285A3 for ; Thu, 27 Jun 2019 17:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727374AbfF0Rp5 (ORCPT ); Thu, 27 Jun 2019 13:45:57 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44897 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbfF0Rpz (ORCPT ); Thu, 27 Jun 2019 13:45:55 -0400 Received: by mail-pl1-f195.google.com with SMTP id t7so1673580plr.11; Thu, 27 Jun 2019 10:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=drjgftEWAZg3/oKZde2zMkT36C0ZEqDQk/rQk2ecHqE=; b=XjfUBn3mJbrbGfnwsW7qoISdtv6h21GLg/ORcHgYgxh0ZNbGJvRJm8p7NUx83k8CXF UE9f/pywfKSF3lbE6Z9b9N2B1hbKKM0S8YiLgbKkZhiKTe8xjRneYdFvNHs8HVWBx67n JhBdsjs0sFx7N+B/9O/lkx75hKe+oLyunRlmmkgbR7EotaRQSX4Odn6J012YHLNnzZB/ b2UIpsrlefZYyexOoe5sUfgGdsgrpB0xqB/I7Rmrqdov2RW4iXd6aynhTO9mSlrjrbjx T3pvu5kE66+EDc+N2M7BJOSALqSKbcyWGEFKK53Q6vlKd1d0eJ1fPtdqCwZQOhXF7Nrc C0RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=drjgftEWAZg3/oKZde2zMkT36C0ZEqDQk/rQk2ecHqE=; b=bE9rdc75do/KtENCg/yfyzO4dXw/Mp5sN1NUwEl593p4YwdP7eodl4MSj6ud47xIgV ay7M5NHPIO6qiY9CVy34UD4C8i3HxhBD1FrNOo/uc9WyGKlTBsJ0r3N6UAgr5oby/X5c MXwSpXS+1B0MmRlX7ip+GLTLdCB/QVns4dHmtUqqc8PgFehcVtYtfC6emdU1K5/v0lAL 53B85Vih1ZJcO9GmJat2rNry/woZ3CcAu38XLRo9T5X9HRIz+593Mo18nP1ScZna/k+e V6IvCv37tB4RTpR5bRLclBtgqwJv5JdaR7rkG6FQ8oujsQ+Kf0uzKw1oOsw7WtTgkkGl SDgg== X-Gm-Message-State: APjAAAXjirSFEXw6+Bg8JMhipPsInUPzmzDxiP7dVsF69FqI0u5hX1vl f7ugmGTpeKxt+5DyyRiMgX7AfsWOt5h3vg== X-Google-Smtp-Source: APXvYqwrFX/Sk4b/bSSq48Wz4qHMklsVR8zrsDYcV8VDNsPA4F3Z9IARxomaPfDpugHllO0j07+RFw== X-Received: by 2002:a17:902:7887:: with SMTP id q7mr6105676pll.129.1561657554912; Thu, 27 Jun 2019 10:45:54 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id h26sm4116937pfq.64.2019.06.27.10.45.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:45:54 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Hans de Goede , Luis Chamberlain , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 77/87] wireless: broadcom: remove memset after dma_alloc_coherent Date: Fri, 28 Jun 2019 01:45:43 +0800 Message-Id: <20190627174544.6145-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index 83e4938527f4..3fc08fe7c3a2 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -1033,8 +1033,6 @@ brcmf_pcie_init_dmabuffer_for_device(struct brcmf_pciedev_info *devinfo, address & 0xffffffff); brcmf_pcie_write_tcm32(devinfo, tcm_dma_phys_addr + 4, address >> 32); - memset(ring, 0, size); - return (ring); } From patchwork Thu Jun 27 17:45:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuqian Huang X-Patchwork-Id: 11020217 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2CD2E13B4 for ; Thu, 27 Jun 2019 17:45:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20372284C3 for ; Thu, 27 Jun 2019 17:45:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D7DE2857D; Thu, 27 Jun 2019 17:45:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC36F284C3 for ; Thu, 27 Jun 2019 17:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727346AbfF0Rph (ORCPT ); Thu, 27 Jun 2019 13:45:37 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46980 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727338AbfF0Rpg (ORCPT ); Thu, 27 Jun 2019 13:45:36 -0400 Received: by mail-pl1-f193.google.com with SMTP id e5so1661158pls.13; Thu, 27 Jun 2019 10:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=YcrOIML8x2OsusC75WoEHjxhMdfGqgM3ZNHf/dMTePc=; b=jf7n5fH2A5HNpS8PTM3S811DsWred9JfeFur4PDK5+BudkEiGv0uONGRk5LPBKX5G1 igwiiPl5vGHIZPuIqoEe5l0Qs+cin2RFFIMudj7GJPW0mPr66sKSrbwTUKz249EJoPSn 8Hs7tWuLze0yhunJHSGizmLFFeiJw1o1IfQxO04RFUiW4KlfMkSZlJD6Z6L4W7C9ei4U X1li4zYSgq37mTn1irKNa1ka/hTFpj0qgHUsNHsiM9uMWD1hSSpiGrnJ9rOHWYQwnOeh B1pYgzlYTDmPbk2zt7ht/oTG6uJ34b/ldweUXOBJXiIDRBLwMqAA0fdEwR8lwPbU8Q7o /IZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YcrOIML8x2OsusC75WoEHjxhMdfGqgM3ZNHf/dMTePc=; b=pk1oU4DNJxScnN9bfqKfiPypsK1CFN4daa0K4N5CVizhGtXnNaiwqDrq3f4E1DYiJh Ll61wgyuRzIYGOuKP7Ef2evnUPTPdZn69/F9+nqFIUoBsPxU0EMOMK1G+WdfQsoG1ai/ GHk3msa/X+75yoSccD/88EwcVWw+QR0kAqnjFHizLnMvcdvOtPsP/4onCfH3laYija4x VszOu9g/NFZDFS8/iBH7aSazWaDQADVDqa0e5kWOjky307NzgS7Sj/2Te9rRt1IyxrNF bHppZXZwWa03x5gWbxSCXeimaA3+j1t+1z1tJyfDiSAQ85QeBA0kzAM7oZz13WytwdSz ZYtA== X-Gm-Message-State: APjAAAXXqHgWHffws9dxtVcnYPdbxanNaU4zhPxhAJPtl1i/GEVuvNHC p4AEn9Ks72Ui2F5ae9E4Src= X-Google-Smtp-Source: APXvYqzbE72vwOnzbiDPERLuny3jJnLY2gpyWJh7MxzsMwmFnRrKeXVhleKt5228V1zkdGf43LmBdw== X-Received: by 2002:a17:902:110b:: with SMTP id d11mr6279856pla.213.1561657535820; Thu, 27 Jun 2019 10:45:35 -0700 (PDT) Received: from hfq-skylake.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.googlemail.com with ESMTPSA id t7sm4641393pjq.15.2019.06.27.10.45.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 10:45:35 -0700 (PDT) From: Fuqian Huang Cc: Fuqian Huang , Kalle Valo , "David S. Miller" , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 78/87] wireless: ath10k: remove memset after dma_alloc_coherent Date: Fri, 28 Jun 2019 01:45:27 +0800 Message-Id: <20190627174527.5987-1-huangfq.daxian@gmail.com> X-Mailer: git-send-email 2.11.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang --- drivers/net/wireless/ath/ath10k/ce.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c index eca87f7c5b6c..294fbc1e89ab 100644 --- a/drivers/net/wireless/ath/ath10k/ce.c +++ b/drivers/net/wireless/ath/ath10k/ce.c @@ -1704,9 +1704,6 @@ ath10k_ce_alloc_dest_ring_64(struct ath10k *ar, unsigned int ce_id, /* Correctly initialize memory to 0 to prevent garbage * data crashing system when download firmware */ - memset(dest_ring->base_addr_owner_space_unaligned, 0, - nentries * sizeof(struct ce_desc_64) + CE_DESC_RING_ALIGN); - dest_ring->base_addr_owner_space = PTR_ALIGN(dest_ring->base_addr_owner_space_unaligned, CE_DESC_RING_ALIGN); @@ -2019,8 +2016,6 @@ void ath10k_ce_alloc_rri(struct ath10k *ar) value |= ar->hw_ce_regs->upd->mask; ath10k_ce_write32(ar, ce_base_addr + ctrl1_regs, value); } - - memset(ce->vaddr_rri, 0, CE_COUNT * sizeof(u32)); } EXPORT_SYMBOL(ath10k_ce_alloc_rri);