From patchwork Fri Jun 28 11:55:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nitin Gote X-Patchwork-Id: 11022019 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02B6B1398 for ; Fri, 28 Jun 2019 11:56:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6D0E2851E for ; Fri, 28 Jun 2019 11:56:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DAFE9287CF; Fri, 28 Jun 2019 11:56:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id D46F02851E for ; Fri, 28 Jun 2019 11:56:00 +0000 (UTC) Received: (qmail 19466 invoked by uid 550); 28 Jun 2019 11:55:59 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 18380 invoked from network); 28 Jun 2019 11:55:58 -0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,427,1557212400"; d="scan'208";a="314115039" From: Nitin Gote To: keescook@chromium.org, jannh@google.com Cc: kernel-hardening@lists.openwall.com, Nitin Gote Subject: [PATCH] checkpatch: Added warnings in favor of strscpy(). Date: Fri, 28 Jun 2019 17:25:48 +0530 Message-Id: <1561722948-28289-1-git-send-email-nitin.r.gote@intel.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Added warnings in checkpatch.pl script to : 1. Deprecate strcpy() in favor of strscpy(). 2. Deprecate strlcpy() in favor of strscpy(). 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad(). Signed-off-by: Nitin Gote --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 342c7c7..bb0fa11 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -595,6 +595,9 @@ our %deprecated_apis = ( "rcu_barrier_sched" => "rcu_barrier", "get_state_synchronize_sched" => "get_state_synchronize_rcu", "cond_synchronize_sched" => "cond_synchronize_rcu", + "strcpy" => "strscpy", + "strlcpy" => "strscpy", + "strncpy" => "strscpy or strscpy_pad", ); #Create a search pattern for all these strings to speed up a loop below