From patchwork Mon Jul 1 03:39:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 11025151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 077C5138B for ; Mon, 1 Jul 2019 07:13:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 046042850D for ; Mon, 1 Jul 2019 07:13:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ECE0B28514; Mon, 1 Jul 2019 07:13:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6A41D2850D for ; Mon, 1 Jul 2019 07:13:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FBB789F19; Mon, 1 Jul 2019 07:13:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 860BA89C1B for ; Mon, 1 Jul 2019 03:39:28 +0000 (UTC) Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hhnA2-0005HP-JY; Mon, 01 Jul 2019 03:39:22 +0000 To: dri-devel , LKML From: Randy Dunlap Subject: [PATCH] drm: bridge: DRM_SIL_SII8620 should depend on, not select INPUT Message-ID: <8baa25c0-498b-d321-4e6a-fe987a4989ba@infradead.org> Date: Sun, 30 Jun 2019 20:39:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Language: en-US X-Mailman-Approved-At: Mon, 01 Jul 2019 07:12:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WmShzI9iFuKGxmB8xLb0p4KOmNmec9AETrO7/tG34T0=; b=Qn7AHdhRQFyigFqNMTVizzZAh Hj1RMvU2sMlXLkyWgMj2cs6q9Szx7vdGU9yu9gioYef22lNmR+J/sSdAGE/a9kJ7jDVEzh2TvlX8S w4lQZqPLfIN9OrKs1wcdZfEtFVlS/qKdMDbabY8NP11WGPzugE6MPTCKjQPvvw2gTOlJu0Cd4fbC5 28HpYaANDX9JJyU5Z06cEFF4awRRUdiBd3rPlAG7ywv4wyFkgMZM2N2bs2qf2N540acZkpYW06R5/ 12BcK9+TFp3iMWKrw0cJtcEMk/4LllcBxMcUJ6NURE27oul16kBfEmLW+tR6bf8MIdwPT59iYyqwu 2+Pw6KL3Q==; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap A single driver should not enable (select) an entire subsystem, such as INPUT, so change the 'select' to "depends on". Fixes: d6abe6df706c ("drm/bridge: sil_sii8620: do not have a dependency of RC_CORE") Signed-off-by: Randy Dunlap Cc: Inki Dae Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org --- Linus has written this a couple of times in the last 15 years or so, but my search fu cannot find it. And there are a few drivers in the kernel tree that do this, but we shouldn't be adding more that do so. drivers/gpu/drm/bridge/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- lnx-52-rc7.orig/drivers/gpu/drm/bridge/Kconfig +++ lnx-52-rc7/drivers/gpu/drm/bridge/Kconfig @@ -83,10 +83,9 @@ config DRM_PARADE_PS8622 config DRM_SIL_SII8620 tristate "Silicon Image SII8620 HDMI/MHL bridge" - depends on OF + depends on OF && INPUT select DRM_KMS_HELPER imply EXTCON - select INPUT select RC_CORE help Silicon Image SII8620 HDMI/MHL bridge chip driver.