From patchwork Wed Jul 3 08:13:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishka Dasgupta X-Patchwork-Id: 11029033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 147371398 for ; Wed, 3 Jul 2019 08:13:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 066F528786 for ; Wed, 3 Jul 2019 08:13:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE6562880A; Wed, 3 Jul 2019 08:13:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7700528786 for ; Wed, 3 Jul 2019 08:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b1FRcQX7QCEM3eCZYQFA19WcLEyzCwAu8TqMods43ss=; b=aTl1cjjRMpUAzQ ytUrFPSFLf14YHEj7xSTX3ZtTgxObgISnAbXGvXWEPi6IYb1YiuPwYcawvx6wJC5bTaRW/pW2I68U 9+bLwi3Fknojj6Yx9Lw1zxymFpeTsY6Cfjdx4Al4HT3kpnoXzKJVNzxb8ZxdPV+9ilIBiH0aQekUC eocR76dolLGs/KcQ4Vm2TWMBTkZkHBgzZPjPVMCtgijW9NQBomy5kCopBgV+6wUdLNWetm7KR57XH 4oNjlgEeXFAwq/VcYNpmbKJvXx4xVCPl6/Y1dPIEdR1fize0A10Y51TSl2+QJL6/7/QfDi1mFIbjP DltjN4t/KJKD6wQBWRmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiaOU-0003WW-M8; Wed, 03 Jul 2019 08:13:34 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiaOR-0003Vv-Ur for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2019 08:13:33 +0000 Received: by mail-pl1-x644.google.com with SMTP id 9so803915ple.5 for ; Wed, 03 Jul 2019 01:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BvJNwkPS9MfNl5cMsC1QP7QkMzi/DuELy2LvBnmsMXs=; b=lVKLv9ep+x4cUvfF60e2j506ilKkHO6GJ9kMGHlE16ajbL+aUPEEM5VQAC6ea0Bldg JELTiHoLc+YIjPM+QPlPf3s6whkUv9WCjVkrb9BjMPoiXgeiwiQ1nTMFlgaks4IDjskG 0fgyOsK2vtV9xEHR7ZT0fOL/B2opBXSj2h5l+UdEpM1YuBjWJa0wPoV7ob8l3qqIAOTr vFuyiv9yqqiITs5cpwC3l380edGBtpIjt3jVRO9ocbLYjW4xtkfe8V8K4+hlo8UCt1pt 7cv0tjmysRqss+du9MGt7dKW2lha1blcf4PAFNaJg4ObAmXj5Ld+TPmEAFnwdAc7oBYs jc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BvJNwkPS9MfNl5cMsC1QP7QkMzi/DuELy2LvBnmsMXs=; b=rO+F4ZwFgmCjlQ+w7GcJSV47Z9QUuUpWgIw9BEYlaVEv88uJdwvzQAhDpGQCLRG0Do wDLw51i93Tz7bF+dvHqW8zM0mlTO/55dSGu6nIIQGfm8rqXgq9k18975TLSlJ7DZm1VL Ysz7p+CcH/unOFBOGpA85uyWO3SGPCd+7nLqKXDMPOGbCjjZSuuQFipivZbb2XEfEb9V tD37MiT4Fpru/9rXQ93oTdMzAsH4QxBk87nprv84kGZYoxc2IQBdgHeDqZPXFhAKQXaK f6hs3IS3vQwAxQl/Gc/Tb1lRrBDMVYptd5QdWdPUCbBmP97+R42VzrD9B7hRkwt4HVlc zpHw== X-Gm-Message-State: APjAAAWGfc/eVdg30qnZJ0D9umnXNvCiaYqH6G+NUMosM5O9UisZROT1 HsywGFTUuKe1UxhnxnNiWSI= X-Google-Smtp-Source: APXvYqyU1k/W96dJNhLR99ByjoiAJ5wVF3nwNApkKn61Qi1jDrfWmGEXDoi1IdFinLjkKK+4fQ8R1Q== X-Received: by 2002:a17:902:b284:: with SMTP id u4mr42218344plr.36.1562141610635; Wed, 03 Jul 2019 01:13:30 -0700 (PDT) Received: from localhost.localdomain ([122.163.64.117]) by smtp.gmail.com with ESMTPSA id m6sm1176450pjl.18.2019.07.03.01.13.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Jul 2019 01:13:30 -0700 (PDT) From: Nishka Dasgupta To: maxime.ripard@bootlin.com, paul.kocialkowski@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] staging: media: sunxi: Change return type of cedrus_find_format() Date: Wed, 3 Jul 2019 13:43:16 +0530 Message-Id: <20190703081317.22795-1-nishkadg.linux@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190703_011331_997028_2B2C1449 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishka Dasgupta Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Change return type of cedrus_find_format to bool as it is only called once, by a function whose return value is bool, and the return value of cedrus_find_format is returned as-is at the call-site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index 9673874ece10..0ec31b9e0aea 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c @@ -55,8 +55,8 @@ static inline struct cedrus_ctx *cedrus_file2ctx(struct file *file) return container_of(file->private_data, struct cedrus_ctx, fh); } -static struct cedrus_format *cedrus_find_format(u32 pixelformat, u32 directions, - unsigned int capabilities) +static bool cedrus_find_format(u32 pixelformat, u32 directions, + unsigned int capabilities) { struct cedrus_format *fmt; unsigned int i; @@ -70,13 +70,10 @@ static struct cedrus_format *cedrus_find_format(u32 pixelformat, u32 directions, if (fmt->pixelformat == pixelformat && (fmt->directions & directions) != 0) - break; + return true; } - if (i == CEDRUS_FORMATS_COUNT) - return NULL; - - return &cedrus_formats[i]; + return false; } static bool cedrus_check_format(u32 pixelformat, u32 directions, From patchwork Wed Jul 3 08:13:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishka Dasgupta X-Patchwork-Id: 11029035 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 117AD13A4 for ; Wed, 3 Jul 2019 08:13:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03AD72880A for ; Wed, 3 Jul 2019 08:13:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC3182893D; Wed, 3 Jul 2019 08:13:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A15E028972 for ; Wed, 3 Jul 2019 08:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ne82rVM1Z+sGORStK+OMwEM6ZzkhZRDkJs5G8EI5ggI=; b=PHjq5AepVsmQga OqLPRnj7dHAlf7k1me3rf7RAOAn0djY9Hd/Bbr5aY4ml8EvZ8jCUTkiMQv/2CRfaGqESSjqxt2tck GWohq3WUa8xm8lGmQfSP4s92fnb0EKAwqU7rwCOHJ11G9Zwogw5aUQS/iawwmAOOZVbdLLM0vZA3q Q+/AtjEYUE19KSigSr3nar9mGd1gXSaHRKtEGAwgxwiOrxWN/m7llcdbHgEHLiapYdQ7LOoKPHznX RbKT1FVGJUX8aBusFvzIS4r11UPqp+3BCAdTW4DpeV0NMiieDs88Ei58fUjHBDG16qOYRelSJhWa5 CoHuXm8CzbB7K1gHun+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiaOf-0003gA-Oq; Wed, 03 Jul 2019 08:13:45 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiaOU-0003WY-Vf for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2019 08:13:36 +0000 Received: by mail-pf1-x444.google.com with SMTP id i189so844106pfg.10 for ; Wed, 03 Jul 2019 01:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jpedf64g2nGaIs7kgKn6od/wbXCzG2Hoh0kidvPp7dk=; b=tOprpnLAEEu6fBkdjXEIJ34BuvWtKBDm5oEf54+Da+m50nWfaYSHHYYdb5/6Vg0El4 GJXh6N9s/2RFeP58PZSTqgYb2ZdhyQS2yTWrNvpC6u1D9qtX1/Qlc4cRYCxvCgbG0De5 jguuTe0m9jiGaF+yO+h2AMOilbpq1WM7maY29R5L9CrC/EYcCkNr9OWivOSCFOjuq69D EczBnsIA5UnKpZuB9Ia+uJvA+97afMhGs5Rm1HCuUAZfMqJdl+6ll0oGKFfn9b2dITd7 BNZ2sm9qhOeUAIBRDu9q74BmWc5/WvUNz0KwH+MVw2Lb26Xh5Rqc3UaLLh7sTs8/xFit RP8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jpedf64g2nGaIs7kgKn6od/wbXCzG2Hoh0kidvPp7dk=; b=GAZk4nnR878HLpqfTUT9LptZjAGPttZw4yYi634QlIsWa/EJD3P/bDcWEKVwTXJnxU ZzcHsypTi3xj8eFCsTXoI/FuU7suAuMCGlUBYr1GMh9TQAsYPlcxpF1oDLe+F4ZTZtCU wK5OY0idshv3COFw505s7mRcFrT11rxI9WgGB40MNmrD/bgyAWPx5Z5fZaf6dRPQpHud jSacVQJNVSjIrdggHKrljUZZSXL7yO8/qXjTr/rTU4h2LGluO0oDePzQ3PJeTni3qLh7 m+oxIuTBorc7YmlkDZsn+kRWVlUqk5yGFF6OhAVtBecTsCerU0WO72k1xT4c5iAAlPv5 fH7A== X-Gm-Message-State: APjAAAWU7X0BVsLpG3ZNVvumPazfAHc40n+LksazHEhKDZW1fIEZgipE 22wEMskONWNJDtXma5qoXlI= X-Google-Smtp-Source: APXvYqzNOnUDpfrEJM1ib6cYQUAiqJDL28YiIUT8L7BJ5nYJWLkdmVuLfk19mXffx4aXSbV1sHUrBQ== X-Received: by 2002:a17:90a:a116:: with SMTP id s22mr11066464pjp.47.1562141614267; Wed, 03 Jul 2019 01:13:34 -0700 (PDT) Received: from localhost.localdomain ([122.163.64.117]) by smtp.gmail.com with ESMTPSA id m6sm1176450pjl.18.2019.07.03.01.13.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Jul 2019 01:13:33 -0700 (PDT) From: Nishka Dasgupta To: maxime.ripard@bootlin.com, paul.kocialkowski@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] staging: media: sunxi: Replace function cedrus_check_format() Date: Wed, 3 Jul 2019 13:43:17 +0530 Message-Id: <20190703081317.22795-2-nishkadg.linux@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190703081317.22795-1-nishkadg.linux@gmail.com> References: <20190703081317.22795-1-nishkadg.linux@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190703_011335_081012_81A2F8DD X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishka Dasgupta Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Remove function cedrus_check_format as all it does is call cedrus_find_format. Rename cedrus_find_format to cedrus_check_format to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index 0ec31b9e0aea..d5cc9ed04fd2 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c @@ -55,8 +55,8 @@ static inline struct cedrus_ctx *cedrus_file2ctx(struct file *file) return container_of(file->private_data, struct cedrus_ctx, fh); } -static bool cedrus_find_format(u32 pixelformat, u32 directions, - unsigned int capabilities) +static bool cedrus_check_format(u32 pixelformat, u32 directions, + unsigned int capabilities) { struct cedrus_format *fmt; unsigned int i; @@ -76,12 +76,6 @@ static bool cedrus_find_format(u32 pixelformat, u32 directions, return false; } -static bool cedrus_check_format(u32 pixelformat, u32 directions, - unsigned int capabilities) -{ - return cedrus_find_format(pixelformat, directions, capabilities); -} - static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt) { unsigned int width = pix_fmt->width;