From patchwork Wed Jul 3 19:06:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Pandit X-Patchwork-Id: 11030187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF48814F6 for ; Wed, 3 Jul 2019 19:10:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A22AF285E0 for ; Wed, 3 Jul 2019 19:10:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 968DB28684; Wed, 3 Jul 2019 19:10:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7A043285E0 for ; Wed, 3 Jul 2019 19:10:55 +0000 (UTC) Received: from localhost ([::1]:38760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hikec-0005CC-KX for patchwork-qemu-devel@patchwork.kernel.org; Wed, 03 Jul 2019 15:10:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39683) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hikcZ-0003dx-VX for qemu-devel@nongnu.org; Wed, 03 Jul 2019 15:08:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hikcZ-000895-5L for qemu-devel@nongnu.org; Wed, 03 Jul 2019 15:08:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60216) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hikcW-000871-Jh; Wed, 03 Jul 2019 15:08:44 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 530DE3082E51; Wed, 3 Jul 2019 19:08:26 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-160.sin2.redhat.com [10.67.116.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18C05968A0; Wed, 3 Jul 2019 19:08:21 +0000 (UTC) From: P J P To: Qemu Developers Date: Thu, 4 Jul 2019 00:36:15 +0530 Message-Id: <20190703190615.31436-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 03 Jul 2019 19:08:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] hw/ssi/xilinx_spips: add lqspi_write routine X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Prasad J Pandit , Lei Sun Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Prasad J Pandit Define skeleton lqspi_write routine. Avoid NULL dereference. Reported-by: Lei Sun Signed-off-by: Prasad J Pandit --- hw/ssi/xilinx_spips.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 8115bb6d46..0836b8977a 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -1221,8 +1221,15 @@ lqspi_read(void *opaque, hwaddr addr, unsigned int size) } } +static void +lqspi_write(void *opaque, hwaddr addr, uint64_t data, unsigned size) +{ + return; +} + static const MemoryRegionOps lqspi_ops = { .read = lqspi_read, + .write = lqspi_write, .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 1,