From patchwork Wed Jul 10 02:30:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hariprasad Kelam X-Patchwork-Id: 11037743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF534138D for ; Wed, 10 Jul 2019 02:32:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD454288CF for ; Wed, 10 Jul 2019 02:32:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9ED54288F7; Wed, 10 Jul 2019 02:32:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F34FC288CF for ; Wed, 10 Jul 2019 02:32:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C191B15F2; Wed, 10 Jul 2019 04:31:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C191B15F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1562725921; bh=rBnEsPe2CaYdYYFIP8JKa4PGnKo2KnpkZBYeY5lcAAw=; h=Date:From:To:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=SkWTx9l/cyAslNYhnssm8aAKNa9P0DiFTKBhxR1Vhgp00gvDXIsDQLq1I6vvcJWmF Z1bhRP00ur56Ca/aOKPzc3UE6yan3AT2oo5xtfQML8TR3coaOFuKvBRC52RcGkMF2w TkZY3kvpud3pAyoaNOgHpn1Kd28oTVf4IlY9EXOw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 371B2F802A0; Wed, 10 Jul 2019 04:31:11 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E3A4F802A1; Wed, 10 Jul 2019 04:31:10 +0200 (CEST) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4BD39F800E2 for ; Wed, 10 Jul 2019 04:31:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4BD39F800E2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TcSDpgWZ" Received: by mail-pg1-x544.google.com with SMTP id g15so421030pgi.4 for ; Tue, 09 Jul 2019 19:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=4cRP2WCZtummGCJmZjETlwBuipDUxE57gp0VCpL4ho0=; b=TcSDpgWZpw8sLhLS8hOEKXei4aNVrcM8KH61CL66GmWu2wgPFvVSi1uI0KpG/X5wx7 U3/NtP/DhFikSl/ERcT7WzTpI5aoHCqbd5myNR8Lqz5jvDq4I3tPLttR77m+WWBI53+R 8yIev1fHE3BiekEOcKVZVG0TKmytVuJFlSoSFRh/HvdVgEHk3NCAuIxVczM6S0shEyQ7 4aZlPQDVNc6BSxjU1WKFcr54DcTQIU13U03lCUhpxuAkHl18SC1YRIcwceeVqWwyAJ+4 P/tIyqBMyaX4otCiZMtZiPFWxHTr93pRnBMiin2SlBQeTPbbVs2efCYCtLRWHWjR8Dry hoZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=4cRP2WCZtummGCJmZjETlwBuipDUxE57gp0VCpL4ho0=; b=W63XEiV1a8BwnW9Z57dmnT8WcJd2X6miyHoSt8/+F2r/74up6LEBikWcUXAZgDBrDr IAF01EgeYrhormM/y+gaZfMC2PH0oLunCAznYHTFFNCqy2fKQK4LH59mra2aRORSBmTQ Ge7DfQ5FnWHQSiRM6wB2T4GPlXsgELXoYYBHl6m/+7ZkFXSxODZmJp1gFhgE2yxh0GZg 1/mxM1y/0QL+YksR+JLhhuZ1WdlDIgLMeQMKU77SKe29inB6r1KYa+njC3SSqumeFT8m 1hksvz6a2SsXAw076gZC2UkuKk8OEK+BMmNdidIXkoAlnwTKUWW82kzoLQ6scD+CbcUo 2uIQ== X-Gm-Message-State: APjAAAWNoUwZZcGJ837X7QECA0aJ5htPxOudunWxhAC1SZtpwOvYg+s0 s6gX55pVW1e5/PWFf86IZZo= X-Google-Smtp-Source: APXvYqzY/mS53Xz6A6fiZt/w7HVVhNTxk8ojhH/ywhjWnS0wRHa/saBxl3uWe++xDS6GzuH2JUorYg== X-Received: by 2002:a17:90a:8c18:: with SMTP id a24mr3622949pjo.111.1562725864971; Tue, 09 Jul 2019 19:31:04 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.86.126]) by smtp.gmail.com with ESMTPSA id r7sm387790pfl.134.2019.07.09.19.31.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 19:31:04 -0700 (PDT) Date: Wed, 10 Jul 2019 08:00:59 +0530 From: Hariprasad Kelam To: Jaroslav Kysela , Takashi Iwai , Kate Stewart , Hariprasad Kelam , Allison Randal , Thomas Gleixner , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20190710023059.GA14204@hari-Inspiron-1545> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Subject: [alsa-devel] [PATCH] sound: pci: lx6464es: Remove unneeded variable err X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes below issue reported by coccicheck sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return "0" on line 258 We cannot change return value as its registered with snd_pcm_ops->close Signed-off-by: Hariprasad Kelam --- sound/pci/lx6464es/lx6464es.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c index 1771a6d..583ca73 100644 --- a/sound/pci/lx6464es/lx6464es.c +++ b/sound/pci/lx6464es/lx6464es.c @@ -253,9 +253,8 @@ static int lx_pcm_open(struct snd_pcm_substream *substream) static int lx_pcm_close(struct snd_pcm_substream *substream) { - int err = 0; dev_dbg(substream->pcm->card->dev, "->lx_pcm_close\n"); - return err; + return 0; } static snd_pcm_uframes_t lx_pcm_stream_pointer(struct snd_pcm_substream