From patchwork Wed Jul 10 02:39:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hariprasad Kelam X-Patchwork-Id: 11037745 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C139A138D for ; Wed, 10 Jul 2019 02:40:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A400D28689 for ; Wed, 10 Jul 2019 02:40:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 93702286A8; Wed, 10 Jul 2019 02:40:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C9E4028689 for ; Wed, 10 Jul 2019 02:40:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A645D1607; Wed, 10 Jul 2019 04:39:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A645D1607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1562726448; bh=qBO0DKmTEnlGOjrF6szV7Qo1D/bs2mtC0NS2vgJmVyA=; h=Date:From:To:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=i0oWubLM7W2oFExHwNsNf5OiXL4I5SIWGjvcv0zTZ9j/vMbAz48tNXfR2nU0Zrgp2 s5qxHbpwdmncFSj4V5DKdQzAQBXzcRdz0RQXiGPwj2bKru2inXnOLKSTQJHoEQTdy5 TTbdF9jgbkg8vej8Bl7holBf4PpMh6lnwC9/Sokc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1D99DF802A0; Wed, 10 Jul 2019 04:39:58 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id D4F6BF802A1; Wed, 10 Jul 2019 04:39:56 +0200 (CEST) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6F0B2F800E2 for ; Wed, 10 Jul 2019 04:39:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6F0B2F800E2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hUE1adA9" Received: by mail-pg1-x543.google.com with SMTP id l21so434826pgm.3 for ; Tue, 09 Jul 2019 19:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=eYXNQQatx5CsTvcWnAhx8hozPNi1nTqqLqSrJNAWy6w=; b=hUE1adA9ehAy7iETpmQ8DNp3I53GbtbDOpYXs19uYfbIeOI7Jh7sZe4hHXjymkDZQs hZ7qW12GR1twmIEm7NT3T5lAYCepIFPOe6U95PJ+OlUGT2SUkGj3GnbMI7Cbgo5ITSd9 J0D//1L6lMdg0qoHBdNNCnVl7GJ4obVkGLHFIVI2XXykumF67E0odyhvCX+38mqcfvwT mtJkBJQcqD3C+B+RGOfaCary++05pvc1tRN4x21wktTQT+JvgntqaPM+0E/XZC9ib5MR HKo0gX0SrwvcuRgRss3BufISgUN28PS40ArtDEVC4WqOk5GlvdO7pwf/Gv1A5Dsam3yh c7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=eYXNQQatx5CsTvcWnAhx8hozPNi1nTqqLqSrJNAWy6w=; b=HFBVhZDktT/mnmad9hjNBkXkd1bQebfA5x0rp7HtqeYjdvMnRlVo4EEwgeUFD6JbVZ 5/UVjn2Bz6omZVepUWHmvurUEabfxtcLDb4VuF/0Er64F2ktfHGKhPXBggxemtoZobGe svCwJ7WI1n+ygMZclBy7zMf8JzjbMiOZxe91XJVy1boQnYnCF6TvLjsjOp2sZTyt4Twc YYFtfQr+SSG+8z5yHbc0aaAnl6C0DLAX4IWbmolbIjk7/WC9DZc2hg3ENSUuLAMTmT8g SmI8kx9uGRiKFbAEnAOfT2peRwFvFja+5ckqHM+rqnRBgVQNkz4PBl69LVa4y9QRCh/I IVQw== X-Gm-Message-State: APjAAAUU8Mg3EfnTTAVRnny4LnULquju8PmDgb33Sd50Le2aImy64BS4 RgOe1EMwRX6BgCNg3DWStSU= X-Google-Smtp-Source: APXvYqzV4cvph+x4iw9QnWrbLU+PYZ7pHPVu5gaXf5zLuHL5eAGc0SdNKwVpnfRK/oSfv6jyQqrQ8A== X-Received: by 2002:a17:90a:fa07:: with SMTP id cm7mr3831866pjb.115.1562726392001; Tue, 09 Jul 2019 19:39:52 -0700 (PDT) Received: from hari-Inspiron-1545 ([183.83.86.126]) by smtp.gmail.com with ESMTPSA id x12sm360063pgj.79.2019.07.09.19.39.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 19:39:51 -0700 (PDT) Date: Wed, 10 Jul 2019 08:09:46 +0530 From: Hariprasad Kelam To: Geoff Levand , Jaroslav Kysela , Takashi Iwai , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20190710023946.GA15604@hari-Inspiron-1545> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Subject: [alsa-devel] [PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes below issue reported by coccicheck sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on line 668 We cannot change return type of snd_ps3_pcm_trigger as it is registered with snd_pcm_ops->trigger Signed-off-by: Hariprasad Kelam --- sound/ppc/snd_ps3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c index 71b7fd3..c213eb7 100644 --- a/sound/ppc/snd_ps3.c +++ b/sound/ppc/snd_ps3.c @@ -628,7 +628,6 @@ static int snd_ps3_pcm_trigger(struct snd_pcm_substream *substream, int cmd) { struct snd_ps3_card_info *card = snd_pcm_substream_chip(substream); - int ret = 0; switch (cmd) { case SNDRV_PCM_TRIGGER_START: @@ -665,7 +664,7 @@ static int snd_ps3_pcm_trigger(struct snd_pcm_substream *substream, } - return ret; + return 0; }; /*