From patchwork Wed Jul 10 21:45:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary R Hook X-Patchwork-Id: 11038975 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A7FF51395 for ; Wed, 10 Jul 2019 21:45:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A8B6287C6 for ; Wed, 10 Jul 2019 21:45:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8EA2528867; Wed, 10 Jul 2019 21:45:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42484287C6 for ; Wed, 10 Jul 2019 21:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727248AbfGJVpj (ORCPT ); Wed, 10 Jul 2019 17:45:39 -0400 Received: from mail-eopbgr730082.outbound.protection.outlook.com ([40.107.73.82]:47295 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727188AbfGJVpj (ORCPT ); Wed, 10 Jul 2019 17:45:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDMBjwSH7TwAwJJZVaaXbY8nrDtRsSD1MhPnNnhrgnNGq+myAToOaWLjUh9TVrG9p63/4cjLdvz+2wC8H+fnox4YSpj7ki4jpxIB1M27IDjlMx2TyItWKfnyFTC2OTG4ZKD9JJGeDeIMPlldcJdkUDfUJ161oXHLEGwLknxlvkZpiwk3vH6JqDRyl6dsBhBzHCygsCckJhzBH24edpJFoGOsqi/8SHlYHjyBHpIdcgmLvfdxbK2cxfAYs9jAQHPERO4snIhaoAtPzroks4kvb99Re6ZO5ZSUdFiXauno0AfKJUnQDFFBg41wVpjhy8zwhi0dNsNdeR9PXTTR2Re/YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMDnHu04HhRV8PXhzAJ9KDbu2JuzrSyhOHUXbrK5h+M=; b=HgXaAkC/wqOhiU2Q3Ep0WrYGiGrW50R+L4Cn6c5kaa478Yq6DaL3hnvkp1+qZa4JUUBz3X/DCi52jCzlG+qtEIulqMk34xJIQvZhDHqOpw2rDD/Q+YDDO2NO7qR5BtPVm07xdvRXbjpj4AEKzaUtiO2eX6hfZM/9szw0/27Jy52QrHIovl6F1nBxtqTDeOtx3AC6X7HhUOwCtKmlWHjGrQDKbvHqnxF4dFqKkcrhMH3Rp/bjLF7X70xYxQOu+8csF6X8FlCpv40mAe+XV7tDNrogIC66T6BDu3owbmQXN+kAcpjuSM2D8VHInZt9vKMcvnzJqMDJFcEF6RZTVTG9/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=amd.com;dmarc=pass action=none header.from=amd.com;dkim=pass header.d=amd.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMDnHu04HhRV8PXhzAJ9KDbu2JuzrSyhOHUXbrK5h+M=; b=TnleHqz7p0rBYhI7vXv6BQIp77zy5DE5cOeuDLp2VBa1dphsxW9evhKw3f9tHFKt8MZVwWEDL7gkyPn74x6mR6vHw5edFSC2naWhytKYXxrzcBBUGCPdR1h+vBPTcT+ZtPV8UifZbodSCmtNXRqoCdjsfFFECWRMNaGN7yD8mBE= Received: from DM5PR12MB1449.namprd12.prod.outlook.com (10.172.40.14) by DM5PR12MB1450.namprd12.prod.outlook.com (10.172.33.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Wed, 10 Jul 2019 21:45:37 +0000 Received: from DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::a894:b1d5:a126:adce]) by DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::a894:b1d5:a126:adce%6]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 21:45:37 +0000 From: "Hook, Gary" To: "linux-crypto@vger.kernel.org" CC: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "Lendacky, Thomas" , "Hook, Gary" Subject: [PATCH 1/2] crypto: ccp - Include the module name in system log messages Thread-Topic: [PATCH 1/2] crypto: ccp - Include the module name in system log messages Thread-Index: AQHVN2jPzLE/a3eleESWpr/+UGvtNg== Date: Wed, 10 Jul 2019 21:45:37 +0000 Message-ID: <20190710214504.3420-2-gary.hook@amd.com> References: <20190710214504.3420-1-gary.hook@amd.com> In-Reply-To: <20190710214504.3420-1-gary.hook@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN6PR06CA0017.namprd06.prod.outlook.com (2603:10b6:805:8e::30) To DM5PR12MB1449.namprd12.prod.outlook.com (2603:10b6:4:10::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [165.204.78.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6c870a80-0088-44f6-918b-08d7057ff198 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DM5PR12MB1450; x-ms-traffictypediagnostic: DM5PR12MB1450: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(189003)(199004)(256004)(6436002)(6486002)(8936002)(5640700003)(68736007)(99286004)(2501003)(2351001)(1076003)(316002)(71200400001)(14454004)(66066001)(8676002)(486006)(386003)(6506007)(81166006)(52116002)(71190400001)(50226002)(66446008)(64756008)(66556008)(66476007)(53936002)(76176011)(54906003)(6512007)(66946007)(2906002)(186003)(102836004)(15650500001)(3846002)(305945005)(36756003)(478600001)(6116002)(7736002)(81156014)(26005)(446003)(4326008)(4744005)(5660300002)(476003)(2616005)(11346002)(25786009)(86362001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1450;H:DM5PR12MB1449.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0qmBaBHzEKL/SCz9r32AIftztDHVIbkQNwaDyOsAOLOWS5oCwcY1MEymnLU66uTomd3ZOpoul7D7PFcdhujsYfCdQgN+w679M6hOf5x/Li0lh5bXGNcR0IiWR9HYawLsRZQ6SwagDvt7WhtyUkc/LrZb1co2sSWvS+ZCtpdKmO2DIaPXIJUXAXFnqJq5L3AUu6qkdZqF/ny7Yy2kJ+mOHygus7OXZZJEhBE9/ScLoJSkZ5aop9fCriXkjt7Ix8CGfNOPnCUJq9acs4GWnbnVAa4p3WJdFHsRwhhp3ALuJHJ+d0EqWYGfHfLKw57Z4GH2SaJC0LC1WktyeMMXYjvzJVVpkl+zm+mBHKcwOIFijXH79rtrGPgADzb5Nl9B7K436bE+JGd6LSprTdQXi+dNS+pM9zlbeFNWecTTlxC+Uyo= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c870a80-0088-44f6-918b-08d7057ff198 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 21:45:37.0749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ghook@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1450 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Redefine pr_fmt so that the module name is prefixed to every log message produced by the ccp-crypto module Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-crypto.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/ccp/ccp-crypto.h b/drivers/crypto/ccp/ccp-crypto.h index a4a593dddfd6..c5d471b2ac1b 100644 --- a/drivers/crypto/ccp/ccp-crypto.h +++ b/drivers/crypto/ccp/ccp-crypto.h @@ -24,6 +24,10 @@ #include #include +/* We want the module name in front of our messages */ +#undef pr_fmt +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #define CCP_LOG_LEVEL KERN_INFO #define CCP_CRA_PRIORITY 300 From patchwork Wed Jul 10 21:45:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary R Hook X-Patchwork-Id: 11038977 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DF51912 for ; Wed, 10 Jul 2019 21:45:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 90C77287C6 for ; Wed, 10 Jul 2019 21:45:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8516B28867; Wed, 10 Jul 2019 21:45:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 329B2287C6 for ; Wed, 10 Jul 2019 21:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfGJVpp (ORCPT ); Wed, 10 Jul 2019 17:45:45 -0400 Received: from mail-eopbgr700056.outbound.protection.outlook.com ([40.107.70.56]:40421 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727188AbfGJVpp (ORCPT ); Wed, 10 Jul 2019 17:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cedYW+pyQKokb5vEkvQ/8bnSDvk7hVM1qk9cLe/q9sg=; b=CkZtPgXCoyl4JZJkRrV7H/eijhoGLt4y66rwDvkA11GpFfw+39JbNLqzTToqwzYnycLfdSqCYQWSbO2otTKUlvzXLrZkcTV/IgONZDhjQviMgg6AGfT2PXO2pJnhovbxUgx968VoRw5eKaIjersJ9BMbY2YOkLztHTv91enrU5Y= Received: from DM5PR12MB1449.namprd12.prod.outlook.com (10.172.40.14) by DM5PR12MB1338.namprd12.prod.outlook.com (10.168.235.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Wed, 10 Jul 2019 21:45:39 +0000 Received: from DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::a894:b1d5:a126:adce]) by DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::a894:b1d5:a126:adce%6]) with mapi id 15.20.2052.020; Wed, 10 Jul 2019 21:45:39 +0000 From: "Hook, Gary" To: "linux-crypto@vger.kernel.org" CC: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "Lendacky, Thomas" , "Hook, Gary" Subject: [PATCH 2/2] crypto: ccp - Log an error message when ccp-crypto fails to load Thread-Topic: [PATCH 2/2] crypto: ccp - Log an error message when ccp-crypto fails to load Thread-Index: AQHVN2jQwttvC61Yq0WbCSh/OEN7tA== Date: Wed, 10 Jul 2019 21:45:38 +0000 Message-ID: <20190710214504.3420-3-gary.hook@amd.com> References: <20190710214504.3420-1-gary.hook@amd.com> In-Reply-To: <20190710214504.3420-1-gary.hook@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN6PR06CA0017.namprd06.prod.outlook.com (2603:10b6:805:8e::30) To DM5PR12MB1449.namprd12.prod.outlook.com (2603:10b6:4:10::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [165.204.78.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34dfc445-dd49-47a1-fb24-08d7057ff2b7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DM5PR12MB1338; x-ms-traffictypediagnostic: DM5PR12MB1338: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(189003)(199004)(186003)(478600001)(14454004)(54906003)(316002)(25786009)(14444005)(102836004)(6506007)(4326008)(386003)(71190400001)(26005)(256004)(3846002)(76176011)(1076003)(5640700003)(52116002)(99286004)(6116002)(66066001)(305945005)(2906002)(2501003)(6436002)(7736002)(6486002)(8676002)(81166006)(53936002)(86362001)(50226002)(6512007)(6916009)(66446008)(11346002)(15650500001)(446003)(66946007)(66556008)(64756008)(2351001)(36756003)(68736007)(66476007)(476003)(2616005)(4744005)(5660300002)(71200400001)(81156014)(486006)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1338;H:DM5PR12MB1449.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zrYdEMQNXIhqwkmALH1/hvF8X+sVO95gAFPvquaxroNcD7mZNyHSZrTcWxk3KGRBwaO1Kc0bMqR9K576+BJ4NroyBvzYH0AJdncC2W1CFeN4csx/WSGg3dTHf/erbWSiJIVVEA8bE8ete3i/K44K0gkF2CgQ3geGztdwH54Dzxfl7f7WmelngFGHYM3/l5lq5IC8/5bm1dS+UY7yJ7oDzwnQi+YE5AhRSPUW3b+7F0BLUzG5pf336Yq/U4OoE0jZmxdMQBd+pfej44ZGPVmlOwD/bakf779s3DZ5fRwzJBaIWVAAdm3xaux/7A/rstoyezDS97tbpctIQ2285Rndo/8sIN7PieE0otMa134ZhKJZPWEHb29tncRDnCyqo39TGiEsL19dV2n2YnTMUs6uY4OV3G6h50GsaRhUGPNY7XE= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34dfc445-dd49-47a1-fb24-08d7057ff2b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2019 21:45:38.9695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ghook@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1338 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If there are no CCP devices on the system, ccp-crypto will not load. Write a message to the system log clarifying the reason for the failure of the modprobe operation --- drivers/crypto/ccp/ccp-crypto-main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp-crypto-main.c b/drivers/crypto/ccp/ccp-crypto-main.c index 44a9917a4a6a..5b61c440dff0 100644 --- a/drivers/crypto/ccp/ccp-crypto-main.c +++ b/drivers/crypto/ccp/ccp-crypto-main.c @@ -405,8 +405,10 @@ static int ccp_crypto_init(void) int ret; ret = ccp_present(); - if (ret) + if (ret) { + pr_err("Cannot load: there are no available CCPs\n"); return ret; + } spin_lock_init(&req_queue_lock); INIT_LIST_HEAD(&req_queue.cmds);