From patchwork Tue Jul 23 07:19:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuhong Yuan X-Patchwork-Id: 11054025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 247C8112C for ; Tue, 23 Jul 2019 07:21:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0733527E5A for ; Tue, 23 Jul 2019 07:21:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE339284A3; Tue, 23 Jul 2019 07:21:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A790027E5A for ; Tue, 23 Jul 2019 07:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=INmwIA8m+eX2pHKXsLJvbDVgOF81XuElTC7Bjc2D4nQ=; b=UDxVcy7vzvvmKF u7QvW5cdQ8bBIQIlbJaBlMO3qvFCqQy05Aws59+twtTxIVWALlDAavRm0J/9cGfRpn4NjyfS9dIz8 3U/Cckw67zi+eelk8pcHFeFpGZrWhlE09S6wBQT2X3LPnH/EXrlynGRXf1tdVgsj/HPj2Q/YVI+zh d1aAFX4aOuyfn25LPzdV7qzqpgUINsy3VVBhb4gf2QQJuYMdCREcPNpZmAkJHgv15MtjWtG3/fdl+ YQNVdDsoH1dNzJjVGdQw0Ak4lEnV0Zmd+MF0q6pQuyTjNv5l2NFhxJLrMpQdj2Ia3SJzTozZSsXa7 dzoO4ejnLvrEM8AmOoUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpp6t-0000B7-4h; Tue, 23 Jul 2019 07:21:19 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpp6U-00009U-2w for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 07:20:56 +0000 Received: by mail-pl1-x642.google.com with SMTP id a93so20204827pla.7 for ; Tue, 23 Jul 2019 00:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QWiA/u7FUkm/LP2+FlraH63gXlLRpOie6WBL+YDZks=; b=c1pXgPiAsMw1pk8bFK3PwA0hqGMc/sMpkQtw/FfggkERlGIWgPpZNFo/K4CSzw6hd6 +zz+DO4Bq011chyUgykYBW/IkBssKoYBjfFVYC1kredHk5WX1FmXs4DosE7MK1cerlGI wTU/dMy0KoS0rzhw4w/nFiiJwC7JNEC327bqEGrJQZrAfrJ39cs+2rQfU8ylPvzRK+QM 4afzpXrveZ3d9936OCfAJ7mRhYxKy9xZ5/Hp7WkO3w2hErwZqOUlEFaB14Lpv38NYXfO ZmQrd3mvX4gDwemKPKlxatRA0adWdrPQj/WycIIHZ+lLp6QJM0e6dVYom7AHafUlUbqD oG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4QWiA/u7FUkm/LP2+FlraH63gXlLRpOie6WBL+YDZks=; b=Br59v3LwgBx+rN60zyLyo0eauua01GbEcHH9KkNGMp9aJ6Hvnn4jKENxBoYo9WKK8A ffL7blTYqp95Nh1cZ/SkjlE7/tcVwcOIMOcabIGnEzwnowAcDH52nhWdeq5ezmUiblT0 ZjJritxHatUDCg4JtY5nmu1W1HazWJ7c8I5ANyfkdYxLuzBh+nSVUI+HdRrIk63g06wn 4XHsSUXblxnl0wTTnLWlebpZzNkojESufFltN+pxSwuVZSir3mI3I3qeArTlKnnOdIP+ iky2VWqcWVNJE6WDM7fydNKO2Fk82cLAAz35YIYEwYut+JzyEFeQXbaJkPwQzuKfqLxr F4Nw== X-Gm-Message-State: APjAAAWATkJqCE1DD7GHyk8OiDj90zKvKV8v3AQDoxuF51JhdW5P0TKc DEZ16IKjX9PZllPrwgHNjiU= X-Google-Smtp-Source: APXvYqwTihw8jhNsCmpI+cCen8+lZlsATFxXbsy6cUIM8VdRumBC1BtQZh3JMcofrWyj/ptB6zC+fQ== X-Received: by 2002:a17:902:a9ca:: with SMTP id b10mr5633876plr.69.1563866451938; Tue, 23 Jul 2019 00:20:51 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([89.31.126.54]) by smtp.gmail.com with ESMTPSA id v18sm34217115pgl.87.2019.07.23.00.20.48 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 00:20:51 -0700 (PDT) From: Chuhong Yuan To: Subject: [PATCH] crypto: atmel-sha204a: Use device-managed registration API Date: Tue, 23 Jul 2019 15:19:36 +0800 Message-Id: <20190723071934.12528-1-hslester96@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_002054_730119_D8C3A485 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Herbert Xu , Chuhong Yuan , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-crypto@vger.kernel.org, "David S . Miller" , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_hwrng_register to get rid of manual unregistration. Signed-off-by: Chuhong Yuan Acked-by: Ludovic Desroches --- drivers/crypto/atmel-sha204a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index ea0d2068ea4f..c96c14e7dab1 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -109,7 +109,7 @@ static int atmel_sha204a_probe(struct i2c_client *client, i2c_priv->hwrng.read = atmel_sha204a_rng_read; i2c_priv->hwrng.quality = 1024; - ret = hwrng_register(&i2c_priv->hwrng); + ret = devm_hwrng_register(&client->dev, &i2c_priv->hwrng); if (ret) dev_warn(&client->dev, "failed to register RNG (%d)\n", ret); @@ -127,7 +127,6 @@ static int atmel_sha204a_remove(struct i2c_client *client) if (i2c_priv->hwrng.priv) kfree((void *)i2c_priv->hwrng.priv); - hwrng_unregister(&i2c_priv->hwrng); return 0; }