From patchwork Fri Jul 26 22:13:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 11061867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 44DB313A4 for ; Fri, 26 Jul 2019 22:15:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A144288EE for ; Fri, 26 Jul 2019 22:15:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 03E5028ABB; Fri, 26 Jul 2019 22:15:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 505AC288EE for ; Fri, 26 Jul 2019 22:15:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr8TK-0006TQ-Cl; Fri, 26 Jul 2019 22:13:54 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hr8TI-0006TL-U0 for xen-devel@lists.xenproject.org; Fri, 26 Jul 2019 22:13:52 +0000 X-Inumbo-ID: a5763ddc-aff2-11e9-8980-bc764e045a96 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id a5763ddc-aff2-11e9-8980-bc764e045a96; Fri, 26 Jul 2019 22:13:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EF350AE34; Fri, 26 Jul 2019 22:13:49 +0000 (UTC) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Sat, 27 Jul 2019 00:13:49 +0200 Message-ID: <156417922934.29470.16776755402986910394.stgit@Palanthas> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of the "taking address of packed member of ... may result in an unaligned pointer value" kind. Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation error with gcc 9.1") seems to fix the problem. For more info, see: https://git.ipxe.org/ipxe.git/commit/1dd56dbd11082fb622c2ed21cfaced4f47d798a6 Signed-off-by: Dario Faggioli Acked-by: Wei Liu --- Cc: Wei Liu --- Hey, Wei, I have never played much with ipxe, so I can't be 100% sure that this is the best idea, and what could be the problems. I just thought I'll mention the issue to you, in the form of a patch, in an attempt to help as much as possible. Regards --- tools/firmware/etherboot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index fd8dfdf5a7..0de30599bf 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -10,7 +10,7 @@ else IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git endif -IPXE_GIT_TAG := d2063b7693e0e35db97b2264aa987eb6341ae779 +IPXE_GIT_TAG := 1dd56dbd11082fb622c2ed21cfaced4f47d798a6 IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz